gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #3203 from FreeCodeCamp/fix/run-button

Browse Source 
fix isInitRun flag not set
This commit is contained in:
Ben McMahon
2015-09-09 21:46:27 +01:00
parent 82f7b3825c 7874dc5222
commit f4f9f183ba
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
client/commonFramework.js
View File

@ -409,9 +409,13 @@ var postError = function(data) {
var goodTests = 0; var goodTests = 0;
var testSuccess = function() { var testSuccess = function() {
goodTests++; goodTests++;
// test successful run show completion
if (goodTests === tests.length) { if (goodTests === tests.length) {
showCompletion(); return showCompletion();
} }
// test unsuccessful, make sure initRun is set to false
isInitRun = false;
}; };
function showCompletion() { function showCompletion() {
@ -632,7 +636,9 @@ var runTests = function(err, data) {
) { ) {
try { try {
if (chaiTestFromJSON) { if (chaiTestFromJSON) {
/* eslint-disable no-eval */
var output = eval(reassembleTest(chaiTestFromJSON, data)); var output = eval(reassembleTest(chaiTestFromJSON, data));
/* eslint-enable no-eval */
} }
} catch (error) { } catch (error) {
allTestsPassed = false; allTestsPassed = false;
@ -647,8 +653,7 @@ var runTests = function(err, data) {
if (allTestsPassed) { if (allTestsPassed) {
allTestsPassed = false; allTestsPassed = false;
showCompletion(); showCompletion();
} } else {
else{
isInitRun = false; isInitRun = false;
} }
} }