fix: timeline not showing when set to public (#37937)

2019-12-20 07:49:02 -06:00
parent 2e3a5d4b1f
commit f5360e9393
1 changed files with 11 additions and 1 deletions
--- a/api-server/common/models/user.js
+++ b/api-server/common/models/user.js
@ -796,7 +796,17 @@ export default function(User) {
      ...user,
      about: showAbout ? about : '',
      calendar: showHeatMap ? calendar : {},
-      completedChallenges: showCerts && showTimeLine ? completedChallenges : [],
+      completedChallenges: (function() {
+        if (showTimeLine) {
+          return showCerts
+            ? completedChallenges
+            : completedChallenges.filter(
+                ({ challengeType }) => challengeType !== 7
+              );
+        } else {
+          return [];
+        }
+      })(),
      isDonating: showDonation ? isDonating : null,
      location: showLocation ? location : '',
      name: showName ? name : '',