gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix: stop user code after 500ms of execution

Browse Source 
Code like `var xs = []; while(true){ xs.push(1) }` can quickly run the
browser out of memory causing it to crash.  These changes stop user loops
from running indefinitely so that common mistakes will no longer cause
the browser to crash.

Also, the user is informed if a long running loop is detected (js and
jsx challenges) during preview or testing.  Before this there was no
protection for js challenges and no information was given to the
user if they had created such a loop.

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
Co-Authored-By: mrugesh <1884376+raisedadead@users.noreply.github.com>
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
This commit is contained in:
Oliver Eyton-Williams
2019-11-27 02:51:43 +01:00
committed by mrugesh
parent 1a56f4d5f4
commit f5feff386a
5 changed files with 83 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
client/src/templates/Challenges/redux/execute-challenge-saga.js
View File

@@ -33,6 +33,9 @@ import {
isJavaScriptChallenge
} from '../utils/build';
// How long before bailing out of a preview.
const previewTimeout = 2500;
export function* executeChallengeSaga() {
const isBuildEnabled = yield select(isBuildEnabledSelector);
if (!isBuildEnabled) {
@@ -90,9 +93,9 @@ function* takeEveryConsole(channel) {
});
}
function* buildChallengeData(challengeData) {
function* buildChallengeData(challengeData, preview) {
try {
return yield call(buildChallenge, challengeData);
return yield call(buildChallenge, challengeData, preview);
} catch (e) {
yield put(disableBuildOnError());
throw e;
@@ -155,7 +158,7 @@ function* previewChallengeSaga() {
const challengeData = yield select(challengeDataSelector);
if (canBuildChallenge(challengeData)) {
const buildData = yield buildChallengeData(challengeData);
const buildData = yield buildChallengeData(challengeData, true);
// evaluate the user code in the preview frame or in the worker
if (challengeHasPreview(challengeData)) {
const document = yield getContext('document');
@@ -163,10 +166,14 @@ function* previewChallengeSaga() {
} else if (isJavaScriptChallenge(challengeData)) {
const runUserCode = getTestRunner(buildData, { proxyLogger });
// without a testString the testRunner just evaluates the user's code
yield call(runUserCode, null, 5000);
yield call(runUserCode, null, previewTimeout);
}
}
} catch (err) {
if (err === 'timeout') {
// eslint-disable-next-line no-ex-assign
err = `The code you have written is taking longer than the ${previewTimeout}ms our challenges allow. You may have created an infinite loop or need to write a more efficient algorithm`;
}
console.log(err);
yield put(updateConsole(escape(err)));
}