From f65eea3dd6203666ad76dbc1b3395aecc80069f8 Mon Sep 17 00:00:00 2001 From: organicdude Date: Wed, 3 Jul 2019 03:43:25 -0600 Subject: [PATCH] Increase language clarity in challenge "Basic Javascript: Iterate Through an Array with a For Loop" (#36081) * Increase language clarity in the challenge. * Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-through-an-array-with-a-for-loop.english.md Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com> * fix/make-suggested-changes-on-behalf-of-author * fix/add-empty-line-back-in --- ...te-through-an-array-with-a-for-loop.english.md | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-through-an-array-with-a-for-loop.english.md b/curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-through-an-array-with-a-for-loop.english.md index 9b42cad7c4..9b9631d486 100644 --- a/curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-through-an-array-with-a-for-loop.english.md +++ b/curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-through-an-array-with-a-for-loop.english.md @@ -16,7 +16,7 @@ for (var i = 0; i < arr.length; i++) { } ``` -Remember that Arrays have zero-based numbering, which means the last index of the array is length - 1. Our condition for this loop is i < arr.length, which stops when i is at length - 1. +Remember that arrays have zero-based indexing, which means the last index of the array is length - 1. Our condition for this loop is i < arr.length, which stops the loop when i is equal to length. In this case the last iteration is i === 4 i.e. when i becomes equal to arr.length and outputs 6 to the console. ## Instructions @@ -30,21 +30,19 @@ Declare and initialize a variable total to 0. Use a total should be declared and initialized to 0 - testString: assert(code.match(/(var|let|const)\s*?total\s*=\s*0.*?;?/), 'total should be declared and initialized to 0'); + testString: assert(code.match(/(var|let|const)\s*?total\s*=\s*0.*?;?/)); - text: total should equal 20 - testString: assert(total === 20, 'total should equal 20'); + testString: assert(total === 20); - text: You should use a for loop to iterate through myArr - testString: assert(code.match(/for\s*\(/g).length > 1 && code.match(/myArr\s*\[/), 'You should use a for loop to iterate through myArr'); + testString: assert(code.match(/for\s*\(/g).length > 1 && code.match(/myArr\s*\[/)); - text: Do not set total to 20 directly - testString: assert(!code.match(/total[\s\+\-]*=\s*(0(?!\s*[;,]?$)|[1-9])/gm), 'Do not set total to 20 directly'); - + testString: assert(!code.match(/total[\s\+\-]*=\s*(0(?!\s*[;,]?$)|[1-9])/gm)); ``` ## Challenge Seed
-
```js @@ -61,12 +59,10 @@ var myArr = [ 2, 3, 4, 5, 6]; // Only change code below this line - ```
- ### After Test
@@ -82,7 +78,6 @@ var myArr = [ 2, 3, 4, 5, 6]; ## Solution
- ```js var ourArr = [ 9, 10, 11, 12]; var ourTotal = 0;