From f848bae00b0b01b35b99b304f8a2d60ef3749484 Mon Sep 17 00:00:00 2001 From: tktgius <42583503+tktgius@users.noreply.github.com> Date: Wed, 28 Nov 2018 12:20:28 -0600 Subject: [PATCH] Adding more description on how teams approach reviews (#22930) Adding description on how teams approach code reviews and what an effective code review is --- guide/english/working-in-tech/code-reviews/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guide/english/working-in-tech/code-reviews/index.md b/guide/english/working-in-tech/code-reviews/index.md index 6f8e3b988d..a4e11dba3d 100644 --- a/guide/english/working-in-tech/code-reviews/index.md +++ b/guide/english/working-in-tech/code-reviews/index.md @@ -14,7 +14,7 @@ the feeling that your code is going to be read/ inspected by another programmer As to what is reviewed and when, well there is no clear answer. Many teams have rules that every piece of code that checks-in in the version control system has to be reviewed by another programmer, -while other teams have whole days when they dedicate to code reviews across the team. +while other teams have whole days when they dedicate to code reviews across the team. Teams, within an organization, create internal Coding Standards for the various languages used, as a guidance for developers, and code reviewers. An effective code review is one where functionality, testability, security, and readibility/styling issues are addressed. It is important to be humble throughout the code review process. Accept your mistakes, and be professional when pointing out improvements or errors in the code of your fellow