From fdd20700dadef7d777335086e2fa9aeefe01f13d Mon Sep 17 00:00:00 2001 From: Steven <52871164+sstonaker@users.noreply.github.com> Date: Thu, 10 Feb 2022 18:43:24 -0600 Subject: [PATCH] fix(curriculum): typography step 43 tests pass in safari (#44984) * meta tag accepts valid html * Fix step 43 tests for safari * Incorporating suggestions from PR * incorporating suggestions from PR * added fix for step17 --- .../learn-basic-css-by-building-a-cafe-menu/step-003.md | 2 +- .../learn-basic-css-by-building-a-cafe-menu/step-017.md | 4 ++-- .../step-043.md | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/curriculum/challenges/english/14-responsive-web-design-22/learn-basic-css-by-building-a-cafe-menu/step-003.md b/curriculum/challenges/english/14-responsive-web-design-22/learn-basic-css-by-building-a-cafe-menu/step-003.md index 1474c544d3..43f72c61e1 100644 --- a/curriculum/challenges/english/14-responsive-web-design-22/learn-basic-css-by-building-a-cafe-menu/step-003.md +++ b/curriculum/challenges/english/14-responsive-web-design-22/learn-basic-css-by-building-a-cafe-menu/step-003.md @@ -16,7 +16,7 @@ Inside the `head` element, nest a `meta` element with an attribute named `charse You should have a `meta` tag. ```js -assert(code.match(//i)); +assert(code.match(//is)); ``` Your `meta` tag should have a `charset` attribute. diff --git a/curriculum/challenges/english/14-responsive-web-design-22/learn-basic-css-by-building-a-cafe-menu/step-017.md b/curriculum/challenges/english/14-responsive-web-design-22/learn-basic-css-by-building-a-cafe-menu/step-017.md index ae92e9e0ee..f197250c89 100644 --- a/curriculum/challenges/english/14-responsive-web-design-22/learn-basic-css-by-building-a-cafe-menu/step-017.md +++ b/curriculum/challenges/english/14-responsive-web-design-22/learn-basic-css-by-building-a-cafe-menu/step-017.md @@ -28,13 +28,13 @@ assert($('head').length === 1); Your `link` element should be a self-closing element. ```js -assert(code.match(//i)); +assert(code.match(//i)); ``` Your `link` element should be within your `head` element. ```js -assert(code.match(/[\w\W\s]*[\w\W\s]*<\/head>/i)) +assert(code.match(/[\w\W\s]*[\w\W\s]*<\/head>/i)) ``` Your `link` element should have a `rel` attribute with the value `stylesheet`. diff --git a/curriculum/challenges/english/14-responsive-web-design-22/learn-typography-by-building-a-nutrition-label/step-043.md b/curriculum/challenges/english/14-responsive-web-design-22/learn-typography-by-building-a-nutrition-label/step-043.md index 8e4947bade..054289a775 100644 --- a/curriculum/challenges/english/14-responsive-web-design-22/learn-typography-by-building-a-nutrition-label/step-043.md +++ b/curriculum/challenges/english/14-responsive-web-design-22/learn-typography-by-building-a-nutrition-label/step-043.md @@ -15,13 +15,13 @@ You should create a new `p` element below your element with the `Total Fat` text ```js assert(document.querySelector('.daily-value.sm-text')?.lastElementChild?.localName === 'p'); -assert(document.querySelector('.daily-value.sm-text')?.lastElementChild?.previousElementSibling?.innerText.match(/Total Fat 8g[\s|\n]+10%/)); +assert(document.querySelector('.daily-value.sm-text')?.lastElementChild?.previousElementSibling?.innerText.match(/Total Fat 8g\s*10%/)); ``` Your new `p` element should have the text `Saturated Fat 1g 5%`. ```js -assert(document.querySelector('.daily-value.sm-text')?.lastElementChild?.innerText.match(/Saturated Fat 1g[\s|\n]+5%/)); +assert(document.querySelector('.daily-value.sm-text')?.lastElementChild?.innerText.match(/Saturated Fat 1g\s*5%/)); ``` Your new `p` element should have a `span` element.