From fe3187a4d78d1618dbfc5ceacdd76e5c667417d2 Mon Sep 17 00:00:00 2001 From: Bruce B Date: Thu, 10 Feb 2022 14:28:55 -0800 Subject: [PATCH] fix: RWD beta update remaining doctype first tests (#44996) --- .../step-001.md | 4 ++-- .../step-001.md | 4 ++-- .../learn-css-grid-by-building-a-magazine/step-001.md | 4 ++-- .../step-001.md | 6 ++++++ .../step-002.md | 4 ++-- .../step-001.md | 6 ++++++ .../step-002.md | 4 ++-- .../step-001.md | 4 ++-- .../step-001.md | 4 ++-- 9 files changed, 26 insertions(+), 14 deletions(-) diff --git a/curriculum/challenges/english/14-responsive-web-design-22/learn-css-colors-by-building-a-set-of-colored-markers/step-001.md b/curriculum/challenges/english/14-responsive-web-design-22/learn-css-colors-by-building-a-set-of-colored-markers/step-001.md index 8669316c4f..f89df517d9 100644 --- a/curriculum/challenges/english/14-responsive-web-design-22/learn-css-colors-by-building-a-set-of-colored-markers/step-001.md +++ b/curriculum/challenges/english/14-responsive-web-design-22/learn-css-colors-by-building-a-set-of-colored-markers/step-001.md @@ -49,10 +49,10 @@ Your `html` element should have a closing tag. assert(code.match(/<\/html\s*>/gi)); ``` -Your `html` element should be below the `DOCTYPE` declaration. +Your `DOCTYPE` declaration should be at the beginning of your HTML. ```js -assert(code.match(/(?)/gi)); +assert(__helpers.removeHtmlComments(code).match(/^\s*/i)); ``` # --seed-- diff --git a/curriculum/challenges/english/14-responsive-web-design-22/learn-css-flexbox-by-building-a-photo-gallery/step-001.md b/curriculum/challenges/english/14-responsive-web-design-22/learn-css-flexbox-by-building-a-photo-gallery/step-001.md index e87f069508..1536fe8e56 100644 --- a/curriculum/challenges/english/14-responsive-web-design-22/learn-css-flexbox-by-building-a-photo-gallery/step-001.md +++ b/curriculum/challenges/english/14-responsive-web-design-22/learn-css-flexbox-by-building-a-photo-gallery/step-001.md @@ -47,10 +47,10 @@ Your `html` element should have a closing tag. assert(code.match(/<\/html\s*>/)); ``` -Your `html` element should be below the `DOCTYPE` declaration. +Your `DOCTYPE` declaration should be at the beginning of your HTML. ```js -assert(code.match(/(?)/gi)); +assert(__helpers.removeHtmlComments(code).match(/^\s*/i)); ``` You should have an opening `head` tag. diff --git a/curriculum/challenges/english/14-responsive-web-design-22/learn-css-grid-by-building-a-magazine/step-001.md b/curriculum/challenges/english/14-responsive-web-design-22/learn-css-grid-by-building-a-magazine/step-001.md index a9c1f26bca..0c372dcbfa 100644 --- a/curriculum/challenges/english/14-responsive-web-design-22/learn-css-grid-by-building-a-magazine/step-001.md +++ b/curriculum/challenges/english/14-responsive-web-design-22/learn-css-grid-by-building-a-magazine/step-001.md @@ -49,10 +49,10 @@ Your `html` element should have a closing tag. assert(code.match(/<\/html\s*>/)); ``` -Your `html` element should be below the `DOCTYPE` declaration. +Your `DOCTYPE` declaration should be at the beginning of your HTML. ```js -assert(code.match(/(?)/gi)); +assert(__helpers.removeHtmlComments(code).match(/^\s*/i)); ``` You should have an opening `head` tag. diff --git a/curriculum/challenges/english/14-responsive-web-design-22/learn-css-variables-by-building-a-city-skyline/step-001.md b/curriculum/challenges/english/14-responsive-web-design-22/learn-css-variables-by-building-a-city-skyline/step-001.md index 04b5bf100b..0dfd8acd66 100644 --- a/curriculum/challenges/english/14-responsive-web-design-22/learn-css-variables-by-building-a-city-skyline/step-001.md +++ b/curriculum/challenges/english/14-responsive-web-design-22/learn-css-variables-by-building-a-city-skyline/step-001.md @@ -35,6 +35,12 @@ You should close the `DOCTYPE` declaration with a `>` after the type. assert(code.match(/html\s*>/gi)); ``` +Your `DOCTYPE` declaration should be at the beginning of your HTML. + +```js +assert(__helpers.removeHtmlComments(code).match(/^\s*/i)); +``` + # --seed-- ## --seed-contents-- diff --git a/curriculum/challenges/english/14-responsive-web-design-22/learn-css-variables-by-building-a-city-skyline/step-002.md b/curriculum/challenges/english/14-responsive-web-design-22/learn-css-variables-by-building-a-city-skyline/step-002.md index a796cd3341..3a3b1cce47 100644 --- a/curriculum/challenges/english/14-responsive-web-design-22/learn-css-variables-by-building-a-city-skyline/step-002.md +++ b/curriculum/challenges/english/14-responsive-web-design-22/learn-css-variables-by-building-a-city-skyline/step-002.md @@ -11,10 +11,10 @@ Add opening and closing `html` tags below the `DOCTYPE` so you have a place to s # --hints-- -Your `html` element should be below the `DOCTYPE` declaration. +Your `DOCTYPE` declaration should be at the beginning of your HTML. ```js -assert(code.match(/(?)/gi)); +assert(__helpers.removeHtmlComments(code).match(/^\s*/i)); ``` Your `html` element should have an opening tag. diff --git a/curriculum/challenges/english/14-responsive-web-design-22/learn-html-forms-by-building-a-registration-form/step-001.md b/curriculum/challenges/english/14-responsive-web-design-22/learn-html-forms-by-building-a-registration-form/step-001.md index 871f7cea6c..e8490875ff 100644 --- a/curriculum/challenges/english/14-responsive-web-design-22/learn-html-forms-by-building-a-registration-form/step-001.md +++ b/curriculum/challenges/english/14-responsive-web-design-22/learn-html-forms-by-building-a-registration-form/step-001.md @@ -35,6 +35,12 @@ You should close the `DOCTYPE` declaration with a `>` after the type. assert(code.match(/html\s*>/gi)); ``` +Your `DOCTYPE` declaration should be at the beginning of your HTML. + +```js +assert(__helpers.removeHtmlComments(code).match(/^\s*/i)); +``` + # --seed-- ## --seed-contents-- diff --git a/curriculum/challenges/english/14-responsive-web-design-22/learn-html-forms-by-building-a-registration-form/step-002.md b/curriculum/challenges/english/14-responsive-web-design-22/learn-html-forms-by-building-a-registration-form/step-002.md index d78a9b2eb0..87cb5bf271 100644 --- a/curriculum/challenges/english/14-responsive-web-design-22/learn-html-forms-by-building-a-registration-form/step-002.md +++ b/curriculum/challenges/english/14-responsive-web-design-22/learn-html-forms-by-building-a-registration-form/step-002.md @@ -11,10 +11,10 @@ Add opening and closing `html` tags below the `DOCTYPE` so you have a place to s # --hints-- -Your `html` element should be below the `DOCTYPE` declaration. +Your `DOCTYPE` declaration should be at the beginning of your HTML. ```js -assert(code.match(/(?)/gi)); +assert(__helpers.removeHtmlComments(code).match(/^\s*/i)); ``` Your `html` element should have an opening tag. diff --git a/curriculum/challenges/english/14-responsive-web-design-22/learn-intermediate-css-by-building-a-picasso-painting/step-001.md b/curriculum/challenges/english/14-responsive-web-design-22/learn-intermediate-css-by-building-a-picasso-painting/step-001.md index 2af84caa2b..2c2494158b 100644 --- a/curriculum/challenges/english/14-responsive-web-design-22/learn-intermediate-css-by-building-a-picasso-painting/step-001.md +++ b/curriculum/challenges/english/14-responsive-web-design-22/learn-intermediate-css-by-building-a-picasso-painting/step-001.md @@ -35,10 +35,10 @@ You should close the `DOCTYPE` declaration with a `>` after the type. assert(code.match(/html\s*>/gi)); ``` -Your `html` element should be below the `DOCTYPE` declaration. +Your `DOCTYPE` declaration should be at the beginning of your HTML. ```js -assert(code.match(/(?)/gi)); +assert(__helpers.removeHtmlComments(code).match(/^\s*/i)); ``` Your `html` element should have an opening tag. diff --git a/curriculum/challenges/english/14-responsive-web-design-22/learn-responsive-web-design-by-building-a-piano/step-001.md b/curriculum/challenges/english/14-responsive-web-design-22/learn-responsive-web-design-by-building-a-piano/step-001.md index 9b86935fa0..93723e75b4 100644 --- a/curriculum/challenges/english/14-responsive-web-design-22/learn-responsive-web-design-by-building-a-piano/step-001.md +++ b/curriculum/challenges/english/14-responsive-web-design-22/learn-responsive-web-design-by-building-a-piano/step-001.md @@ -47,10 +47,10 @@ Your `html` element should have a closing tag. assert(code.match(/<\/html\s*>/)); ``` -Your `html` element should be below the `DOCTYPE` declaration. +Your `DOCTYPE` declaration should be at the beginning of your HTML. ```js -assert(code.match(/(?)/gi)); +assert(__helpers.removeHtmlComments(code).match(/^\s*/i)); ``` You should have an opening `head` tag.