add pull in user image on signup when available

This commit is contained in:
Berkeley Martinez
2015-06-11 11:38:08 -07:00
parent 4d8ab0a915
commit fe5cbec117
3 changed files with 40 additions and 29 deletions

View File

@ -1,27 +1,34 @@
// var debug = require('debug')('freecc:models:userIdent'); var debug = require('debug')('freecc:models:userIdent');
//
// module.exports = function(UserIdent) { var defaultProfileImage =
// require('../utils/constantStrings.json').defaultProfileImage;
// UserIdent.observe('before save', function(ctx, next) {
// module.exports = function(UserIdent) {
// var userIdent = ctx.instance;
// userIdent.user(function(err, user) { UserIdent.observe('before save', function(ctx, next) {
// if (err) { return next(err); } var userIdent = ctx.currentInstance;
// debug('got user', user.username); // treat userIdent as immutable
// userIdent.user(function(err, user) {
// // check if user has picture if (err) { return next(err); }
// // set user.picture from twitter debug('got user', user.username);
// if (!user.picture) {
// debug('use has no pic'); var picture = userIdent.profile && userIdent.profile[0] ?
// user.picture = userIdent.profile.photos[0].value; userIdent.profile[0].value :
// user.save(function(err) { null;
// if (err) { return next(err); }
// next(); // check if user has picture
// }); // set user.picture from twitter
// } else { if (picture && !user.picture || user.picture === defaultProfileImage) {
// debug('exiting after user ident'); debug('use has no pic');
// next(); user.picture = userIdent.profile.photos[0].value;
// } user.save(function(err) {
// }); if (err) { return next(err); }
// }); next();
// }; });
} else {
debug('exiting after user ident');
next();
}
});
});
};

View File

@ -0,0 +1,3 @@
{
"defaultProfileImage": "https://s3.amazonaws.com/freecodecamp/camper-image-placeholder.png"
}

View File

@ -1,3 +1,5 @@
var defaultProfileImage =
require('../../common/utils/constantStrings.json').defaultProfileImage;
var message = var message =
'Learn to Code JavaScript and get a Coding Job by Helping Nonprofits'; 'Learn to Code JavaScript and get a Coding Job by Helping Nonprofits';
@ -9,8 +11,7 @@ module.exports = function(app) {
function index(req, res, next) { function index(req, res, next) {
if (req.user && !req.user.picture) { if (req.user && !req.user.picture) {
req.user.picture = req.user.picture = defaultProfileImage;
'https://s3.amazonaws.com/freecodecamp/camper-image-placeholder.png';
req.user.save(function(err) { req.user.save(function(err) {
if (err) { return next(err); } if (err) { return next(err); }