gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix: allow log in testString, restrict test errors

Browse Source 
Console logs from testString get reported and test errors are sent to
the dev console (JS).

challenge building is only attempted if there is a build function to do
so.

Various functions have been renamed to better reflect what they do.
This commit is contained in:
Oliver Eyton-Williams
2019-11-19 12:46:48 +01:00
committed by mrugesh
parent 9194b7731b
commit febba792e7
4 changed files with 32 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
client/src/templates/Challenges/redux/execute-challenge-saga.js
View File

@@ -26,6 +26,7 @@ import {
import {
buildChallenge,
canBuildChallenge,
getTestRunner,
challengeHasPreview,
updatePreview,
@@ -153,15 +154,17 @@ function* previewChallengeSaga() {
yield fork(takeEveryConsole, logProxy);
const challengeData = yield select(challengeDataSelector);
const buildData = yield buildChallengeData(challengeData);
// evaluate the user code in the preview frame or in the worker
if (challengeHasPreview(challengeData)) {
const document = yield getContext('document');
yield call(updatePreview, buildData, document, proxyLogger);
} else if (isJavaScriptChallenge(challengeData)) {
const runUserCode = getTestRunner(buildData, { proxyLogger });
// without a testString the testRunner just evaluates the user's code
yield call(runUserCode, null, 5000);
if (canBuildChallenge(challengeData)) {
const buildData = yield buildChallengeData(challengeData);
// evaluate the user code in the preview frame or in the worker
if (challengeHasPreview(challengeData)) {
const document = yield getContext('document');
yield call(updatePreview, buildData, document, proxyLogger);
} else if (isJavaScriptChallenge(challengeData)) {
const runUserCode = getTestRunner(buildData, { proxyLogger });
// without a testString the testRunner just evaluates the user's code
yield call(runUserCode, null, 5000);
}
}
} catch (err) {
console.log(err);