gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix: prevent scroll jumping on /settings (#44937)

Browse Source
This commit is contained in:
Oliver Eyton-Williams
2022-01-28 09:02:07 +01:00
committed by GitHub
parent a03f3ab47e
commit fff1d833b9
2 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
client/src/components/settings/Certification.js
View File

@ -429,9 +429,7 @@ export class CertificationSettings extends Component {
const { t } = this.props; const { t } = this.props;
return ( return (
<ScrollableAnchor id='certification-settings'> <ScrollableAnchor id='certification-settings'>
{/* it's weird that we repeat the id, but the ScrollableAnchor does not <section className='certification-settings'>
add any elements to the DOM and cannot be used for styling */}
<section id='certification-settings'>
<SectionHeader>{t('settings.headings.certs')}</SectionHeader> <SectionHeader>{t('settings.headings.certs')}</SectionHeader>
{certifications.map(certName => {certifications.map(certName =>
this.renderCertifications(certName, projectMap) this.renderCertifications(certName, projectMap)

10
client/src/components/settings/certification.css
View File

@ -1,14 +1,14 @@
#certification-settings .solutions-dropdown, .certification-settings .solutions-dropdown,
#certification-settings .solutions-dropdown .dropdown-menu, .certification-settings .solutions-dropdown .dropdown-menu,
#certification-settings .solutions-dropdown .dropdown { .certification-settings .solutions-dropdown .dropdown {
width: 100%; width: 100%;
} }
#certification-settings tr { .certification-settings tr {
height: 57px; height: 57px;
} }
#certification-settings .project-title > a { .certification-settings .project-title > a {
line-height: 40px; line-height: 40px;
} }