5494b7c90a
fix(curriculum): copy edit for grammar ( #45580 )
...
* over-write -> overwrite
* fix(curriculum): correct grammar in lesson
* fix(curriculum): apply verbiage change to all English instances
Co-authored-by: Karen Lowe <klowe@ancestry.com >
Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com >
2022-04-01 13:48:56 +02:00
ebc4fa273e
fix(curriculum): remove obnoxious, bloated library use ( #44737 )
2022-01-10 18:38:49 +05:30
f90dc7d903
fix(curriculum): update challenge to heading tags instead of headers ( #43429 )
...
* header changed to heading tag
* fix: Exercise about heading tags <h1> ... <h6>, accidentally refers to header tags
* fix: changed header to heading on pages affected
* Update curriculum/challenges/_meta/applied-visual-design/meta.json
Co-authored-by: Ilenia <nethleen@gmail.com >
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/use-headings-to-show-hierarchical-relationships-of-content.md
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com >
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/use-headings-to-show-hierarchical-relationships-of-content.md
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com >
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/use-headings-to-show-hierarchical-relationships-of-content.md
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com >
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/use-headings-to-show-hierarchical-relationships-of-content.md
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com >
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/use-headings-to-show-hierarchical-relationships-of-content.md
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com >
* Update curriculum/challenges/english/01-responsive-web-design/basic-html-cat-photo-app/part-002.md
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com >
* Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/adjust-the-size-of-a-header-versus-a-paragraph-tag.md
Co-authored-by: gikf <60067306+gikf@users.noreply.github.com >
* Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/adjust-the-size-of-a-header-versus-a-paragraph-tag.md
Co-authored-by: gikf <60067306+gikf@users.noreply.github.com >
* file renamed
* dashed-name changed for all languages
* made changes in all the challenges
* file title changed
* added cypress test
* cypress test added
* Update cypress/integration/learn/redirects/heading-challenge.js
Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com >
Co-authored-by: Ilenia <nethleen@gmail.com >
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com >
Co-authored-by: gikf <60067306+gikf@users.noreply.github.com >
Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com >
2021-10-25 16:17:54 +01:00
a0463d2c99
fix: insert missing forward-slash in instructions ( #41934 )
...
inserted forward-slash in closing 'sup' tag in instructions section
2021-04-28 08:07:43 +02:00
093325abdf
fix(curriculum): tabindex order lesson ( #41901 )
...
Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com >
2021-04-27 00:55:28 +05:30
ca3d5d51d6
fix: wrong text in standardize times challenge ( #41842 )
2021-04-17 06:19:52 +02:00
b064991667
fix(curriculum): Replace single-line blocks with multi-line blocks for Responsive Web Design ( #41519 )
...
* fix(curriculum) replace single-line block with multi-line blocks
* fix(curriculum) replace single-line block with multi-line blocks (missed blocks)
2021-03-18 17:24:09 -06:00
5b760e50a3
fix(curriculum) Improved readability and grammar ( #41340 )
...
* fix(curriculum) Improved readability and grammar
* fix missing tags and grammar
* fix(curriculum) changes to grammar
* fix(curriculum) grammar fixes
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/make-elements-only-visible-to-a-screen-reader-by-using-custom-css.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* fix(curriculum) Grammar fix
* chore: apply suggestions from code review
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com >
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
2021-03-10 09:00:03 -08:00
18068cdeaa
fix: remove forward slash from <source> tag ( #41422 )
...
The forward slash at the end of the <source> tag in the example is removed, as this is more common.
2021-03-09 16:20:22 +00:00
f328bdb93e
fix(curriculum) fixes for grammar and missing articles ( #41335 )
...
* fix(curriculum) fixes for grammar and missing articles
* Update curriculum/challenges/english/01-responsive-web-design/css-grid/add-gaps-faster-with-grid-gap.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-03-02 12:27:45 -07:00
167f93df76
fix(learn): Add inline code blocks to for i18n ( #40921 )
2021-02-05 14:16:19 +05:30
427444c757
chore(learn): audit files for crowdin ( #40838 )
...
* chore(learn): audit files for crowdin
Audits the challenge text in the Responsive Web Design superblock to
account for words/phrases that should not be translated because they
refer to code.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* fix: remove quotes from code
Removes instances of quoted code blocks, or code blocked quotes.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* fix: additional uncaught quote-codes
Thanks Oliver :)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* fix: so many quotes
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix: missing punctuation
Noted in a Crowdin comment.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* fix: remove more quotes
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-02-01 12:56:07 -07:00
bab54ad619
fix(learn): no capital code block ( #40688 )
...
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
2021-01-16 12:54:38 -07:00
ee1e8abd87
feat(curriculum): restore seed + solution to Chinese ( #40683 )
...
* feat(tools): add seed/solution restore script
* chore(curriculum): remove empty sections' markers
* chore(curriculum): add seed + solution to Chinese
* chore: remove old formatter
* fix: update getChallenges
parse translated challenges separately, without reference to the source
* chore(curriculum): add dashedName to English
* chore(curriculum): add dashedName to Chinese
* refactor: remove unused challenge property 'name'
* fix: relax dashedName requirement
* fix: stray tag
Remove stray `pre` tag from challenge file.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
Co-authored-by: nhcarrigan <nhcarrigan@gmail.com >
2021-01-12 19:31:00 -07:00
0bd52f8bd1
Feat: add new Markdown parser ( #39800 )
...
and change all the challenges to new `md` format.
2020-11-27 10:02:05 -08:00
2b9e38a17b
fix: replace .english.md extension with .md
2020-09-29 22:09:04 +02:00
bd68b70f3d
Feat: hide blocks not challenges ( #39504 )
...
* fix: remove isHidden flag from frontmatter
* fix: add isUpcomingChange
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com >
* feat: hide blocks not challenges
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com >
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com >
2020-09-03 15:07:40 -07:00
29ab6c32ec
minor <code> tag fixes ( #39046 )
2020-08-30 23:12:04 -05:00
fe3f0b2ac4
fix: remove quotation marks from code tag text ( #38316 )
2020-08-30 22:53:09 -05:00
9a861d1f1c
fix(curriculum): Fixed Spelling Error. 'lightning speed' ( #39056 )
2020-06-13 15:14:24 +05:30
f1c9b08cf3
fix(curriculum): add isHidden: false to challenges
...
This includes certificates (where it does nothing), but does not
include any translations.
2020-05-25 16:25:19 +05:30
41718abf76
fix(learn): consolidate comments for responsive web design cert ( #38256 )
...
Related to PR #38040
This PR is an attempt to consolidate/remove as many comments in the challenge seed code in the Responsive Web Design certification challenges, to be able to create a small translation lookup object for translating the English comments to other languages.
2020-02-27 20:50:46 +05:30
9bf3fdbf38
fix(curriculum): changed challenge test text to use the word should for Responsive Web Design ( #36860 )
...
* fix: changed challenge test text to use should
* fix: changed have to be used in
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: reworded test verbiage
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: improved test verbiage
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: improved test verbiage
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: changed have the to be used in
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: corrected verbiage
Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com >
2019-11-20 20:15:19 +05:30
39df6a2b56
fix(curriculum): added new test to Give Links Meaning by Using Descriptive Link Text challenge to specifically for href attribute ( #37699 )
...
* fix: added new test to test href attribute
* fix: changed You to Your
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: changed a to an
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
2019-11-15 10:14:54 -06:00
568f00e02a
fix(curriculum): Added forumTopicId to remaining 1200 challeng… ( #36558 )
2019-08-05 22:14:37 +05:30
3ec1fe8ea7
feat: add forumTopicId to challenge frontmatter [pre-existing]
...
This commit adds the pre-existing challenge guide topics in the
forum to the forntmatter of their challenge markdown files.
2019-08-05 22:14:37 +05:30
d0d8282f86
fix(curriculum): Remove additional unnecessary assert message argument wrapped in double quotes from various curriculum sections ( #36457 )
...
* fix: remove double quoted assert msg arg - responsive
* fix: remove double quoted assert msg arg - js
* fix: remove double quoted assert msg arg - libraries
* fix: remove double quoted assert msg arg - coding interview
2019-07-24 13:06:12 +01:00
e763330fc3
fix: removed assert msg argument ( #36405 )
2019-07-24 11:42:26 +02:00
c387873640
fix(curriculum): added extra line before </section> tag - Engl… ( #36278 )
2019-07-19 15:30:17 +05:30
438e7d4c51
fixed testString to disallow any extra characters from passing. Also … ( #35987 )
...
* fixed testString to disallow any extra characters from passing. Also changed markup in testString and text
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md
Co-Authored-By: Stevo99 <Sfailla1983@gmail.com >
* fixed test so it won't pass if datetime attr is left blank
* fixed test so it will not pass if datetime attribute is left empty
* fixed error in testString where test would pass if user runs test right away
* added tear-down div to make test code look cleaner
* fixed merge conflict. added tear-down div to make code look cleaner
* fixed testString to disallow any extra characters from passing. Also changed markup in testString and text
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md
improvement to test case where element should have closing tag.
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fixed conflict in git
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md
removed unnecessary test
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md
removed unnecessary test
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2019-06-28 18:49:00 -04:00
acbc07e0ff
Fixed typo addressed in #36225 ( #36227 )
...
* Fixed typo addressed in #36225
* Updated as per discussion.
2019-06-15 13:02:01 +07:00
8cb540fe85
fix: use lowercase for 'article' tag ( #36222 )
2019-06-09 07:47:09 -07:00
df8659ab8c
fix(curriculum): Convert blockquote elements to triple backtick syntax for Responsive Web Design ( #35993 )
...
* fix: converted blockquotes to code fences
2019-05-14 10:11:58 +02:00
cf86246866
fix(curriculum): Add solutions to 16 Applied Accessibility challenges #35751 ( #35809 )
...
This commit adds 16 full working solutions to the responsive web design
principles dealing with applied accessibility.
2019-04-24 19:12:46 +05:30
7e522dc473
fix: add new scrimbas ( #35803 )
2019-04-10 09:23:12 -07:00
f74d507434
fix(curriculum): replace js with full solution in accessibility challenge ( #35810 )
...
* fix(curriculum): add full, working solution for accessibility challenge.
This commit replaces a JavaScript only solution where a full, working
solution should have been written.
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/avoid-colorblindness-issues-by-using-sufficient-contrast.english.md
Co-Authored-By: rimij405 <effendiian@gmail.com >
2019-04-10 17:55:16 +02:00
bc72c86dc6
fix: updated the note sections for responsive web design english ( #35528 )
2019-03-22 15:02:12 +01:00
0a2aa3dcfa
feat: add solution to accessibility challenge ( #35553 )
...
* feat: add solution to accessibility challenge
* Remove space before closing `time` tag
Co-Authored-By: Dana94 <dana.ottaviani@gmail.com >
2019-03-10 11:09:57 -07:00
3d1fd805e6
feat: add solution to accessibility challenge ( #35484 )
2019-03-01 20:03:38 -05:00
30fd0aa78e
fix: add solution for accessibility challenge ( #35366 )
2019-02-25 21:58:35 -05:00
aa621a20b5
fix: removed unecessary guideUrl from frontmatter
2019-02-19 11:34:27 +03:00
9562bf0baa
Solution to implementing an accessible date picker ( #35262 )
...
* feat: add challenge solution
* fix: remove whitespace and filler comments
2019-02-17 17:25:41 -08:00
a0c00de32b
Use correct spelling of navigable ( #34817 )
2019-02-17 01:52:19 -08:00
9c3145ea49
fix: improved the grammar and readability ( #35133 )
2019-02-16 18:02:35 +05:30
bad8846e04
feat: add solution to accessibility challenge ( #35131 )
2019-02-16 18:00:42 +05:30
16ef2639c0
Updated wrong guideUrl to correct one ( #35066 )
...
* Update add-a-text-alternative-to-images-for-visually-impaired-accessibility.english.md
* Use standard link for guide URLs
* fix: corrected guideUrl
* fix: corrected guideUrl again
2019-02-16 17:52:16 +05:30
9c881dcc6e
Fixed issue with accessibility challenge about contrast ( #19711 )
...
* Update avoid-colorblindness-issues-by-using-sufficient-contrast.english.md
* Update avoid-colorblindness-issues-by-using-sufficient-contrast.english.md
2019-02-10 14:03:01 -06:00
80e80a4c8b
Word Correction ( #29689 )
...
* Word Correction
Some words were missing, making the sentence sound grammatically incorrect.
* fix: removed the word its
2019-02-10 07:51:00 -08:00
f6f58d3228
Remove unwanted comma ( #26050 )
2019-02-10 07:33:56 -08:00
16bca6e24a
Closes #34988 : "Clicking on link in the code preview opens up the web page within the web page" ( #34995 )
2019-02-04 15:57:49 +03:00
