Commit Graph

362 Commits

Author SHA1 Message Date
b24f606847 added example to make description clear (#26492)
Added example in the description for understanding that the width of the element is still set using the width property in CSS.
fixes issue #17617
2019-02-11 18:28:07 -08:00
9c881dcc6e Fixed issue with accessibility challenge about contrast (#19711)
* Update avoid-colorblindness-issues-by-using-sufficient-contrast.english.md

* Update avoid-colorblindness-issues-by-using-sufficient-contrast.english.md
2019-02-10 14:03:01 -06:00
80e80a4c8b Word Correction (#29689)
* Word Correction

Some words were missing, making the sentence sound grammatically incorrect.

* fix: removed the word its
2019-02-10 07:51:00 -08:00
f6f58d3228 Remove unwanted comma (#26050) 2019-02-10 07:33:56 -08:00
cc659a9a2d Expected solution for the challenge seed code (#32530)
* Expected solution for the challenge seed code

I have updated the expected output for the challenge seed code.

* Update create-a-text-field.english.md

* fix: change language tag and remove wrong comment
2019-02-05 18:33:30 -08:00
098c622fc6 Sample solution for the file (#31770)
* Sample solution for the file

I have updated the sample solution for the challenge seed code.

* Update add-images-to-your-website.english.md

formatted ```html tags
2019-02-05 18:31:31 -08:00
9e4583b1f3 fix: change video url for clockwise-notation challenge (#35013) 2019-02-04 16:29:26 +03:00
Leo
16bca6e24a Closes #34988: "Clicking on link in the code preview opens up the web page within the web page" (#34995) 2019-02-04 15:57:49 +03:00
693047d5c6 fix: "Applied Visual Design: Adjust the Hover State of an Anchor Tag" now accepts more ways of writing 'blue' (#34939)
* fix: test now accepts more ways of writing 'blue'

* fix: include test for rgb
2019-02-04 12:22:30 +03:00
b56462c5ee Fixed grammar (#28571)
Changed 4th sentence to be more readable, it was slightly confusing with the comma.
2019-02-02 22:19:01 +04:00
8fa32c52fc Fixes #13774 (#34801)
* Fixes #13774

* del redundant group in test ereg
2019-01-31 12:55:10 -08:00
Leo
47857d9fcb Deleted wrong comma (#34979) 2019-01-28 08:33:11 -08:00
Leo
721cbba477 Deleted an unneccessary comma (#34976) 2019-01-28 08:28:11 -08:00
Leo
7f31aa807c Deleted comma (#34987) 2019-01-28 08:18:42 -08:00
a284b296fc fix: Capitalize test text for Cascading CSS variables (#34910) 2019-01-27 18:11:49 -07:00
fef2ed3c11 Fixed description of wrap-reverse option of flex-wrap property (#28513)
from "bottom-to-top" to "right-to-left" for row values
from "right-to-left" to "bottom-to-top" for column values
2019-01-26 10:06:43 -08:00
9cd1610839 Add solution to css-flexbox challenge (#34253)
<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->

- [x] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [x] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [x] My pull request targets the `master` branch of freeCodeCamp.
- [x] None of my changes are plagiarized from another source without proper attribution.
- [x] My article does not contain shortened URLs or affiliate links.


Co-authored-by: Paul Gamble <pgamble@gmail.com>
2019-01-25 12:13:07 -05:00
de03d3f112 Solution to Comment out H1 and p tag, but not H2 element. (#32125)
<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->

- [x] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [x] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [x] My pull request targets the `master` branch of freeCodeCamp.
- [x] None of my changes are plagiarized from another source without proper attribution.
- [x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.

Closes #XXXXX


Co-authored-by: Paul Gamble <pgamble@gmail.com>
2019-01-25 11:53:30 -05:00
6b6b33092b Sample solution for the challenge seed code (#31929)
* Sample solution for the challenge seed code

I have updated the sample solution for the challenge seed code.

* Update headline-with-the-h2-element.english.md

Removed //solution required


Co-authored-by: Paul Gamble <pgamble@gmail.com>
2019-01-25 11:19:27 -05:00
0351df1c24 Added solution to the uncomment-html-english-challenge (#28868)
LGTM!
2019-01-24 16:03:03 -05:00
2fea28aca8 add solution (#28406)
LGTM!
2019-01-24 15:57:09 -05:00
d006696c85 Correct two mixed up Scrimba links (#34892) 2019-01-18 03:27:01 +05:30
e3df17b8f5 Update learn-about-tertiary-colors.md (#26027)
Fixes issue #18179
Fixed wording to be more clear about which color model was being used
2019-01-17 07:56:22 +07:00
5de9f32c06 Solution added to exercise 'Use the s tag to strikethrough text ' (#34526)
<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->

- [x] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [x] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [x] My pull request targets the `master` branch of freeCodeCamp.
- [x] None of my changes are plagiarized from another source without proper attribution.
- [x] My article does not contain shortened URLs or affiliate links.

<!--If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.-->

Closes #XXXXX
2018-12-06 15:03:20 +00:00
62059eeb3b fix(challenges): YAMLException warning (#34544) 2018-12-05 20:52:41 +05:30
9f5fbe9af4 Fixes issue with background-color and background being interpreted differently (#34275) 2018-12-05 15:22:58 +09:00
cffe1be295 Grammar consistency fix. (#24228)
Entire article is using "isn't" so the "wasn't" seems out of place. I'm just following https://english.stackexchange.com/questions/283758/proper-use-of-was-vs-is
2018-12-04 16:12:48 +00:00
29297f48c9 Fixed issue about tag capitalization (#34276) 2018-12-04 23:16:30 +09:00
786cda2627 Add challenge solution
Added a solution. Please let me know if this is submitted incorrectly or in the wrong location.

<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->

- [X] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [X] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [X] My pull request targets the `master` branch of freeCodeCamp.
- [X] None of my changes are plagiarized from another source without proper attribution.
- [X] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.

Closes #XXXXX
2018-12-03 23:10:41 +00:00
bdbf83e5a2 added 01-responsive-web-design/basic-css/ (#22531)
I have added use rgb-to-mix-color
2018-11-25 10:20:27 -07:00
d98be1be7c added (do not include the period) to address common mistake (#34381)
Thank you for your pull request.

I am closing this pull request. Please add links and other details to the challenge’s corresponding guide article instead.

If you think I’m wrong in closing this issue, please reopen it and add further clarification. Thank you, and happy coding.

@MP7373
2018-11-19 14:22:13 +08:00
b2328e96db Update import-a-google-font.english.md (#19717) 2018-11-18 08:45:03 -06:00
fd8414062d Fixed issue which was causing problem while testing for headings challenge (#19590)
* Update use-headings-to-show-hierarchical-relationships-of-content.english.md

* Update use-headings-to-show-hierarchical-relationships-of-content.english.md

* Update use-headings-to-show-hierarchical-relationships-of-content.english.md

* fix(tests): for closing tags

* Update use-headings-to-show-hierarchical-relationships-of-content.english.md

* Update use-headings-to-show-hierarchical-relationships-of-content.english.md
2018-11-15 20:59:35 +05:30
04d8e46012 Updated text formatting and inconsistencies for files in basic-html-and-html5 challenges (#19921) 2018-11-12 19:23:12 +09:00
29863028ae image added to website (#34247)
image added to website using 'img' tag, 'src' tag and 'alt' tag
2018-11-08 10:39:13 +05:30
4ea0953446 submit button added (#34233)
submit button added to the form
2018-11-06 11:44:23 -05:00
9c44af828d added missing word 'like' to the Instructions (#34215) 2018-11-05 19:20:22 +00:00
24c1110a87 fix(curriculum): fix solution (#34220) 2018-11-05 08:09:44 -08:00
ac5bbb2dc7 Add solution
For "Use the flex-basis Property to Set the Initial Size of an Item" challenge
2018-11-05 13:36:38 +03:00
6ce41d6203 fixed a typo (#34170) 2018-11-03 01:24:58 +05:30
b67e3d4305 fix: add new test to create a set of new checkboxes (#18294) 2018-11-01 17:06:50 +09:00
b904ba15a2 Remove unnecessary space after grid-template-columns repeat in container class (#31528)
I was working through this challenge and noticed an extra space in the challenge seed that was probably a typo so i'm making this PR to fix it.
2018-10-29 13:44:31 -07:00
c54896273b Added a missing space and period in basic-css challenge files (#20480)
* Added missing space

* Added missing period in add-borders-around-your-elements.md

* Added missing space in adjust-the-padding-of-an-element.english.md
2018-10-29 22:13:45 +07:00
6e3da1c4b3 Added a space after css property colon (#29807)
I was doing this challenge and noticed that there wasn't a space after "transform:scale(2)" in the description which is inconsistent with the other challenges so I changed it to "transform: scale(2)"
2018-10-28 03:22:11 +05:30
dc7bb257b9 fix(curriculum): correct test 2018-10-28 03:16:22 +05:30
022a2fce8a Add solution using all code (#25669) 2018-10-25 08:22:13 -04:00
843f6bff66 Added solution using all of the code. (#25671) 2018-10-25 08:17:44 -04:00
b8bdfef6d4 Added the solution while using all of the code. (#25675) 2018-10-23 15:04:19 -04:00
e099d6486d fix: test curriculum challenges (#24180) 2018-10-23 18:51:53 +05:30
79d9012432 fix(curriculum): quotes in tests (#18828)
* fix(curriculum): tests quotes

* fix(curriculum): fill seed-teardown

* fix(curriculum): fix tests and remove unneeded seed-teardown
2018-10-20 23:32:47 +05:30