* fix: remove circular dependency
redux depended on templates/Challenges/redux and vice versa. This
meant that import order mattered and confusing bugs could arise.
(cherry picked from commit 7d67a4e70922bbb3051f2f9982dcc69e240d43dc)
* feat: require imports to be in alphabetical order
Import order generally does not matter, but there are edge cases
(circular imports and css imports, for example) where changing order
changes behaviour
(cherry picked from commit b8d1393a91ec6e068caf8e8498a5c95df68c2b2c)
* chore: order imports
* fix: lift up challenge description + title comps
This brings the classic Show closer to the others as they
now all create the description and title components
* fix: remove donation-saga/index circular import
(cherry picked from commit 51a44ca668a700786d2744feffeae4fdba5fd207)
* refactor: extract action-types from settings
(cherry picked from commit 25e26124d691c84a0d0827d41dafb761c686fadd)
* fix: lint errors
* feat: prevent useless renames
Changes the schema validation script to print warnings to the
console instead of throwing errors. This will no longer cause CI
to fail on missing/extra/empty translation object keys.
* fix(api): decouple api from curriculum
This reverts commit 8f0e441644 and
introduces the implementations from #40703.
* fix(gitpod): add curriculum build to GitPod
This reverts commit 706d70f58d and
introduces implementations from #41234.
* docs: update DevOps manual for api change (#41259)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* tools: Move schema validation to linter
Migrates the schema validation process for
translation files out of the `test` step and
in to a `lint` step.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
* fix: typo
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
* tools: Lint motivation object
Verifies that the motivation.json objects are
correct, and that the quote objects are all
structured properly.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
* tools: add object value validation
Adds a function that validates each translation
object does not have any empty keys.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
* tools: Log missing values with property chain
Modifies the value validation to log property names
as chains, for easier identification of misisng key
values.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
* fix(tools): Correct typo
Corrects the typo in the motivation-schema.js comments
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>