14 Commits

Author SHA1 Message Date
Oliver Eyton-Williams
efba2e777d chore: simplify eslint configuration (#44347)
* chore: extend import/recommended

* chore: use recommended lint rules

* refactor: apply lint rules

* chore: drop used config
2021-12-02 00:01:12 +00:00
Oliver Eyton-Williams
e118dda13a fix: order imports and remove circular dependencies (#41824)
* fix: remove circular dependency

redux depended on templates/Challenges/redux and vice versa.  This
meant that import order mattered and confusing bugs could arise.

(cherry picked from commit 7d67a4e70922bbb3051f2f9982dcc69e240d43dc)

* feat: require imports to be in alphabetical order

Import order generally does not matter, but there are edge cases
(circular  imports and css imports, for example) where changing order
changes behaviour

(cherry picked from commit b8d1393a91ec6e068caf8e8498a5c95df68c2b2c)

* chore: order imports

* fix: lift up challenge description + title comps

This brings the classic Show closer to the others as they
now all create the description and title components

* fix: remove donation-saga/index circular import

(cherry picked from commit 51a44ca668a700786d2744feffeae4fdba5fd207)

* refactor: extract action-types from settings

(cherry picked from commit 25e26124d691c84a0d0827d41dafb761c686fadd)

* fix: lint errors

* feat: prevent useless renames
2021-08-02 08:39:40 -05:00
Nicholas Carrigan (he/him)
70a28cc528 fix(tools): i18n schema linting (#41823) 2021-04-15 09:31:18 +05:30
Nicholas Carrigan (he/him)
f1c8a9825b fix(i18n,client): translatable cta url (#41384) 2021-03-12 17:14:54 -07:00
Nicholas Carrigan (he/him)
eda444a4ef tools: disable schema validation (#41300)
Changes the schema validation script to print warnings to the
console instead of throwing errors. This will no longer cause CI
to fail on missing/extra/empty translation object keys.
2021-03-01 00:05:21 +05:30
Mrugesh Mohapatra
b5f4754e2a fix: re-revert the API decoupling (#41263)
* fix(api): decouple api from curriculum

This reverts commit 8f0e441644 and
introduces the implementations from #40703.

* fix(gitpod): add curriculum build to GitPod

This reverts commit 706d70f58d and
introduces implementations from #41234.

* docs: update DevOps manual for api change (#41259)

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-02-25 12:02:35 -08:00
Mrugesh Mohapatra
8f0e441644 revert(api): decouple api from curriculum
This reverts commit c077ffe4b9
via PR #40703
2021-02-25 03:40:09 +05:30
Oliver Eyton-Williams
c077ffe4b9 feat(api): decouple api from curriculum (#40703) 2021-02-22 12:23:59 +05:30
Oliver Eyton-Williams
e7aa1c5d62 refactor: use the English json as the schema (#41146)
Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>
2021-02-18 10:38:45 +05:30
Oliver Eyton-Williams
6c1f6bebed feat: label un-audited challenges (#41002)
Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>
Co-authored-by: Mrugesh Mohapatra <me@raisedadead.com>
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
2021-02-11 18:10:32 +05:30
Kristofer Koishigawa
3b0ebb3dcb feat(client): translation status banner (#41001)
Co-authored-by: nhcarrigan <nhcarrigan@gmail.com>
2021-02-09 13:26:18 +05:30
Nicholas Carrigan (he/him)
1a642ba542 feat(i18n, client): migrate meta translations (#40885) 2021-02-03 13:33:52 +05:30
Tom
625469c82f feat: improve ui/ux learn map (#40579)
Co-authored-by: Kris Koishigawa <scissorsneedfoodtoo@gmail.com>
2021-01-31 12:15:39 +05:30
Nicholas Carrigan (he/him)
49b1c29f6b fix(tools): validate and lint i18n schema (#40597)
* tools: Move schema validation to linter

Migrates the schema validation process for
translation files out of the `test` step and
in to a `lint` step.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: typo

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* tools: Lint motivation object

Verifies that the motivation.json objects are
correct, and that the quote objects are all
structured properly.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* tools: add object value validation

Adds a function that validates each translation
object does not have any empty keys.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* tools: Log missing values with property chain

Modifies the value validation to log property names
as chains, for easier identification of misisng key
values.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix(tools): Correct typo

Corrects the typo in the motivation-schema.js comments

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-01-31 12:15:37 +05:30