1727 Commits

Author SHA1 Message Date
4ff9c2a6fc feat: update wording for string length (#45602) 2022-04-15 08:13:42 -07:00
832eb29c0d fix(learn): Change width for piano on step 28 (#45673)
* fix: change width on step 28

* fix: update step-33 seed

Co-authored-by: Rafael Hernandez <rafaeldavish@Rafaels-MacBook-Pro.local>
2022-04-15 09:36:24 -05:00
4cc20172c5 fix: fallback to english challenges (#45635)
* fix: fallback to english challenges

All challenges will use the english version if a translated file is not
available.  SHOW_NEW_CURRICULUM still gates what's shown in the client.

* refactor: use closures to simplify createChallenge

* refactor: remove messy destructure

* refactor: add meta via helper

* fix: fallback to [] for meta.required

* fix: repair challenge.block

* refactor: use CONST_CASE for meta + challenge dirs

* fix: catch empty superblocks immediately

* fix: clean up path.resolves

* fix: invalid syntax in JS project steps

* fix: default to english comments and relax tests

Instead of always throwing errors when a comment is not translated, the
tests now warn while SHOW_UPCOMING_CHANGES is true, so that tests will
pass while we're developing and allow translators time to work.

They still throw when SHOW_UPCOMING_CHANGES is false to catch issues
in production

* test: update createCommentMap test

* refactor: delete stale comment

* refactor: clarify validate with explanatory consts

* feat: throw if audited cert falls back to english

* fix: stop testing upcoming localized curriculum
2022-04-15 09:17:49 -05:00
8072041012 fix(curriculum): improve the wording of a challenge (#45677) 2022-04-12 22:05:14 -07:00
f88b272f79 chore: migrate instructions to learn (#45568)
* chore: migrate instructions to learn

* chore: apply sem's review suggestions

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>

* chore: apply tom's review suggestion

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2022-04-12 09:20:56 -05:00
7882ff1c94 fix(curriculum): adjusted hint img src
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2022-04-09 11:41:17 +00:00
c92a71e11e fix(curriculum): include note about counting spaces by .length property (#45641)
Added a sentence to bring attention to the fact that the JS string .length property counts space characters.
2022-04-09 12:27:50 +02:00
6af38bb240 fix(curriculum,i18n): issues in the source string (#45622)
* Added code formatting

* Removed dots from postscript since they break the emphasis tag
2022-04-05 14:23:16 -07:00
a6d2660c7c fix(curriculum): remove style note (#45625) 2022-04-05 13:49:27 -06:00
3a01deef48 fix(curriculum): attribute linked image to W3C (#45589)
Co-authored-by: Karen Lowe <klowe@ancestry.com>
2022-04-05 09:11:00 -06:00
b2c05d3c79 fix(curriculum): add removing element to the mutation test (#45581) 2022-04-05 15:59:46 +02:00
5494b7c90a fix(curriculum): copy edit for grammar (#45580)
* over-write -> overwrite

* fix(curriculum): correct grammar in lesson

* fix(curriculum): apply verbiage change to all English instances

Co-authored-by: Karen Lowe <klowe@ancestry.com>
Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>
2022-04-01 13:48:56 +02:00
405675261d fix(curriculum): clear up confusion of array index (#45576) 2022-03-30 20:45:20 +02:00
7fef4346a4 over-write -> overwrite (#45577)
Co-authored-by: Karen Lowe <klowe@ancestry.com>
2022-03-30 20:19:11 +02:00
fc22061a9e fix: expand the editable regions (#45526) 2022-03-30 19:05:13 +05:30
0a3690572c fix: failing challenge test because of commented out code (#45492)
id: 587d7b87367417b2b2512b43
title: Use Arrow Functions to Write Concise Anonymous Functions
forumTopicId: 301211
dashedName: use-arrow-functions-to-write-concise-anonymous-functions

User code tests fail when seed code is left and commented out.
2022-03-29 08:36:13 -07:00
40d7dc4af9 chore(learn): Remove colors shown as keywords (#45564) 2022-03-29 11:25:58 +02:00
e1262977ba chore: fixed mistakes in the source string (#45517)
Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>
2022-03-25 13:16:48 +01:00
dbb7f309a7 fix(curriculum): update instructions on step 49 (#45509)
Added the word "radio" to make the instructions explicit and clearer.
2022-03-23 15:21:23 +01:00
caaa416be0 fix(curriculum): fix method listings to improve readability of description (#45483)
* fix method listings

* fix lint
2022-03-22 12:07:30 -07:00
4d620dea1a fix(curriculum): allow spaces before brackets (#45494)
* chore(curriculum): update regex in use-braket-notation-* tests

Update regex used in tests, so that tests are more forgiving and spaces tolerant.

* Allow for spaces within brackets
2022-03-22 13:52:13 +01:00
3edc38e054 fix(curriculum): Change typo on step 76 (#45497) 2022-03-22 11:42:11 +05:30
d781c63fdf chore: resolve flagged Crowdin issues (#45442)
* chore: resolve bengali issues

* chore: resolve french issues

* chore: resolve hebrew issues

* chore: resolve persian issues

* chore: resolve portuguese brazilian issues

* chore: resolve russian issues

* chore: resolve spanish issues

* chore: resolve japanese issues
2022-03-19 13:26:57 +05:30
8a3cbde3df fix(curriculum): error in asserting initial state of redux store (#45457)
Initialize different store variable (_store) to prevent test failures in case user tested his own store in the exercise.
2022-03-18 18:42:04 +01:00
aa7c58f7e5 fix(curriculum): add missing quotation marks (#45460) 2022-03-18 18:28:42 +01:00
c46cf6e5ca fix(curriculum): fixed mistakes in the source string (#45448)
* chore: fixed mistakes in the source string

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-html-by-building-a-cat-photo-app/5ef9b03c81a63668521804e7.md

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>
2022-03-18 15:42:26 +00:00
17898b0ffc fix(curriculum): update meta naming inconsistencies (#45446)
Fixes incorrect uses of the word `tag` to refer to an element.
2022-03-17 20:13:16 +00:00
ce5b9b8aba fix(curriculum): augment test for adding tracks property (#45424)
* Only English

* Consitent quotation marks
2022-03-17 19:13:16 +00:00
85677bfcab fix(curriculum: removed repeated word in challenge (#45451) 2022-03-17 13:08:49 +01:00
dab600b4b1 chore: refactor the everything be true challenge (#45433) 2022-03-16 08:29:46 -07:00
25aa04e2e7 chore(curriculum): standardise titles for rwd-beta (#45398)
* chore(curriculum): accessibility-quiz

* chore(curriculum): cafe-menu

* chore(curriculum): ferris-wheel

* chore(curriculum): fix ferris-wheel tests

* chore(curriculum): colored-markers

* chore(curriculum): photo-gallery

* chore(curriculum): magazine

* chore(curriculum): penguin

* chore(curriculum): city-skyline

* chore(curriculum): registration-form

* chore(curriculum): picasso-painting

* chore(curriculum): balance-sheet

* chore(curriculum): piano

* chore(curriculum): rothko-painting

* fix: title min 15 chars
2022-03-14 16:54:43 +01:00
d3304276ca fix(curriculum) : Make tests stricter for challenge "Decrement a number with javascript" (#45242)
* Make tests stricter for challenge "Decrement a number with javascript" #44648

* Update decrement-a-number-with-javascript.md
2022-03-09 22:47:02 -06:00
b39716539b fix: use an invalid TLD for the test URL (#45375) 2022-03-09 10:52:31 +01:00
25c927e79b fix(curriculum): clarify unix value must be of type number (Timestamp Microservice) (#45341) 2022-03-07 10:42:25 +05:30
90c58ff349 fix:(RWD beta): correct parent selector (#45360) 2022-03-07 10:41:20 +05:30
982ba9b307 fix: unrevert verbiage changes (#45349)
* fix: unrevert verbiage changes

* fix: typo

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix(tools): update cypress test

* chore: apply sem's review

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>
2022-03-04 16:35:56 -06:00
Tom
e24c8abc7f revert: release rdbms to production (#45347) 2022-03-04 15:15:20 +01:00
Tom
84c305ab08 feat: release rdbms to production (#45169)
* fix: add cert to email for when all certs are earned

* fix: unhide rdbms from production

* fix: cert project input field

* feat: add cypress tests

* fix: message on project pages to lower expectations

* fix: update instructions

* fix: add quincy's suggestions

* fix: add beta label and reorder

* fix: utils test

* fix: move rdbms to bottom of settings

* fix: cypress tests

* Apply suggestions from code review

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: only drop seeded users webhook tokens

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-03-04 15:38:09 +05:30
592d49d19d fix(curriculum): add comma to fix syntax in example (#45320) 2022-03-02 20:50:37 +01:00
16e7cdedb1 feat: migrate filenames to IDs (#45146)
* feat: migrate filenames to IDs

* feat: migrate balance sheet file names

* revert: no id name for cert projects

* fix: i swear i know what i'm doing
2022-03-02 09:06:00 -06:00
01c1a54f17 fix(curriculum): formatting on project euler 356 (#45312) 2022-03-02 14:46:06 +01:00
470297027d fix(curriculum): remove outdated text (#45290) 2022-03-01 20:40:03 +05:30
8c37389701 fix(curriculum): fixed incorrect exponent display (#45284) 2022-02-28 23:00:30 +07:00
e1516b718e Added a missing assert for when the value is 70 (#45268) 2022-02-28 11:29:13 +01:00
5e5015e47d fix(curriculum): fix typo in challenge (#45270)
* fix typo in other languages

* Revert "fix typo in other languages"

This reverts commit b973317cc14fb4f719ec60f1bdfad83d0c03760f.

* remove typo in challenge
2022-02-28 08:54:19 +01:00
5300433783 fix: correct link to wikipedia
Standard Deviation -> Standard_deviation
2022-02-25 14:01:51 +01:00
a04c7e1096 test(curriculum): Add sudoku solver test cases (#45026) 2022-02-24 16:48:59 +05:30
1c65d5d34a fix(curriculum): remove callback thereby stripping js comments (#45133)
* fix: strip js comments

* fix: revert helper export, better test approach

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2022-02-24 16:29:56 +05:30
ea416b6dc2 fix(curriculum): add result of comparison expression evaluation to the inline comment (#45224)
* Add result of comparison expression evaluation in the inline comment #45183

* Apply suggestions from code review

thanks!

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
2022-02-23 18:58:42 +01:00
43a389b0c8 fix(curriculum): Remove root relative path from action URL in example (#45203) 2022-02-22 13:04:33 -06:00