33 Commits

Author SHA1 Message Date
d781c63fdf chore: resolve flagged Crowdin issues (#45442)
* chore: resolve bengali issues

* chore: resolve french issues

* chore: resolve hebrew issues

* chore: resolve persian issues

* chore: resolve portuguese brazilian issues

* chore: resolve russian issues

* chore: resolve spanish issues

* chore: resolve japanese issues
2022-03-19 13:26:57 +05:30
5f57667c7d fix: clarify slice-and-splice (#43170) 2021-08-11 17:00:44 +02:00
7117919d36 chore(learn): audit javascript algorithms and data structures (#41092)
* chore(learn): audit basic algorithm scripting

* chore(learn): audit basic data structures

* chore(learn): audit basic javascript

* chore(learn): audit debugging

* chore(learn): audit es6

* chore(learn): audit functional programming

* chore(learn): audit intermidate algorithms

* chore(learn): audit js projects

* chore(learn): audit object oriented programming

* chore(learn): audit regex

* fix(learn): remove stray .

* fix(learn): string to code

* fix(learn): missed some

* fix(learn): clarify strings

Based on Randy's feedback, clarifies string instances where quotes
were removed in favour of back ticks.

* fix: apply suggestions - thanks Randy! :)

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: non-suggestion comments

* chore(learn): remove comments from codes

Removes the comments from the description and instruction code
blocks to ensure that all relevant information is translatable.

* fix: Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: revert crowdin fix

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-algorithm-scripting/mutations.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-arrays.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: Apply suggestions from code review

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* chore: change voice

* fix: Christopher Nolan

* fix: expressions would evaluate

* fix: will -> would

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/object-oriented-programming/add-methods-after-inheritance.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: to work to push

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-with-javascript-for-loops.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/object-oriented-programming/add-methods-after-inheritance.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-03-02 17:12:12 -07:00
ee1e8abd87 feat(curriculum): restore seed + solution to Chinese (#40683)
* feat(tools): add seed/solution restore script

* chore(curriculum): remove empty sections' markers

* chore(curriculum): add seed + solution to Chinese

* chore: remove old formatter

* fix: update getChallenges

parse translated challenges separately, without reference to the source

* chore(curriculum): add dashedName to English

* chore(curriculum): add dashedName to Chinese

* refactor: remove unused challenge property 'name'

* fix: relax dashedName requirement

* fix: stray tag

Remove stray `pre` tag from challenge file.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: nhcarrigan <nhcarrigan@gmail.com>
2021-01-12 19:31:00 -07:00
0bd52f8bd1 Feat: add new Markdown parser (#39800)
and change all the challenges to new `md` format.
2020-11-27 10:02:05 -08:00
fb0812b6d2 fix(learn): added description about a nonallowed method (#40121) 2020-10-31 20:01:03 +01:00
2b9e38a17b fix: replace .english.md extension with .md 2020-09-29 22:09:04 +02:00
a86b220eb7 chore: remove isRequired from curriculum files 2020-09-21 20:51:46 +05:30
d8e8da36a0 Fixed tests for JS Basic Algorithms: Slice and Splice challenge as suggested in issue #39560 (#39610) 2020-09-18 11:30:56 -07:00
bd68b70f3d Feat: hide blocks not challenges (#39504)
* fix: remove isHidden flag from frontmatter

* fix: add isUpcomingChange

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

* feat: hide blocks not challenges

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
2020-09-03 15:07:40 -07:00
4b7ad8447b fix(learn): Added test for edge case (#39323)
* fix(learn): Added test for edge case

* Test checks edge cases for incorrect spelling in middle characters.

* fix: removed 'pen' sageTest

* the 'pen' points out that it is not the end of the first word to be tested for, but the end of the string.

However, this is explained clearly in the 'mountain' test below just as well.
2020-07-27 07:43:59 -07:00
0b700b5f78 fix(learn): clarify description for finders keepers (#39068)
* fix(learn): clarify description for finders keepers

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-07-14 09:29:53 +02:00
511238d36e challenges: description improvement (#39197)
Co-authored-by: PeterF521 <peterf521@gmail.com>
2020-07-07 06:10:04 -07:00
f1c9b08cf3 fix(curriculum): add isHidden: false to challenges
This includes certificates (where it does nothing), but does not
include any translations.
2020-05-25 16:25:19 +05:30
Tom
17a55c6e18 fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 1 of 4 (#38258)
* fix: consolidate/remove comments

* fix: remove => from comment

* fix: reverted changes to add same changes to another PR

* fix: removed 'the' from sentence

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: removed 'the' from the sentence

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-03-04 13:08:54 -06:00
f84173866a fix: make frankenSplice tests more robust (#38225) 2020-02-18 21:24:24 +05:30
afd467f5dc Removes RSA links from English challenges (#37869)
* RSA links deleted from challenges

* fix: remove remaining RSA links in challenges
2020-02-07 14:46:07 +09:00
3cc0395964 added a test to challenge:falsy-bouncer (#37973)
* added a test to challenge:falsy-bouncer

* modified tests of challenge:falsy-bouncer
2019-12-29 17:17:17 -06:00
8bd2fb8bc5 fix(i18n): delete duplicate text in test desc (#37975) 2019-12-23 20:47:10 +05:30
2c15bcbb43 fix(curriculum): changed test text to use should for JavaScript Algorithms and Data Structures (#37761)
* fix: corrected typo

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-27 11:57:38 +01:00
437ba8b103 fix(curriculum): Read-search-ask link now point to correct url as noted in the issue (#37753)
* fix: broken Read-search-ask link now point to correct url

* fix: changed link to original forum link with more views

* fix: changed http links to correct version

* fix: link in help modal
2019-11-19 19:54:48 -05:00
00914be3e8 Removed text about prior knowledge (#37722)
This section is now after Basic Javascript, but the challenge indicates that "function" and "return" are unknown at this point. Simply a product of an (apparent?) move.
2019-11-08 22:03:44 -05:00
8225ce7572 fix: added 3 new tests to mutations challenge (#36857) 2019-09-30 16:33:57 -04:00
568f00e02a fix(curriculum): Added forumTopicId to remaining 1200 challeng… (#36558) 2019-08-05 22:14:37 +05:30
3ec1fe8ea7 feat: add forumTopicId to challenge frontmatter [pre-existing]
This commit adds the pre-existing challenge guide topics in the
forum to the forntmatter of their challenge markdown files.
2019-08-05 22:14:37 +05:30
ba6ae7154c fix: removed more assert msg arguments (#36439) 2019-07-28 05:16:04 +01:00
5bf8527523 fix(curriculum): Remove unnecessary assert message argument from English challenges JavaScript Algorithms and Data Structures - 02 (#36402)
* fix: rm assert msg basic-algorithm-scripting

* fix: rm assert msg debugging

* fix: rm assert msg es6

* fix: rm assert msg functional-programming
2019-07-24 10:47:32 +02:00
545b8a6f34 Modify if statement (#36088)
* Modify if statement

Change the solution so an empty string is returned when num is less than 1 rather than less than 0 for consistency with instructions.

* Add test 

New test checks that if num is 0, an empty string is returned

* Fix test 

Fixing errors in newly proposed test that checks that empty string is returned when num is 0

* Modify intermediate solution

Changing if statement in intermediate solution to check whether num is less than 1 rather than less than 0. (Also adding curly brackets to that solutions if/else statements.)

* fix: removed unnecessary assert message arguments
2019-05-20 21:08:20 -04:00
b2e514d39f A better solution to finders-keepers.english.md (#34759)
* Update finders-keepers.english.md

A better approach to finder's keepers problem

* A better appoach to solve finders-keepers (JS)

Fixed travis bug

* fix: indented solution code
2019-02-10 20:13:48 -08:00
79d9012432 fix(curriculum): quotes in tests (#18828)
* fix(curriculum): tests quotes

* fix(curriculum): fill seed-teardown

* fix(curriculum): fix tests and remove unneeded seed-teardown
2018-10-20 23:32:47 +05:30
ee9f6b2d72 chore(meta): Move challenge meta to challenges root 2018-10-11 02:15:05 +05:30
a859035023 fix(challenge-md): Fix quotes that failed in the transform 2018-10-08 11:38:26 +05:30
8f39bc1288 chore(curriculum): Remove files in wrong format 2018-10-05 15:58:12 +01:00