70 Commits

Author SHA1 Message Date
832eb29c0d fix(learn): Change width for piano on step 28 (#45673)
* fix: change width on step 28

* fix: update step-33 seed

Co-authored-by: Rafael Hernandez <rafaeldavish@Rafaels-MacBook-Pro.local>
2022-04-15 09:36:24 -05:00
8072041012 fix(curriculum): improve the wording of a challenge (#45677) 2022-04-12 22:05:14 -07:00
7882ff1c94 fix(curriculum): adjusted hint img src
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2022-04-09 11:41:17 +00:00
6af38bb240 fix(curriculum,i18n): issues in the source string (#45622)
* Added code formatting

* Removed dots from postscript since they break the emphasis tag
2022-04-05 14:23:16 -07:00
fc22061a9e fix: expand the editable regions (#45526) 2022-03-30 19:05:13 +05:30
e1262977ba chore: fixed mistakes in the source string (#45517)
Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>
2022-03-25 13:16:48 +01:00
dbb7f309a7 fix(curriculum): update instructions on step 49 (#45509)
Added the word "radio" to make the instructions explicit and clearer.
2022-03-23 15:21:23 +01:00
3edc38e054 fix(curriculum): Change typo on step 76 (#45497) 2022-03-22 11:42:11 +05:30
d781c63fdf chore: resolve flagged Crowdin issues (#45442)
* chore: resolve bengali issues

* chore: resolve french issues

* chore: resolve hebrew issues

* chore: resolve persian issues

* chore: resolve portuguese brazilian issues

* chore: resolve russian issues

* chore: resolve spanish issues

* chore: resolve japanese issues
2022-03-19 13:26:57 +05:30
c46cf6e5ca fix(curriculum): fixed mistakes in the source string (#45448)
* chore: fixed mistakes in the source string

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-html-by-building-a-cat-photo-app/5ef9b03c81a63668521804e7.md

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>
2022-03-18 15:42:26 +00:00
17898b0ffc fix(curriculum): update meta naming inconsistencies (#45446)
Fixes incorrect uses of the word `tag` to refer to an element.
2022-03-17 20:13:16 +00:00
85677bfcab fix(curriculum: removed repeated word in challenge (#45451) 2022-03-17 13:08:49 +01:00
25aa04e2e7 chore(curriculum): standardise titles for rwd-beta (#45398)
* chore(curriculum): accessibility-quiz

* chore(curriculum): cafe-menu

* chore(curriculum): ferris-wheel

* chore(curriculum): fix ferris-wheel tests

* chore(curriculum): colored-markers

* chore(curriculum): photo-gallery

* chore(curriculum): magazine

* chore(curriculum): penguin

* chore(curriculum): city-skyline

* chore(curriculum): registration-form

* chore(curriculum): picasso-painting

* chore(curriculum): balance-sheet

* chore(curriculum): piano

* chore(curriculum): rothko-painting

* fix: title min 15 chars
2022-03-14 16:54:43 +01:00
90c58ff349 fix:(RWD beta): correct parent selector (#45360) 2022-03-07 10:41:20 +05:30
16e7cdedb1 feat: migrate filenames to IDs (#45146)
* feat: migrate filenames to IDs

* feat: migrate balance sheet file names

* revert: no id name for cert projects

* fix: i swear i know what i'm doing
2022-03-02 09:06:00 -06:00
431bcbda10 refactor(curriculum): new balance sheet project (#45048)
* refactor: delete existing steps

* feat: create new steps

* feat: start writing tests

* feat: complete html tests

* feat: remaining tests

* chore: remove "test 1"

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fix: wow I really botched that find and replace

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>

* fix: why firefox gotta be different?

* fix: I can maths...

* chore: apply shaun's review suggestions

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fix: unbotch the css oops

* fix: acme widget corp

* fix: remove z-index

* feat: introduce the calc() function

* fix: even one more find and replace oops

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>
2022-02-18 19:15:16 +01:00
ed88a25359 fix(curriculum): add test cases to ferris-wheel project #45099 (#45134)
* added tests to satisfy first-of-type and last-of-type

* edited hints to require nth-of-type selector

* refactor for readability
2022-02-17 11:15:11 -08:00
fdd20700da fix(curriculum): typography step 43 tests pass in safari (#44984)
* meta tag accepts valid html

* Fix step 43 tests for safari

* Incorporating suggestions from PR

* incorporating suggestions from PR

* added fix for step17
2022-02-10 16:43:24 -08:00
fe3187a4d7 fix: RWD beta update remaining doctype first tests (#44996) 2022-02-10 16:28:55 -06:00
ee0fb44c62 fix(curriculum): removed step 28 and edited meta.json (#44856) 2022-02-10 10:27:55 -06:00
f09c167a03 fix(curriculum): correct hint text for step-093 penguin (#45023) 2022-02-05 13:12:18 +01:00
4173c2783a fix(curriculum): reword city-skyline lesson description (#44839)
Co-authored-by: “Jim” <“jimkernicky@gmail.com”>
2022-01-31 12:38:13 +00:00
0f27af6b46 fix(curriculum): rwd beta update doctype tests (#44829) 2022-01-31 11:57:05 +00:00
a196848bd0 Update step-028.md (#44971) 2022-01-30 20:00:22 -08:00
6a896919b1 fix(curriculum): correct tests for Firefox (#44913) 2022-01-26 10:09:42 +07:00
54a15c6589 fix(curriculum): allow code on new lines for camper-cafe (#44891) 2022-01-25 17:29:28 -06:00
98a0d3ecd2 correcting typo adaquate = adequate (#44906) 2022-01-25 17:15:58 -06:00
b1fb6adc39 fix: insert user html more consistently (#42195)
* fix: use an iframe to preserve head and body

* fix: remove unnecessary parsing of html

The contents gets inserted into the DOM during transformHtml, which
is always part of the build pipeline

* fix: pipe contents through iframe

* refactor: use the same code for both transforms

* fix: try to handle test errors better

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2022-01-24 18:02:25 +00:00
2abfa63738 fix(curriculum): typo on step 43 2022-01-22 19:03:23 +01:00
59f21b1d8f fix(curriculum): improve instructions in rothko-painting (#44816)
* Improved instructions in rothko painting lesson

* Removed duplicate line in step 42

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-the-css-box-model-by-building-a-rothko-painting/step-012.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-the-css-box-model-by-building-a-rothko-painting/step-014.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-the-css-box-model-by-building-a-rothko-painting/step-015.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-the-css-box-model-by-building-a-rothko-painting/step-021.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-the-css-box-model-by-building-a-rothko-painting/step-022.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-the-css-box-model-by-building-a-rothko-painting/step-034.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-the-css-box-model-by-building-a-rothko-painting/step-041.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-the-css-box-model-by-building-a-rothko-painting/step-042.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-the-css-box-model-by-building-a-rothko-painting/step-044.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-the-css-box-model-by-building-a-rothko-painting/step-045.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-the-css-box-model-by-building-a-rothko-painting/step-020.md

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-the-css-box-model-by-building-a-rothko-painting/step-014.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-the-css-box-model-by-building-a-rothko-painting/step-034.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>
2022-01-21 14:31:41 +01:00
5aaf8677d4 chore: fix typo in step-010.md (#44807)
targetting -> targeting
2022-01-20 09:18:07 +01:00
357b4802fd fix: update wording in description (#44842) 2022-01-20 09:13:35 +01:00
9c800526a7 fix: correct typo in 'targetting' - line 12 (#44823) 2022-01-19 13:36:32 +01:00
9848b05458 Fix (curriculum): wording (#44815) 2022-01-18 08:54:23 -06:00
6f30720715 fix(curriculum): improve wording (#44799) 2022-01-17 22:02:13 +07:00
401cd86076 fix(curriculum): move img tag to editable region (#44804)
* Step 24: moved img tag to editble region

* Indented img tag

Co-authored-by: “Jim” <“jimkernicky@gmail.com”>
Co-authored-by: "Krzysztof G." <"60067306+gikf@users.noreply.github.com">
2022-01-17 14:36:18 +01:00
d53a457fc2 Fix typo mentioned in issue #44761 (#44768) 2022-01-12 21:35:28 -08:00
ef417c95f9 fix(curriculum): make english to i18n easier (#44711) 2022-01-12 10:03:26 -06:00
9655cd26a1 fix(curriculum): typo in cat photo app (#44757) 2022-01-12 11:08:37 +01:00
43f970aa3f fix(curriculum): Additional clarification in hint (#44746) 2022-01-11 15:32:37 +01:00
09a41ccd38 fix(curriculum): typos in building-a-piano (#44729)
* fix(curriculum): typos in BETA  Piano Build section

* Added back the id and class characters

Co-authored-by: “Jim” <“jimkernicky@gmail.com”>
2022-01-10 13:35:59 +01:00
72d989c681 fix(curriculum): correct spelling error (#44727)
Changed the incorrect spelling (rbg) to the correct spelling (rgb)
2022-01-09 07:11:18 +01:00
3416a4adef fix(curriculum): typos in balance-sheet (#44693)
Co-authored-by: “Jim” <“jimkernicky@gmail.com”>
2022-01-08 15:53:47 +00:00
9cbd7f3b28 fix(curriculum): "locaton" changed to "location" (#44717) 2022-01-07 19:15:11 +01:00
82c4bf9556 fix(curriculum): possible typo and simplification (#44704)
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2022-01-07 16:36:49 +05:30
9b6dc9ee34 fix(curriculum): clarify instruction regarding color (#44688)
* Added instruction to clarify color should be red

* Added comma before "and" for punctuation

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2022-01-06 20:26:43 +01:00
340581e888 fix(curriculum): typos in accessibility-quiz (#44681)
Co-authored-by: “Jim” <“jimkernicky@gmail.com”>
2022-01-05 09:36:58 -08:00
75f64d1728 fix(curriculum): change tests to make them pass on firefox (#44685) 2022-01-05 09:12:10 -08:00
ddbe5f3fc0 fix(curriculum): typo in cat-photo app (#44678)
There was a typo in tenth line. I changed it from "withing" to "within".
2022-01-05 09:02:16 -08:00
f04ec72c44 fix(curriculum): typos in rothko-painting (#44644)
* fix(curriculum): typos in Rothko Painting section

* Set step 36 back to original wording

Co-authored-by: “Jim” <“jimkernicky@gmail.com”>
2022-01-04 21:09:41 +01:00