Commit Graph

27 Commits

Author SHA1 Message Date
Oliver Eyton-Williams
e118dda13a fix: order imports and remove circular dependencies (#41824)
* fix: remove circular dependency

redux depended on templates/Challenges/redux and vice versa.  This
meant that import order mattered and confusing bugs could arise.

(cherry picked from commit 7d67a4e70922bbb3051f2f9982dcc69e240d43dc)

* feat: require imports to be in alphabetical order

Import order generally does not matter, but there are edge cases
(circular  imports and css imports, for example) where changing order
changes behaviour

(cherry picked from commit b8d1393a91ec6e068caf8e8498a5c95df68c2b2c)

* chore: order imports

* fix: lift up challenge description + title comps

This brings the classic Show closer to the others as they
now all create the description and title components

* fix: remove donation-saga/index circular import

(cherry picked from commit 51a44ca668a700786d2744feffeae4fdba5fd207)

* refactor: extract action-types from settings

(cherry picked from commit 25e26124d691c84a0d0827d41dafb761c686fadd)

* fix: lint errors

* feat: prevent useless renames
2021-08-02 08:39:40 -05:00
ABHINAV SHARMA
e2ca65c803 feat(client): ts-migrate layoutSelector component (#42748) 2021-07-12 14:05:01 +07:00
Ahmad Abdolsaheb
4879d26604 fix(client): inject bootstrap tags to the top of head (#40804) 2021-01-31 12:15:40 +05:30
Ahmad Abdolsaheb
3ec468be38 feat: optimize head tags (#40630)
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2021-01-31 12:15:39 +05:30
Tom
a6432ec561 fix(client): translation hydration (#40469)
* fix: translation hydration
2021-01-31 12:15:33 +05:30
Kristofer Koishigawa
849e78d72e feat: enable MathJax for Project Euler challenges (#38017)
* feat: enable MathJax for Project Euler challenges

Enables MathJax to render mathematical formulae for some Project Euler problems

* refactor: DRY out script insertion

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-01-07 14:14:12 +03:00
Kristofer Koishigawa
77b27d79f6 fix: conditionally load MathJax (#37360)
* fix: Removed MathJax CDN from header and set it up to download whenever a user goes to a Rosetta Code challenge

* Reworked slightly so that MathJax CDN script is only rendered once

* Simplified further

* Resolved conflicts and updated MathJax fallback to work like the one on donate.js

* Escaped backticks in scriptLoaders.js

* refactor: remove reliance on state
2019-10-30 15:46:39 +03:00
Oliver Eyton-Williams
058e0b7f8f feat: SSR MathJax and Stripe on routes using them (#37388)
* feat: SSR MathJax and Stripe on routes using them

* refactor: clean up scripts
2019-10-18 21:15:34 +05:30
Ahmad Abdolsaheb
78b6fd1adf fix: load stripe conditionally (#37365) 2019-10-17 18:21:01 +05:30
mrugesh
2e82c76b53 Revert "feat: load scripts conditionally based on path " (#37351)
This reverts commit 87be96a244.
2019-10-17 02:41:33 +05:30
Ahmad Abdolsaheb
87be96a244 feat: load scripts conditionally based on path (#37344) 2019-10-17 00:44:53 +05:30
mrugesh
a2762fe4c3 fix: remove rollbar from loading in client (#37338) 2019-10-16 17:33:08 +05:30
Bouncey
15f18d1cda fix: Dedupe layout selection logic 2019-06-08 03:16:28 +05:30
Oliver Eyton-Williams
17e112d25e fix(client): make top navigation menu replaceable (#35943)
* fix(client): Stop using react-responsive and use media queries to display menu

* Change guide to show menu

* DRYed out a bit

* Restore main, top-right nav to guide

* fix: Separate guide and top menu state

* Update client/src/components/Header/index.js

Co-Authored-By: Valeriy <ValeraS@users.noreply.github.com>

* Update client/src/components/Header/index.js

Co-Authored-By: Valeriy <ValeraS@users.noreply.github.com>

* Update client/src/components/Header/index.js

Co-Authored-By: Valeriy <ValeraS@users.noreply.github.com>

* Update client/src/components/Header/index.js

Co-Authored-By: Valeriy <ValeraS@users.noreply.github.com>

* fix: Refactor menu button and links

* feat(client): make top navigation menu replaceable

* fix: Refactor nav menu logic out of Header

* fix(client): use default nav menu in header and use landingPage props instead of disableSettings
2019-05-26 20:36:23 +03:00
Ahmad Abdolsaheb
b5b3482d0e fix: wire menu to redux and add change meanu breakpoint for guide 2019-03-01 13:02:29 +00:00
Ahmad Abdolsaheb
357b824033 fix: custom menu for guide 2019-03-01 13:02:29 +00:00
mrugesh mohapatra
293e58cc23 fix(certs): remove footer and nav from certs (#35333)
* fix(certs): remove footer and nav from certs

* fix: revert spacing on cert
2019-02-22 18:06:47 +03:00
Valeriy
fc8c71ad16 feat: use eslint with prettier to format code 2019-02-19 14:30:27 +05:30
Valeriy
1a889d9f3f fix(footer): change nonLearnPage to showFooter 2019-02-18 14:39:56 +00:00
Mrugesh Mohapatra
71cf52144e fix(footer): show only on non-learn pages 2019-02-18 14:39:56 +00:00
Valeriy
a44935a520 fix(client): do not unmount Guide Layout on navigate 2019-01-28 12:02:45 +00:00
Valeriy
28ee458ceb fix(client): do not unmount default layout on navigate 2019-01-28 12:02:45 +00:00
Valeriy S
83ef4ebee1 fix(client): remove chai from a body 2019-01-14 13:44:54 +00:00
Stuart Taylor
d327a5c36b Feat: News in the client app (#34392) 2018-11-29 15:12:15 +03:00
Bouncey
6e728ce16d feat(guide): Import guide in to the client app 2018-10-05 15:58:12 +01:00
Bouncey
5b254f3ad6 chore(learn): Merge learn in to the client app 2018-09-30 12:42:40 +01:00
Bouncey
e59ad6ebda chore(client): Move client app to /client 2018-09-03 17:47:48 +05:30