Randell Dawson
5bf8527523
fix(curriculum): Remove unnecessary assert message argument from English challenges JavaScript Algorithms and Data Structures - 02 ( #36402 )
...
* fix: rm assert msg basic-algorithm-scripting
* fix: rm assert msg debugging
* fix: rm assert msg es6
* fix: rm assert msg functional-programming
2019-07-24 10:47:32 +02:00
Oliver Eyton-Williams
b8593326b0
fix: remove guide linting and fix failing challenges
2019-07-19 15:30:17 +05:30
Randell Dawson
c387873640
fix(curriculum): added extra line before </section> tag - Engl… ( #36278 )
2019-07-19 15:30:17 +05:30
moT01
9ce8bbb4c0
fix/add-suggested-grammar-and-punctuation
2019-07-12 22:44:23 +09:00
moT01
d3cf6f42dd
fix/grammar+punctuation
2019-07-12 22:44:23 +09:00
moT01
fa365a7f77
fix/capitalization-in-title
2019-07-12 22:44:23 +09:00
moT01
832cbc91b1
fix/the-mess-I-made
2019-07-12 22:44:23 +09:00
moT01
da254743cd
feat/new-lessons-on-js-promises
2019-07-12 22:44:23 +09:00
lasjorg
f03f05d53d
fix(challenge): rename challenge, change fields to properties, fix test ( #36338 )
...
* fix(challenge): rename challenge, change fields to properties, fix test
* fix(challenge): update challenge name in meta.json
* fix(challenge): update test and assertion message
* fix(challenge): update second assert message
* fix(challenge): remove the word Person from text
2019-07-10 10:31:15 +02:00
Tom
50b45b9379
Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/create-an-export-fallback-with-export-default.english.md
...
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2019-06-28 16:04:59 +08:00
moT01
2e49aa02df
fix/add-anonymous-function-example
2019-06-28 16:04:59 +08:00
moT01
9c1b83dd0c
fix/add-tests+note-in-import-lesson
2019-06-28 16:04:59 +08:00
moT01
9199319ae1
fix/build-error
2019-06-28 16:04:59 +08:00
moT01
9c249bf8be
fix/build-error
2019-06-28 16:04:59 +08:00
moT01
d68475e7ea
fix/build-error
2019-06-28 16:04:59 +08:00
moT01
61895e05f7
fix/final-draft-before-reviews
2019-06-28 16:04:59 +08:00
moT01
f14f1bf750
fix/rename-lessons
2019-06-28 16:04:59 +08:00
moT01
23d723a71f
fix/add-tests
2019-06-28 16:04:59 +08:00
moT01
2e6cb9181a
fix/revise-es6-import-export-lessons
2019-06-28 16:04:59 +08:00
moT01
6e8bbd169b
fix/final-draft-before-reviews
2019-06-28 16:04:59 +08:00
moT01
956212cdc0
fix/rename-lessons
2019-06-28 16:04:59 +08:00
moT01
8b5cc6d277
fix/add-tests
2019-06-28 16:04:59 +08:00
moT01
8a579210e3
fix/revise-es6-import-export-lessons
2019-06-28 16:04:59 +08:00
moT01
00b5ce97e3
fix/verbiage
2019-06-27 15:48:07 +08:00
Tom
72cb38a839
Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-objects.english.md
...
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2019-06-27 15:48:07 +08:00
moT01
3b96f3e60d
fix/terminology
2019-06-27 15:48:07 +08:00
Tom
81758eeea6
Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-nested-objects.english.md
...
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
2019-06-27 15:48:07 +08:00
Tom
d2c5cc7ff3
Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-nested-objects.english.md
...
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
2019-06-27 15:48:07 +08:00
Tom
9f4799bba1
Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-nested-objects.english.md
...
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
2019-06-27 15:48:07 +08:00
Tom
e58c512052
Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-objects.english.md
...
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
2019-06-27 15:48:07 +08:00
moT01
d0e5405e5c
fix/make-tests-more-robust
2019-06-27 15:48:07 +08:00
moT01
21b411b855
fix/bad-solution
2019-06-27 15:48:07 +08:00
moT01
246ca16f32
fix/es6-destructuring-reword+new-lesson
2019-06-27 15:48:07 +08:00
Randell Dawson
05f73ca409
fix(curriculum): Convert blockquote elements to triple backtick syntax for JavaScript Algorithms and Data Structures ( #35992 )
...
* fix: convert js algorithms and data structures
* fix: revert some blocks back to blockquote
* fix: reverted comparison code block to blockquotes
* fix: change js to json
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix: convert various section to triple backticks
* fix: Make the formatting consistent for comparisons
2019-05-17 08:20:30 -05:00
Randell Dawson
4b4762716c
fix(curriculum): Rewrote the Write Higher-Order Arrow Functions challenge and moved to Functional Programming section ( #35954 )
...
* fix: reworded and moved challenge
* fix: removed extra line
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com >
* fix; removed extra line
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com >
* fix: reworded sentence
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com >
2019-05-15 11:12:17 -05:00
Deanna Tran
338d7ee8a7
Change "rest operator" to say "rest parameter" in challenges and guide ( #35496 )
...
* change es6 challenges rest operator to param
* fix rest parameter typos
* change rest operator to parameter in guide
* fix casing
* change rest operator to rest parameter in guide
* change rest operator to rest parameter in curriculum
* remove extra whitespace
* remove whitespaces
* remove whitespace
* fix: removed arabic file
* fix: removed chinese file
2019-05-08 16:30:24 +02:00
Randell Dawson
7d7a1127a7
fix: remove comments before tests ( #35906 )
2019-04-30 19:26:07 -05:00
Aly Pilkons
dae22c95c3
Edit Instructions Text To Make Goal Clearer ( #35887 )
...
* Edit Instructions Text To Make Goal Clearer
The instructions end with "using the object provided" which is unclear since the user is expected to create their own name for the object. Users may think they need to reference an object name and be confused when they do not find it. Reiterating that the user needs to create the name for the object themselves makes the task clearer.
* Updated commit based on comments
2019-04-26 18:33:04 +05:30
BSi
f8555c2f8b
Added the semicolon in the example provided ( #35898 )
2019-04-23 19:26:50 -04:00
Илья
a326c2cf9a
Make a comparison in the test more accurately ( #35500 )
...
* Update use-arrow-functions-to-write-concise-anonymous-functions.english.md
* refactor: fix the assert messages to make them more like all the rest in the curriculum (i.e. using `should`)
Co-Authored-By: iliyaZelenko <iliyazelenkog@gmail.com >
2019-04-01 10:55:43 +02:00
Amy Lam
914a7c522d
Copy edits ( #35536 )
...
* Copy edits to Basic JavaScript section
* Copy edits to ES6 section
* Update index.md
2019-03-29 22:06:58 +05:30
Lipis
e84ae45008
Javascript -> JavaScript (English) ( #35183 )
...
* Javascript -> JavaScript (English)
* Update technical documentation page for required change
* Update use-class-syntax-to-define-a-constructor-function.english.md
* Update left-factorials.md
2019-03-28 14:05:41 +05:30
Randell Dawson
6c82a07b2d
fix: made destructuring test more flexible ( #35685 )
2019-03-27 23:59:53 +05:30
Justin Hilliard
8b5ef8cfdd
Fix(Curriculum): Constructor function not explained before ES6 #17865 ( #35463 )
...
* Fix(Curriculum): Constructor function not explained before ES6 #17865
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-class-syntax-to-define-a-constructor-function.english.md
Co-Authored-By: hilliarj <hilliarj@dickinson.edu >
* Update to #17865 PR
Fix(Curriculum): Constructor function not explained before ES6. Used an unordered list and the syntax that others recommended.
2019-03-26 09:53:19 -07:00
seanlaing
e4870c472a
fix/update-es6-destructor-challenge: Added test ( #35455 )
...
* fix/update-es6-destructor-challenge: Added test
- Added test incase during destructuring somebody pass and extra key
* fix/update-es6-destructor-challenge: Fixed the test case per review comments
-Cleaned up regex
- Setup two cases one where additional assignment of variables before and then after
- Did not put uppercase case CONSTANT checks because not related to question
* fix: corrected tests
2019-03-25 15:49:56 -05:00
Aditya
9cca21f57f
[Fix] Removed unnecessary IIFEs from ES6 challenges ( #34538 )
...
* feat: removed IIFE and added solution
* feat: updated challenges seed, test and solution
* style: removed semicolon
* feat: updated seed and solution
* feat: updated challenges seed and solution
* feat: updated test, seed and solution
* fix: added seed code to solution
* fix: removed function and added solution
* fix: removed makeClass function and fixed solution
* style: removed excessive semicolons
* Fixed spacing for note in instructions section
* fix: removed assert messages and used const
* fix: regex fails correctly now
2019-03-25 09:19:34 -05:00
Hugo
739f4a8850
fix: Update test for ES6 challenge ( #34300 )
...
* fix: es6 challenge test
* delete console.log
2019-03-21 10:50:30 +01:00
Chuck Adams
4b2219b01d
close #35246 - change AVG_TEMPERATURES to avgTemperatures in instructions ( #35537 )
2019-03-20 22:02:21 +01:00
Lewis Horwood
38c99d7ff5
Simplify challenge wording ( #25120 )
...
* Simplify challenge wording
* Update use--to-import-everything-from-a-file.english.md
2019-03-06 18:57:43 -05:00
Alan Price
27a59c5418
fix: reworded text messages ( #27072 )
2019-03-06 18:30:58 -05:00