Commit Graph

55 Commits

Author SHA1 Message Date
Naomi Carrigan
431bcbda10 refactor(curriculum): new balance sheet project (#45048)
* refactor: delete existing steps

* feat: create new steps

* feat: start writing tests

* feat: complete html tests

* feat: remaining tests

* chore: remove "test 1"

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fix: wow I really botched that find and replace

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>

* fix: why firefox gotta be different?

* fix: I can maths...

* chore: apply shaun's review suggestions

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fix: unbotch the css oops

* fix: acme widget corp

* fix: remove z-index

* feat: introduce the calc() function

* fix: even one more find and replace oops

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>
2022-02-18 19:15:16 +01:00
wbenarto
ed88a25359 fix(curriculum): add test cases to ferris-wheel project #45099 (#45134)
* added tests to satisfy first-of-type and last-of-type

* edited hints to require nth-of-type selector

* refactor for readability
2022-02-17 11:15:11 -08:00
Steven
fdd20700da fix(curriculum): typography step 43 tests pass in safari (#44984)
* meta tag accepts valid html

* Fix step 43 tests for safari

* Incorporating suggestions from PR

* incorporating suggestions from PR

* added fix for step17
2022-02-10 16:43:24 -08:00
Bruce B
fe3187a4d7 fix: RWD beta update remaining doctype first tests (#44996) 2022-02-10 16:28:55 -06:00
wbenarto
ee0fb44c62 fix(curriculum): removed step 28 and edited meta.json (#44856) 2022-02-10 10:27:55 -06:00
Shaun Hamilton
f09c167a03 fix(curriculum): correct hint text for step-093 penguin (#45023) 2022-02-05 13:12:18 +01:00
Jim Kernicky
4173c2783a fix(curriculum): reword city-skyline lesson description (#44839)
Co-authored-by: “Jim” <“jimkernicky@gmail.com”>
2022-01-31 12:38:13 +00:00
Bruce B
0f27af6b46 fix(curriculum): rwd beta update doctype tests (#44829) 2022-01-31 11:57:05 +00:00
Gautam Hegde
a196848bd0 Update step-028.md (#44971) 2022-01-30 20:00:22 -08:00
Krzysztof G
6a896919b1 fix(curriculum): correct tests for Firefox (#44913) 2022-01-26 10:09:42 +07:00
Shaun Hamilton
54a15c6589 fix(curriculum): allow code on new lines for camper-cafe (#44891) 2022-01-25 17:29:28 -06:00
Juan Alberto González
98a0d3ecd2 correcting typo adaquate = adequate (#44906) 2022-01-25 17:15:58 -06:00
Oliver Eyton-Williams
b1fb6adc39 fix: insert user html more consistently (#42195)
* fix: use an iframe to preserve head and body

* fix: remove unnecessary parsing of html

The contents gets inserted into the DOM during transformHtml, which
is always part of the build pipeline

* fix: pipe contents through iframe

* refactor: use the same code for both transforms

* fix: try to handle test errors better

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2022-01-24 18:02:25 +00:00
Anmol Pandita
2abfa63738 fix(curriculum): typo on step 43 2022-01-22 19:03:23 +01:00
Darshan Vaishya
59f21b1d8f fix(curriculum): improve instructions in rothko-painting (#44816)
* Improved instructions in rothko painting lesson

* Removed duplicate line in step 42

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-the-css-box-model-by-building-a-rothko-painting/step-012.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-the-css-box-model-by-building-a-rothko-painting/step-014.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-the-css-box-model-by-building-a-rothko-painting/step-015.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-the-css-box-model-by-building-a-rothko-painting/step-021.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-the-css-box-model-by-building-a-rothko-painting/step-022.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-the-css-box-model-by-building-a-rothko-painting/step-034.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-the-css-box-model-by-building-a-rothko-painting/step-041.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-the-css-box-model-by-building-a-rothko-painting/step-042.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-the-css-box-model-by-building-a-rothko-painting/step-044.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-the-css-box-model-by-building-a-rothko-painting/step-045.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-the-css-box-model-by-building-a-rothko-painting/step-020.md

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-the-css-box-model-by-building-a-rothko-painting/step-014.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-the-css-box-model-by-building-a-rothko-painting/step-034.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>
2022-01-21 14:31:41 +01:00
Ikko Ashimine
5aaf8677d4 chore: fix typo in step-010.md (#44807)
targetting -> targeting
2022-01-20 09:18:07 +01:00
Jason Barry
357b4802fd fix: update wording in description (#44842) 2022-01-20 09:13:35 +01:00
Chris Castle
9c800526a7 fix: correct typo in 'targetting' - line 12 (#44823) 2022-01-19 13:36:32 +01:00
Glenn Lanzer
9848b05458 Fix (curriculum): wording (#44815) 2022-01-18 08:54:23 -06:00
SaarthakMaini
6f30720715 fix(curriculum): improve wording (#44799) 2022-01-17 22:02:13 +07:00
Jim Kernicky
401cd86076 fix(curriculum): move img tag to editable region (#44804)
* Step 24: moved img tag to editble region

* Indented img tag

Co-authored-by: “Jim” <“jimkernicky@gmail.com”>
Co-authored-by: "Krzysztof G." <"60067306+gikf@users.noreply.github.com">
2022-01-17 14:36:18 +01:00
mdSrq
d53a457fc2 Fix typo mentioned in issue #44761 (#44768) 2022-01-12 21:35:28 -08:00
Shaun Hamilton
ef417c95f9 fix(curriculum): make english to i18n easier (#44711) 2022-01-12 10:03:26 -06:00
Juan Alberto González
9655cd26a1 fix(curriculum): typo in cat photo app (#44757) 2022-01-12 11:08:37 +01:00
Etkesmeci
43f970aa3f fix(curriculum): Additional clarification in hint (#44746) 2022-01-11 15:32:37 +01:00
Jim Kernicky
09a41ccd38 fix(curriculum): typos in building-a-piano (#44729)
* fix(curriculum): typos in BETA  Piano Build section

* Added back the id and class characters

Co-authored-by: “Jim” <“jimkernicky@gmail.com”>
2022-01-10 13:35:59 +01:00
Reuben Menezes
72d989c681 fix(curriculum): correct spelling error (#44727)
Changed the incorrect spelling (rbg) to the correct spelling (rgb)
2022-01-09 07:11:18 +01:00
Jim Kernicky
3416a4adef fix(curriculum): typos in balance-sheet (#44693)
Co-authored-by: “Jim” <“jimkernicky@gmail.com”>
2022-01-08 15:53:47 +00:00
Etkesmeci
9cbd7f3b28 fix(curriculum): "locaton" changed to "location" (#44717) 2022-01-07 19:15:11 +01:00
Etkesmeci
82c4bf9556 fix(curriculum): possible typo and simplification (#44704)
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2022-01-07 16:36:49 +05:30
Darshan Vaishya
9b6dc9ee34 fix(curriculum): clarify instruction regarding color (#44688)
* Added instruction to clarify color should be red

* Added comma before "and" for punctuation

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2022-01-06 20:26:43 +01:00
Jim Kernicky
340581e888 fix(curriculum): typos in accessibility-quiz (#44681)
Co-authored-by: “Jim” <“jimkernicky@gmail.com”>
2022-01-05 09:36:58 -08:00
Krzysztof G
75f64d1728 fix(curriculum): change tests to make them pass on firefox (#44685) 2022-01-05 09:12:10 -08:00
Etkesmeci
ddbe5f3fc0 fix(curriculum): typo in cat-photo app (#44678)
There was a typo in tenth line. I changed it from "withing" to "within".
2022-01-05 09:02:16 -08:00
Jim Kernicky
f04ec72c44 fix(curriculum): typos in rothko-painting (#44644)
* fix(curriculum): typos in Rothko Painting section

* Set step 36 back to original wording

Co-authored-by: “Jim” <“jimkernicky@gmail.com”>
2022-01-04 21:09:41 +01:00
Jim Kernicky
c704895614 fix(curriculum): typos in camper-cafe-menu (#44629)
* Fixed typos in Beta CamperCafe lessons

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-basic-css-by-building-a-cafe-menu/step-060.md

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>

Co-authored-by: “Jim” <“jimkernicky@gmail.com”>
Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>
2022-01-04 16:48:27 +00:00
Jim Kernicky
7af4a564c0 fix(curriculum): fix typo in registration-form (#44641)
Co-authored-by: “Jim” <“jimkernicky@gmail.com”>
2022-01-04 12:18:45 +00:00
Bruce B
418480782a fix(curriculum): convert to placeholder attr (#44661) 2022-01-03 22:50:54 +01:00
Eric Cheng
3e797480ed fix: allow usage of gray in css (#44633) 2022-01-03 13:16:37 +01:00
Jim Kernicky
386d897671 fix(curriculum): typos in Nutrition Label section (#44652)
* fix(curriculum): typos in Nutrition Label section

* Deleted tream file from last commit

Co-authored-by: “Jim” <“jimkernicky@gmail.com”>
2022-01-03 08:29:07 +01:00
Bruce B
070ef7bb09 fix: rwd beta - ferris wheel step 1 html test (#44625)
* fix: rwd beta - ferris wheel step 1 html test

* fix: update regex to require new line/remove caret
2022-01-01 18:35:27 -08:00
Jim Kernicky
a9852c7180 fix(curriculum): typos in Beta Colored Markers section (#44631)
Co-authored-by: “Jim” <“jimkernicky@gmail.com”>
2022-01-01 18:27:47 -08:00
Jack Howard
2a3e344d13 fix(curriculum): remove extra "\" from description (#44615)
Noticed an extra "/" in the text file on
2022-01-01 18:18:13 -08:00
Karalee Conover
a72326cea1 fix(curriculum): spelling of cinnamon in RWD Camper Cafe Menu (#44635)
* Change Sp from Cinammon to Cinnamon Steps 54-92

* Step 53 Changed sp of Cinammon to Cinnamon

* Fix spelling of Cinnamon Step 92 L250
2022-01-01 18:13:11 -08:00
Buntu Redempter
1a9a48911f fix(curriculum): remove "is" in the description (#44592) 2021-12-30 07:03:18 +01:00
Jim Kernicky
d29a09ebbb fix(curriculum): improve wording (#44605)
* Fix: Removed words from steps 42 & 58, made changes to steps 41 & 45 (Beta)

* Made the suggested change by removing the word 'Note'

* Changed 'last' to 'previous' in step 58

Co-authored-by: “Jim” <“jimkernicky@gmail.com”>
2021-12-30 06:54:43 +01:00
Bruce B
46ba5f5cbd fix(curriculum): css tests for firefox in beta rwd (#44598)
* fix: css tests for firefox in beta rwd

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-accessibility-by-building-a-quiz/step-059.md

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-accessibility-by-building-a-quiz/step-025.md

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-accessibility-by-building-a-quiz/step-061.md

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>
2021-12-29 00:05:58 -08:00
Najmieh Sadat Safarabadi
73e3565707 fix(curriculum): add missing word in instructions - step 31 (#44607)
* Edited Missing Word in instructions- Step 31

Learn HTML Forms by Building a Registration Form - Step 31 - missing word in instructions

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-html-forms-by-building-a-registration-form/step-031.md

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>
2021-12-28 19:06:55 -08:00
Buntu Redempter
b4acccbde9 Added "be" in the first paragraph (#44610)
Added "be" in the first paragraph of the description.
2021-12-28 19:05:28 -08:00
Bruce B
58aea70c9e fix: remove extraneous word from instructions (#44601) 2021-12-28 19:03:20 -08:00