gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
25,081 Commits 9 Branches 0 Tags
06a26861f677dd09b623f2d374cbca1a24d77f01
Commit Graph

181 Commits

Author SHA1 Message Date
Randell Dawson
9bf3fdbf38 fix(curriculum): changed challenge test text to use the word should for Responsive Web Design (#36860) 
* fix: changed challenge test text to use should

* fix: changed have to be used in

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: reworded test verbiage

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: improved test verbiage

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: improved test verbiage

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: corrected typo

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: corrected typo

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: changed have the to be used in

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: corrected verbiage

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
 2019-11-20 20:15:19 +05:30
Mo Zargham
437ba8b103 fix(curriculum): Read-search-ask link now point to correct url as noted in the issue (#37753) 
* fix: broken Read-search-ask link now point to correct url

* fix: changed link to original forum link with more views

* fix: changed http links to correct version

* fix: link in help modal
 2019-11-19 19:54:48 -05:00
Randell Dawson
39df6a2b56 fix(curriculum): added new test to Give Links Meaning by Using Descriptive Link Text challenge to specifically for href attribute (#37699) 
* fix: added new test to test href attribute

* fix: changed You to Your

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: changed a to an

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
 2019-11-15 10:14:54 -06:00
Randell Dawson
55f95c2f74 fix(curriculum): Allow leading to zero before decimal point to be optional for opacity value (#37715) 
* fix: allow-leading-zero-to-be-optional-before-decimal-point-for-opacity

* fix: use getComputedStyle intead of regex

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
 2019-11-13 14:39:03 -06:00
Quincy Larson
e169779805 fix: update twitter image URL (#37739) 2019-11-12 02:32:17 +05:30
Tom
6ff5e52b2d Improve viewport unit readability (#36673) 
* Improve viewport unit readability

Ran into a readability issue when trying to complete challenge. Instead of using `width: 80vw` was attempting `vw: 80vw` based on the initial layout. I believe either this change or the example that was added but doesn't seem to be pushed yet will help.
 2019-11-11 10:24:02 +01:00
Tristan Michael Lawrence
5296d5c731 fix: removed trailing spaces, fixed a typo (#37572) 
* removed trailing spaces, fixed a typo

* removed trailing spaces from basic-css challenges
 2019-11-10 04:33:10 -08:00
Daniel Veazey
9e1b2b7401 fix(curriculum) correct "an" to "a" (#37726) 
* replace the word "dashes" with "hyphens"

* correct "an" to "a"
 2019-11-09 18:13:10 -05:00
Randell Dawson
5ae8470bd5 fix: changed container to container2 (#37483) 2019-11-07 21:15:38 -05:00
Daniel Veazey
7f4531aed0 replace the word "dashes" with "hyphens" (#37705) 2019-11-07 01:19:39 -05:00
lasjorg
316d56ba11 fix(challenge): use offsetHeight to get height value (#36995) 2019-10-27 19:02:53 -04:00
SomeDer
bfa5c26288 fix: use dfn instead of code tag (#36640) 
* Use dfn tags

* remove misused <dfn> tags

* Revert "remove misused <dfn> tags"

This reverts commit b24968a968.

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/fill-in-the-blank-with-placeholder-text.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Make "array" lowercase

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Fix dfn usage

* Address last dfn tags
 2019-10-27 12:45:37 -04:00
Rajat Hans
0551a6a57f Word change in responsive design principles English (#37559) 
* Word change in responsive design principles

* Word change in responsive design principles
 2019-10-26 16:57:20 -04:00
Ahmad Shahzad
9db88a0d7c Fixed a typo in Specify How Fonts Degrade lesson. (#37567) 
* Fixed a typo in Specify How Fonts Degrade.

'-->!' inside the code is misleading and prompts a learner
to put the exclamation mark when it is not needed as '-->!' is
also followed by a period.

Instead of "'-->!'.", it should be "'-->'."

* Made text wording consistent for the test instructions.

* Changed "To begin with," to "To begin," and fixed a minor typo.

If we are going to use "To begin with," the sentence should be
"To begin with the lesson/challenge", otherwise, "To begin" will
be more than enough.

Also added a space between "font(using HTML..." and changed it to
"font (using HTML...".
 2019-10-26 16:55:10 -04:00
Ezgi Kaysı Kesler
93360f4e01 fix:Typo in uncomment-html page (#36800) 
* fix:Typo in uncomment-html page

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/uncomment-html.english.md

removed comma

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
 2019-09-18 10:51:55 -07:00
Randell Dawson
568f00e02a fix(curriculum): Added forumTopicId to remaining 1200 challeng… (#36558) 2019-08-05 22:14:37 +05:30
Randell Dawson
3ec1fe8ea7 feat: add forumTopicId to challenge frontmatter [pre-existing] 
This commit adds the pre-existing challenge guide topics in the
forum to the forntmatter of their challenge markdown files.
 2019-08-05 22:14:37 +05:30
Randell Dawson
ba6ae7154c fix: removed more assert msg arguments (#36439) 2019-07-28 05:16:04 +01:00
Randell Dawson
cbbfc08108 fix: removed more assert msg args (#36441) 2019-07-24 13:13:06 +01:00
Randell Dawson
d0d8282f86 fix(curriculum): Remove additional unnecessary assert message argument wrapped in double quotes from various curriculum sections (#36457) 
* fix: remove double quoted assert msg arg - responsive

* fix: remove double quoted assert msg arg - js

* fix: remove double quoted assert msg arg - libraries

* fix: remove double quoted assert msg arg - coding interview
 2019-07-24 13:06:12 +01:00
Randell Dawson
8e6c26f271 fix: removed assert msg argument (#36407) 2019-07-24 12:54:35 +02:00
Randell Dawson
87615d2a7b fix: removed assert msg argument (#36406) 2019-07-24 11:50:51 +02:00
Randell Dawson
e763330fc3 fix: removed assert msg argument (#36405) 2019-07-24 11:42:26 +02:00
Oliver Eyton-Williams
7d4dc382b4 fix(curriculum): format challenge markdown as per linting rules (#36326) 
* fix: Format challenge markdown according to linting rules

* fix: Put spaces after section tags
 2019-07-19 15:30:17 +05:30
Randell Dawson
c387873640 fix(curriculum): added extra line before </section> tag - Engl… (#36278) 2019-07-19 15:30:17 +05:30
Fabricio Asfora Lira
a32f719d3a Fix/add a stricter test for the Add Placeholder Text to a Text Field challenge (#36186) 
* fix: add test for input closing tag

* fix: add condintion to final syntax test

This wil test if there's any character after the input tag that isn't a white space

* fix/tests+remove-not-needed-text
 2019-07-02 19:30:12 -04:00
Steven Failla
438e7d4c51 fixed testString to disallow any extra characters from passing. Also … (#35987) 
* fixed testString to disallow any extra characters from passing. Also changed markup in testString and text

* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md

Co-Authored-By: Stevo99 <Sfailla1983@gmail.com>

* fixed test so it won't pass if datetime attr is left blank

* fixed test so it will not pass if datetime attribute is left empty

* fixed error in testString where test would pass if user runs test right away

* added tear-down div to make test code look cleaner

* fixed merge conflict. added tear-down div to make code look cleaner

* fixed testString to disallow any extra characters from passing. Also changed markup in testString and text

* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md

improvement to test case where element should have closing tag.

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fixed conflict in git

* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md

removed unnecessary test

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md

removed unnecessary test

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
 2019-06-28 18:49:00 -04:00
adamthahir
acbc07e0ff Fixed typo addressed in #36225 (#36227) 
* Fixed typo addressed in #36225

* Updated as per discussion.
 2019-06-15 13:02:01 +07:00
Ugur Yilmaz
2a18b1a308 Consistency Update for label and input elements for last lessons (#36192) 
* Updated to reflect the relationship between label and input elements

* Updated to reflect the relationship between label and input elements
 2019-06-09 20:47:50 +01:00
Weibin Luo
8cb540fe85 fix: use lowercase for 'article' tag (#36222) 2019-06-09 07:47:09 -07:00
Oliver Eyton-Williams
43fa451a38 fix(curriculum): Change wording to talk about inheritance not cascade (#36110) 2019-06-08 19:09:00 -07:00
Val Lipat
6feda1badb Improve capitalization (#36166) 2019-06-04 07:52:52 -07:00
Ahmad Abdolsaheb
8b4fb5a452 fix: imgur to s3 for various files without conflict (#36057) 2019-05-20 23:58:20 +05:30
Kyle Cheung
937dc23b5d fixed typos in custom css-variable challenge #36038 (#36041) 
* fixed typos in custom css-variable challenge

* fix: Remove extra line
 2019-05-14 20:31:03 +07:00
Randell Dawson
df8659ab8c fix(curriculum): Convert blockquote elements to triple backtick syntax for Responsive Web Design (#35993) 
* fix: converted blockquotes to code fences
 2019-05-14 10:11:58 +02:00
Huyen Nguyen
791e589c93 Remove tag characters (#36037) 2019-05-14 00:14:16 +05:30
Randell Dawson
48884f3a4a fix: changed to h4 > s in selector (#36023) 2019-05-11 19:09:08 -05:00
RIHANE ZAKARIA
a40451feaa Define the Head and Body of an HTML Document for challenge solution (#35826) 
* Define the Head and Body of an HTML Document for challenge solution

* edit on check the body tag contain h1 and p tags
 2019-05-06 16:44:57 +02:00
Randell Dawson
409aa30b0a fix(curriculum): add new test to use calculated space for Use grid-column to Control Spacing challenge (#35893) 
* fix: use calculated space for test

* fix: reworded comment

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>

* fix: changed After Test to Before Test

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
 2019-05-01 14:08:35 +05:30
Huyen Nguyen
5b32e98c4a fix(curriculum): Add solutions to Applied Visual Design challenges (#35815) 
* fix: add solutions to Applied Visual Design challenges

* fix: remove extra opening style tag
 2019-04-28 13:13:38 -05:00
Ian Effendi
cf86246866 fix(curriculum): Add solutions to 16 Applied Accessibility challenges #35751 (#35809) 
This commit adds 16 full working solutions to the responsive web design
principles dealing with applied accessibility.
 2019-04-24 19:12:46 +05:30
Manish Giri
722b65d80f fix(curriculum): Add solutions to HTML challenges (#35766) 
* fix(curriculum): Add solutions to HTML challenges

* Remove extra anchor element
 2019-04-22 11:37:05 +05:30
Manish Giri
e736179720 fix(curriculum): Add solutions to CSS challenges (#35873) 2019-04-22 11:27:43 +05:30
Catalina
ffcb092bf1 Fixed CSS Challenge English version (#35849) 2019-04-20 09:49:23 -07:00
Tom
f1bcd5f0de fix/add-full-solutions-to-flexbox (#35760) 2019-04-20 09:45:18 -07:00
Astrid
9ee8b4fa57 fix: minor grammar mistake in 'applied visual design' challenge (#35839) 
fix: revert changes to package-lock.json
 2019-04-15 14:05:30 +05:30
Beau Carnes
63fc21f702 Update videoURL for HTML5 Elements challenge (#35802) 2019-04-14 09:20:36 -07:00
Paul Gamble
bddcda5559 added html solution for testing - responsive-web-design/applied-visual-design/decrease-the-opacity-of-an-element (#35516) 
* added html solution for testing

* fix: corrected invalid solution
 2019-04-12 18:17:12 +02:00
Aditi Joshi
ebdd8632fc Fix/update challenges for responsive-web-design-principles (#35804) 
* Fix/update challenges for responsive-web-design-principles

* fix/update fix some minor mistakes

* fix/update remove extra line

* Update curriculum/challenges/english/01-responsive-web-design/responsive-web-design-principles/create-a-media-query.english.md

Co-Authored-By: aditijoshi14 <aditijoshi1997@hotmail.com>

* Update curriculum/challenges/english/01-responsive-web-design/responsive-web-design-principles/create-a-media-query.english.md

Co-Authored-By: aditijoshi14 <aditijoshi1997@hotmail.com>
 2019-04-10 17:26:56 -04:00
Beau Carnes
7e522dc473 fix: add new scrimbas (#35803) 2019-04-10 09:23:12 -07:00