Commit Graph

379 Commits

Author SHA1 Message Date
Kristofer Koishigawa
095188215f fix(challenges): Regex Asterisk Challenge (#34800)
* fix(challenges): Fixes description and adds tests to close #17872.

* fix(challenges): Removed unnecessary string arguments from testString

* fix: improved challenge instr and tests
2019-04-01 19:19:13 +05:30
Илья
a326c2cf9a Make a comparison in the test more accurately (#35500)
* Update use-arrow-functions-to-write-concise-anonymous-functions.english.md

* refactor:  fix the assert messages to make them more like all the rest in the curriculum (i.e. using `should`)

Co-Authored-By: iliyaZelenko <iliyazelenkog@gmail.com>
2019-04-01 10:55:43 +02:00
Dana Ottaviani
c08f3785cb Add solutions to Bootstrap challenges (#35710)
* feat: add solution for font-awesome icon challenge

* feat: add solution to add all button icons challenge

* feat: add solution to add ids to bootstrap elements challenge
2019-03-30 23:20:01 -07:00
Jonathan Lawrence
f743c675c7 Grammar fix (#35711)
I was going through the Bootstrap lessons and found this. Very small change, I know, but I believe it's important.
2019-03-31 11:30:37 +05:30
Randell Dawson
60c796e70d Revert "curriculum: Change pre and code to blockquote in Advanced Node and Express challenge (#35697)" (#35709)
This reverts commit b16773617e.
2019-03-30 00:40:12 +04:00
The Coding Aviator
b16773617e curriculum: Change pre and code to blockquote in Advanced Node and Express challenge (#35697) 2019-03-29 13:10:46 -07:00
Amy Lam
914a7c522d Copy edits (#35536)
* Copy edits to Basic JavaScript section

* Copy edits to ES6 section

* Update index.md
2019-03-29 22:06:58 +05:30
lucassorenson
b0565aa8d0 Update match-anything-with-wildcard-period.english.md (#35696)
A fix for issue #35089, updated the examples in the description to use .test() instead of .match() to better reflect the challenge
2019-03-28 11:46:33 -07:00
Lipis
e84ae45008 Javascript -> JavaScript (English) (#35183)
* Javascript -> JavaScript (English)

* Update technical documentation page for required change

* Update use-class-syntax-to-define-a-constructor-function.english.md

* Update left-factorials.md
2019-03-28 14:05:41 +05:30
Randell Dawson
6c82a07b2d fix: made destructuring test more flexible (#35685) 2019-03-27 23:59:53 +05:30
lasjorg
be687977cf fix(challenge): add .english to file name (#35687) 2019-03-27 06:38:25 -07:00
NITIN BISHT
a403dfe5e1 fix: formatting code for quality assurance and testing with chai (#35471) 2019-03-27 17:01:58 +05:30
Avahe Kellenberger
cde8516688 Added missing 'var' on variable declaration. (#35675) 2019-03-27 11:37:58 +05:30
lasjorg
d9213b38cd fix(challenge): remove child selector from name attribute test (#35423) 2019-03-27 11:33:41 +05:30
lasjorg
69d9d522a2 fix(challenge): fix broken regex (#35632)
* fix(challenge): fix broken regex

* fix(challenge): update solution
2019-03-26 21:48:52 -07:00
lasjorg
a1e853337b fix(challenge): simplify and cleanup tests (#35535) 2019-03-26 21:35:38 -07:00
Oliver Eyton-Williams
b10589fadf fix: Challenge solution added and broken test updated. (#35526)
* fix: solution added and broken test updated.

* fix: Change test to equality and finish solution

* Update use-css-selectors-to-style-elements.english.md
2019-03-26 21:01:22 -07:00
Justin Hilliard
8b5ef8cfdd Fix(Curriculum): Constructor function not explained before ES6 #17865 (#35463)
* Fix(Curriculum): Constructor function not explained before ES6 #17865

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-class-syntax-to-define-a-constructor-function.english.md

Co-Authored-By: hilliarj <hilliarj@dickinson.edu>

* Update to #17865 PR

Fix(Curriculum): Constructor function not explained before ES6. Used an unordered list and the syntax that others recommended.
2019-03-26 09:53:19 -07:00
seanlaing
e4870c472a fix/update-es6-destructor-challenge: Added test (#35455)
* fix/update-es6-destructor-challenge: Added test
- Added test incase during destructuring somebody pass and extra key

* fix/update-es6-destructor-challenge: Fixed the test case per review comments
-Cleaned up regex
- Setup two cases one where additional assignment of variables before and then after
- Did not put uppercase case CONSTANT checks because not related to question

* fix: corrected tests
2019-03-25 15:49:56 -05:00
Hrishit Prasad Biswas
4eb4afe53b Fixed bug in 2nd test for Access Multi-Dimensional Arrays With Indexe… (#35666)
* Fixed bug in 2nd test for Access Multi-Dimensional Arrays With Indexes Challenge

* Fix for issue #35665

Fixed Bug In 2nd test case for Access Multi Dimensional Arrays With Indexes

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/access-multi-dimensional-arrays-with-indexes.english.md

Co-Authored-By: Artistic18 <hrishitbiswas20@gmail.com>

* fix: added missing ) for assert statement
2019-03-25 15:42:21 -05:00
Jean Jordaan
33edc072b9 Use the correct element name in <code> blocks, gloss it seperately (#35616)
* Update link-to-external-pages-with-anchor-elements.english.md

If you write "`anchor` element" instead of "`a` element", you should also write "`hyperreference` attribute", instead of "`href` attribute".
Suggestion: write "`a` (_anchor_) element", or "anchor (`a`) element", to communicate the element name explicitly and gloss it at the same time.
The `<code>` sections should be valid code as far as possible.

* Change md to html

* Don't mark up 'anchor' as code

The tag is `a`, the name is _anchor_.

* Revert "Don't mark up 'anchor' as code"

This reverts commit 50c6a3a7c9.

* Don't mark up 'anchor' as code

The tag is `a`, the name is _anchor_.
2019-03-25 10:50:33 -05:00
Christine Gierer
6d9ce1c85c Update description of tests pig-latin.english.md where too vague (#35499)
* Update description of tests pig-latin.english.md

The last two tests "Should handle words where the first vowel comes in the end of the word." and "Should handle words without vowels." are too vague without examples of what is meant by that.

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/intermediate-algorithm-scripting/pig-latin.english.md

Co-Authored-By: beansprout <christinegierer@gmail.com>
2019-03-25 08:02:18 -07:00
Zebulan Stanphill
6a9f459a42 Fix missing "currentNode" variable declaration in data structures linked list challenges (English) (#35638)
* Fix missing variable declaration in data structures challenges (English)

* Fix duplicate currentNode var declaration.
2019-03-25 15:53:38 +01:00
Aditya
9cca21f57f [Fix] Removed unnecessary IIFEs from ES6 challenges (#34538)
* feat: removed IIFE and added solution

* feat: updated challenges seed, test and solution

* style: removed semicolon

* feat: updated seed and solution

* feat: updated challenges seed and solution

* feat: updated test, seed and solution

* fix: added seed code to solution

* fix: removed function and added solution

* fix: removed makeClass function and fixed solution

* style: removed excessive semicolons

* Fixed spacing for note in instructions section

* fix: removed assert messages and used const

* fix: regex fails correctly now
2019-03-25 09:19:34 -05:00
lasjorg
98e68d04be feat(curriculum): Add challenge on using the value attribute (#35301)
* feat(curriculum): Add challenge on using the value attribute

fix(challenge): update file name and add comma

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

Apply suggestions from code review

Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>

* fix(challenge): update tests
2019-03-24 18:43:05 -05:00
Dana Ottaviani
73b4f8c41d fix: add solution to Bootstrap challenge (#35650) 2019-03-24 10:28:07 -07:00
Vikas KM
9e36ff87bb changes to no validate comment (#34810)
* changes to no validate comment 

Added single line comment check for regex to not validate.

* fix: corrected regex

* fix: changed + to *
2019-03-23 15:27:42 -04:00
rupali317
bc72c86dc6 fix: updated the note sections for responsive web design english (#35528) 2019-03-22 15:02:12 +01:00
Carol W
6d43682397 fix: update tests for difference on two sets (#34664)
* fix: update tests for difference on two sets

* fix: update tests for difference on two sets - fix quotes

* fix: reverted testString and reworded text
2019-03-22 11:40:06 +01:00
Chuck Adams
a09bb2ea1d log set as Array.from(set) (#35646) 2019-03-21 21:15:45 +05:30
Hugo
739f4a8850 fix: Update test for ES6 challenge (#34300)
* fix: es6 challenge test

* delete console.log
2019-03-21 10:50:30 +01:00
Kristofer Koishigawa
3e51ced41b fix(challenges): Remove duplicate Rosetta Code sorting problems (#35547)
<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->

- [x] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [x] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [x] My pull request targets the `master` branch of freeCodeCamp.
- [x] None of my changes are plagiarized from another source without proper attribution.
- [x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
- [x] My changes do not use shortened URLs or affiliate links.

<!--If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.-->

This PR is to remove duplicate Rosetta Code sorting problems that exist in other parts of the curriculum. Here are the problems that are being removed: 
* Sorting algorithms/Bubble sort
* Sorting algorithms/Counting sort
* Sorting algorithms/Heapsort
* Sorting algorithms/Insertion sort
* Sorting algorithms/Merge sort
* Sorting algorithms/Quicksort
* Sorting algorithms/Radix sort
* Sorting algorithms/Selection sort

This PR only removes the challenges in English. I could remove the other languages in this PR, or in another PR.

Closes #34776
2019-03-21 13:05:02 +05:30
Bhanu Pratap Singh Rathore
79394d141f feat(interview-prep): Converting and transferring Rosetta problems (#35487)
* feat(interview-prep): Converting and transferring Rosetta problems

* feat(interview-prep): Fixing challenges

* fix(challenges): Added code tags

* Update knight's-tour.md

Moved text to instructions section and fixed a small typo.

* feat(interview-prep): Update description of Knight's tour

Co-Authored-By: NitronR <bhanur05@gmail.com>

* feat(interview-prep): Update description of Kaprekar numbers

Co-Authored-By: NitronR <bhanur05@gmail.com>

* feat(inteview-prep): Kaprekar numbers description

Added <code> tags.

* fix(interview-prep): Update description Kaprekar Numbers

Co-Authored-By: NitronR <bhanur05@gmail.com>

* fix(interview-prep): Added code tags Kaprekar numbers

Co-Authored-By: NitronR <bhanur05@gmail.com>
2019-03-21 11:52:35 +05:30
Timur
cab064a183 Fix tests for Basic JavaScript: Write Reusable JavaScript with Functions (#34345)
* Fix tests

- fix original log() method restoration

- fix case that other userscripts(or extensions) can affect console output and therefore can ruin the test

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/write-reusable-javascript-with-functions.english.md

allow function calling without semicolon

Co-Authored-By: T1mL3arn <T1mL3arn@users.noreply.github.com>
2019-03-21 11:50:23 +05:30
Chuck Adams
4b2219b01d close #35246 - change AVG_TEMPERATURES to avgTemperatures in instructions (#35537) 2019-03-20 22:02:21 +01:00
grets311
2219a9a8dd Update positive-and-negative-lookahead.english.md (#34582)
Update solution from w{5} to w{6} as exercise is to match at greater than 5 characters long.
2019-03-20 15:58:09 +01:00
Shashank Bairy R
f313c094cb fix: clarify how to create multiple box shadows (Issue: #35534) (#35555)
* fix: clarify how to create multiple box shadows

* Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/add-a-box-shadow-to-a-card-like-element.english.md

<code> tags added to 'color' property in order to make it look more consistent with the other propertes of 'box-shadow'.

Co-Authored-By: BA1RY <shashank.bairy04@gmail.com>
2019-03-20 15:32:53 +01:00
Edwin van Meerendonk
5f894a3231 A solution was missing (#35552)
My solution
2019-03-20 15:17:00 +01:00
Jade Michael Thornton
d5861edc84 add more specific tests for username regex challenge (#34655)
* add more specific tests for username regex challenge

* fix: removed unnecessary test
2019-03-19 15:21:30 -07:00
lasjorg
88a5d46ccb fix(challenge): add support for IIFE arrow function (#35573)
* fix(challenge): add support for IIFE arrow function

* fix(challenge): update regex
2019-03-19 08:39:43 -07:00
Yuran Pereira
39b597f1c2 Corrected grammatical mistake (#35631)
From: "The version numbers themselves not should be changed"
To: "The version numbers themselves should not be changed"
2019-03-19 11:24:48 -04:00
NITIN BISHT
228d873dd3 Fix: remove quote from challenge where not needed [english] (#35493) 2019-03-19 15:04:03 +05:30
Randell Dawson
4d1d89b1c7 fix(curriculum) Fixed test to only allow valid JSX comments for Add Comments In JSX challenge (#35320)
* fix: only allow valid jsx comments in div elem

* fix: allow blank comment and removed assert msgs
2019-03-19 01:00:12 -04:00
Oliver Eyton-Williams
e7bc4bd014 fix: Allow trailing commas to be used in challenge (#35585)
* fix: Allow trailing commas to be used in challenge

* fix: use regex to simplify challenge tests

* Update curriculum/challenges/english/03-front-end-libraries/react/review-using-props-with-stateless-functional-components.english.md

Co-Authored-By: ojeytonwilliams <ojeytonwilliams@gmail.com>
2019-03-18 09:56:46 -07:00
The Coding Aviator
17715a795e fix(formatting): Zhang-Suen | Rosetta Code (#35472)
* fix(formatting): Move challenge instructions to instruction section

* Fix table and list

* fix(curriculum): Zhangsuen

* fix(curriculum): add bold tags

* Fix typo in instructions
2019-03-18 17:19:02 +09:00
Randell Dawson
9051ad2eb5 Fixed bug allowing versions of Object.keys method and hard coding of ownProps array (#35021)
* fix: disallow variants of Object.keys method

* fix: added new test to help prevent hardcoding array

* fix: refactored regex
2019-03-17 18:47:41 -04:00
Roberto Beltran
fb8dcd4dbc Make link text more descriptive (#35218)
* Make link text more descriptive

Make link text more descriptive for improved accessibility.

* Add mention of MDN to link description

As suggested by Sidak Singh Aulakh, added reference to MDN web docs which is the link's destination.

* Update curriculum/challenges/english/03-front-end-libraries/jquery/change-text-inside-an-element-using-jquery.english.md

Adjust link wording

Co-Authored-By: RobertoJBeltran <45843750+RobertoJBeltran@users.noreply.github.com>
2019-03-17 16:47:30 -04:00
kevindelsh
64faca718b Changed the definition of stateful components (#34837)
A stateful component is always a class component because functional components can't maintain state by definition. Changed a line to better reflect that.
2019-03-16 19:25:46 +01:00
Gökhan Gurbetoğlu
3b0a75e648 Add default value for justify-content (#34419)
According to the standard, the default value for justify-content if it is not specified is flex-start.
Source: https://www.w3schools.com/cssref/css3_pr_justify-content.asp
2019-03-14 07:14:21 -07:00
Nathan Lakritz
c31d1e2de9 Add semicolon to inline CSS (#34737) 2019-03-14 01:08:25 +05:30