Commit Graph

1269 Commits

Author SHA1 Message Date
BKinahan
09537ba2c1 Add closing parenthesis to second test code
Fixes #4858
2015-12-01 22:22:06 +00:00
Logan Tegman
aa5e699b10 Fix WP Manipulate Arrays with Shift Example Code 2015-12-01 10:30:07 -08:00
Arsen Melikyan
f9cd2b341a Merge pull request #4818 from ltegman/fix/wp-typeof-tests
Fix Waypoint Typeof Tests
2015-12-01 21:18:20 +04:00
Arsen Melikyan
2f2e021e03 Merge pull request #4846 from gasperno/fix/test-waypoint-image-link
Improve test case for waypoint:Turn an Image into a Link
2015-12-01 21:11:32 +04:00
Arsen Melikyan
d77f4eab06 Fix a test and add periods 2015-12-01 15:49:14 +04:00
Harsha
d8143ba7e8 Improve test case for waypoint:Turn an Image into a Link 2015-12-01 02:06:12 -05:00
Logan Tegman
140b8e46f4 Fix Waypoint Typeof Tests 2015-11-30 12:59:34 -08:00
Logan Tegman
92c44e0520 Merge pull request #4815 from erictleung/fix/space-consistency
Add space after `while` statement for consistency
2015-11-30 11:11:02 -08:00
Eric Leung
d865716cf1 Add space after while statement for consistency 2015-11-30 11:07:21 -08:00
Eric Leung
56336c1bd1 Add code tags to the word 'size' in Chunky Monkey 2015-11-30 11:00:26 -08:00
Allister
3ac5ea40f5 Removing sentence, Fixes #4791 2015-11-30 19:36:49 +07:00
Logan Tegman
d210044b6b Fix Misleading BF Test Messages 2015-11-29 19:46:44 -08:00
Berkeley Martinez
4a7470f658 Keywords are not function calls 2015-11-29 16:28:32 -08:00
chriscampbell32
d99be4b44e added that this does not work in safari.
added that this does not work in safari in description

added period.
2015-11-29 14:58:35 -05:00
Logan Tegman
8bab9c627e Fix Waypoint Add Font Awesome Icons Tests
Closes #4769
2015-11-28 22:57:18 -08:00
Logan Tegman
8284a0054f Merge pull request #4738 from AryanJ-NYC/fix/truncate-a-string-description
Corrected description of Truncate a String bonfire.
2015-11-28 09:42:01 -08:00
Aryan Jabbari
af5a3e088f Corrected description of Truncate a String bonfire.
Close #4706
2015-11-28 12:23:23 -05:00
Blauelf
98d2322da9 Added a test case to Where do I belong with return value 0
On the chat today I have seen several solutions that cannot return 0 (usually return arr.length instead), and they still pass, as there is no such test case. Here is one, `where([3, 10, 5], 3) === 0`.
2015-11-28 14:37:25 +01:00
sycrat
fdbcce7277 added alt-text in waypoint seeds after it is taught 2015-11-28 16:07:57 +10:00
Eric Leung
341cd1461b Fix display of Roman numeral tests 2015-11-27 21:22:54 -08:00
Rex Schrader
ffd3a926aa Merge pull request #4749 from erictleung/fix/random-number-test-check
Random Whole Numbers - Add test to check for editing of first line of code
2015-11-27 19:24:29 -08:00
Eric Leung
5976fa5ee0 Add test to check for editing of first line of code 2015-11-27 18:29:13 -08:00
Juan Martínez
d3e7f75671 Fixes description on bonfire Check for Palindromes
Closes  #4734
2015-11-27 21:03:00 -04:30
Eric Leung
eda2334743 Fix example code on filter method to avoid confusion 2015-11-26 18:02:37 -08:00
Christian Ipanaque
19c291f2a4 Fixes Math.random() description in waypoint
Fixes the description of Math.random() in Javascript waypoint.

Math.random() generates a random decimal number between 0 and 1.

Closes #4728
2015-11-26 06:03:11 -08:00
Rex Schrader
857f8fd3ef Merge pull request #4704 from erictleung/fix/decimal-and-hexadecimal-description
Fix description explaining hexadecimal numbers
2015-11-26 01:06:26 -08:00
Logan Tegman
a0ffaa6ca4 Merge pull request #4726 from erictleung/fix/change-potential-confusion-on-conditionals
Fix example if-else statements with clearer example
2015-11-26 00:09:56 -08:00
Eric Leung
9c3e43e190 Fix example if-else statements with clearer example 2015-11-26 00:04:10 -08:00
Eric Leung
8cfd2eb114 Add note about how jQuery is zero-indexed for clarification 2015-11-25 20:39:02 -08:00
Logan Tegman
5afd061b90 Merge pull request #4724 from SaintPeter/fix/jquery-comments-to-clarify
Fixes "Use Comments to Clarify Code" Ambiguity
2015-11-25 17:31:05 -08:00
SaintPeter
2a29d8e1f0 Fixes comments top of code ambiguity 2015-11-25 17:26:22 -08:00
Logan Tegman
eff3fc9ff7 Merge pull request #4723 from dcsmith926/staging
use of ".map()" should be ".forEach()"
2015-11-25 17:11:18 -08:00
dcsmith926
1584485739 use of ".map()" should be ".forEach()"
In "seed/challenges/json-apis-and-ajax.json", the use of ".map()" in the 5th and 6th challenges doesn't make sense -- we're not creating a new array by modifying each element of the response, and in challenge 4, the learner was told to use ".forEach()". Seeing ".map()" instead for no apparent reason would likely be a source of confusion.
2015-11-25 18:38:19 -05:00
Aryan Jabbari
c07bb591c4 Rewrote test goal description for waypoint: Remove an Element using jQuery
Close #4517
2015-11-25 10:57:48 -05:00
Logan Tegman
3465000275 Merge pull request #4689 from SaintPeter/fix/jquery-wp-releasedon-date
Add release date to new JQ waypoint
2015-11-24 22:52:52 -08:00
Eric Leung
3081033695 Fix description explaining hexadecimal numbers 2015-11-24 22:22:30 -08:00
Rex Schrader
102d2d8344 Merge pull request #4701 from erictleung/fix/remove-waypoint-checkbox-quotes
Unescape quotation marks
2015-11-24 21:43:38 -08:00
SaintPeter
36c8181270 Add release date to new JQ waypoint 2015-11-24 21:39:26 -08:00
Rex Schrader
996aec0d2f Merge pull request #4697 from gasperno/fix/modify-test-description
fixed test description in html5-and-css.json
2015-11-24 21:37:35 -08:00
Eric Leung
74005c6d44 Unescape quotation marks 2015-11-24 20:23:48 -08:00
Harsha
05cea5dcbb fixed test description in html5-and-css.json 2015-11-24 18:05:00 -05:00
Eric Leung
40821dc526 Add additional Roman numeral checks 2015-11-24 09:44:03 -08:00
Logan Tegman
ade83e08b7 Fix BF Validate US Phone Numbers Tests
Closes #4666 and closes #4677
2015-11-23 15:31:17 -08:00
Rex Schrader
d6a7fa5562 Merge pull request #4659 from AryanJ-NYC/fix/semicolons-in-bonfire-drop-it-test
Added semicolons to Bonfire: Drop It tests
2015-11-23 08:12:16 -08:00
Aryan Jabbari
eda8668f9c Added semicolons to Bonfire: Drop It tests; close #4610 2015-11-23 08:53:30 -05:00
Akira Laine
9e7fb144b5 fixed typo in bootstrap.json - closes #4661 2015-11-23 19:47:02 +11:00
Rex Schrader
3079af3571 Merge pull request #4654 from ltegman/fix/wp-create-bulleted-ul-4652
Fix WP Bulleted List Tests
2015-11-22 22:06:03 -08:00
Logan Tegman
8aace767c0 Merge pull request #4620 from zkrzyzanowski/fix/add-monospace-to-font-family-#4592
Added Monospace to H2 font-family CSS
2015-11-22 12:39:40 -08:00
Logan Tegman
50ba343915 Fix WP Bulleted List Tests
Closes #4652
2015-11-22 12:24:38 -08:00
Logan Tegman
7814045aff Fix BF Where Do I Belong Description
Closes #4458
2015-11-21 21:57:51 -08:00