351 Commits

Author SHA1 Message Date
Kushagra
0b700b5f78
fix(learn): clarify description for finders keepers (#39068)
* fix(learn): clarify description for finders keepers

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-07-14 09:29:53 +02:00
Bianca Zanardi
35f24c6085
Fix text inconsistency (#39203)
* Fix text inconsistency

To match the eight ECMAScript Language Types on the previous paragraph.

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2020-07-09 16:18:11 +02:00
Jovani
aff56ac392
learn(fix) - fixed grammar because it was confuse to understand the sentence (#39188)
* fix(learn): confusing grammar in copy array items using slice
2020-07-09 01:20:08 +09:00
PeterF521
511238d36e
challenges: description improvement (#39197)
Co-authored-by: PeterF521 <peterf521@gmail.com>
2020-07-07 06:10:04 -07:00
Nicholas Carrigan
2aee480c46
Remove example code from challenge seed (#39083)
Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2020-06-22 16:13:21 +05:30
Kushagra
be4070a73d
fix(curriculum): improve test robustness (#39004)
* Add: // Only change code...comments

* Allow user to modify bob
2020-06-13 11:47:06 +02:00
Nicholas Carrigan
43865fc098
fix(learn): function must return boolean, not string. (#39010) 2020-06-06 15:22:46 +05:30
Nicholas Carrigan
62dcb1f3fa
fix(curriculum): remove whitespace typo (#39009) 2020-06-05 16:08:38 +02:00
jasnkwcz
95371f92b3
fix(learn): clarify formatting requirements for multiple ternary operators challenge (#38993)
* fix(learn): clarify formatting requirements for multiple ternary operators challenge

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-06-03 18:33:03 +02:00
JapneetSingh5
87ef15befa
Fixes a broken link to 'undefined is a keyword' (#38897)
Fixes a broken link to 'undefined is a keyword' by replacing the wrong link with the correct one.
2020-06-02 16:22:59 +09:00
Aditya Nagla
a6c2b5ee1d
fix(curriculum) remove unnecessary */ from description (#38969) 2020-05-31 10:49:10 -05:00
John Montgomery
5cd850f666
Update wording of what multiplyAll should do in "Nesting For Loops" (#38852) 2020-05-31 08:16:00 -05:00
DaVicki
2e819b2e0a
fix(curriculum): update instructions (#38865)
* fix(learn): update instructions

edited text - change "returns a random number" to "returns a random whole number" to be more clear on the problem statement.

Address review comments : add the keyword "whole" to description, to make it consistent with challenge title and Instructions.
2020-05-29 10:56:17 +02:00
PRAKASH
3c3ceaa3f5 Update declare-javascript-variables.english.md (#38884) 2020-05-27 09:37:34 +02:00
Oliver Eyton-Williams
f1c9b08cf3 fix(curriculum): add isHidden: false to challenges
This includes certificates (where it does nothing), but does not
include any translations.
2020-05-25 16:25:19 +05:30
Rajat Singh
bdbf5bfd8d
fix:Added extra test cases for 'arguments-optional' problem (#38827) 2020-05-21 14:56:06 +05:30
Josh Queen
23ca15241c
fix:(curriculum): Moved code tag to include new keyword (#38780)
* Moved code tag to include new keyword

The new keyword hasn't been explained in the curriculum yet, so have moved the <code> tag to include the new keyword to give a prompt that it needs to be used in the solution.

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-arrow-functions-to-write-concise-anonymous-functions.english.md

Added comma.

Co-authored-by: Lasse Jørgensen <28780271+lasjorg@users.noreply.github.com>
2020-05-20 10:09:35 +02:00
Renato Melo
e9614d60d4
fix: update regex specify exact number of matches - lastIndex = 0 before test (#38717) 2020-05-19 12:50:20 +02:00
Paul Gamble
54d59ffc37
Fix/curriculum en es6 complete a promise - modified test messages to be more clearer (#38836)
* Changed tests messages to indicate string

* minor tweak with wording of message

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-05-19 12:44:59 +02:00
Damjan Ostrelič
bfe76794c0
Allow use of g flag in Regular Expressions: Check for All or None (#38659)
* allow use of g flag

added functionality of tests to allow for the use of g flag by resetting the lastIndex as per example in https://github.com/freeCodeCamp/freeCodeCamp/pull/37941.

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/regular-expressions/check-for-all-or-none.english.md

Co-Authored-By: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/regular-expressions/check-for-all-or-none.english.md

Co-Authored-By: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/regular-expressions/check-for-all-or-none.english.md

Co-Authored-By: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/regular-expressions/check-for-all-or-none.english.md

Co-Authored-By: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-05-18 22:50:50 -05:00
Vipul Sinha
7e2b159350
fix(curriculum): update solution to match seed (#38828) 2020-05-18 19:52:38 +02:00
Ashraf Nazar
e10a046f8a
fix(curriculum): use example in Modifying an Object Within a Nested Object challenge (#38468)
* fix: use example in modifying an object within a nested object exercise to explain how to do so

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/modify-an-object-nested-within-an-object.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/modify-an-object-nested-within-an-object.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/modify-an-object-nested-within-an-object.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/modify-an-object-nested-within-an-object.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-05-15 16:41:40 -05:00
Kristofer Koishigawa
b017ce192c
fix: dotall flag not supported in firefox (#38762)
Addresses https://github.com/freeCodeCamp/freeCodeCamp/pull/38546#issuecomment-625611675 where it's pointed out that Firefox doesn't support the /s regex flag yet. This workaround matches anything that's not blank.
2020-05-08 19:27:32 +02:00
Eric Elli
f757840624
fix(learn): add test to return early pattern (#38751)
* add: test to return early pattern

Currently no test for a = 0 or b = 0. This results in if(a<=0 || b<= 0) also being a valid solution

* fix: typo in test text

* fix: update return early pattern test

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-05-07 14:37:48 -05:00
Twaha Rahman
c0e2b65864
Wrapped all the test results with quotation (#38706) 2020-05-02 09:25:55 -05:00
Michael Schneider
1f2b66a432
feat: edit 2nd test description for clarity (#38661)
current description logically fits, yet fails this solution: myVar = ++myVar;
2020-05-02 08:27:52 -05:00
Farjad Fazli
fd85f57376
fix(learn): fixed typo "in the left" should be "at the left" (#38651)
* Fixed typo "in the left" should be "at the left"

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/comparison-with-the-equality-operator.english.md

Co-Authored-By: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-05-02 08:17:11 -05:00
Joel Duran
7035516483
fix: typo in 'Build JavaScript Objects' (#38690) 2020-04-30 17:41:55 +05:30
Oliver Eyton-Williams
f2f5dbc4b8
fix(curriculum): improve declaration tests (#38546) 2020-04-29 16:39:48 +05:30
Gabriel Majeri
9230db42ee
fix(learn): update currency name in cash register challenge (#38637) 2020-04-26 17:38:22 +05:30
Kimon
a3b54d34cb
Differentiate between test & match (#38498)
* Differentiate between test & match

I noticed that nowhere was there a mention that .match() and .test() pass in and are applied to opposite objects.  This would've saved me a few minutes of searching during later challenges that assume this is understood.

* Add in .match & .test difference after example

* fix: add spaces to stop lint errors

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-04-25 08:35:46 -05:00
Ashraf Nazar
c2558b3816
fix(Curriculum): ensure code that includes and is not equal to the fl… (#38497)
* fix(Curriculum): ensure code that includes and is not equal to the flat or flatMap methods do not fail the test suite

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/intermediate-algorithm-scripting/steamroller.english.md

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* Update steamroller.english.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-04-23 14:59:58 -05:00
Ashraf Nazar
3a82e9f857
fix: add more examples on how to set key-value pairs (#38472)
* fix(Curriculum): update examples on how to set key-value pairs

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/add-key-value-pairs-to-javascript-objects.english.md

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/add-key-value-pairs-to-javascript-objects.english.md

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* Update add-key-value-pairs-to-javascript-objects.english.md

* Update add-key-value-pairs-to-javascript-objects.english.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-04-22 11:20:30 -05:00
Shaun Hamilton
17585b63f8
added const to test string (#38583) 2020-04-21 09:12:53 +02:00
piouson
2b60f3e61e
fixed arrow function with no curly braces failing IIFE test (#38544)
* fixed arrow function with no curly braces failing IIFE test

* added iife 2nd test fix and 3 new solutions
2020-04-20 11:04:28 +02:00
Shaun Hamilton
d739a0cc5d
fix(curriculum): change debugging console lesson (#38554)
* changed lesson to match behaviour

* Update wording for debugging

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update wording from suggestion

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* all suggestions with note

* fix: replaced code tags with backticks for markdown

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Ashraf Nazar <ashraf.caspian@gmail.com>

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-04-18 16:31:41 +05:30
Beau Carnes
756f33775e
fix(learn): update video challenge (#38564)
* fix(learn): update video challenge

* fix: update scrimba URL

Co-authored-by: Mrugesh Mohapatra <me@raisedadead.com>
2020-04-18 16:16:31 +05:30
kundan kumar
19c514b702
Fix/functional programming challange (#38516)
* Improved readbility of FP challage

* replace the with a

* corrected gramatical mistake
2020-04-11 21:20:44 -05:00
Randell Dawson
a5818506f0
fix(curriculum): remove setup code not needed anymore from Testing Objects for Properties challenge (#38454)
* fix: remove setup code

* fix: remove call to function
2020-03-28 02:25:04 +12:00
Enock Kasaadha
06d97ac813
fix(curriculum/learn): moved the comment one line below. (#38422)
moved the comment ` //add code above this line` in the text editor of [this challenge](https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures/es6/use--to-import-everything-from-a-file) one line below so that it makes meaning.
2020-03-26 20:01:58 -05:00
Joseph Crandal
f142eed6ef
Fix pig latin challenge description (#38018)
* Fix pig latin challenge description

Added statement for beginning with consonants and if a vowel does not begin with a vowel.

* fix: update description/instructions

* fix:  removed extra line break

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix:  removed extra line break

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-03-26 23:38:07 +01:00
Randell Dawson
1fdb691996
fix(learn): updated tests and deleted old sample code (#38450) 2020-03-26 23:12:18 +05:30
Hassaan Pasha
4fbce07792
fix: improve test regex to validate disallowed methods that can be bypassed by prototype reassignments and/or otherwise (#38214)
* fix: improve test regex to validate disallowed methods that can be bypassed by prototype reassignments and/or otherwise

* fix: fixing regex pattern
2020-03-26 08:13:34 -07:00
Randell Dawson
e0e6334628
fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 3 of 4 (#38264)
* fix: remove example code from challenge seed

* fix: remove declaration from solution

* fix: added sum variable back in

* fix: reverted description back to original version

* fix: added examples to description section

* fix: added complete sentence

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: corrected typo

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* fix: reverted to original desc with formatted code

* fix: removed unnecessary code example from description section

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: failiing test on iterate through array with for loop

* fix: changed to Only change this line

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Manish Giri <manish.giri.me@gmail.com>
Co-authored-by: moT01 <tmondloch01@gmail.com>
2020-03-25 16:07:13 +01:00
Randell Dawson
50f15886b8
fix(curriculum): Strip comments from user code for Use Destructuring Assignment to Extract Values from Objects challenge (#38213)
* fix: strip user code to improve tests

* fix: removed closing section tag messing up tests
2020-03-25 13:28:17 +01:00
Kalyanasundaram
8b0cbd6f83
Modify tests for testing objects for properties challenge (#38414)
* Stronger test cases for testing objects for properties

Change function signature to take in a custom object to be tested

* YML formatting mistake

* Yaml no space in string

* Small one more fix - most likely final

* REmove double space in return

* Update instruction Section
2020-03-24 22:09:57 -07:00
Vincent Shury
6920634e6c
TYPO-FIX JS-regex-match-non-whitespace-characters (#38407)
Added Markdown to correctly display second test
2020-03-20 21:13:48 -07:00
Hassaan Pasha
a282c24bf4
fix (curriculum): added console output checks for the inheritance challenge (#38360)
Co-authored-by: Hassaan Pasha <hassaan.pasha@teamo.io>
2020-03-14 21:55:21 -07:00
Shivam saini
4ef78f7f7d
Update use-recursion-to-create-a-countdown.english.md (#38366) 2020-03-13 16:05:59 +01:00
Randell Dawson
c401fc7f83
fix(curriculum): removed solution required comment from 6 challenges (#38339)
* fix: removed solution required comments

* fix: fixed two more challenge soltuions with solution required comment

* fix: remove debugging code

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-03-09 13:58:46 +01:00