Oliver Eyton-Williams
cd5131b07c
fix: proxy console logs during test evaluation ( #37809 )
2019-11-27 23:08:03 +05:30
Randell Dawson
08bbd893d3
fix: switched order of first two bst challenges ( #37675 )
2019-11-27 12:12:58 +01:00
Randell Dawson
2c15bcbb43
fix(curriculum): changed test text to use should for JavaScript Algorithms and Data Structures ( #37761 )
...
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
2019-11-27 11:57:38 +01:00
mrugesh
9886cf7ca2
fix(client,server): usernames should not be a http error code ( #37804 )
...
* fix(client,server): usernames should not be a http error code
* feat: reject invalid chars first
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
2019-11-27 10:49:17 +05:30
Randell Dawson
b7949087e3
fix(curriculum): Improve verbiage and add examples to the map, filter, and reduce challenges ( #37709 )
...
* fix: improve verbiage and add examples to challenges
* fix: condensed map method wording
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix: remove leading space
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix: improved verbiage
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix: shortened reduce challenge verbiage
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix: shorten verbiage related to reduce 2nd parameter
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix: added comma
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix: shortened filter verbiage
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix; added comma
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix: improved verbiage of map method
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix: shortened reduce verbiage
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix: correct map method verbiage
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix: added word array
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com >
* fix: added missing comma
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com >
* fix: changed u to sumOfAges
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com >
* fix: created one sentence out of many
Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com >
* fix: changed to on each iteration
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com >
* fix: fixed verbiage in filter and map challenges
2019-11-27 07:33:09 +05:30
Stryyder
58444af093
very minor grammar fix ( #37840 )
2019-11-26 15:53:18 -08:00
Randell Dawson
ba415184f6
fix(curriculum): simplify the Remove Items Using splice() challenge without using reduce ( #37829 )
...
* fix: simplify challenge without using reduce
* fix: prevent user from adding new elements to sum to 10
* fix: add from
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com >
2019-11-26 15:14:44 -05:00
mrugesh
1b61bceee7
feat(client): completion modal progress bar ( #37836 )
...
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com >
2019-11-26 22:14:44 +05:30
Ahmad Abdolsaheb
1d73575a59
Revert "feat(client): completion modal progress bar ( #37775 )" ( #37835 )
...
This reverts commit a8928739dd
.
2019-11-26 18:30:08 +03:00
Tom
a8928739dd
feat(client): completion modal progress bar ( #37775 )
...
* feat: add progress bar to completion modal
* feat: add stuff
* feat: finalize-layout-and-make-responsive
* feat: add feature to all challenge templates
* git test
* fix: remove challenge title + enlarge top message
* fix: move graphql query to completion modal
* fix: remove some previous additions
* fix: optimize functions
* fix: removed isRequired flag
* feat: add animation
* feat: add interval to state + clear on unmount
* fix: change around interval function
* feat: make bar fill non-linearly
* Update client/src/templates/Challenges/components/CompletionModal.js
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* Update client/src/templates/Challenges/components/CompletionModal.js
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* Update client/src/templates/Challenges/components/CompletionModal.js
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* Update client/src/templates/Challenges/redux/index.js
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* Update client/src/templates/Challenges/redux/index.js
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* Update client/src/templates/Challenges/redux/index.js
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* Update client/src/templates/Challenges/redux/index.js
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* Update client/src/templates/Challenges/components/CompletionModalBody.js
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* Update client/src/templates/Challenges/components/CompletionModalBody.js
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* Update client/src/templates/Challenges/components/CompletionModalBody.js
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix: remove bracket
* fix: tweak animation + change to pure component
* fix: remove comment
* Update client/src/templates/Challenges/components/CompletionModalBody.js
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* Update client/src/templates/Challenges/components/CompletionModalBody.js
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix: remove animateProgress
* feat: add tests for progress bar
* feat: add working tests
Co-authored-by: ojeytonwilliams <ojeytonwilliams@gmail.com >
* fix: add formatting
* fix: use content selectors where possible
* fix: make progress bar show 0 for unauthed users
2019-11-26 18:15:59 +03:00
Quincy Larson
989bbfa8c6
Update donate link
...
Now it doesn't need to trigger a 301 redirect
2019-11-26 08:27:31 -06:00
lasjorg
ba927090fe
fix(challenge): account for browser zoom, add note to challenge (for height challenge) ( #37687 )
...
* fix(challenge): account for browser zoom, add note to challenge
* fix(challenge): use regex for height assert
* fix(challenge): remove note
* fix(challenge): revert to initial PR code
2019-11-25 19:40:21 -08:00
Randell Dawson
98bb2c1085
fix: added new test case to prevent invalid regex ( #37769 )
2019-11-25 20:25:24 -05:00
Kiara Barias
c1b3588e59
Basic JS challenge: use-prototype-properties link added ( #37802 )
...
* Update use-prototype-properties-to-reduce-duplicate-code.english.md
* Update use-prototype-properties-to-reduce-duplicate-code.english.md
2019-11-25 13:02:21 -06:00
Randell Dawson
4fbe02abba
fix(curriculum): Added necessary variable declarations for JSON APIs and Ajax challenges ( #37535 )
...
* fix: added necessary variable declarations
* fix: added spacing
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix: added spacing
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix: added spacing
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix: added spacing
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix: added spacing
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix: added spacing
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix: added spacing
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix: added spacing
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix: added spacing
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix: added spacing
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix: added spacing
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix: added spacing
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix: added spacing
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix: added spacing
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix: added spacing
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix: deleted unnecessary file
* fix: corrected some spacing
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix: indented code sections
2019-11-25 12:21:17 -06:00
mikemorr
62e1464eb7
change "given" to "adding" (Was: change "given" to "giving") ( #37823 )
...
* change "given" to "giving"
* change to "adding" as suggested
As suggested in https://github.com/freeCodeCamp/freeCodeCamp/pull/37823
2019-11-25 08:14:08 -08:00
Jamie Strusz
cc9c86bd72
Update docs/how-to-open-a-pull-request.md for grammar and readability ( #37235 )
...
* Fix minor grammar errors
* Rephrase keyword section
* Add keyword documentation link for learners
* Reword for clarity and fix grammar
* fix: make suggested changes
* fix: removed comma
2019-11-25 10:09:30 -06:00
Martine Ross
9dd1d42b7e
Update how-to-set-up-freeCodeCamp-locally ( #37264 )
...
Made some minor grammatical changes to clarify the message intended by the sentence
2019-11-25 09:58:13 -06:00
Divyanshu
a987245e18
Added new test cases and corrected the solution for positive and negative lookahead for ensuring that strings beginning with numbers are not accepted ( #37485 )
...
* Added new test case '8pass99' for positive and negative lookahead
* Changed the pwRegex to reflect the new solution
* Updated the pwRegex to reflect the latest solution as on forum
* Added another test case to catch "/^(?=\w{6,})(?=\D*\d{2})/" solution
2019-11-24 17:11:20 -05:00
Waldo Luis Ribeiro
deb24f77b6
fix(curriculum): English editing ( #37814 )
...
* fix(curriculum): English editing
* fix(curriculum): English editing
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-class-syntax-to-define-a-constructor-function.english.md
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com >
* Update use-class-syntax-to-define-a-constructor-function.english.md
2019-11-24 16:38:30 -05:00
Randell Dawson
dc1b59070e
fix: use arrow function syntax ( #37818 )
2019-11-24 02:37:11 -05:00
Waldo Luis Ribeiro
0c22313760
fix(curriculum): English editing ( #37815 )
...
* fix(curriculum): English editing
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-getters-and-setters-to-control-access-to-an-object.english.md
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com >
2019-11-23 18:37:36 -05:00
Waldo Luis Ribeiro
70f736fe07
fix(curriculum): English editing ( #37816 )
2019-11-23 17:28:56 -05:00
Mathew Joseph
174af7fa66
feat(client): pagination on timeline ( #37569 )
...
* Implemented pagination on timeline
* Made requested change and removed outline from button
* fix: PropTypes and off-by-one error
* Keep buttons centered in all cases and give fixed height timeline table rows to prevent jerk while changing pages
* First and last page navigation and margin issue fix.
* Explicitly importing specific lodash functions
* Refactored timeline pagination into a separate file.
* Refactored timeline to have total Pages as prop and made text corrections.
* Added proptypes for total pages
* made changes to setState call for lastPage
* Made a11y changes
2019-11-23 12:06:13 -08:00
Waldo Luis Ribeiro
5ea745d61f
fix(curriculum): English punctuation correction ( #37811 )
2019-11-22 06:35:10 -08:00
Waldo Luis Ribeiro
1fc71e6969
Update create-a-basic-javascript-object.english.md ( #37810 )
...
small spelling correction (everyday -> every day)
2019-11-22 06:34:34 -08:00
Randell Dawson
6fc32ab9b6
fix(curriculum): changed test text to use should for Front End Libraries ( #37762 )
...
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
2019-11-22 13:44:40 +01:00
ibqu
9706bc47ff
Work on the space-evenly option for flexbox justify-content ( #37797 )
...
This challenge requests setting the justify-content attribute to one of the possible values shown in the previous challenge. One of these values - space-evenly - doesn't actually work (at least for the English version).
In this commit I fix the space-evenly issues to some extent.
I cannot tick the box saying that all files changed are in the same world language. However, the changes made should be understandable in all languages.
There still is more to be done for languages other than English, like adding to the test text for Arabic, Portuguese, and Spanish, and adding descriptions for space-evenly in the previous challenge.
2019-11-21 12:46:46 -05:00
mrugesh
06a26861f6
fix(donate): unify layouts and navigation for consitency ( #37795 )
...
This commit updates the layouts and the styles to be consistent with the rest of the application. This also ensures now that the gatsby navigation is used for smoother transtions.
2019-11-21 15:00:22 +05:30
Randell Dawson
c25916c9a2
fix(curriculum): changed test text to use should for Coding Interview Prep - part 2 of 2 ( #37766 )
...
* fix: changed test text to use should
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: removed extra period
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: removed extra period
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: removed extra period
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: removed extra period
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
2019-11-20 10:01:31 -05:00
Randell Dawson
9cd57105af
fix(curriculum): changed test text to use should for Information Security and Quality Assurance ( #37763 )
...
* fix: changed test text to use should
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: remove unnecessary backslash
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: simplified text
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: added period
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com >
2019-11-20 09:58:14 -05:00
Randell Dawson
9bf3fdbf38
fix(curriculum): changed challenge test text to use the word should for Responsive Web Design ( #36860 )
...
* fix: changed challenge test text to use should
* fix: changed have to be used in
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: reworded test verbiage
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: improved test verbiage
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: improved test verbiage
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: changed have the to be used in
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: corrected verbiage
Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com >
2019-11-20 20:15:19 +05:30
Mrugesh Mohapatra
b663c39901
fix(donate): fix computed hours donated for monthly donation
...
Closes #37786
2019-11-20 12:15:00 +05:30
Mrugesh Mohapatra
65e5b26fa1
fix(donate): update default donation amounts
...
Closes #37787
2019-11-20 12:15:00 +05:30
Randell Dawson
c25fa49b5b
fix(curriculum): changed test text to use should for Coding Interview Prep - part 1 of 2 ( #37765 )
...
* fix: changed test text to use should
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: use singular of verb
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: changed punctuation
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: reworded test text
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
2019-11-19 20:13:45 -05:00
Lowell Hamilton
301d03df7b
Update add-font-awesome-icons-to-all-of-our-buttons.english.md ( #37668 )
...
The thumbs up from the previous challenge was removed from the seed in an earlier merge -- seems like it should be there since the instructions only say to add the icons to the remaining buttons.
2019-11-19 20:12:15 -05:00
Mo Zargham
437ba8b103
fix(curriculum): Read-search-ask link now point to correct url as noted in the issue ( #37753 )
...
* fix: broken Read-search-ask link now point to correct url
* fix: changed link to original forum link with more views
* fix: changed http links to correct version
* fix: link in help modal
2019-11-19 19:54:48 -05:00
mrugesh
62aa54efba
fix(donate): apply suggestions from code review
...
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
2019-11-20 00:02:07 +05:30
Mrugesh Mohapatra
0bd66eaf82
chore: temporarily remove PayPal components
...
This commit should be reverted while implementing PayPal integration
2019-11-19 23:09:56 +05:30
Mrugesh Mohapatra
f30f8072b0
chore(donate): unify donation config
...
This commit can be further optimised to DRY out values
2019-11-19 23:09:56 +05:30
Ahmad Abdolsaheb
a5969ac0e5
fix(donate): update font to Lato on paragraphs
2019-11-19 23:09:55 +05:30
Mrugesh Mohapatra
1da1f7d0be
fix(donate): re-order and scroll to top on processing
2019-11-19 23:09:54 +05:30
Mrugesh Mohapatra
aeec1bb9e6
feat(donate): integrate servicebot
2019-11-19 23:09:53 +05:30
Mrugesh Mohapatra
2cb8c16b28
fix(donate): control plan creation with environment variable
2019-11-19 23:09:52 +05:30
Mrugesh Mohapatra
21b09b53cb
fix(donate): adjust verbiage and time contibuted
2019-11-19 23:09:48 +05:30
Mrugesh Mohapatra
f737b24b6f
feat(donate): remove themes from donate pages
2019-11-19 22:28:05 +05:30
Mrugesh Mohapatra
ef0a801c90
feat(donate): remove unauthenticated routes
2019-11-19 22:28:05 +05:30
Mrugesh Mohapatra
e13f35171c
feat(donate): updated donate page and plans
...
- [x] two column layout for the page.
- [x] amount to learning minutes mapping for contribution impact.
- [x] handle one-time and recurring stripe subscription charges.
- [x] server side validation of donate forms.
- [x] prevent multiple subscriptions and onetime donations per user.
2019-11-19 22:28:04 +05:30
Jefferson Oliveira
6921c3fecc
updates text for the location of the button ( #37764 )
...
fixes the text describing the location of the logs button, due to the new design of the glitch.com website
2019-11-19 10:54:14 -06:00
Oliver Eyton-Williams
febba792e7
fix: allow log in testString, restrict test errors
...
Console logs from testString get reported and test errors are sent to
the dev console (JS).
challenge building is only attempted if there is a build function to do
so.
Various functions have been renamed to better reflect what they do.
2019-11-19 22:23:57 +05:30