8 Commits

Author SHA1 Message Date
Randell Dawson
c387873640 fix(curriculum): added extra line before </section> tag - Engl… (#36278) 2019-07-19 15:30:17 +05:30
Randell Dawson
db8098601e fix(curriculum): Remove unnecessary assert message argument from English Data Visualization challenges (#36424)
* fix: removed assert msg argument

* fix: corrected test text
2019-07-11 10:53:41 +02:00
Randell Dawson
dd6011b2cc fix(curriculum): Convert blockquote elements to triple backtick syntax for Data Visualization (#35995)
* fix: convert data visualization

* fix: reverted to blockquote

* fix: changed js to json

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: cleaned up code

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-05-14 07:04:05 -05:00
Yoelvis Jiménez
fdb49ba89a Fix "ReferenceError: url is not defined" in challenge (#35415)
* Fix "ReferenceError: url is not defined" in challenge

I fix the challenge because issue #14002 
- The `url` variable is set to external resource `https://jsonplaceholder.typicode.com/posts`
- I replaced .textContent instead of .innerHTML (better practice)
- Checking for HTTP status of 201 instead of 200
All these suggestions by @HarplingeTom and "approved" by  @QuincyLarson. See the issue comments.
I test the code locally in my computer and this works 👍 
I modified and verify the tests according the new assessment.

* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/post-data-with-the-javascript-xmlhttprequest-method.english.md

Minor typo: `<code>` to `</code>`

Co-Authored-By: yoelvisj <43357527+yoelvisj@users.noreply.github.com>

* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/post-data-with-the-javascript-xmlhttprequest-method.english.md

new declared as const

Co-Authored-By: yoelvisj <43357527+yoelvisj@users.noreply.github.com>
2019-05-08 20:07:36 -05:00
NITIN BISHT
b5468932f0 fix: seed code doesn't match description [english] (#35380) 2019-02-24 09:02:56 -06:00
Valeriy
79d9012432 fix(curriculum): quotes in tests (#18828)
* fix(curriculum): tests quotes

* fix(curriculum): fill seed-teardown

* fix(curriculum): fix tests and remove unneeded seed-teardown
2018-10-20 23:32:47 +05:30
Bouncey
a859035023 fix(challenge-md): Fix quotes that failed in the transform 2018-10-08 11:38:26 +05:30
Bouncey
8f39bc1288 chore(curriculum): Remove files in wrong format 2018-10-05 15:58:12 +01:00