Commit Graph

348 Commits

Author SHA1 Message Date
Enes Gönültaş
43623f3a7a Fixed dead link 2016-04-05 11:16:48 +03:00
Rex Schrader
41ce2d83f8 Merge pull request #7856 from erictleung/fix/usability-on-local-scope-and-functions
Clarify instructions for Local Scope and Functions
2016-04-03 14:11:29 -07:00
Joseph Morse
57e8d4abdf Added Additional Test to Increment a Number
Added an additional test to check that myVar = myVar is not still
present. Tested locally.
2016-04-03 11:52:02 -04:00
Eric Leung
0f5c329051 Simplify temp convert challenge
- Make grammar changes

- Add code tags to numbers

- Add note to calm students about foreign function and return statements

- Add spaces in seed code to align code with indents

- Remove unnecessary code from seed code
2016-04-03 17:41:40 +05:30
Eric Leung
094a48f0a9 Accept >=1 versus >=5 returns in chaining if else 2016-04-03 04:18:57 -07:00
Eric Leung
35e38d61b8 Clarify instructions for Local Scope and Functions
- Add additional instructions on following commented out instructions
- Add hint to refresh page if you encounter issues
- Lint the head script to follow two space indent
- Capitalize words in commented out instructions
2016-04-02 01:33:32 -07:00
Mrugesh Mohapatra
d806f91fde Merge pull request #7736 from BKinahan/fix/counting-cards-tests
Add test to Counting Cards
2016-03-31 12:55:58 +05:30
Eric Leung
4ad03d1223 Clarify Declare JS Vars challenge description
- Update description on what variables are
- Change code tags to dfn tags around the words "data" and "variables"
2016-03-28 21:46:24 -05:00
Michael Ro
ab1a440622 Adds switch statement MDN link 2016-03-27 12:33:57 -07:00
Mrugesh Mohapatra
a483f57c48 Fix Compound Assignment Challenges
This commit updates the Compound assignment challenges:

* Compound Assignment With +=
* Compound Assignment With -=
* Compound Assignment With *=
* Compound Assignment With \=

to

* Compound Assignment With Augmented Addition
* Compound Assignment With Augmented Substraction
* Compound Assignment With Augmented Multiplication
* Compound Assignment With Augmented Division

Tested locally
2016-03-27 13:49:45 +05:30
BKinahan
1400842828 Add test to Counting Cards
Adds a test to Counting Cards for cases when last drawn card decreases Count but Count is still positive
2016-03-26 18:13:30 +00:00
Ivan Kurnosov
766f088ea8 Fixed assignment operator terminology
It's not accurate to call the `assignment operator` `=` and `equal` operator, since it might be confused with the `equality operators`, eg `==`.

For the very same reason changed the `Minus Equals` wording to characters `-=` and titled the challenges with its commonly used name: compound or augment assignment (see https://en.wikipedia.org/wiki/Augmented_assignment)

What do you think of this clarification?

Thanks.
2016-03-24 12:02:26 +13:00
Rex Schrader
56c6b66204 Merge pull request #7615 from drk7891/fix/array-name-typo
Fixed challenge typo
2016-03-19 20:50:24 -07:00
Rex Schrader
9cf2b498d1 Merge pull request #7569 from paycoguy/fix/accessing-nested-arrays
Updated example code for Accessing Nested Arrays in JSON to match challenge code
2016-03-19 19:44:03 -07:00
drk7891
5b75652fa6 Fixed challenge typo 2016-03-18 10:35:28 -04:00
Jacob Bearden
fcf866906b fix image protocol 2016-03-16 20:32:12 -06:00
Andre Alonzo
e54e83494f Updated example code fo r Accessing Nested Arrays in JSON 2016-03-14 22:50:24 -07:00
Rex Schrader
6e7d5db741 Change nameXX properties to title XX properties 2016-03-11 21:00:06 -08:00
Eric Leung
bcbd863b9a Fix javascript to JavaScript in Basic JavaScript 2016-03-10 00:09:18 -08:00
Vladimir Támara Patiño
9767546767 Finishing reviewing of spanish translation by @jorgeruvalcaba.
Thanks for corrections to @justinian336
2016-03-08 21:58:27 -05:00
Randy Tolentino
0fe14f897d Changed very last test for the Comparisons with the Logical And Operator challenge.
- the last test was a repeat, of testing the number 51 and expecting No
- changed the spec to test for 80, and should still return No
2016-03-02 09:54:21 -06:00
Eric Leung
70d4938481 Remove unnecessary line break in Counting Cards 2016-02-21 13:23:53 -08:00
Logan Tegman
1028a1cd0c Merge pull request #7091 from jorgeruvalcaba/add/ES-translation-basic-javascript
Verify and update translation to spanish of basic javascript
2016-02-19 20:16:45 -08:00
Jorge Ruvalcaba
b79ab9085c Challenges of Basic Javascript translated. Closes #6496
Challenges of Javascript translated and corrected.

Some changes in challenges of Javascript.

Format nameEs and general corrections.
2016-02-18 18:18:06 -06:00
Jami Gibbs
97cd338430 Fix grammar in the Golf Code challenge directions 2016-02-17 16:00:09 -06:00
Eric Leung
860419bf56 Clarify Counting Cards instructions & add tests
- Clarify instructions by changing table column "Value" to "Count Change"
- Add two more tests with mix of 7, 8, 9 and other card values
2016-02-16 07:31:41 -08:00
Logan Tegman
4ccf76bd76 Merge pull request #6925 from erictleung/fix/further-clarify-dot-operator
Clarify instructions on saving object properties
2016-02-14 13:32:26 -08:00
Ankit Aggarwal
f6196b0c7d Improve test cases of Record Collection challenge 2016-02-12 19:15:28 +05:30
Eric Leung
7f8c10b602 Clarify instructions on saving object properties 2016-02-11 19:12:33 -08:00
Rex Schrader
858546e3ec Migrate invalid Challenge IDs 2016-02-10 15:18:48 -08:00
Alister N. Mada
b5e8f84dae Fix test for Iterate Through An Array With For Loop 2016-02-10 06:29:11 +07:00
Joshua Henson
4def4278ef Clarify "Nest one Array..." challenge to include multiple arrays 2016-02-06 11:27:54 -08:00
Rex Schrader
bf2c944b87 Merge pull request #6729 from alistermada/fix/test-for-loop-challenge-too-strict
Fix test for Iterate Through an Array with a For Loop
2016-02-05 20:35:57 -08:00
Alister N. Mada
ed66e1c060 Make Iterate Through Array for loop test less strict 2016-02-05 14:21:49 +07:00
Mrugesh Mohapatra
0a33d45368 Fix Range Error : Maximum Call Stack Size Exceeded
This commit fixes the `capture` console.log, with an alternate logic
to resolve the objects with correct scope.

Refer the PR FreeCodeCamp/FreeCodeCamp#6681 discussion for details.
Tested locally.

Updated fix to resolve broken CI
2016-02-04 14:51:37 +05:30
Quincy Larson
2d63a3d5fa Merge pull request #6562 from SaintPeter/fix/restore-es-translations
Restore Prior Spanish Translations to basic-javascript.json
2016-02-02 00:16:39 -08:00
Mrugesh Mohapatra
6b8c2bb220 Add Instructions Clarification to Using Objects for Lookups
This commit adds clarification to the Instructions.
Tested locally.
2016-02-02 02:17:56 +05:30
BKinahan
4feae4a768 Changed 'will gives' to 'will give'
Corrected typo for challenge Generate Random Whole Numbers with Javascript, 'will gives' to 'will give'.
2016-02-01 11:24:19 +00:00
Eric Leung
b4e35cb535 Clarify escape literal quotes instructions
- Change example quote to valid JavaScript
- Add example of what you will get if you print said example quote
- Place emphasis on "if" in the instructions so that it'll hopefully be clear
  you do not actually need to print it
2016-01-31 01:39:47 -08:00
Rex Schrader
29e50b4bc5 Merge pull request #6581 from raisedadead/fix/comparison-with-the-greater-than-or-equal-to-operator
Fix the test case for Comparison with operators
2016-01-30 11:35:53 -08:00
Rex Schrader
3e6b2f34f5 Merge pull request #6583 from raisedadead/fix/undefined-is-not-explained
Add a hint to Return Early Pattern for Functions
2016-01-30 11:32:07 -08:00
Mrugesh Mohapatra
42ec641645 Fix the test case for Comparison with operators
This commit fixes the test case with change to assert in one case,
and change to the test case message in another case.

I intentionally, changed the assert for one case and message for other

Tested locally.
2016-01-30 11:45:40 +05:30
Mrugesh Mohapatra
a3c9d1fce6 Add a hint to Return Early Pattern for Functions
This commit adds a hint as disccussed in the issue, to clarify,
the difference between `undefined` and `"undefined"`.

Tested locally.
2016-01-30 11:34:11 +05:30
Hallaathrad
a04fa02d7c Fix for "Multiple Identical Options in Switch Statements"
Corrects typo "ommitted".
Closes #6593
2016-01-29 22:58:29 -05:00
Rex Schrader
317b27b614 Merge pull request #6567 from raisedadead/fix/introducing-javascript-object-notation-json
Fix the release year for Billy Joel - Piano Man
2016-01-29 09:26:52 -08:00
Mrugesh Mohapatra
cee3b691ef Fix test case in Comparisons with the Logical And Operator
This fixes the test case to do the correct assert as per the message.

tested locally.
2016-01-29 13:55:59 +00:00
Mrugesh Mohapatra
6094a9da12 Fix the release year for Billy Joel - Piano Man
This fixes the release year as mentioned in the issue.
Hope the fans will forgive us!

Tested locally.
closes #6561
2016-01-29 07:42:48 +00:00
SaintPeter
6af6091793 Restore Prior Spanish Translations to basic-javascript.json
Tested Locally

Please review, @vtamara
2016-01-28 20:07:34 -08:00
Rex Schrader
a006e48738 Merge pull request #6529 from robjloranger/fix/all-greaterthan-quotes
Fix for greater than + less than quotes
2016-01-28 10:20:48 -08:00
Alister N. Mada
85637d0ba7 Fix test for Comparison with the Equality Operator 2016-01-28 11:15:52 +07:00