Commit Graph

1902 Commits

Author SHA1 Message Date
2c9a900353 fix: added more values to list to improve tests (#40256) 2020-11-18 09:38:26 +00:00
c03beb3ca6 Fix tests to allow spaces in "Sass: Create Reusable CSS with Mixins" (#40230)
* Fix tests to allow spaces. Closes #40212

* Apply suggestions from code review

Remove redundant whitespace from regex

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-11-15 00:14:47 +01:00
1ef49d2c57 fix(learn): add note about tweet button restrictions (#40118)
* fix: add note about tweet button restrictions

* fix: added target blank and top hint
2020-11-14 11:52:48 +00:00
273f1d1aed fix(learn): typo in an answer to the Numpy question (#40227)
* fix: typo in an answer to the Numpy question

* fix: revert typo in Chinese file
2020-11-13 13:52:13 -06:00
5a9680a1a6 feat(learn): Add Tests to Issue Tracker Project, Remove InfoSec Tests (#39627)
* Feature: Add Tests to Issue Tracker Project

* Refactored User Stories

* Apply suggestions from code review

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* Modify verbiage for #39721

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2020-11-12 19:51:09 -08:00
bd593667f6 feat(learn): Add tests to Personal Library (#39642)
* Resolve Merge Conflict

* Add Instructions, Reformat Description

* Update curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/personal-library.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Update curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/personal-library.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/personal-library.md

* Change links to Markdown style

* Apply suggestions from code review

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* Apply suggestions from code review

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Verbiage per #39721

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Update curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/personal-library.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/personal-library.md

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-11-12 16:13:00 -06:00
Tom
f353278905 feat: update description and user stories (#40217)
* feat: update description and user stories

* feat: add hint from boilerplate

* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/file-metadata-microservice.md

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2020-11-11 12:32:10 -08:00
135928dc5d fix(learn): update machine learning project colab links (#40213)
* fix(learn): update machine learning project colab links

Update current machine learning project Colab links to clone Jupyter notebooks from the boilerplate repos rather than the ones in Google Drive.

* fix(learn): update chinese versions of colab links
2020-11-11 08:56:23 -08:00
Tom
5aef8a70c6 Fix(learn): improve timestamp project user stories (#39961)
* fix(learn): enhance timestamp project user stories

* fix(learn): clarify user stories for timestamp project

* fix: update description area

* fix: update verbiage

* fix: broken tests + add a specific example

* fix: add code highlighting
2020-11-10 15:53:57 -08:00
e8b6a9e5dd fix(learn): add example declaration for clarity (#40207)
Variable declaration is added which is used inside the switch case.
2020-11-09 17:09:21 +00:00
8fd00afd9c feat(learn): Add tests for refactored American/British Translator (#39822)
* feat(learn): Add tests for refactored American/British Translator

* Move to Markdown formatting

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/american-british-translator.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* Update american-british-translator.md

With contributions from @mot01

* Apply suggestions from code review

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-11-06 20:23:11 -06:00
9cfd9ad887 feat: Add tests for Sudoku Solver (#39816)
* Add tests

* Apply Tom's requests

* Verbiage change

* Apply suggestions from code review

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-11-06 20:03:43 -06:00
895e6b8daf fix(learn): add test to prevent hardcoded pass (#40179) 2020-11-06 17:05:20 +00:00
Tom
7ce85a8f03 fix(learn): update helmet and bcrypt instructions so we can remove them from boilerplates (#39954)
* fix: update helmet and bcrypt lesson instructions

* fix: update instrutions I missed

* Update curriculum/challenges/english/09-information-security/information-security-with-helmetjs/install-and-require-helmet.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Update curriculum/challenges/english/09-information-security/information-security-with-helmetjs/understand-bcrypt-hashes.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-11-04 19:11:36 -08:00
f2236983a2 Strengthen test for reassigning node reference (#40133) 2020-11-04 09:46:18 -08:00
cf35d24311 feat(learn): Add Stock Price Checker tests (#39640)
* Add some tests

* More tests

* remove extraneous declaration

* Remove unneeded test string

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-11-04 09:37:27 -08:00
c058af2caa feat(learn): add url-shortener instructions (#40162)
* feat(learn): add url-shortener instructions

* capatalise post word

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* remove sentence with external link

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2020-11-03 09:06:07 -06:00
d8be4d24a5 feat(learn): Some tests for Anonymous Message Board (#39652)
* Clean up text, partial test completion

* remove extraneous declaration

* Apply suggestions from code review

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Use non-breaking space after colon

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-11-03 08:26:10 -06:00
e1bae44036 feat(learn): migrate mongodb-mongoose instructions to learn (#39970)
* feat(learn): migrate mongodb-mongoose instructions to learn

* remove extraneous quotation mark

* update with boilerplate change

* grammar changes on instructions

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-11-03 08:22:55 -06:00
d2e1a385e7 fix(learn): add route to timestamp api in tests (#40144) 2020-11-02 12:54:56 +09:00
1badd3c3a6 fix(learn): add test case to regex challenge (#40087)
existing test cases can be satisfied by /^[a-z][a-z]+$|^[a-z][a-z]*\d\d+$/i
2020-11-01 13:24:35 +00:00
fb0812b6d2 fix(learn): added description about a nonallowed method (#40121) 2020-10-31 20:01:03 +01:00
8ceae38730 fix(learn): modified usage of words from argument to parameter based on the title (#40130) 2020-10-31 19:59:43 +01:00
2645fae939 fix(learn): updated instructions to be explicit (#40131) 2020-10-31 19:53:30 +01:00
e4a9b2988c feat: update Ask for help (#40114)
* feat: get helpCategory from frontmatter

* DEBUG: sets all the projects to JavaScript

This is just so the tests pass, it'll need to go.

* fix: updated helpCategoryMap categories

* fix: added Python to helpCategory frontmatter key

Co-authored-by: Randell Dawson <rdawson@onepathtech.com>
2020-10-30 14:10:34 -05:00
5f956e9a16 Strengthen isBinarySearchTree test (#39982) 2020-10-26 13:30:46 -05:00
0ae1df30c7 fix: add info for problem 54 - project Euler (#40057)
* fix: add info for problem 54 - project Euler

* update text
2020-10-22 11:59:49 -07:00
8ec0da2259 fix(learn): update the required package name (#40056) 2020-10-22 19:32:55 +05:30
dec4b2180f Scalar addition issue on Element-wise operations (#40013)
* Scalar addition issue on Element-wise operations

* remove chinese from PR

Co-authored-by: Sreekumar Menon <sreekumar@roofstock.com>
2020-10-19 11:29:23 -07:00
b503333c64 Rephrase linear gradient explanation (#39990)
* Rephrase linear gradient explanation

Small tweak to explanation to remove ambiguity over horizontal vs vertical

* Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/create-a-gradual-css-linear-gradient.md

Code review suggestion - mention horizontal and quote the values

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Use code tag for snippets

Was using backtick but updated based on formatting guidelines - https://contribute.freecodecamp.org/#/how-to-work-on-coding-challenges?id=formatting-challenge-text

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-10-19 11:01:03 -07:00
71659b7c94 fix(learn): Date corrected the example description from Sunday, to Friday, in the date-format Rosetta Code Challenge (English) (#39998) 2020-10-17 23:01:18 +02:00
13e7251ed9 fix(learn): Update findXmasSunday function arguments from (2008,2121) to (1970, 2017) to match expected return. (#39996)
Co-authored-by: keiveland <keivelanddev@gmail.com>
2020-10-17 22:46:03 +02:00
35c4020f4d fix(curriculum): test typos (#39984) 2020-10-15 14:49:57 -04:00
f6fcb26a9d fix(learn): strengthen a test in "Data Structures: Remove Elements from a Linked List" (#39977)
* Add an additional test to LinkedList.remove

* Consolidate tests
2020-10-15 17:14:05 +01:00
Tom
15cf41e7e1 fix(learn): Update basic node express instructions to remove them from boilerplates (#39953)
* fix: adjust instuctions so we can remove them all from the boilerplate

* fix: adjust instuctions so we can remove them all from the boilerplate
2020-10-15 16:01:10 +01:00
cb1c3b2001 feat(learn): migrate instructions from adnode boilerplate (#39791)
* feat(learn): clarify instructions for boilerplate

* add how-to-put-a-profile-together

* add pug as language

* rephrase sentence for clarity

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-10-15 09:37:29 -05:00
52f27c1cbf fix(learn): Remove isHidden from frontmatter for steps 87-94 of Cafe Menu project (#39974)
* fix: remove isHidden from frontmatter

* fix: corrected ERM name

* fix: removed duplicate step (54)
2020-10-15 09:24:25 -05:00
cc464a6e56 fix(learn): Possible semantic error in explanation comment (#39813)
* Possible semantic error

"identical" generally means that both variables are linked to exact same array which is not the case:
``` thisArray !== thatArray ```

Maybe "similar" or other word could be used instead

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/copy-an-array-with-the-spread-operator.md

Made the comment more accurate

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-10-14 19:53:49 -06:00
Tom
3131360318 fix(learn): enhance user stories for header parser project (#39964)
* fix(learn): enhance user stories for header parser project

* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/request-header-parser-microservice.md

Co-authored-by: Manish Giri <manish.giri.me@gmail.com>

Co-authored-by: Manish Giri <manish.giri.me@gmail.com>
2020-10-14 18:49:02 -04:00
5164b09dab Update post-data-with-the-javascript-xmlhttprequest-method.md (#39835)
Uses common language to describe API data request. Improves clarity of instruction.
2020-10-14 16:34:13 -06:00
e2ae6303d5 fix(learn): Implement map and filter (#39621)
* Added changes to implement-filter-method challenge as requested in reviews by Randall D and moT01

* Added changes requested for in code review
2020-10-14 10:33:43 -06:00
a71150074d fix(learn): preserve whitespace in the tool panel (#39973) 2020-10-14 21:40:15 +05:30
1d2ff7aef6 Add Tests to the Shortener Microservice Project (#39311)
* fix/add-tests-for-url-shortner-project

* update microservice url shortner test on checking submitted project link

* update microservice url shortner test first test wording

* update microservice url shortner test tests wording

* fix: add suggestions and clarify instructions

* fix: instructions

* fix: add Kris's second suggestion

* fix: change to use timestamp project for requests

* fix: update wording for first test

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
Co-authored-by: Kris Koishigawa <scissorsneedfoodtoo@gmail.com>
2020-10-14 12:28:44 +09:00
b3cbbe0f3d fix(learn): Broke several steps down into smaller steps for the Cafe Menu project - v7 (#39778)
* fix: made some verbiage changes to existing steps

* fix: rewrite step 45 instructions

* fix: added two steps between 45 and 46

* fix: miscellaneous edits for steps 21,22, 27

* fix: change step 35 to allow for smaller steps

* fix: update 36-41 seed code

* fix: added new step between 41 and 42

* fix: add new step between 42 and 43

* fix: broke step 33 into 4 new steps

* fix: removed unnecessary step 37

* fix: change wording of step 33 instructions

* fix: corrected ERM syntax

* fix: corrected seed code typos in steps 45 and 46

* fix: corrected typo

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: changed wording to improve readability

Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>

* fix: changed "Free Code Camp" to "freeCodeCamp"

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: corrected typo and improved wording

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: corrected typo

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: correct typos

Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>

* fix: corrected punctuation

Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>

* fix: corrected punctuation

Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>

* fix: corrected punctuation

Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>

* fix: added missing period

Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>

* fix: corrected typo

Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>

* fix: added the missing word "larger"

Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>

* fix: corrected typo

Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>

* fix: change paragraph to `p`

* fix: reorderd steps after step 37 deleted

* fix: added two new steps to fix missing steps problem

* fix: added missing ERMs for step 69

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>
2020-10-13 17:27:40 -05:00
10d3126383 fix(learn): correct minor grammar mistake (#39915) 2020-10-13 12:14:49 +01:00
e22adfcc6b fix(learn): Update the regex in Adjust the background-color Property (#39907)
* fix: Updated the regex in background-color test

As mentioned by @Skye020 in issue #39823, I have made the semi-colon after the background-colour declaration optional, but only if it is the last declaration in the scope.

* Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/adjust-the-background-color-property-of-text.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-10-09 11:09:33 -07:00
a32427c120 fix(learn): make semicolon at end of line optional (#39821) 2020-10-08 21:02:59 +01:00
94f0cf0ef8 chore(learn): Remove remaining isHidden keys from frontmatter (English and Chinese challenges) (#39809)
* fix: remove isHidden key from tool template

* fix: removed isHidden key from English challenges

* fix: remove isHidden key from Chinese challenges
2020-10-08 14:18:47 +02:00
dec409a4bd fix: s/localeTitle/title/g 2020-10-06 23:10:08 +05:30
4a74567986 fix: remove title from Chinese chals 2020-10-06 23:10:08 +05:30