Commit Graph

350 Commits

Author SHA1 Message Date
Nicholas Carrigan (he/him)
2cfa1d3bcd chore: rename css skyline (#44211)
* chore: rename files

* chore: update codebase

* chore: proper title case

* chore: block name

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2021-11-20 08:34:21 -06:00
Nicholas Carrigan (he/him)
fbb9f657b1 chore: rename accessibility quiz (#44206)
* chore: rename files

* chore: update codebase

* chore: proper title case

* chore: preformatted block name
2021-11-20 07:43:42 -06:00
Nicholas Carrigan (he/him)
a73cffdc63 chore: rename photo gallery (#44204)
* chore: rename files

* chore: update codebase

* chore: proper title case

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-11-20 00:05:22 -06:00
Nicholas Carrigan (he/him)
ff0fc1bdbf chore: rename picasso painting (#44209)
* chore: rename files

* chore: update codebase

* chore: proper title case

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-11-19 23:30:57 -06:00
Nicholas Carrigan (he/him)
57d303826c chore: rename nutrition label (#44205)
* chore: rename files

* chore: update codebase

* chore: proper title case

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-11-19 23:10:09 -06:00
Nicholas Carrigan (he/him)
59c24bd4be chore: rename cafe menu (#44201)
* chore: rename files

* chore: update codebase

* chore: proper title case

* chore: missed block name

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-11-19 22:22:24 -06:00
Nicholas Carrigan (he/him)
0e66904272 chore: rename css piano (#44210)
* chore: rename files

* chore: update codebase

* chore: proper title case
2021-11-19 21:49:10 -06:00
Nicholas Carrigan (he/him)
06651d7043 chore: rename ferris wheel (#44213)
* chore: rename files

* chore: update codebase

* chore: proper title case
2021-11-19 21:38:19 -06:00
Nicholas Carrigan (he/him)
2ca67a6c23 chore: rename magazine (#44212)
* chore: rename files

* chore: update codebase

* chore: proper title case
2021-11-19 21:33:29 -06:00
Nicholas Carrigan (he/him)
1958eb2acd chore: rename rothko painting (#44203)
* chore: rename files

* chore: update codebase

* chore: missed one

* chore: use proper title case
2021-11-19 21:23:04 -06:00
Nicholas Carrigan (he/him)
ca6f5dbbcd chore: rename registration form (#44202)
* chore: rename files

* chore: update codebase

* chore: proper title case
2021-11-19 21:18:01 -06:00
Nicholas Carrigan (he/him)
48550a582e chore: rename cat photo project (#44200)
* chore: move files

* chore: update names in code

* chore: use correct name oops

* chore: proper title case
2021-11-19 21:11:31 -06:00
Emiliano
67cac9ac42 definition change of :: before :: after pseudo elements (#44188) 2021-11-19 15:24:36 +01:00
Nicholas Carrigan (he/him)
229fa686ca feat(curriculum): css ferris wheel (#43460)
* feat: initial infra

* feat: initial step breakdown

* feat: expand instructions

* feat: write tests!

* chore: apply shaun's review suggestions

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* chore: more tweaks

* chore: ferris → Ferris

* chore: apply shaun's review suggestions

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fix: no lang

* chore: fix lint issues

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-11-09 18:03:21 +00:00
Kolja Markwardt
a961b2c032 fix(curriculum): use CSSHelper for grid-template-columns (#43982) 2021-11-04 09:24:18 +01:00
Nicholas Carrigan (he/him)
0d33dff597 feat: nutrition label (#43852)
* feat: initial infra

* feat: break down steps

* feat: tests 1-30

* feat: tests 31 to end

* chore: apply gikf's review suggestions

Co-authored-by: Krzysztof <60067306+gikf@users.noreply.github.com>

* feat: actually testing things helps

* chore: apply review suggestions

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>

* chore: take the part, put it in a step

* chore: apply shaun's review suggestions

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* chore: missed one

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* chore: clarify verbiage

Co-authored-by: Krzysztof <60067306+gikf@users.noreply.github.com>
Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2021-11-03 09:13:47 +01:00
Ikko Ashimine
f163a77fe5 fix(curriculum): typo in accessibility-quiz step-046.md (#44087)
targetting -> targeting
2021-11-01 16:14:22 +00:00
Aishwary Shukla
cf6e545b03 fix(curriculum): change user story to match test suite (#44076)
* Solving issue #44068 

Eliminated the difference between project’s stated requirements in own page and in widget on codepen

* Update build-a-tribute-page.md
2021-10-31 08:18:29 +01:00
Nicholas Carrigan (he/him)
cb5244be73 feat: css magazine (#43507)
* feat: initial infrastructure

* feat: html steps done

* feat: through step 50

* feat: complete steps

* feat: write tests

* chore: apply gikf's review suggestions

Co-authored-by: Krzysztof <60067306+gikf@users.noreply.github.com>

* chore: use correct alt text

Co-authored-by: Krzysztof <60067306+gikf@users.noreply.github.com>

* fix: image size

Co-authored-by: Krzysztof <60067306+gikf@users.noreply.github.com>

* feat: add temporary width

* chore: apply sem's review suggestions

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>

* chore: missed one

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>

* chore: apply kris' review suggestions

Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>

* chore: no text walls

Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>

* chore: walls of text

* chore: remaining review suggestions

* chore: apply shaun's review suggestions

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fix: linting index.md

* chore: lang tags

* feat: clarify noreferrer

* feat: clarify lazy loading

* chore: apply shaun's review suggestions

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fix: note about justify

* fix: split step 7

* fix: hero title

* chore: parts are secretly steps

* chore: apply tom's review suggestions

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* chore: missed one

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Krzysztof <60067306+gikf@users.noreply.github.com>
Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>
Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-10-28 14:31:12 -05:00
Nicholas Carrigan (he/him)
2868347742 feat: css photo gallery (#43602)
* feat: initial infra

* feat: create steps

* feat: prototype tests

Haven't tested locally yet :)

* feat: complete tests

* feat: move image size step

* chore: apply shaun's review suggestions

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* chore: apply kris' review suggestions

Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>

* fix: index.md linting

* chore: steps are parts in disguise

* chore: apply tom's review suggestions

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: colon to period

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-10-27 13:40:44 -05:00
Anurag Gupta
f90dc7d903 fix(curriculum): update challenge to heading tags instead of headers (#43429)
* header changed to heading tag

* fix: Exercise about heading tags <h1> ... <h6>, accidentally refers to header tags

* fix: changed header to heading on pages affected

* Update curriculum/challenges/_meta/applied-visual-design/meta.json

Co-authored-by: Ilenia <nethleen@gmail.com>

* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/use-headings-to-show-hierarchical-relationships-of-content.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/use-headings-to-show-hierarchical-relationships-of-content.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/use-headings-to-show-hierarchical-relationships-of-content.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/use-headings-to-show-hierarchical-relationships-of-content.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/use-headings-to-show-hierarchical-relationships-of-content.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-cat-photo-app/part-002.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/adjust-the-size-of-a-header-versus-a-paragraph-tag.md

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>

* Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/adjust-the-size-of-a-header-versus-a-paragraph-tag.md

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>

* file renamed

* dashed-name changed for all languages

* made changes in all the challenges

* file title changed

* added cypress test

* cypress test added

* Update cypress/integration/learn/redirects/heading-challenge.js

Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>

Co-authored-by: Ilenia <nethleen@gmail.com>
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>
2021-10-25 16:17:54 +01:00
Nicholas Carrigan (he/him)
b36cdbafd1 chore: rename "part" to "step" (#43934)
* chore: rename part to step

* chore: update metas

* chore: more renaming

* chore: update tooling

* chore: update frontmatter

* chore(tools): title testing
2021-10-21 18:07:52 +01:00
Nishant Shah
a927257e1d fix(curriculum): update text of a challenge (#43891) 2021-10-18 18:42:42 +02:00
Shaun Hamilton
4a605c5cd2 feat(curriculum): add registration form practice project (#42876)
* feat(curriculum): add registration-form practice project

* add parts 001-006

* add parts 007-009

* add parts 010-013

* add parts 014-024, fix 013

* add parts 025-043

* add parts 043-046

* add parts 0047-057 without tests

* fix tests and adjust index.md file I do not understand

* add css tests to parts 037-040

* add tests parts 040-057

* remove space around ERM

* add true assertion until document iframe is fixed

* add critical review suggestions

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>

* use clear, Tom-like language for 038

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* change order to match author's age

* apply suggestions with personal pazzaz

* add that thing Nich forgets

* use innerText

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-10-14 15:33:13 -07:00
Eric Cheng
de422fe365 fix: change phrasing in challenges to make it easier to read (#43732)
* refactor: made instructions incurriculum\challenges\english\01-responsive-web-design\applied-visual-design\use-the-strong-tag-to-make-text-bold.md a little more clear to user

* refactor: changed phrasing in instructions in curriculum\challenges\english\01-responsive-web-design\applied-visual-design\use-the-s-tag-to-strikethrough-text.md to make it slightly easier to read and less verbose

* refactor: fix phrasing in curriculum/challenges/english/01-responsive-web-design/applied-visual-design/use-the-s-tag-to-strikethrough-text.md

* fix: streamline phrasing according to requested changes

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>

* fix: change phrasing according to requested changes

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>
2021-10-14 15:54:39 -05:00
Pranav Joglekar
d947d8c975 fix: add test to ensure the innerText of labels doesn't change (#43803)
For the check-radio-buttons-and-checkboxes-by-default exercise,
campers are able to pass the exercise if the checked attribute is
written in an incorrect syntax. This PR checks the innerText of the
elements which are being added the 'checked' attribute and ensures that
their value doesn't change.
Fixes #43750
2021-10-11 21:21:30 +02:00
Dharmin K Shah
f9e35a0e6c fix(curriculum): Remove videoUrl using old image srcs (#43631)
* fix: replace responsive web dev bitly links

* Revert "fix: replace responsive web dev bitly links"

This reverts commit 3d2bcbef4b.

* fix: remove video url from html challenges using old image srcs
2021-09-30 19:13:43 +04:00
Shaun Hamilton
2deb73c8d1 feat(curriculum): add accessibility-quiz practice project (#43244)
* feat(curriculum): add accessibility-quiz practice project

* add parts 002-006

* add parts 7-8, tentative on logo aspect-ratio

* add parts 008-013

* add parts 013-016

* add parts 017-026

* add parts 026-027

* add parts 027-029

* add parts 029-044

* add parts 044-067 - all parts done

* add tests 001-009

* add tests 010 - 033

* add tests 034 - 039

* update tests 008~033, add tests 040-050

* add all tests

* fix some stuff, remove final.md

* take reasonable suggestions from Nich, ignore rest

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* replace svg link with actual CDN

* remove getAttribute in potentially bad places

* add method to form

* fix silly querySelectors

* adjust selectors for 028

* fix selectors, and add color transformations

Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>

* fix: typos, and make one test lenient

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
2021-09-28 15:38:44 -05:00
Ilenia
00a81067a3 chore(curriculum): changed external links to news articles in 4 challenges (#43373)
* changed 4 links

* fix wording

* change link as suggested by @gikf
2021-09-27 09:12:53 +01:00
James Geer
77b8405a31 fix(curriculum): allow optional final css semi-colon (#43545)
* fix for issue: #43536, final css property optional semi-colon

* accidentally left a "y" at the end of the sentence

* replaced regex with CSSHelp

* removed trailing white-space
2021-09-23 19:25:50 +01:00
James Geer
3207ea04e7 fix(curriculum): Css fix for issue #43517: Example css code does not demonstrate hover animation (#43524)
* fix question example code for id: 587d78a7367417b2b2512ae0

* Revert "fix question example code for id: 587d78a7367417b2b2512ae0"

This reverts commit c99edf8609.

* modifying only the english version of button hover example

* change to keep css looking consistent
2021-09-22 16:22:11 +02:00
Kristofer Koishigawa
1d4e7e1d16 fix: replace responsive web dev bitly links (#41811) 2021-09-21 09:46:55 -05:00
Nicholas Carrigan (he/him)
2cf4a7d787 feat(curriculum): add piano project (#43364)
* feat: i broke it horribly

* fix: background colour first

* chore: apply shaun's review suggestions

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fix: missing asserts

* chore: apply shaun's review suggestions

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* chore: apply shaun's review suggestions

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fix: remove extra background

* fix: meta order

* feat: clarify descriptions

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2021-09-13 17:51:42 +01:00
Nicholas Carrigan (he/him)
a563b3b4e4 feat(curriculum): CSS Box Model project (#42182)
* feat(curriculum): add initial steps

Add the initial step files for this project.

* feat(curriculum): write test texts

Add some test text (tests coming soon).

* feat: tests for HTML bits

Add tests for the HTML bits - CSS holding off until parser lands.

* feat: CSS tests

New CSS parser works great!

* fix: link href

Fix the href in the boilerplate.

* chore: apply suggestions from code review

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>

* fix: clarify link element

* fix: optional chaining

* fix: remove unused meta props

* fix: update helper and fix tests

* chore: apply tom's review suggestions

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* chore: no console logs

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* feat: intro

Add introductory text, tweak instructions a bit.

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2021-09-10 17:17:03 +01:00
Nicholas Carrigan (he/him)
fa84f6c449 feat(curriculum): css picasso painting (#42436)
* feat: generating steps

- Steps 1-32 done.
- Steps 33-80 done.
- Instructions 1-26 done.
- Instructions 27-61 done.
- More steps.
- Instructions 62-88 done.
- Clarify instructions for new concepts.
- build fixes
- Audit instructions on live site.

* fix: add helpCategory

* feat: write tests

* feat: add intro

* chore: use the right selectors

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>

* chore: cannot read property Shaun of undefined :)

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* feat: Shau-ptional chaining

* chore: apply shaun's review suggestions

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fix: uncross my wires

* chore: apply shaun's review suggestions

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2021-09-07 21:49:42 +02:00
chandan270
96bed09af6 fix: remove image from challenge (#43303) 2021-08-25 22:02:09 +02:00
srijit2002
ab3e12935d fix(curriculum):Incorrect answer passes test for Set the font-size for Multiple Heading Elements challenge. (#43297) 2021-08-25 20:16:49 +02:00
MChiancone
1745411c24 fix(curriculum): add sentence to instructions for clarity (#43227) 2021-08-18 17:17:50 +02:00
Jay Huang
e71b1f3dbf fix(curriculum): Removed URL for wrong video solution (#43210) 2021-08-18 16:35:57 +05:30
Tom
8b2a4cbab9 fix(curriculum): grid area template lesson (#43059)
* fix(curriculum): grid area template lesson

* fix: remove next step mention and fix hint

* fix: rework to make solution line up with seed of next lesson

* Update curriculum/challenges/english/01-responsive-web-design/css-grid/divide-the-grid-into-an-area-template.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/01-responsive-web-design/css-grid/divide-the-grid-into-an-area-template.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2021-08-06 06:52:00 +02:00
Nicholas Carrigan (he/him)
8535c23b08 fix: address crowdin issues (#43021) 2021-07-26 19:43:15 +01:00
Nicholas Carrigan (he/him)
8900fe0b8e feat: CSS Cafe Menu (#41797)
* fix: general bugs

- Ensure editable region at end of code-block is followed by a blank
line.
- Remove apparent duplicate step.
- Address spelling issues.

* feat: some tests

* feat: tests 6-20

Add tests for steps 6-20.

* feat: tests 21-30

Add tests for steps 21 through 30.

* feat: tests 31-40

Add tests for steps 31 through 40.

* feat: tests 41-50

Add tests for steps 41 through 50.

* feat: tests 51-60

Add tests for steps 51 through 60.

* feat: tests 61-70

Add tests for steps 61 through 70.

* feat: tests 71-80

Add tests for steps 71 through 80.

* feat: steps 81-92

Add tests for steps 81 through 92.

* feat: align dashed names

Align the dashed names with the titles and file names.

* fix: apply gikf's suggestions

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>

* fix: manual review suggestions

Apply gikf's other suggestions.

* feat: more thorough testing

When a test asserts that a camper adds a new element relative to
an existing element, also test that the existing element is not
malformed.

* feat: optional semi colons

Make EOL semi-colons optional in the CSS. If they're missing and the
CSS doesn't render correctly, other tests will catch that. If they
are on the last property of the ruleset, they technically aren't
required so we shouldn't require them?

* chore: apply review suggestions

Apply review suggestions from gikf

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>

* chore: apply suggestions from code review

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>

* feat: review suggestions

Apply Ahmad's review suggestions.

* chore: additional suggestions

Manual application of Ahmad's review suggestions.

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

* chore: apply suggestions from code review

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

* chore: apply shaun's review suggestions

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* feat: add clarification

Add a bit of text clarifying the file switch in the editor.

* chore: replace URLs

Replace the tinyurls with our self-hosted CDN images.

* feat: new CSS tests

Re-write CSS tests with new parser.

* fix: grammar

Apply Shaun's grammar reviews.

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: optional chaining

* chore: apply suggestions from code review

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* chore: apply reviews manually

* chore: getStyle update

Replace getStyleDeclaration with getStyle.

* fix: resolve test issue

* chore: remove jQuery :(

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* chore: apply suggestions from code review

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fiux: Update curriculum/challenges/english/01-responsive-web-design/basic-css-cafe-menu/part-073.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-07-21 14:03:09 -05:00
Tom
8e28785913 fix(curriculum): remove outdated video (#42945) 2021-07-20 18:07:14 +02:00
Shaun Hamilton
ff20199e63 feat(curriculum): add tests to css variables skyline (#42067)
* add(tests): parts 1-2

* refactor for multi-file editor, and add temp css tests

* re-re-rebasing

* add link to subsequent challenges

* add test strings to 007-015

* add final tests 001-016

* fix 005-007, add 017-022 tests and test strings

* add: tests 021-030, and formatting

* add: 031-034 tests

* tests: add 035-046

* fix: test in 021

* tests: add 047-050

* format: 009, 051-118 remove css whitespace

* tests: add 051-078

* tests: add 079-105

* tests: add 104-118

* fix: empty -> isEmpty, and include -> match

* fix: correct editable region

* fix: formatting and spelling

* fix: test logic, and add TODO for whitespace

* fix: add final part solution 🤦‍♂️

* fix typo in part-006

* remove whitespace in prep

* getStyleDeclaration -> getStyle

* remove editable region from solution 🤦‍♂️

* fix: correct tests to fail on initial

* fix: add missing regex

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>

* fix: correct tests

* remove commas and stuff 🤷‍♂️

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* uppercaserise doctype

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* add "the"

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* remove half-colon

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* use more boring form of the word "shoudl"

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* add suggestions to tests

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-015.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-016.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-016.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-016.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-022.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-093.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-098.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-101.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-023.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-024.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-026.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-035.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-058.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-090.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-058.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-064.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-064.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-064.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-076.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-070.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-079.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-085.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-086.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-087.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-090.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-019.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-019.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-019.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-074.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-078.md

* fix: the few commits I couldn't add on github

* fix: lesson 41

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-07-15 22:46:40 -05:00
Lorem Ispum
28efec9e63 fix: recognize background-image as correct (#42738) (#42745)
* fix: recognize background-image as correct (#42738)

The page mentioned in #42738 before would not accept background-image and background, now it should.

* fix: CI build error

Co-authored-by: Ilenia <nethleen@gmail.com>

Co-authored-by: Ilenia <nethleen@gmail.com>
2021-07-05 12:28:49 +02:00
Devesh Rane
dba157e7c0 Add a period at the end of an ul tag (#42483) 2021-06-15 20:44:36 +05:30
Stephan Düsterhöft
d6491a9902 fix(curriculum): Period added to the end of the sentence. (#42480)
Dot added to the end of the sentence.
2021-06-14 20:44:23 +05:30
Shaun Hamilton
35b18829d1 fix(curriculum): use mediaText for CSSHelp (#42393)
* fix(curriculum): use mediaText in CSSHelp

prevent selection of style elements with class or media attributes
this should avoid picking up some browser extensions
2021-06-07 23:33:58 +02:00
Seth Falco
dfe80470c6 fix: require a link element in html (#42336)
* fix: require a link element in html

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-06-02 22:38:21 +02:00
impirios
f7ca9796c1 Update specify-how-fonts-should-degrade.md (#42335)
Added a period at the end of the second sentence "These generic font families include monospace, serif and sans-serif".
2021-06-02 22:28:57 +04:00