Commit Graph

18 Commits

Author SHA1 Message Date
342d8657a5 guide: add code explanations to algorithm (#25816)
Added a code explanation for the beginner and intermediate code solutions of the 'convert-html-entities' algorithm, from the js certification
2019-02-11 06:17:34 -05:00
722d136858 Fix typo: add 'y' to truthy (#27517) 2019-01-15 17:23:05 -06:00
9e5e3dcf9b Fix order of hint paragraph 3 (#27514) 2019-01-15 17:22:35 -06:00
6e9a09b013 Updated missing link for JS regex resources (#34306)
JS regex resources link above advanced solution wasn't referencing any webpage. Updated it to link to MDN's regular expressions guide.
2019-01-15 17:18:17 -06:00
2262ab56b4 Updated stub article (#29494) 2019-01-15 17:16:40 -06:00
120f418c41 Fix typos: remove 's' from callback (#27512) 2019-01-15 17:13:12 -06:00
ac9a18a7f7 Update index.md (#34720) 2018-12-21 13:52:19 -08:00
d1d6c08215 docs: grammar and clarity updates (#34567)
* docs: grammar and clarity updates

* docs: clarity revision per request
2018-12-05 18:22:42 -08:00
62ba0777e0 Adding short and clear solution 2018-12-02 00:23:24 +09:00
d16c9b58fd Improved Advanced Code Solution (#22898)
This way it is less confusing + people should be aware of slice default arguments
2018-11-28 19:01:42 -07:00
9fb1d9f49c Update index.md (#22622)
more easy to understand and short than all other solutions
2018-11-25 10:53:00 -07:00
af13067197 Fixed Typo: Added missing indefinite article 'a' (#25605) 2018-11-14 20:49:05 +05:30
0f5c28cfdf fix: update intermediate solution (#34263)
Intermediate code solution doesn't pass tests when the greater number is even because it's the starting acc without passing the reducer function that avoids even number.
Proposed solution: reverse the array before reduce.
2018-11-13 12:54:50 +05:30
3920b7c4ce Corrected capitalization, corrected to American spellings and typos (#30685)
* Translate challenge subtitles and example challenge text to Spanish

* Corrected errors in syntax and punctuation

* Multiple corrections of it/s to its plus other grammar corrections

* Correction and added paragraph to CSS Flex article

* Corrected my own typo

* Corrected capitalization, American spellings and typos
2018-11-07 10:34:13 -05:00
360e3fffbd Fix misplaced anchor tag (#20346) 2018-10-30 19:01:01 -07:00
5c2bd53d5c fixes the Advanced Code Solution to make it work when run tests in the Convert HTML Entities exercise (#24930)
* fix in the Advanced Code Solution to make it work when run tests

* making htmlEntities a const to fix the example
2018-10-25 13:41:36 -07:00
f0eb384b10 Smallest Common Multiple – Optimized Advanced Solution (#19572)
* Optimized advanced solution

Made 2 minor improvement to the advanced solution:

1. The original advanced solution used `Math.max` and `Math.min` against the supplied array, this causes the values in the supplied array to be compared twice. If we use sort instead, the values are only compared once and we can target the max and min values using an index. This is more efficient.

2. The original solution caused `lcm(min, min + 1)` to be evaluated twice. By incrementing `min` the first time we run `lcm` we avoid this duplication and also by taking advantage of the prefix increment operator ++ in the while loop, we trim a line.

* Fixed extra spaces in code block

* Incorporated code feedback from #19572

Made the following changes to the advanced code solution:

- Converted helper functions to arrow function constants
- Simplified comments
- Used destructuring and `sort` for `min` and `max`

* Fixed spacing.
2018-10-18 10:08:45 -07:00
da0df12ab7 fix(guide): simplify directory structure 2018-10-16 21:32:40 +05:30