Commit Graph

51 Commits

Author SHA1 Message Date
Quincy Larson
3739998d73 Merge pull request #3137 from natac13/fix-parentheses-in-description-#3133
fix parenthesis in the description of first jquery challenge
2015-09-09 14:10:37 -07:00
natac13
b8dd3107bf fix parenthesis in the description of first jquery challenge
in the live version there is also duplicate tests the staging branch
has 4 though. I am not to sure about this discrepancy

closes #3133
2015-09-06 20:25:39 -04:00
natac13
34246716c0 Test improvements
changed the jquery selector to account for single and double quotes
as well as optional spaces on:
[Give your JavaScript Slot Machine some stylish images](http://www.freecodecamp.com/challenges/waypoint-give-your-javascript-slot-machine-some-stylish-images)
[Bring your JavaScript Slot Machine to Life](http://www.freecodecamp.com/challenges/waypoint-bring-your-javascript-slot-machine-to-life)
[Target the same element with multiple jQuery Selectors](http://www.freecodecamp.com/challenges/waypoint-target-the-same-element-with-multiple-jquery-selectors)
[Target the Parent of an Element Using jQuery](http://www.freecodecamp.com/challenges/waypoint-target-the-parent-of-an-element-using-jquery)
2015-09-06 13:12:06 -04:00
Arsen Melikyan
909f6725f7 Merge pull request #1866 from jbmartinez/jbmartinez-1854
Changed test case for Waypoint: target elements by id
2015-09-06 19:28:40 +04:00
Juan Martínez
227b574927 removed semicolons at the end of asserts 2015-09-06 15:08:14 +00:00
Arsen Melikyan
d0d011bab1 Merge pull request #2410 from souldreamer/patch-1
[Waypoint: Remove Classes from an element with jQuery] usually expected to not validate if using removeClass() without parameters
2015-09-06 15:14:37 +04:00
Arsen Melikyan
163868a3ea Merge pull request #2579 from ahstro/ahstro-2573
Check all children instead of just one in 'Target Children with jQuery'
2015-09-06 13:18:23 +04:00
natac13
1151929f25 General improvements to jquery file
added a few tests to account for single and double quotes
fixed a typo
added test to add clarity

closes #3107
2015-09-05 21:39:27 -04:00
Quincy Larson
04c3047361 improve jquery challenge wording 2015-09-04 15:00:58 -07:00
natac13
34760ae375 fix misleading description that leads to issues being submitted.
closes #3044
closes #2980
closes #2805
closes #2337
2015-09-04 08:11:44 -04:00
Arsen Melikyan
fe61b1618c Merge pull request #2872 from natac13/fix-backslash-typo-2832
Removed backslash. When I just removed the one the linter did not lik…
2015-09-03 21:22:58 +04:00
Natac13
eddeeb630b I forgot a semi colon... 2015-09-03 13:14:42 -04:00
Natac13
2757ebf6b3 fixes grammatical error on jQuery challenge 'Target the Children of an
Element Using jQuery'.... missing 'they' word
2015-09-01 06:42:33 -04:00
Natac13
42758dfadf Removed backslash. When I just removed the one the linter did not like this so I replace with &#125 for right curly brace 2015-08-30 05:46:19 -04:00
Natac13
28b63c824e fixed the typo of double 'your' words in Delete jQuery Functions. issue #2832 2015-08-29 18:57:52 -04:00
Ben McMahon
a048049ca3 allow literally any whitespace fix #2769 2015-08-27 15:31:56 +01:00
Ben McMahon
6296f3695b Merge pull request #2734 from awesomeaniruddh/staging
Expanded description of 'Remove an Element Using jQuery' waypoint
2015-08-26 13:42:51 +01:00
Aniruddh Agarwal
18acaba2f2 Expanded description of 'Remove an Element Using jQuery' waypoint 2015-08-26 20:40:54 +08:00
Ionut Costica
172543e670 Fixed ")" error
Somehow the assert's closing paren got deleted :")
2015-08-26 13:52:40 +03:00
Berkeley Martinez
cfd94523c3 Merge pull request #2699 from bugron/bugron-2106
Changes CSS attributes to CSS properties
2015-08-25 22:32:23 -07:00
Berkeley Martinez
cb2bc3c0bd Merge pull request #2705 from QuincyLarson/alt-text
Alt text
2015-08-25 22:30:44 -07:00
Quincy Larson
31a82c5c64 add a note about jQuery and Animate.css not usually being accessible in code editor 2015-08-25 17:16:08 -07:00
bugron
ac8fa3cbec Changes CSS attributes to CSS properties 2015-08-26 03:58:49 +04:00
Berkeley Martinez
782f06b737 Merge pull request #2018 from itxchy/patch-5
In the 9th jQuery challenge, I changed "#button" to "button" in the example to target all buttons.
2015-08-24 23:22:27 -07:00
benmcmahon100
f0a783c9df Added some leniency to the test so that it doesn't require a new line 2015-08-24 00:29:34 +01:00
ahstro
67158e876d Check all children instead of just one in 'Target Children with jQuery' 2015-08-23 15:19:05 +02:00
Isabell Long
9ae92c92b2 Target Even Numbered Elements: consistently use double quotes
- Fixes #2528.
2015-08-22 23:20:48 +01:00
Isabell Long
ab35e56661 Target Parent jQuery: elements => element because we reference only one
- Partially fixes #2392.
2015-08-22 18:46:37 +01:00
Ionut Costica
636e16d522 [Waypoint: Remove Classes from an element with jQuery] usually expected to not validate if using removeClass() without parameters
Added extra test to the waypoint to check if `.removeClass` was used with the `"btn-default"` parameter as most people expect to have to do (and are confused when the code validates before they've finished writing their function, as seen by the myriad of issues opened about it).

Closes #2302
Closes #2402
Closes #2301
Closes #2197
Closes #2160
Closes #1923
Closes #1898
2015-08-21 15:18:40 +03:00
benmcmahon100
708b8dc0dc Merge pull request #2241 from dokkillo/dokkillo-2238
issue #2238
2015-08-20 17:35:23 +01:00
Kian Moretz
9cf0f80321 change div to button in Target an element by ID jQuery challenge - fix for issue #2309 2015-08-20 10:09:33 -04:00
Matt Trifilo
45bcd32c9c Edited Pull Request #2018
Escaped the double quotation marks on line 418.
2015-08-19 22:48:25 -05:00
dokkillo
cd26a96757 issue #2238 2015-08-20 00:33:53 +02:00
benmcmahon100
a5faffc082 Merge pull request #1995 from jbmartinez/jbmartinez-1833
Fixes #1833
2015-08-19 21:29:50 +01:00
dokkillo
222df425ac issue #2189 2015-08-19 21:57:41 +02:00
Matt Trifilo
666a0a2cf3 Fixed: issue #2014
I changed "#button" to "button" in the example to target all buttons, and I changed the single quotes to double quotes in the description for consistency.
2015-08-18 00:43:28 -05:00
Juan Martínez
da2f54a2bc Fixes #1833 2015-08-18 03:33:38 +00:00
Abhisek Pattnaik
2b080ec2b7 Problem Instruction clarrification
Replaced with correct instruction to the problem.
2015-08-18 04:17:24 +05:30
benmcmahon100
7c80d64d08 Fix #1942 2015-08-17 22:57:25 +01:00
benmcmahon100
f0f75eeae5 fixed the tests on a challenge 2015-08-17 21:09:40 +01:00
benmcmahon100
7f4aa5487f Fix #1895 2015-08-17 20:16:11 +01:00
Juan Martínez
2fade59319 Changed test case for Waypoint: target elements by id 2015-08-17 16:01:51 +00:00
Quincy Larson
40ab7d2911 more style improvements to front end challenges 2015-08-14 18:17:34 -07:00
Quincy Larson
f3cef6de46 finish jquery and start modifying javascript 2015-08-13 22:07:54 -07:00
Quincy Larson
66bd9338ab remove inaccurate copy from jQuery challenge 2015-08-13 00:57:36 -07:00
Quincy Larson
7a2c2544a4 fix issue discovered by @reddraft 2015-08-12 02:00:24 -07:00
Quincy Larson
5c1b45da2e Fix issues discovered by @eaglecookie and @sonorangirl 2015-08-12 01:39:17 -07:00
Quincy Larson
84c76bcfd0 fix typo discovered by @pieterdeville 2015-08-12 01:35:27 -07:00
Quincy Larson
a9bea09cc9 make changes suggested by @ahstro 2015-08-12 01:11:56 -07:00
Quincy Larson
9e128e2787 manually apply pull requests submitted by @cristianvnica and @kurzninja 2015-08-12 01:04:46 -07:00