gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
26,031 Commits 9 Branches 0 Tags
3836ce08e39d6ece27ac70639d0fe871bcfbd63a
Commit Graph

222 Commits

Author SHA1 Message Date
Ashlee Crusco
3836ce08e3 fix(learn): add for and id attributes to label and input (#39019) 
* add value and id attributes

* revert prettier format changes

* fix whitespace changes

* Revert "fix whitespace changes"

This reverts commit 9da78e58ce474b0f4a7cf076574e23961a6d3734.

* fix typo

* fix: conflict I forgot to resolve

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
 2020-09-02 15:19:47 +01:00
Hassaan Pasha
b0f85de311 fix (curriculum): Adding regex to disregard any whitespaces in the basic-css challenge (#38330) 
* fix (curriculum): Adding regex to account for any whitespace that may be added to the code

* Update curriculum/challenges/english/01-responsive-web-design/basic-css/use-attribute-selectors-to-style-elements.english.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
 2020-08-31 15:16:24 -07:00
Ashraf Nazar
71051fef50 fix(Curriculum): make sure the nested input element in the form is th… (#38480) 
* fix(Curriculum): make sure the nested input element in the form is the existing element given in the editor

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: use backticks to avoid linting error

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Randell Dawson <rdawson@onepathtech.com>
 2020-08-30 22:50:46 -07:00
Quinn
29ab6c32ec minor <code> tag fixes (#39046) 2020-08-30 23:12:04 -05:00
Shaun Hamilton
fe3f0b2ac4 fix: remove quotation marks from code tag text (#38316) 2020-08-30 22:53:09 -05:00
Carlos Diaz
e0a062a3e7 Changes order of padding, border, margin in introductory sentence. (#39414) 2020-08-30 22:28:42 -05:00
tomki1
9c3de2df24 added test to assert h1 is before h2 (#39040) 2020-08-30 22:13:30 -05:00
law27
b88c8ab351 Update use-the-s-tag-to-strikethrough-text.english.md (#38515) 
Alphabet word is not wrapped inside double quotes

Co-authored-by: LawranceMichaelite <40236169+LawranceMichaelite@users.noreply.github.com>
 2020-08-30 22:08:51 -05:00
Charles Ross
3db5bd7067 Update import-a-google-font.english.md (#38839) 
Changed optional plural to possessive.
 2020-08-30 22:07:46 -05:00
Ieahleen
ed6246b91a update description of "Nest an anchor element in a paragraph" as discussed in #38507 (#38524) 
* remove parenthesis from description

As discussed in #38507 , I'm removing the phrase in parenthesis

* more succint description

Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
 2020-08-30 22:01:40 -05:00
Kristofer Koishigawa
b73156373f fix: tests for use a retina image challenge (#39133) 2020-08-29 22:09:43 -05:00
mstillman9
1f1c58ae18 fix regex 2020-07-16 15:41:35 +03:00
Randell Dawson
8ebb4922d4 fix(learn): updated catphotoapp links (#39215) 2020-07-15 15:26:49 +05:30
Oliver Eyton-Williams
db6d97142a fix: remove whitespace to test solution (#39210) 2020-07-08 15:13:02 -05:00
Dman247
9a861d1f1c fix(curriculum): Fixed Spelling Error. 'lightning speed' (#39056) 2020-06-13 15:14:24 +05:30
Oliver Eyton-Williams
f1c9b08cf3 fix(curriculum): add isHidden: false to challenges 
This includes certificates (where it does nothing), but does not
include any translations.
 2020-05-25 16:25:19 +05:30
Shaun Hamilton
b1de8ee4f8 fix(curriculum): change project codepen links (#38746) 2020-05-06 19:53:27 +05:30
Ashraf Nazar
99c2f0d4f5 fix(curriculum): allow hex triplets for red and green colors to pass tests (#38523) 2020-04-12 17:15:31 +03:00
Randell Dawson
fde8c05a20 fix(curriculum): strip comments from CSS in testString to fix bug caught by tests (#38351) 
* fix: strip-comments-from-css

* fix: added challenge referenced in issue

* fix: added call to function removeCssComments

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
 2020-03-11 08:56:34 -05:00
Randell Dawson
c401fc7f83 fix(curriculum): removed solution required comment from 6 challenges (#38339) 
* fix: removed solution required comments

* fix: fixed two more challenge soltuions with solution required comment

* fix: remove debugging code

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
 2020-03-09 13:58:46 +01:00
Hassaan Pasha
3a47c5411f fix (curriculum): made the order of the required code to be re… (#38320) 
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
 2020-03-06 12:44:39 +05:30
Ashraf Nazar
181ac1e8ad fix: Update test for wrapping strong tag around text to include periods at the end (#38305) 2020-02-29 01:02:39 -05:00
Randell Dawson
41718abf76 fix(learn): consolidate comments for responsive web design cert (#38256) 
Related to PR #38040

This PR is an attempt to consolidate/remove as many comments in the challenge seed code in the Responsive Web Design certification challenges, to be able to create a small translation lookup object for translating the English comments to other languages.
 2020-02-27 20:50:46 +05:30
Tom
a09ffadd5a fix: responsive image challenge (#37934) 
* fix: responve image challenge

* fix: bad solution

* Update curriculum/challenges/english/01-responsive-web-design/responsive-web-design-principles/make-an-image-responsive.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/01-responsive-web-design/responsive-web-design-principles/make-an-image-responsive.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/01-responsive-web-design/responsive-web-design-principles/make-an-image-responsive.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
 2020-02-20 22:53:30 +05:30
lasjorg
9a5ae756ac fix(challenge): check inline style for color (#38211) 
* fix(challenge): check inline style for color

* Update curriculum/challenges/english/01-responsive-web-design/basic-css/change-the-color-of-text.english.md

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
 2020-02-18 23:38:16 +05:30
Kiara Barias
afd467f5dc Removes RSA links from English challenges (#37869) 
* RSA links deleted from challenges

* fix: remove remaining RSA links in challenges
 2020-02-07 14:46:07 +09:00
PHILIP OBIORAH
66e5cf0051 fix(curriclum): modified add images to your website (#38155) 
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Manish Giri <manish.giri.me@gmail.com>
 2020-02-04 20:12:53 +05:30
Randell Dawson
2f39dd07d6 fix: removed part of user story 2020-01-29 14:05:39 +09:00
TAKAHASHI Shuuji
e65c47c6ba fix: Wrap codes with <code> tags in css-flexbox challenge. (#38025) 2020-01-08 15:18:48 +03:00
TAKAHASHI Shuuji
81fe7678c1 Wrap column with <code> tags. (#38020) 2020-01-07 14:15:03 +01:00
Tom
0adfc79c7a fix: fixed position challenge (#37945) 2020-01-02 17:41:36 -07:00
Randell Dawson
5609a1303e fix: corrected tests for 3 challenges (#37948) 2019-12-19 11:26:50 +01:00
John A Maloney
c935d21f84 Fixed bad capture group in regex (#37575) 2019-12-13 22:16:30 -06:00
lasjorg
63b9be8faf fix(challenge): account for browser zoom, add note to challenge (for width challenge) (#37688) 
* fix(challenge): account for browser zoom, add note to challenge

* fix(challenge): use regex for width assert

* fix(challenge): remove note

* fix(challenge): revert to initial PR code

* updated regex, add check for maxWidth
 2019-12-13 07:05:23 -08:00
Christoph Deil
dc5c0c7f82 Fix minor grammar issue in override-styles-in-subsequent-css.english.md (#37871) 2019-12-04 14:32:55 -08:00
Randell Dawson
d39dd970b6 fix(curriculum): use regex to avoid differences in how browsers calculate style property values for Decrease Opacity of an Element challenge (#37838) 
* fix: use regex to avoid diff in browsers

* fix: improve regex
 2019-12-02 20:50:34 +05:30
Tom
9866d2f241 fix: grid column and grid row tests (#37736) 
* fix: grid column and grid row tests

* fix: test text verbiage

* fix: add solution to pass build error

* fix: make test more readable
 2019-12-01 10:02:24 +05:30
Randell Dawson
aac1c58374 fix(curriculum): make last test more robust for Uncomment HTML challenge (#37843) 
* fix: correct last test

* fix: remove forgotten console.log

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
 2019-11-30 23:09:48 -05:00
lasjorg
ba927090fe fix(challenge): account for browser zoom, add note to challenge (for height challenge) (#37687) 
* fix(challenge): account for browser zoom, add note to challenge

* fix(challenge): use regex for height assert

* fix(challenge): remove note

* fix(challenge): revert to initial PR code
 2019-11-25 19:40:21 -08:00
mikemorr
62e1464eb7 change "given" to "adding" (Was: change "given" to "giving") (#37823) 
* change "given" to "giving"

* change to "adding" as suggested

As suggested in https://github.com/freeCodeCamp/freeCodeCamp/pull/37823
 2019-11-25 08:14:08 -08:00
ibqu
9706bc47ff Work on the space-evenly option for flexbox justify-content (#37797) 
This challenge requests setting the justify-content attribute to one of the possible values shown in the previous challenge. One of these values - space-evenly - doesn't actually work (at least for the English version).

In this commit I fix the space-evenly issues to some extent.

I cannot tick the box saying that all files changed are in the same world language. However, the changes made should be understandable in all languages.

There still is more to be done for languages other than English, like adding to the test text for Arabic, Portuguese, and Spanish, and adding descriptions for space-evenly in the previous challenge.
 2019-11-21 12:46:46 -05:00
Randell Dawson
9bf3fdbf38 fix(curriculum): changed challenge test text to use the word should for Responsive Web Design (#36860) 
* fix: changed challenge test text to use should

* fix: changed have to be used in

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: reworded test verbiage

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: improved test verbiage

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: improved test verbiage

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: corrected typo

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: corrected typo

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: changed have the to be used in

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: corrected verbiage

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
 2019-11-20 20:15:19 +05:30
Mo Zargham
437ba8b103 fix(curriculum): Read-search-ask link now point to correct url as noted in the issue (#37753) 
* fix: broken Read-search-ask link now point to correct url

* fix: changed link to original forum link with more views

* fix: changed http links to correct version

* fix: link in help modal
 2019-11-19 19:54:48 -05:00
Randell Dawson
39df6a2b56 fix(curriculum): added new test to Give Links Meaning by Using Descriptive Link Text challenge to specifically for href attribute (#37699) 
* fix: added new test to test href attribute

* fix: changed You to Your

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: changed a to an

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
 2019-11-15 10:14:54 -06:00
Randell Dawson
55f95c2f74 fix(curriculum): Allow leading to zero before decimal point to be optional for opacity value (#37715) 
* fix: allow-leading-zero-to-be-optional-before-decimal-point-for-opacity

* fix: use getComputedStyle intead of regex

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
 2019-11-13 14:39:03 -06:00
Quincy Larson
e169779805 fix: update twitter image URL (#37739) 2019-11-12 02:32:17 +05:30
Tom
6ff5e52b2d Improve viewport unit readability (#36673) 
* Improve viewport unit readability

Ran into a readability issue when trying to complete challenge. Instead of using `width: 80vw` was attempting `vw: 80vw` based on the initial layout. I believe either this change or the example that was added but doesn't seem to be pushed yet will help.
 2019-11-11 10:24:02 +01:00
Tristan Michael Lawrence
5296d5c731 fix: removed trailing spaces, fixed a typo (#37572) 
* removed trailing spaces, fixed a typo

* removed trailing spaces from basic-css challenges
 2019-11-10 04:33:10 -08:00
Daniel Veazey
9e1b2b7401 fix(curriculum) correct "an" to "a" (#37726) 
* replace the word "dashes" with "hyphens"

* correct "an" to "a"
 2019-11-09 18:13:10 -05:00
Randell Dawson
5ae8470bd5 fix: changed container to container2 (#37483) 2019-11-07 21:15:38 -05:00