Commit Graph

1058 Commits

Author SHA1 Message Date
Tom
9cd4b93601 fix(learn): getter setter instructions (#39512)
* Update use-getters-and-setters-to-control-access-to-an-object.english.md

* fix: revert changes, keep example

Co-authored-by: Daniel Sing <danielsingsong@gmail.com>
2020-09-02 18:07:17 +01:00
Shaun Hamilton
9ed2a554a7 fix(curriculum): changed test to use regex (#38770)
* changed test to use regex

* added width has to be spelt correctly

* added second width assertion

* add case insensitive flag

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: allow compilable CSS to pass

* add allowance of final property without semicolon

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-09-02 11:59:16 -05:00
Ashlee Crusco
3836ce08e3 fix(learn): add for and id attributes to label and input (#39019)
* add value and id attributes

* revert prettier format changes

* fix whitespace changes

* Revert "fix whitespace changes"

This reverts commit 9da78e58ce474b0f4a7cf076574e23961a6d3734.

* fix typo

* fix: conflict I forgot to resolve

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2020-09-02 15:19:47 +01:00
Joshua Pelealu
a050de56bb Fix: Running Test with a comment fails test on Understand The immediately invoked function expression iife (#39347)
* Update Regex to test if it's an IIFE instead of checking for a parenthases at the end.

* Second Test will now pass the test

* Escape One Parenthese

* Update Regex to be more structured

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Missing regex ending literal

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-09-01 18:48:32 -05:00
Mayank Chauhan
e7718e5c3f fix(learn): improved tests for validating incrementer function (#39385)
* Update avoid-mutations-and-side-effects-using-functional-programming.english.md

* Update avoid-mutations-and-side-effects-using-functional-programming.english.md

* Update avoid-mutations-and-side-effects-using-functional-programming.english.md

* fix typo in avoid-mutations-and-side-effects-using-functional-programming.english.md
2020-09-01 08:44:24 -07:00
Ashraf Nazar
70f1ebd2fc fix(curriculum): regex to target html elements using jQuery to captur… (#38649)
* fix(curriculum): regex to target html elements using jQuery to capture white spaces

* replace whitespace before test

* fix linting issue with single quotes

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-08-31 20:24:43 -05:00
CheongJY
a294021d53 fix: remove whitespace before testing (#39420)
* Proposed change to remove whitespace for issue #39370

Issue #39370: whitespace fails the 3rd test with test comparing to a no whitespace example.
Proposed: remove all whitespace in between tags(or literally all whitespaces) before comparing it with the no whitespace example

* Update render-state-in-the-user-interface.english.md

* Updated proposed change to remove whitespace 

An update to previously proposed change due to failed test of 'unexpected token \'<\'' was thrown'

* Update curriculum/challenges/english/03-front-end-libraries/react/render-state-in-the-user-interface.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* fix: linting issue

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-09-01 01:15:22 +01:00
Hassaan Pasha
b0f85de311 fix (curriculum): Adding regex to disregard any whitespaces in the basic-css challenge (#38330)
* fix (curriculum): Adding regex to account for any whitespace that may be added to the code

* Update curriculum/challenges/english/01-responsive-web-design/basic-css/use-attribute-selectors-to-style-elements.english.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-08-31 15:16:24 -07:00
Pyi Theim Kyaw
faf426bb40 PR ready fix(learn) (#39208) 2020-08-31 15:31:30 -05:00
Beau Carnes
f334734e98 feat: split JS challenge into two (#39044)
* feat: split JS challenge into two

* fix/change-to-not-use-untaught-assignments

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2020-08-31 19:44:56 +01:00
Kristofer Koishigawa
8e3f740127 fix: update take home project links (#39444)
* fix: update take home project links and update mentions of Glitch with Repl.it

* fix: clean up text, fix typos, and remove deploy to Heroku text

* fix: update nightlife coordination app description text

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: update GH link text based on suggestion

* fix: update links to the fCC forum

* fix: update nightlife coordination app url

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: change http to https

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-08-31 10:32:22 -07:00
Yasmin Yazdi
cf82a2b33e fix global flag fail in Regex by resetting last Index (#39457)
* fixing global flag fail by resetting last index. Issue #37890

* fixed syntax error

* making requested changes
2020-08-31 16:59:42 +05:30
Ashraf Nazar
71051fef50 fix(Curriculum): make sure the nested input element in the form is th… (#38480)
* fix(Curriculum): make sure the nested input element in the form is the existing element given in the editor

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: use backticks to avoid linting error

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Randell Dawson <rdawson@onepathtech.com>
2020-08-30 22:50:46 -07:00
Ty Mick
474ae28d72 Fix number of noun (#38833)
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-08-30 22:15:58 -07:00
Quinn
29ab6c32ec minor <code> tag fixes (#39046) 2020-08-30 23:12:04 -05:00
Shaun Hamilton
fe3f0b2ac4 fix: remove quotation marks from code tag text (#38316) 2020-08-30 22:53:09 -05:00
Carlos Diaz
e0a062a3e7 Changes order of padding, border, margin in introductory sentence. (#39414) 2020-08-30 22:28:42 -05:00
tomki1
9c3de2df24 added test to assert h1 is before h2 (#39040) 2020-08-30 22:13:30 -05:00
law27
b88c8ab351 Update use-the-s-tag-to-strikethrough-text.english.md (#38515)
Alphabet word is not wrapped inside double quotes

Co-authored-by: LawranceMichaelite <40236169+LawranceMichaelite@users.noreply.github.com>
2020-08-30 22:08:51 -05:00
Charles Ross
3db5bd7067 Update import-a-google-font.english.md (#38839)
Changed optional plural to possessive.
2020-08-30 22:07:46 -05:00
Ieahleen
ed6246b91a update description of "Nest an anchor element in a paragraph" as discussed in #38507 (#38524)
* remove parenthesis from description

As discussed in #38507 , I'm removing the phrase in parenthesis

* more succint description

Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2020-08-30 22:01:40 -05:00
Kristofer Koishigawa
b73156373f fix: tests for use a retina image challenge (#39133) 2020-08-29 22:09:43 -05:00
Karuppiah Natarajan
efa4e09efa fix typo in 'integer' word (#39339)
Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2020-08-26 07:38:43 -07:00
Aviel212
fb77d48d13 curriculum: add test in React challenge to detect constructor call (#39304)
* fix: resolve #39301

Add a test to check the "MyComponent" constructor's parameters (params) and to check that the super function exists in the constructor.

* docs: describe the test better

* Update curriculum/challenges/english/03-front-end-libraries/react/write-a-react-component-from-scratch.english.md

Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>

Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>
2020-08-25 08:41:35 -07:00
Joseph Mawa
fccc436e23 Fixed test description for Rosetta Code: Euler method challenge. (#39452)
* Update greatest-subsequential-sum.english.md

Added missing closing bracket in test description in the tests section.
Removed variable declared twice in the solution section.

* Update euler-method.english.md

* Update euler-method.english.md

* Update euler-method.english.md

Added parameter description  fixing the suggested changes.

* Update euler-method.english.md

Removed some formatting from the added text.

* Update euler-method.english.md

Moved seed function parameter description to instructions section.
2020-08-25 08:37:10 -07:00
Shaun Hamilton
cdc1a63ca8 fix(learn): correct personal library replit link (#39442) 2020-08-20 13:08:02 -07:00
Joseph Mawa
fc1200ae2c Update greatest-subsequential-sum.english.md (#39422)
Added missing closing bracket in test description in the tests section.
Removed variable declared twice in the solution section.
2020-08-19 08:04:47 -07:00
Ryan-Chu
bd02c989df fix(curriculum): rename variable to avoid conflict (#39428) 2020-08-19 16:47:30 +02:00
Kristofer Koishigawa
6b3c61c737 feat: update backend project links (#39314)
* feat: update backend project links

Replace solution and remix Glitch links with equivalent Repl.it links in backend projects/challenges and intro pages.

* fix: link and Repl.it casing

* fix: update mention of glitch in testing challenge

* Apply suggestions from code review

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-08-17 14:38:16 -07:00
ML
9a4976bd57 fix(curriculum) typo in Create Reusable CSS (#39418)
Fixed a typo on the Sass Challenge "Create Reusable CSS with Mixins" where the word "vendor" was spelled incorrectly as "vender" in the test cases.
2020-08-16 18:33:34 -07:00
Nicholas Carrigan
4858c2eb0a Remove extra / from link (#39419) 2020-08-16 18:25:55 -07:00
Oliver Eyton-Williams
f9ffcf0c61 fix: update chinese certificates 2020-08-16 04:45:17 +05:30
Oliver Eyton-Williams
c40eab94b7 fix(curriculum): add missing .english extensions 2020-08-16 04:45:17 +05:30
Ruchi Kushwaha
35c3609489 fix:Incorrect Usage of setState in React Challenge (#39290)
* fix:Incorrect Usaage of setState in React Challenge

* apply suggestion

* also set stage usage in other challenges

* fix setState usage in challenges

* correct syntax

* correct usage of useState in other files

* add current message to state

* remove current message from state

* change connect redux to the message app

* remove extra space
2020-08-11 10:12:27 -07:00
Ty Mick
817325d68e Change comma to semicolon (#39258) 2020-08-11 10:02:09 -07:00
Kartik Soneji
f813dfff87 fix: Replace Array.prototype.sort and update old isSorted method. (#39360)
* fix: Replace Array.prototype.sort and update old isSorted method.

* fix: Change name of function from 'checkInBuiltSort' to 'checkBuilitInSort'.

* fix: Change name of function from 'checkBuilitInSort' to 'isBuiltInSortUsed'.
2020-08-10 13:31:18 -07:00
Amy Gurski
8996fa7502 fix: rosetta day of week typos (#39380)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-08-08 19:00:29 -07:00
Iván Franco
0471f7f8d8 Removing # from property name to be consistent with previous challenges (#39334) 2020-08-06 08:33:56 -07:00
Ty Mick
0642002005 Remove add method test (#38824) 2020-08-04 14:37:58 -07:00
Shaun Hamilton
c974fd39dd fix(curriculum): add regex to chai tests for double quotes (#39187)
* fix: allow for use of double quotes in chai tests

* fix: escape forward slash
2020-08-05 01:27:09 +05:30
Shaun Hamilton
7d8e558b91 fix(curriculum): convert all video challenges to markdown (#39189) 2020-08-05 01:26:41 +05:30
Mike Robinson
e7d2028bba fix(learn): change test order to test for the value after execution has finished (#39363)
Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>
2020-08-05 01:18:50 +05:30
dyneskye
f52baa51be fix(learn): Added test for Capitalized -> uncapitalized variants
* myReplace("I think we should look up there", "up", "Down")
* Checks for previously unchecked scanarios of the 'after' input being capitalized and 'before' word being uncapitalized.
2020-08-03 14:52:40 +03:00
Nakul Nambiar
e4960e38ef fix(curriculum): Removed global variable and updated test for "Functional Programming: Apply Functional Programming to Convert Strings to URL Slugs" (#39359)
* Fixed Some Typos

* Removed global variable and updated tests

Co-authored-by: nakulnambiar <nakul.nambiar@demandfarm.com>
2020-08-02 16:24:16 -07:00
Ruchi Kushwaha
41ed64e8d4 fix:regex error in selection sort insertion sort and merge sort (#39230) 2020-08-02 13:17:27 -07:00
Jayesh Patel
908adc2c37 Update Yelp.com documentation API from V2 to V3 (#39344) 2020-07-31 11:39:27 -07:00
anthony
20d397f719 remove MDN links from English challenges (#39337)
* remove MDN links from English challenges

* add push challenge reference to record-collection

* refactor truthy falsy verbiage

* replace MDN link with news link

* remove unnecessary whitespace
2020-07-31 15:19:49 +09:00
dyneskye
4b7ad8447b fix(learn): Added test for edge case (#39323)
* fix(learn): Added test for edge case

* Test checks edge cases for incorrect spelling in middle characters.

* fix: removed 'pen' sageTest

* the 'pen' points out that it is not the end of the first word to be tested for, but the end of the string.

However, this is explained clearly in the 'mountain' test below just as well.
2020-07-27 07:43:59 -07:00
Ty Mick
516602cef8 fix(curriculum): Improve punctuation/formatting in "Add Axes to a Visualization" (#39261)
* Improve punctuation

* Clean up axis identification

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Add block formatting to code sample

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-07-27 00:22:47 -07:00
Mainak Debnath
92377cf71a fix(learn) : Changed language and added a test for Project euler problem-2 (#39221)
* Edited wording in a test

* Rearranged the tests

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-07-26 19:09:46 +02:00