Commit Graph

758 Commits

Author SHA1 Message Date
5feabd762c fix: Add tests to check lazy matching is applied and that the string "h1" is not matched (#38193) 2020-02-11 10:17:51 -06:00
80ba943ca3 fix: fixed regex for validating newlines in for loops (#38180) 2020-02-09 18:43:43 -06:00
004b99bf8f chore: fix typos in spelling (#38100)
* spelling: accidentally

* spelling: announce

* spelling: assembly

* spelling: avoid

* spelling: backend

* spelling: because

* spelling: claimed

* spelling: candidate

* spelling: certification

* spelling: certified

* spelling: challenge

* spelling: circular

* spelling: it isn't

* spelling: coins

* spelling: combination

* spelling: compliant

* spelling: containers

* spelling: concise

* spelling: deprecated

* spelling: development

* spelling: donor

* spelling: error

* spelling: everything

* spelling: exceed

* spelling: exist

* spelling: falsy

* spelling: faulty

* spelling: forward

* spelling: handle

* spelling: indicates

* spelling: initial

* spelling: integers

* spelling: issealed

* spelling: javascript

* spelling: length

* spelling: maximum

* spelling: minimum

* spelling: mutable

* spelling: notifier

* spelling: coordinate

* spelling: passport

* spelling: perform

* spelling: permuter

* spelling: placeholder

* spelling: progressively

* spelling: semantic

* spelling: submission

* spelling: submit

* spelling: translations

* spelling: turquoise

* spelling: visualization

* spelling: without

* spelling: registration

* spelling: representation
2020-02-08 23:59:10 +05:30
a7075a579c Fix: Problem 39: Integer right triangles (#38145)
* fix: correct test and add solution

I also changed the seed to report the results of an easier example to
the user, since just evaluating the function mostly wastes time.

* fix: use a better solution

* fix: credit original author
2020-02-08 21:09:32 +05:30
8cf64f2539 ProjectEuler | Update Problem statement of 002 to match projecteuler.net (#38101)
* Correct ProjectEuler:002 definition and tests

From projecteuler.net:
By considering the terms in the Fibonacci sequence whose values do not exceed four million, find the sum of the even-valued terms.
Correct: take all f(n) where f(n) <= 4,000,000 and f(n) is even
Incorrect: take all f(n) where n <= 4,000,000 and f(n) is even

* Incorporate PR review suggestios to ProjectEuler 002

Reword the problem statement

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-02-07 10:09:35 -06:00
4ef445c543 feat: add styles for markdown tables and convert some HTML tables to markdown (#38126) 2020-02-07 09:47:35 +01:00
afd467f5dc Removes RSA links from English challenges (#37869)
* RSA links deleted from challenges

* fix: remove remaining RSA links in challenges
2020-02-07 14:46:07 +09:00
bef738f0d4 modfied tests and made correction in solution (#38023) 2020-02-06 20:31:03 -05:00
f3a386982a Misspelling fix, add colon. (#38169) 2020-02-06 09:46:44 +01:00
cccad94754 fix(learn): updated challenge text to clarify when to start using new boilerplates (#38124)
* fix: update to clarify new boilerplates used

Updating challenge text to make it more clear that learners need to switch to new boilerplate

* fix: improved wording to clarify new boilerplates used

Updating challenge text to be consistent and make it clear where learners are to switch to new boilerplate
Incorporating suggestions from PR #38124
2020-02-05 21:15:53 -06:00
d89eae392f fix: adding test to check if flat or flatMap method was used in the steamroller challenge (#38158)
* fix: adding test to check if flat or flatMap method was used in the steamroller challenge

* Addressed comments and acknowledged suggestions
2020-02-04 17:00:33 -05:00
66e5cf0051 fix(curriclum): modified add images to your website (#38155)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Manish Giri <manish.giri.me@gmail.com>
2020-02-04 20:12:53 +05:30
6a4b42c4ec Update to make instructions more clear (#38068)
The instructions on the exercise following this specify 'behind the scenes' which sounds more clear than 'in the background'.
2020-02-04 10:54:02 +03:00
8b692560e8 Fix: (Rosetta-Code) Correct the Test suite and make expression clearer (#38102)
* Fix: Correct the Test suite and make expression clearer

* Update 24-game.english.md
2020-02-04 07:08:32 +05:30
cfbb3f64c4 Change variable declaration from var to let in description (#38150) 2020-02-02 15:29:03 -06:00
15d5824795 Change n pounds to n pence in Project Euler problem 31 (#38144) 2020-01-31 15:23:15 +01:00
2f39dd07d6 fix: removed part of user story 2020-01-29 14:05:39 +09:00
7453131461 Apply proper formatting on Note paragraph (#38120) 2020-01-26 17:31:51 -06:00
fda7fb174e fix: Correct paths in English exercises by prefixing "/" before "learn" (#38099)
* fix: Correct paths in English exercises by prefixing "/" before "learn"

* fix(lang): Correct paths to exercises by prefixing "/" before "learn" in remaining languages
2020-01-26 12:51:21 -06:00
1159a8dcaf fix: Add edge case for mixed grouping of characters exercise, where "Frank Roosevelt" returns false (#38097) 2020-01-22 15:58:47 +05:30
10bd00309a Added solution to this exercise (#38074)
* Added solution to this exercise

* fix: changed js to html

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-01-22 00:00:06 +05:30
bc470325d0 Update use-destructuring-assignment-with-the-rest-parameter-to-reassign-array-elements.english.md (#38092)
I added 'the' to correct the English grammar and hence improve the readability of the instructions.
2020-01-21 08:25:10 -06:00
c408cb9c1a Removed typo from Instructions (#38066)
* Removed typo from Instructions

Removed the word 'with' which doesn't belong.

* Update curriculum/challenges/english/06-information-security-and-quality-assurance/quality-assurance-and-testing-with-chai/run-functional-tests-on-api-endpoints-using-chai-http.english.md

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* Update curriculum/challenges/english/06-information-security-and-quality-assurance/quality-assurance-and-testing-with-chai/run-functional-tests-on-api-endpoints-using-chai-http.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-01-15 08:18:58 +05:30
ML
d824c77012 Move the comment on line 71 to its own line (#38036)
* Move the comment on line 71 to its own line

The comment "use function argument destructuring" was on the same line as some code, and when displayed as a challenge it returned to a new line and was not commented out.

* Update line 71 comment per @manish-giri suggestion

Move the comment "use function argument destructuring" to above the "change code below this line" comment for clarity. Based on conversation in this pull request https://github.com/freeCodeCamp/freeCodeCamp/pull/38036
2020-01-15 08:17:34 +05:30
27b4deae36 Update run-functional-tests-on-api-endpoints-using-chai-http-ii.english.md (#38065)
Corrected typos.
2020-01-14 21:18:17 +05:30
e925e854f1 Update delete-one-document-using-model.findbyidandremove.english.md (#38041) 2020-01-11 07:10:51 -08:00
M B
7f6a653c28 fix: update react lesson link (remove 404) (#38031)
* Update lesson link (remove 404)

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-01-09 17:29:50 +01:00
fd36d6db37 fixed typo, "is" changed to "in" (#38032) 2020-01-08 18:58:31 -08:00
Tom
86127a24f7 fix: add tests for header parser microservice project (#37187)
* fix: add tests for header parser microservice project

* fix: make test more robust

* fix: make text use 'should'
2020-01-08 12:31:19 -08:00
e65c47c6ba fix: Wrap codes with <code> tags in css-flexbox challenge. (#38025) 2020-01-08 15:18:48 +03:00
a70e15c0a7 fix: allow-space-in-destructuring-regex (#37997) 2020-01-07 17:22:15 +01:00
81fe7678c1 Wrap column with <code> tags. (#38020) 2020-01-07 14:15:03 +01:00
6809578044 fix: change starting font-size (#37981) 2020-01-07 13:39:06 +03:00
0a0cbead58 fix(learn): Fixed tests for the create a hash table challenge (#37870)
* fix: update create hash table's tests

* fix: update the way lookup method is declared to enable the use of this.collection in it
2020-01-03 11:18:40 +01:00
e4a229187e fix: speed up tests
Either improved the algorithm or reduced the difficulty for the slowest
tests. All these pass with testProtectTimeout = 500, so should be safe
on most machines with the current timeout of 2500.
2020-01-03 11:41:52 +05:30
Tom
1b06bb29f0 fix: allow g flag on regex (#37941) 2020-01-02 18:24:07 -07:00
Tom
0adfc79c7a fix: fixed position challenge (#37945) 2020-01-02 17:41:36 -07:00
fe1c6b24ab Added href to empty <a> tag in social auth implementation II (#38002)
* Added href to empty <a> tag in social auth implementation II

* corrected typos in authentication with socketIO challenge

* corrected typo as suggested

Co-Authored-By: Eric Leung <eric@erictleung.com>

Co-authored-by: Eric Leung <eric@erictleung.com>
2020-01-02 17:36:15 -07:00
d07c85151b Fix typo (remove duplicate word 'should') (#37998) 2019-12-31 08:50:46 -08:00
1f98af5841 fix: used assert.deepEqual to compare arrays (#37959) 2019-12-31 13:33:04 +05:30
3cc0395964 added a test to challenge:falsy-bouncer (#37973)
* added a test to challenge:falsy-bouncer

* modified tests of challenge:falsy-bouncer
2019-12-29 17:17:17 -06:00
8bd2fb8bc5 fix(i18n): delete duplicate text in test desc (#37975) 2019-12-23 20:47:10 +05:30
e5abfa15ad Revert "fix: stop user code after 100ms of execution" (#37965)
This reverts commit 01b37f664f.
2019-12-21 11:09:32 +05:30
01b37f664f fix: stop user code after 100ms of execution (#37841)
Co-authored-by: mrugesh <1884376+raisedadead@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2019-12-20 19:28:17 +05:30
5609a1303e fix: corrected tests for 3 challenges (#37948) 2019-12-19 11:26:50 +01:00
8cca639450 fix(challenge): check inline styles on elements, add solution (#37756) 2019-12-16 16:18:29 +01:00
203c9823e8 Fixed minor grammar issue in escape-sequences-in-strings.english.md (#37940)
* Update escape-sequences-in-strings.english.md

Fixed minor grammar issue in list item 1 of the description section.

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/escape-sequences-in-strings.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-12-16 06:16:16 -08:00
616d96f612 refactor: update trivial regex capture group find and replace challenge (#37768)
* refactor: replace trivial regex capture group challenge

Previous challenge could be completed without any capture groups. New
challenge requires 3 capture groups and 3 uses of the submatches in the
replacement.

resolves #17645

* test: validate at least 3 capture groups were used

Use solution from SO
(https://stackoverflow.com/questions/16046620/regex-to-count-the-number-of-capturing-groups-in-a-regex)
as suggested by @RandellDawson to count the number of capturing
groups, regardless of whether or not the regex in question solves the
broader problem.

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* refactor: more meaningful variable name

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* test: add parenthesized substring test

* test: ensure 3 uses of substring replacement

* refactor: reword instructions

* fix: minor grammar fix

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* refactor: elaborate wording in test
2019-12-14 16:41:47 -05:00
c935d21f84 Fixed bad capture group in regex (#37575) 2019-12-13 22:16:30 -06:00
85e7fe45d5 fix(curriculum): use object.assign to prevent overwriting prototypes if user uses class instead of function (#37648)
* fix: use object.assign to prevent overwriting when using class

* fix: remove non-used isBinarySearchTree method
2019-12-13 15:04:05 -06:00