Commit Graph

1213 Commits

Author SHA1 Message Date
CubeSky
40e6ddca31 Added solution to "01-Responsive Web design" challenge (#36971) 2019-10-03 22:38:49 +07:00
CubeSky
3099f303ed Added solution to "01-Responsive Web design" challenge (#36968) 2019-10-03 21:11:38 +07:00
Randell Dawson
8225ce7572 fix: added 3 new tests to mutations challenge (#36857) 2019-09-30 16:33:57 -04:00
Tom
52bd3a65de fix: balanced-brackets-tests (#36807) 2019-09-25 11:39:11 +02:00
SomeDer
5de58ad98d fix(curriculum): use function form of this.setState (#36623)
* Fix solution

* Update description

* Add test for this.setState function syntax

* Update toggle element instructions

* Fix simple-counter solutions

* Fix bind-this challenge seed and solution

* Fix && challenge seed and solution

* Fix ternary challenge seed and solution

* Use the function form -> Pass a function

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Mention "passing a function" instead of "alternative form"

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Rephrase explanation

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* clarify why functions should be used

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Improve tests

* Fix \s escaping in []

* Improve regex

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Add test for `this`

* Use block code

* Update bind-this challenge

* Fix last part of instructions

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-09-24 08:12:50 -07:00
Ent Wickler
d08f009bd1 fix(curriculum): Add tests for setter, getter and setting a temperature (es6 tests) (#36620)
* add testing for setter, getter and setting a temperature according to some of feedbacks into the issues 17403

* bugfix: temperature is not a function
2019-09-23 17:13:32 +02:00
Oliver Eyton-Williams
3a0cd56ad3 fix(curriculum): Add and modify tests to catch bad code. (#36429) 2019-09-20 09:28:50 -07:00
sybiljasmine
5d946f3d77 valid factorial number update under the tests (#36792)
* valid factorial number update under the tests

* Update curriculum/challenges/english/08-coding-interview-prep/rosetta-code/factorial.english.md

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* Update curriculum/challenges/english/08-coding-interview-prep/rosetta-code/factorial.english.md

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* Update curriculum/challenges/english/08-coding-interview-prep/rosetta-code/factorial.english.md

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* Removed redundant array in the tests
2019-09-19 08:52:09 -07:00
Kaitlin
76e1b1a4ba Update user test 13 desc to match changed test (#36523)
* Update user test 13 desc to match changed test

Refer https://github.com/freeCodeCamp/testable-projects-fcc/issues/933.

* Add examples to illustrate change to user story 13
2019-09-19 17:51:10 +09:00
Ezgi Kaysı Kesler
93360f4e01 fix:Typo in uncomment-html page (#36800)
* fix:Typo in uncomment-html page

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/uncomment-html.english.md

removed comma

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2019-09-18 10:51:55 -07:00
Valeriy S
12f65a6742 fix(curriculum): fix challenges for russian language 2019-09-18 12:05:38 +05:30
Jasper Pilgrim
191f915e94 fix(curriculum): grammar, add period (#36785) 2019-09-12 18:48:28 +05:30
Huyen Nguyen
087640d020 fix(curriculum): Make challenge instruction clearer (#36771) 2019-09-11 14:18:28 +05:30
Tom
91dc86fbf0 fix(curriculum): update debugging challenge (fcc vs browser console) (#36703)
* fix: debugging-challege+difference-in-consoles

* fix: grammar

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/understanding-the-differences-between-the-freecodecamp-and-browser-console.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/understanding-the-differences-between-the-freecodecamp-and-browser-console.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/understanding-the-differences-between-the-freecodecamp-and-browser-console.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/understanding-the-differences-between-the-freecodecamp-and-browser-console.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/understanding-the-differences-between-the-freecodecamp-and-browser-console.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/understanding-the-differences-between-the-freecodecamp-and-browser-console.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/understanding-the-differences-between-the-freecodecamp-and-browser-console.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix/remove-comments-for-first-test
2019-08-30 15:31:57 -07:00
Sahil Bondre
335600d91c fix: change the explanation of splice function (#36721) 2019-08-30 13:59:56 +02:00
Tom
428ab97650 Fix/tests whitespace strictness (#36706)
* fix(tests): make less strict about white space
2019-08-28 10:53:17 +02:00
Tom
46d67deb46 fix(test): make less strict about whitespace (#36705) 2019-08-28 10:48:57 +02:00
Tom
07b38d02b3 fix(challenge-test): make semi-colon optional (#36704) 2019-08-28 06:22:47 +05:30
Tom
742a21345d fix(take-home-projects): Remove paragraphs with bad links (#36702) 2019-08-27 20:02:12 -04:00
Randell Dawson
316503bfaa fix: added forumTopicId to new challenge (#36609) 2019-08-21 11:20:05 -05:00
Lauren Van Sloun
4507a6b254 Minor grammar fixes (#36643)
* Minor grammar fix
2019-08-20 14:36:22 +01:00
Ai-Lyn Tang
24b3bed83f fix: add link to boilerplate Glitch file (#36340)
* Add link to boilerplate Glitch file

The boilerplate link is hard to see in the previous "introduction" page. I was using the old Glitch project link, and was confused.

When I googled for a solution, it was clear than others had also been quite confused. I believe this additional instruction will help many people.

* Direct people back to introduction page

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Remove unnecessary indentation

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Remove spaces on empty line

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Remove spaces on empty line

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Add empty line to fix markdown link

Markdown link needs a blank line to render correctly

* fix: add extra line to prevent linting error

* fix/remove-bullet-points


Co-authored-by: Randell Dawson <rdawson@onepathtech.com>
Co-authored-by: Tom <tmondloch01@gmail.com>
2019-08-18 20:27:54 +05:30
rns350
1ad3abd50f feat(curriculum); added another challenge to help teach recursion (#35966)
* Squashed the removal of the before test section

* fix: changed blockquote triple backtick syntax

* fix: removed recursion explanation

* fix: changed meta title and thru to through

* fix: capitalize "after" in several strings
2019-08-15 20:07:15 +09:00
Oliver Eyton-Williams
44804abeb5 fix: Remove and update challenges with legacy methods (#36444) 2019-08-15 01:22:41 +01:00
Tiago Salema
a305a3df9f componentWillReceiveProps is deprecated (#35894)
* componentWillReceiveProps is deprecated

Consider removing this lesson from the React tutorial, once this lifecycle method is now deprecated.
In case it isn't, a warning in the beginning should be displayed

* Removed also `componentWillReceiveProps`
2019-08-13 09:14:10 -07:00
SomeDer
01c8554adc 03-render-conditionally-from-props: use const (#36551) 2019-08-12 18:17:39 +05:30
SomeDer
4ff5e6eff6 Add code tag to test in extract-state-logic-to-redux (#36553) 2019-08-12 10:50:13 +02:00
happyhappyyay
7bb6aa7605 Typos fixed for readability (#36577)
* typo fixed

* fixed typos
2019-08-11 12:26:32 -05:00
joelzehring
992fc8f1bf Update generate-an-array-of-all-object-keys-with-object.keys.english.md (#36578)
Method should act on any passed parameter rather than the specific object named in this problem.
2019-08-11 11:42:19 -05:00
enrider
76bd5f4fc3 Issue #36564 update regex for spread operator (#36565)
* Issue #36564 update regex for spread operator

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-the-spread-operator-to-evaluate-arrays-in-place.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-08-06 14:56:48 -07:00
Randell Dawson
568f00e02a fix(curriculum): Added forumTopicId to remaining 1200 challeng… (#36558) 2019-08-05 22:14:37 +05:30
Randell Dawson
3ec1fe8ea7 feat: add forumTopicId to challenge frontmatter [pre-existing]
This commit adds the pre-existing challenge guide topics in the
forum to the forntmatter of their challenge markdown files.
2019-08-05 22:14:37 +05:30
lasjorg
881be7121e fix(challenge): remove type coercion check for true and false return (#36519)
* fix(challenge): remove type coercion check for true and false return

* fix(challenge): use Chai methods for false/true check
2019-07-30 08:33:37 -05:00
mrugesh
91df817cfe fix(guide) add stubs, update spellings and prepare for move (#36531)
* fix(guide) add stubs and correct file path misspellings and pr… (#36528)

* fix: corrected file path to match curriculum

* fix: renamed to newer challenge name

* fix: added solutions to articles from challenge files

* fix: added missing .english to file name

* fix: added missing title to guide article

* fix: correct solution for guide article

* fix: replaced stub with hint

* fix: added space in Hint headers

* fix: added solution to guide article

* fix: added solution to guide article

* test: replaced stub with hint and solution

* fix: add Problem number: to title

* fix: changed generatorexponential to correct name

* fix: renamed knight's tour to knights-tour

* fix: updated guide article
2019-07-30 00:25:58 +05:30
Oliver Eyton-Williams
e23c80a021 fix: remove assert messages from gamma function (#36530) 2019-07-29 17:38:29 +01:00
Randell Dawson
54a65d1bf0 fix: correct titles for 5 challenges (#36527) 2019-07-29 19:44:15 +05:30
Randell Dawson
ba6ae7154c fix: removed more assert msg arguments (#36439) 2019-07-28 05:16:04 +01:00
Randell Dawson
a7eb800450 fix(curriculum): Remove unnecessary assert message argument from English Coding Interview Prep challenges - Project Euler - 04 (#36418)
* fix: removed assert msg argument-4

* fix: remove double quotes surrounding testString code

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-07-27 07:34:19 -05:00
Randell Dawson
5cf3b458fa fix: removed assert msg argument-7 (#36421) 2019-07-26 21:48:23 -05:00
Randell Dawson
6e40dd2e50 fix: removed assert msg argument-6 (#36420) 2019-07-26 21:45:56 -05:00
Randell Dawson
71e873128a fix: removed assert msg argument-5 (#36419) 2019-07-26 21:41:55 -05:00
Randell Dawson
3e237f43ad fix: removed assert msg argument-3 (#36417) 2019-07-26 21:30:17 -05:00
Randell Dawson
399705a37a fix: removed assert msg argument-2 (#36416) 2019-07-26 21:26:37 -05:00
Randell Dawson
04f18e43f6 fix(curriculum): Remove unnecessary assert message argument from English Coding Interview Prep challenges - 02 (#36412)
* fix: removed assert msg argument

* fix: removed msgs surrounded by 2 single quotes

* fix: removed missing 2 assert msg arguments

* fix: remove msg surrounded by two single quotes

* fix: removed unnecessary assert msg args

* fix; remove msgs surrounded by double quotes

* fix: removed unnecessary assert msg args

* fix: remove unnecessary assert msg args

* fix: removed unnecessary assert msg arg

* fix: removed unnecessary assert msg args

* fix: removed unnecessary assert msg arg

* fix: removed unnecessary assert msg args

* fix: removed unnecessary assert msg args

* fix: removed unnecessary assert msg args

* fix: removed unnecessary assert msg args

* fix: removed unnecessary assert msg args

* fix: removed unnecessary assert msg arg

* fix: removed unnecessary assert msg args

* fix: Restore expected values to assertions

* fix: remove assertion message

Co-authored-by: Vivek Agrawal <vivekmittalagrawal@gmail.com>
2019-07-26 14:24:52 +02:00
Randell Dawson
d73b94133a fix: removed assert msg argument (#36415) 2019-07-25 17:44:15 +02:00
Randell Dawson
61baeb0cd6 fix(curriculum): Remove unnecessary assert message argument from English Coding Interview Prep challenges - 01 (#36410)
* fix: removed assert msg argument

* fix: remove msg surrounded by two single quotes

* fix: remove assert msg surrounded by double quotes

* fix: remove msg surrounded by double quotes
2019-07-25 08:56:32 +02:00
Randell Dawson
a53d992613 fix(curriculum): Remove unnecessary assert message argument from English Front End Libraries challenges - 01 (#36408)
* fix: removed assert msg argument

* fix: removed more assert msg args

* fix: removed assert msg missed

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: correct indentation
2019-07-25 08:53:37 +02:00
Randell Dawson
cbbfc08108 fix: removed more assert msg args (#36441) 2019-07-24 13:13:06 +01:00
Randell Dawson
ee97fa4542 fix(curriculum): Remove additional unnecessary assert message argument from English Coding Interview Prep challenges (#36440)
* fix: removed more assert msg args

* fix: remove single quotes wrapping testString

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* fix: remove single quotes wrapping testString

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* fix: remove single quotes wrapping testString

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* fix: remove single quotes wrapping testString

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* fix: remove single quotes wrapping testString

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* fix: remove single quotes wrapping testString

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* fix: remove single quotes wrapping testString

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* fix: remove single quotes wrapping testString

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2019-07-24 13:09:23 +01:00
Randell Dawson
f2df76c099 fix(curriculum): Remove unnecessary assert message argument from English Front End Libraries challenges - 02 (#36409)
* fix: removed assert msg argument

* fix: removed more assert msg args

* fix: removed more assert msg args
2019-07-24 13:07:46 +01:00