Commit Graph

3609 Commits

Author SHA1 Message Date
Kristofer Koishigawa
4b1c5ebc7a fix(challenges): change test for template literals challenge (#37)
The original test was too rigid, and many users were forced to use one solution, usually map, to
complete the challenge. The test is changed here to allow for multiple solutions to the problem,
including the use of either single or double quotes when naming a class.

BREAKING CHANGE:
None
2018-06-29 23:47:58 +05:30
huyenltnguyen
6e02f9d3e4 fix(challenges): fix responsive web design cert claim
BREAKING CHANGE:
none
2018-06-24 14:41:31 +01:00
Thomas Lombart
cf9336a3b1 fix(challenges): Correct a regex in ES6 read-only challenge (#41)
The regex testing if the user has entered console.log(SENTENCE); was broken. It has been modified.
2018-06-24 14:41:31 +01:00
NitronR
816be51471 fix(interview-prep): Remove duplicates 2018-06-24 14:41:31 +01:00
Bhanu Pratap Singh Rathore
21930a8c1b feat(interview-prep): Porting Rosetta problems (#17537)
* feat(interview-prep): Porting Rosetta problems

* Objects formatted and description updated.

* Update rosetta-code.json

* Update rosetta-code.json

* Fixed syntax for Identity matrix description array
2018-06-24 14:41:31 +01:00
John Kennedy
d4cf9deee6 fix: sample code in intro to currying
Corrected the code sample that didnt work
Amended uncurried example to better tie in with rest of code making the lesson more cohesive
2018-06-21 18:48:04 +05:30
Stuart Taylor
6de827c8b7 fix: give 'Exercise Tracker' the correct id 2018-06-21 18:48:04 +05:30
Niraj Nandish
16ff132f44 fix: typo errors (#23)
* Typo errors

Unnecessary break

Grammatical error

* remove an unnecessary <br>
2018-06-21 18:48:04 +05:30
Niraj Nandish
5815401097 fix: example link will open in new tab (#22)
Example link will open in new tab

Final editing
2018-06-21 18:48:04 +05:30
Michael Silverman
999c6af639 fix: changes text to bold in the JS Algo and DS (#20) 2018-06-21 18:48:04 +05:30
Ankit Tiwari
e1dfe8f43c fix: Remove an unnecessary line from basic javascript challenge (#19) 2018-06-21 18:48:04 +05:30
Tom
d31e0a3a24 fix: blockquote-formatting-in-challenges (#17590) 2018-06-19 17:53:24 +05:30
Vimal Raghubir
fb3d904b64 Fix: Reword unempathetic sentence (#17598)
* Fix: Reword unempathetic sentence

* Remove unnecessary word
2018-06-19 17:53:24 +05:30
Varun
1573455292 fix(challenges): Fix typo in security challenge (#17608) 2018-06-19 17:53:24 +05:30
Alex Swiontek
3a8ff9a8d1 style(challenges): Change "Mortal Combat" to "Mortal Kombat" (#17625)
Reference the game by using the correct spelling
2018-06-19 17:53:24 +05:30
Bhanu Pratap Singh Rathore
a133a3f139 feat(interview-prep): Porting Rosetta problems (#17537)
* feat(interview-prep): Porting Rosetta problems

* Objects formatted and description updated.

* Update rosetta-code.json

* Update rosetta-code.json

* Fixed syntax for Identity matrix description array
2018-06-19 17:53:24 +05:30
Kristofer Koishigawa
20fac4e2c3 revert: "test(challenges): Corrected expected average value" (#17568) 2018-06-14 03:30:04 +05:30
Vimal Raghubir
0d2afb5743 Fix: Code ordering issues (#17560)
* Fix: Code ordering issues

* Update applied-visual-design.json
2018-06-14 03:30:04 +05:30
Vimal Raghubir
e72755461c Fix: Match single quotes (#17539)
* Fix: Match single quotes

* Fix: slash direction

* Fix: Regex expression and refined tests
2018-06-13 13:02:11 +05:30
Vimal Raghubir
9e84a54d72 fix: rename incorrect variable name (#17538)
* fix: rename incorrect variable name

* Fix: Bad variable naming
2018-06-13 13:02:11 +05:30
Matthew Smith
ed5e02d7ae test(challenges): Corrected expected average value (#17562)
Modified 8.675 to 8.52 in three places for correct average value

BREAKING CHANGE: n/a

Closes #17561
2018-06-13 13:02:11 +05:30
Todd Bradshaw
8d57e1607f fixed line breaks in 'Prevent Object Mutation' challenge (#17547)
* fix(seed):line breaks in 'Prevent Object Mutation' challenge #17541

* Update es6.json
2018-06-13 13:02:11 +05:30
Vimal Raghubir
8c119560d6 Fix: Remove duplicate test (#17543) 2018-06-13 13:02:11 +05:30
Vuong
1245522cba Fix typo in CSS Grid: Use Media Queries to Create Responsive Layouts (#17534) 2018-06-13 13:02:11 +05:30
Devon Aleshire
821164d519 Update to challenge verbiage for radio/checkbox (#17527)
Updated create radio / create checkbox to identify that the input element is not required to be inside the label element. Tried to use soft language without making user think it was incorrect because current tests still require the input to be nested within the label element. Also, this is not necessarily incorrect syntax as noted at W3 - Forms - Labels: https://bit.ly/2sLiXvE. Nesting implies implicit association vs explicit association using for attribute.
2018-06-13 13:02:11 +05:30
Bhanu Pratap Singh Rathore
5e2c24e3b8 feat(interview-prep): Porting Rosetta problems (#17480)
* feat(interview-prep): Porting Rosetta problems

* Changes done

* Update rosetta-code.json

* Update rosetta-code.json
2018-06-11 18:22:32 +05:30
Jarek Wojciechowski
68b089e95d fix(challenges): add info about ReactDOM.render in an early react challenge (#17186) (#17473) 2018-06-11 18:22:32 +05:30
bogadodiegoh
c9f572d271 fix(seed): updated basic javascript URLs for hints (#17445)
* Updated json file with right url values

* Updated url links after review

* Updated another broken url link after review
2018-06-11 18:22:32 +05:30
Vimal Raghubir
0874eca77c fix: added new test and fixed incorrect variable (#17471)
* Added new test and fixed incorrect variable

* Fix: Incorrect sentences and descriptions

* Update es6.json
2018-06-11 18:22:32 +05:30
manjeet5
ff8b13b316 fix(challenges): Corrected a test case for challenge (#17162)
For the last test case in 'Access Props using this.props' challenge, I
updated the test condition to check that the value of the tempPassword
prop is the same as the content within the <strong/> tags. This test
case will ensure that there is text present in the strong tag and its
value is as expected.

BREAKING CHANGE: none

Closes #17134
2018-05-30 01:47:52 +08:00
Rajat Kanti Nandi
2a3369aa6b Updated basic-javascript.json file for challenge Manipulate arrays with shift; issue: #17235 2018-05-25 19:28:17 +00:00
Stuart Taylor
7c694c2666 Fix/react versions (#17236)
<!-- freeCodeCamp Pull Request Template -->

<!-- IMPORTANT Please review https://github.com/freeCodeCamp/freeCodeCamp/blob/staging/CONTRIBUTING.md for detailed contributing guidelines -->
<!-- Help with PRs can be found at https://gitter.im/FreeCodeCamp/Contributors -->
<!-- Make sure that your PR is not a duplicate -->

#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply. -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [x] Your pull request targets the `staging` branch of freeCodeCamp.
- [x] Branch starts with either `fix/`, `feature/`, or `translate/` (e.g. `fix/signin-issue`)
- [ ] You have only one commit (if not, [squash](http://forum.freecodecamp.org/t/how-to-squash-multiple-commits-into-one-with-git/13231) them into one commit).
- [x] All new and existing tests pass the command `npm test`. Use `git commit --amend` to amend any fixes.

#### Type of Change
<!-- What type of change does your code introduce? After creating the PR, tick the checkboxes that apply. -->
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
- [ ] Add new translation (feature adding new translations)

#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply. -->
<!-- If you're unsure about any of these, don't hesitate to ask in the Contributors room linked above. We're here to help! -->
- [x] Tested changes locally.
- [x] Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #17215

#### Description
<!-- Describe your changes in detail -->
2018-05-25 17:27:15 +05:30
Stuart Taylor
15a92597ed fix(seed): challenge types (#17229)
Closes #17221
2018-05-24 21:27:09 +05:30
Bennett Elder
d039668a8f fix(challenges): Fix wrong word on Basic CSS lesson (#17219)
Updated 'valuables' to say 'variables' since that's what the description was about.
2018-05-23 12:59:34 +05:30
Kristofer Koishigawa
bcee3174aa style(challenges): Format Descriptions for Project Euler 1-16 (#17172)
Here are a list of style changes made for problems 1-16:

* 2: Centered text
* 6: Centered text and `<sup>` tags
* 8: Centered text
* 9: Centered text, `<var>`, and `<sup>` tags
* 11: Centered text and spacing between number grid and next paragraph
* 12: Tab spacing (padding-left: 4em)
* 14: Centered text, `<var>` tags, and tab spacing (padding-left: 4em)
* 16: `<sup>` tags

BREAKING CHANGE: None
2018-05-23 12:58:03 +05:30
Kristofer Koishigawa
b996d86cc3 style(challenges): Format Descriptions for Project Euler 17-26 (#17175)
Here's a list of style changes made for problems 17-26:

*17: Bold tags
*18: Bold tags
*19: ul and li tags for leap year information
*20: var tags and line break
*21: var tags
*22: added code tag
*23: var tags
*24: centered text and var tag
*25: sup tags, tab-like spacing, and CSS grid for spacing
*26: sub, sup, and var tags, and CSS grid for spacing

BREAKING CHANGE: None
2018-05-23 12:56:51 +05:30
Stuart Taylor
4e645a5ff6 Package: Validate challenges on test (#17216)
This PR allows us to validate the schema during test.

It also removes some cruft from the seed files and ensures only the required data is packaged and consumable, reducing the package weight somewhat.
2018-05-22 18:13:14 +05:30
Stuart Taylor
ee66d84ccb feat(package): Initial Curriculum separation (#17174)
* feat(package): Initial Curriculum separation

* feat(package): Add org scope to package

* chore(ooops): Remove development file

* feat(npm): Add .npmignore

* fix(paths): Fix curriculum paths

* feat(build): Add a build step

* chore(seed): Move package file back to seed

* fix(ignore): Fix .npmIgnore file

* chore(docs): Update README

* chore(seed): Rename coding interview blocks

* fix(seed): Challenge files now fit into learn

* chore(seed): Update seed files for use in learn

* chore(escapes): Unescape script tags of jQuery
2018-05-21 19:26:49 +05:30
Jarek Wojciechowski
63482406ea style(seed): Remove typo from chai-http-IV challenge title (#17148) (#17149) 2018-05-15 12:36:36 -04:00
Aditya Rohilla
c212258e2d fix(seed): removed typo from task description (#17166) 2018-05-15 10:16:33 +05:30
Kristofer Koishigawa
28eacebaf9 fix(challenges): Add Tests and Solution for Project Euler 50 (#17152)
Added an additional test and a solution adapted from the one
@elliotjz contributed to the fCC Arcade Mode.

BREAKING CHANGE: None
2018-05-14 15:12:04 +01:00
Kristofer Koishigawa
58e82ea802 fix(challenges): Edit Description, Add Tests and Solution for Project Euler 47 (#17142)
Edited the description to more closely match the spacing and line breaks
from projecteuler.net. Added more tests, updated the challenge seed,
and added a solution from user @elliotjz contributed to the fCC
Arcade Mode.

BREAKING CHANGE: None
2018-05-11 22:15:55 -04:00
Kristofer Koishigawa
b7be885c73 fix(challenges): Edit challengeSeed and Add Solution for Project Euler 49 (#17146)
Changed the name of the function in the challengeSeed from euler49 to the
challenge name. Also added a solution that @elliotjz contributed to the
fCC Arcade Mode.

BREAKING CHANGE: None
2018-05-11 17:23:28 -04:00
Kristofer Koishigawa
080c27e7cb fix(challenges): Edit Description, Tests, and Add Solution for Project Euler 48 (#17145)
Added `<sup>` tags to the description to make it more like the one on
projecteuler.net. Also added additional tests and a solution.

Here's a solution for QA:

```
```

BREAKING CHANGE: None
2018-05-11 17:00:46 -04:00
Oliver
26c29f25aa fix(seed): Change tag nesting order (#17093)
Changed em tag to wrap around p tag

Closes #17077
2018-05-08 20:09:14 -04:00
Kristofer Koishigawa
7235ca1def fix(challenges): Edit Description and Add Solution for Project Euler 46 (#17140)
Updated the problem description with `<sup>` tags. Also added a solution
that user @elliotjz contributed to the fCC Arcade Mode.

BREAKING CHANGE: None
2018-05-08 15:53:01 -04:00
Kristofer Koishigawa
6586ecd5b6 fix(challenges): Edit Description and Add Solution for Project Euler 45 (#17126)
Updated the problem description with an inline CSS grid, <sup>, and
<var> tags. Also added a solution that user @elliotjz contributed
to the fCC Arcade Mode.

BREAKING CHANGE: None
2018-05-08 15:43:20 -04:00
Kristofer Koishigawa
cca9b8b3a8 fix(challenges): Edit Description and Add Solution for Project Euler 44 (#17127)
Updated the problem description with <sup> and <var> tags, and centered
some text. Also, added a solution that user @elliotjz contributed to the
fCC Arcade Mode.

BREAKING CHANGE: None
2018-05-06 21:48:17 +05:30
Marcin Procyk
2b5e39e1f8 fix(seed): Bootstrap default button fix (#17082)
added btn-default class to lessons with basic Bootstrap buttons, which
add proper styles for default button

Closes #17075
2018-05-03 10:07:00 -04:00
Jake Magers
23ff6cc16f fix(seed): Fix tests for apisMicroservicesCert (#17105)
Users are now capable of claiming the "Apis and Microservices"
certificate.
2018-05-03 18:34:44 +05:30