Commit Graph

1266 Commits

Author SHA1 Message Date
gikf
bd02249a23 fix(learn): rework Rosetta Code Count the Coins (#41282)
* fix: rework challenge to use argument in function

* fix: use better wording

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-03-09 08:34:10 -06:00
Nicholas Carrigan (he/him)
77730ae209 fix(learn): address translator comments (#41381)
* fix(learn): address translator comments

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/quoting-strings-with-single-quotes.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-09 08:15:26 -06:00
gikf
93495ef6db fix(learn): correct tests description (#41280)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-09 11:48:12 +05:30
Nicholas Carrigan (he/him)
16e420021c chore: audit data visualisation challenges (#41336)
* chore(learn): audit d3 projects

* chore: audit data vis

* chore: audit json apis

* Update curriculum/challenges/english/04-data-visualization/data-visualization-projects/visualize-data-with-a-scatterplot-graph.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: apply suggestions

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: no colour backticks

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/get-geolocation-data-to-find-a-users-gps-coordinates.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-05 12:25:29 -07:00
Ricardo Passos
ae79525493 fix(learn): added a missing period and removed single quotes (#41377)
* Added missing period

On line 24, just before "Note that in your CSS..." a period was missing.

* Removed single quotes and added a missing period

On line 24, just before "Note that in your CSS..." there is a missing period. 
On line 30, the text "red-text" within a code tag is enclosed in single quotes.
2021-03-05 07:16:30 -08:00
Nicholas Carrigan (he/him)
4d8aae1678 fix: backtick formatting (#41371) 2021-03-05 11:39:04 +05:30
gikf
5332628e6d fix(learn): rework Rosetta Code Hailstone Sequence (#41279)
* fix: rework challenge to use argument in function

* fix: change leftover html to markdown

* Apply suggestions from code review

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* remove leftovers

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-03-04 13:28:47 -08:00
lusc
8a5711dda7 Fix: remove a colon in rosetta-code/happy-numbers (#41349)
* Fix: remove a colon in rosetta-code/happy-numbers

Removed a colon that shouldn't be there

* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/happy-numbers.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Add inline code tags around all true and falses

https://github.com/freeCodeCamp/freeCodeCamp/pull/41349#discussion_r586700058

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-04 09:25:55 -07:00
Andrew Cen
65cc800689 fix: add blank lines on empty seeds (#41348) 2021-03-03 13:14:28 -08:00
gikf
728f44ab38 fix: clarify case for already placed valid number (#41225) 2021-03-03 23:02:51 +05:30
Nicholas Carrigan (he/him)
7117919d36 chore(learn): audit javascript algorithms and data structures (#41092)
* chore(learn): audit basic algorithm scripting

* chore(learn): audit basic data structures

* chore(learn): audit basic javascript

* chore(learn): audit debugging

* chore(learn): audit es6

* chore(learn): audit functional programming

* chore(learn): audit intermidate algorithms

* chore(learn): audit js projects

* chore(learn): audit object oriented programming

* chore(learn): audit regex

* fix(learn): remove stray .

* fix(learn): string to code

* fix(learn): missed some

* fix(learn): clarify strings

Based on Randy's feedback, clarifies string instances where quotes
were removed in favour of back ticks.

* fix: apply suggestions - thanks Randy! :)

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: non-suggestion comments

* chore(learn): remove comments from codes

Removes the comments from the description and instruction code
blocks to ensure that all relevant information is translatable.

* fix: Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: revert crowdin fix

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-algorithm-scripting/mutations.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-arrays.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: Apply suggestions from code review

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* chore: change voice

* fix: Christopher Nolan

* fix: expressions would evaluate

* fix: will -> would

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/object-oriented-programming/add-methods-after-inheritance.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: to work to push

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-with-javascript-for-loops.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/object-oriented-programming/add-methods-after-inheritance.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-03-02 17:12:12 -07:00
Randell Dawson
57f3c80345 fix(learn): Clarify date format expectations for the Date Format challenge (#41327)
* fix: clarify date format expectations

* chore: apply suggestions from code review

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-03-02 15:46:30 -08:00
Sem Bauke
f328bdb93e fix(curriculum) fixes for grammar and missing articles (#41335)
* fix(curriculum) fixes for grammar and missing articles

* Update curriculum/challenges/english/01-responsive-web-design/css-grid/add-gaps-faster-with-grid-gap.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-02 12:27:45 -07:00
Ilenia
051a010798 fix(learn): disallow www link from challenge (#41275)
This commit disallows www link from "Nest an anchor in a paragraph" challenge.
2021-02-27 02:47:47 +05:30
Nicholas Carrigan (he/him)
31bdea63a2 chore(learn): audit front end libraries (#41179)
* chore(learn): audit bootstrap

* chore(learn): audit FE projects

* chore(learn): audit jQuery

* chore(learn): audit React

* chore(learn): audit react-redux

* chore(learn): audit redux

* chore(learn): audit sass

* fix: apply review suggestions

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: apply non-suggestions

* chore: remove comments from code

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-25 10:19:24 -07:00
Randell Dawson
33356e403a fix(learn): Use backticks around back slash character (#41254) 2021-02-25 16:34:40 +05:30
Oliver Eyton-Williams
4917e59aaa fix(curriculum): use user's url in url shortner tests (#41257)
This service is both guaranteed to be up (they're hosting it) and should
allow CORS for all requests (including the tests).
2021-02-25 12:04:09 +01:00
Randell Dawson
b11dd87047 fix: remove sentence not needed (#41235) 2021-02-23 11:21:58 -06:00
Randell Dawson
f4bbe3f34c fix(learn): Updated code blocks to help with translation on two challenges (#41217) 2021-02-22 11:21:59 +05:30
Alexander Heß
b12360d4a8 Removed the hint Fixes #41192 (#41215)
* Removed the hint Fixes #41192

* Removed the blank line as suggested
2021-02-21 13:36:14 -07:00
Ilenia
aa615763af fixed tests for link to external pages challenge (#41191)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-21 11:46:00 +05:30
gikf
531c3f9997 feat(learn): add project tests (#41183) 2021-02-21 10:37:02 +05:30
gikf
219339b2ce fix(learn): rework Project Euler - Problem 58 (#41188) 2021-02-20 12:06:32 +05:30
gikf
f5a905b7c2 fix(learn): unmangle challenge description (#41182) 2021-02-20 12:04:38 +05:30
gikf
70c4d82068 fix(learn): correct test result (#41068) 2021-02-20 12:04:12 +05:30
gikf
c8db838754 fix: correct function call in test description (#40949) 2021-02-20 12:03:54 +05:30
gikf
a91444d3d4 fix: correct function call in test description (#40944) 2021-02-20 12:03:33 +05:30
Kelvin Sánchez
f08174b5b1 fix(learn): Remove unnecessary inline code tag in challenge (#41177)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-19 09:44:50 +05:30
Kelvin Sánchez
fad168b465 fix(learn): fix some code tags, capitalization and punctuation in challenge (#41161)
* fix some code tags, capitalization and punctuation

Note: The reserved word in JavaScript is "boolean", so I think it is appropriate to use it like this inside the code tags.

* Remove code tags and capitalize first letter

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* capitalize letter and replace slash

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-18 08:45:12 -07:00
Kelvin Sánchez
2c1280af65 fix(learn): Improve the clarity on a challenge sentence (#41154)
* Improve the clarity on a challenge sentence

* add string type and remove double quotes

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-18 08:29:31 -07:00
gikf
762775889e fix: rework Project Euler - Problem 57 (#40926)
* fix: rework challenge to use argument in function

* fix: add solution

* fix: correct variable name
2021-02-17 11:58:18 -08:00
Kelvin Sánchez
1fe1371b16 add missing inline-code block (#41153) 2021-02-17 11:24:53 -08:00
Joshua Pelealu
10aee18748 Remove broken twitter links (#41152) 2021-02-17 12:03:57 -07:00
Kelvin Sánchez
b45406ec9d fix(learn): Remove repeated definition tag in challenge (#41151) 2021-02-17 23:01:42 +05:30
Joshua Pelealu
c15c27f474 fix(learn): Added another test to check for invalid characters (#41144) 2021-02-17 21:16:07 +05:30
fots
2a2657d36c fix: update regex for Convert JSON Data to HTML (#41134)
* fix: updated solution for Convert JSON Data to HTML

* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/convert-json-data-to-html.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/convert-json-data-to-html.md

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-02-16 16:27:47 +00:00
Nicholas Carrigan (he/him)
21c7abf584 fix(learn): update challenge for crowdin (#41089) 2021-02-16 19:47:40 +05:30
Supritha
ee6764519d REMOVED comments (#41048)
* Added comments

Fixes freeCodeCamp/freeCodeCamp#40903

* remove comments
2021-02-11 09:13:38 -07:00
Kristofer Koishigawa
c9de726d6a feat: move Repl.it links to first challenge in backend projects (#40803) 2021-02-11 14:09:59 +05:30
gikf
6ae3735979 fix: correct tests descriptions (#40945) 2021-02-10 17:12:12 +05:30
ehsabd
9f219f3f2b fix(learn): Fix the public assets folder confusion by giving it its own folder (#40802)
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-02-10 17:11:40 +05:30
Kim Leung
082b269dce fix(learn): backslashes in description & hint text (#40801)
Correct example code in description and last hints text to match the last assertion test's actual and expected inputs.  The string input with a single backslash throws an unterminated string constant error (single backslash starts a regex).  No change to last assertion test as it was written correctly with a double backslash and passing as expected.
2021-02-10 17:10:51 +05:30
Lucas Sorenson
f8aa6c04e2 fix(learn): update seed code for D3.js challenge (#40699)
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
Co-authored-by: Lucas Sorenson <lsorenson@sunsh1n3.com>
2021-02-10 17:06:19 +05:30
Ismail Tlemçani
0f8449788c feat(learn): add tests to use a callback function in the sort method (#40847) 2021-02-10 17:05:23 +05:30
Tom
959fe8323a fix(learn): mongoose set up instructions (#40909)
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-02-10 17:04:16 +05:30
Tom
51f6077f7b fix(learn): regex-criminal-in-hunt-challenge (#40901)
* fix: regex-criminal-in-hunt-challenge

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/regular-expressions/find-one-or-more-criminals-in-a-hunt.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-08 06:10:59 -08:00
Jean-Baptiste LARRIVIERE
1c539d07c3 fix(curriculum): remove mention of null from challenge (#40942)
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-02-08 13:17:32 +05:30
Tom
15227a0148 fix(curriculum): helmet install and csp lessons (#40904) 2021-02-06 16:36:40 +00:00
Randell Dawson
167f93df76 fix(learn): Add inline code blocks to for i18n (#40921) 2021-02-05 14:16:19 +05:30
Shaun Hamilton
1a9b791f29 update(curriculum): explicitise use-the-env-file (#40898)
* update(curriculum): explicitise use-the-env-file

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-02-04 19:43:18 +01:00