Commit Graph

880 Commits

Author SHA1 Message Date
Randell Dawson
54bc113721 fix(curriculum): Added 9 missing solutions to challenges in the Debugging section (#35750)
* fix: add 9 solutions to challenges

* fix: remove extra line

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
2019-04-19 00:14:20 +05:30
Astrid
9ee8b4fa57 fix: minor grammar mistake in 'applied visual design' challenge (#35839)
fix: revert changes to package-lock.json
2019-04-15 14:05:30 +05:30
Beau Carnes
63fc21f702 Update videoURL for HTML5 Elements challenge (#35802) 2019-04-14 09:20:36 -07:00
Benjamin Herrchen
20f71fd22e correct usage of Math.random() to give equal 50/50 results (#35840)
* Update render-conditionally-from-props.english.md

* Update render-conditionally-from-props.english.md
2019-04-13 18:06:01 -04:00
Paul Gamble
bddcda5559 added html solution for testing - responsive-web-design/applied-visual-design/decrease-the-opacity-of-an-element (#35516)
* added html solution for testing

* fix: corrected invalid solution
2019-04-12 18:17:12 +02:00
Stepan Pugachev
55ef2d8a95 Russian translation adjusted (#29511) 2019-04-11 22:05:29 +04:00
Aditi Joshi
ebdd8632fc Fix/update challenges for responsive-web-design-principles (#35804)
* Fix/update challenges for responsive-web-design-principles

* fix/update fix some minor mistakes

* fix/update remove extra line

* Update curriculum/challenges/english/01-responsive-web-design/responsive-web-design-principles/create-a-media-query.english.md

Co-Authored-By: aditijoshi14 <aditijoshi1997@hotmail.com>

* Update curriculum/challenges/english/01-responsive-web-design/responsive-web-design-principles/create-a-media-query.english.md

Co-Authored-By: aditijoshi14 <aditijoshi1997@hotmail.com>
2019-04-10 17:26:56 -04:00
olga1blinova
5f5e886aac Fixed local title. (#29492) 2019-04-10 21:43:37 +04:00
Dmitrii Kholodov
2e3a4abbc1 Update make-circular-images-with-a-border-radius.russian.md (#29375) 2019-04-10 21:41:02 +04:00
Beau Carnes
7e522dc473 fix: add new scrimbas (#35803) 2019-04-10 09:23:12 -07:00
Ian Effendi
f74d507434 fix(curriculum): replace js with full solution in accessibility challenge (#35810)
* fix(curriculum): add full, working solution for accessibility challenge.

This commit replaces a JavaScript only solution where a full, working
solution should have been written.

* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/avoid-colorblindness-issues-by-using-sufficient-contrast.english.md

Co-Authored-By: rimij405 <effendiian@gmail.com>
2019-04-10 17:55:16 +02:00
Randell Dawson
6a859ee7f9 fix: added 12 missing solutions to Basic Data Structure Challenges (#35744) 2019-04-10 21:03:15 +05:30
Guayo Mena
75293e649d fix(curriculum): Fix test in Javascript challenge (#35795)
Fixes #35793

I rearranged the variables in one of the tests.
I just changed the english file. Should I change the rest of the languages as well?

Note: I did this change through github's API, because I couldn't run the project locally so I haven't actually tested it.
2019-04-10 20:55:05 +05:30
lasjorg
394ae3d1ce fix(challenge): check for li and specify elements accepting text (#35193)
* fix(challenge): check for li and specify elements accepting text

* fix(challenge): revert text

* fix(challenge): remove word added by mistake

* fix(challenge): update test, cleanup assertion text
2019-04-10 20:52:37 +05:30
Manish Giri
9b9a96234f fix(curriculum): Add solutions to responsive web design principles (#35761) 2019-04-10 07:57:14 -07:00
Randell Dawson
42bc9fa9b6 fix(curriculum): Made tests not accept invalid HTML (#35774)
* fix: made tests stricter

* fix: simplify text

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
2019-04-10 19:21:52 +05:30
Randell Dawson
d5798c38de fix: rewrite of word blanks challenge (#35779) 2019-04-10 01:48:01 -04:00
Ziyao Zhang
8704a75844 Improve Chinese translation in euler-problem-1 (#29917)
* Improve Chinese translation in euler-problem-1

* Delete temporary reference text
2019-04-08 15:08:40 -07:00
Kyle Scheuerlein
f590fecb34 Update reduce-repetition-using-the-repeat-function.english.md (#35787) 2019-04-08 20:09:26 +05:30
Manish Giri
c27dc72e4d fix(curriculum): Improve Array Sort Challenge (#35756)
* fix(curriculum): Improve Array Sort Challenge

* Update note to include in challenge description

Co-Authored-By: Manish-Giri <manish.giri.me@gmail.com>
2019-04-07 13:42:38 +05:30
lasjorg
f91dea9b5c fix(challenge): update text to give an explanation of wrapping (#34811)
* fix(challenge): update text to give an explanation of wrapping

* fix(challenge): simplify challenge text

* fix(challenge): update challenge text add solution

* fix(challenge): remove line breaks

* fix(challenge): make second instruction more clear
2019-04-04 22:49:21 -04:00
chaomt
216e10e2b7 fix: A testing bug in FCC's React Simple Counter Challenge (#35715) 2019-04-03 22:24:05 -05:00
Roberto Ruccia
91f4865ab4 Fix typo in curriculum/challanges/english/01-responsive-web-design/applied-visual-design/use-the-css-transform-scale-property-to-scale-an-element-on-hover.english.md (#35743) 2019-04-02 21:43:27 -04:00
Kristofer Koishigawa
095188215f fix(challenges): Regex Asterisk Challenge (#34800)
* fix(challenges): Fixes description and adds tests to close #17872.

* fix(challenges): Removed unnecessary string arguments from testString

* fix: improved challenge instr and tests
2019-04-01 19:19:13 +05:30
Илья
a326c2cf9a Make a comparison in the test more accurately (#35500)
* Update use-arrow-functions-to-write-concise-anonymous-functions.english.md

* refactor:  fix the assert messages to make them more like all the rest in the curriculum (i.e. using `should`)

Co-Authored-By: iliyaZelenko <iliyazelenkog@gmail.com>
2019-04-01 10:55:43 +02:00
Dana Ottaviani
c08f3785cb Add solutions to Bootstrap challenges (#35710)
* feat: add solution for font-awesome icon challenge

* feat: add solution to add all button icons challenge

* feat: add solution to add ids to bootstrap elements challenge
2019-03-30 23:20:01 -07:00
Jonathan Lawrence
f743c675c7 Grammar fix (#35711)
I was going through the Bootstrap lessons and found this. Very small change, I know, but I believe it's important.
2019-03-31 11:30:37 +05:30
Aditi Joshi
4ead7621d6 fix: basic-html-and html5 challenge arabic - test (#35441)
* fix: basic-html-and html5 challenge arabic - test

* improve translation quality
2019-03-31 05:51:48 +02:00
Randell Dawson
60c796e70d Revert "curriculum: Change pre and code to blockquote in Advanced Node and Express challenge (#35697)" (#35709)
This reverts commit b16773617e.
2019-03-30 00:40:12 +04:00
The Coding Aviator
b16773617e curriculum: Change pre and code to blockquote in Advanced Node and Express challenge (#35697) 2019-03-29 13:10:46 -07:00
Amy Lam
914a7c522d Copy edits (#35536)
* Copy edits to Basic JavaScript section

* Copy edits to ES6 section

* Update index.md
2019-03-29 22:06:58 +05:30
Valeriy S
845b966bda fix(client): execute web workers concurrently 2019-03-29 15:06:10 +05:30
lucassorenson
b0565aa8d0 Update match-anything-with-wildcard-period.english.md (#35696)
A fix for issue #35089, updated the examples in the description to use .test() instead of .match() to better reflect the challenge
2019-03-28 11:46:33 -07:00
Lipis
e84ae45008 Javascript -> JavaScript (English) (#35183)
* Javascript -> JavaScript (English)

* Update technical documentation page for required change

* Update use-class-syntax-to-define-a-constructor-function.english.md

* Update left-factorials.md
2019-03-28 14:05:41 +05:30
Randell Dawson
6c82a07b2d fix: made destructuring test more flexible (#35685) 2019-03-27 23:59:53 +05:30
lasjorg
be687977cf fix(challenge): add .english to file name (#35687) 2019-03-27 06:38:25 -07:00
NITIN BISHT
a403dfe5e1 fix: formatting code for quality assurance and testing with chai (#35471) 2019-03-27 17:01:58 +05:30
Avahe Kellenberger
cde8516688 Added missing 'var' on variable declaration. (#35675) 2019-03-27 11:37:58 +05:30
lasjorg
d9213b38cd fix(challenge): remove child selector from name attribute test (#35423) 2019-03-27 11:33:41 +05:30
Zebulan Stanphill
8e6bfd57bf Fix missing variable declaration in data structures challenges (Russian) (#35640) 2019-03-26 21:57:15 -07:00
Zebulan Stanphill
94f7ff2802 Fix missing variable declaration in data structures challenges (Portuguese) (#35639) 2019-03-26 21:56:35 -07:00
Zebulan Stanphill
c7f6f9ac55 Fix missing variable declaration in data structures challenges (Chinese) (#35637) 2019-03-26 21:55:48 -07:00
Zebulan Stanphill
0de2050bff Fix missing variable declaration in data structures challenges (Arabic) (#35636) 2019-03-26 21:54:06 -07:00
lasjorg
69d9d522a2 fix(challenge): fix broken regex (#35632)
* fix(challenge): fix broken regex

* fix(challenge): update solution
2019-03-26 21:48:52 -07:00
lasjorg
a1e853337b fix(challenge): simplify and cleanup tests (#35535) 2019-03-26 21:35:38 -07:00
Oliver Eyton-Williams
b10589fadf fix: Challenge solution added and broken test updated. (#35526)
* fix: solution added and broken test updated.

* fix: Change test to equality and finish solution

* Update use-css-selectors-to-style-elements.english.md
2019-03-26 21:01:22 -07:00
Justin Hilliard
8b5ef8cfdd Fix(Curriculum): Constructor function not explained before ES6 #17865 (#35463)
* Fix(Curriculum): Constructor function not explained before ES6 #17865

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-class-syntax-to-define-a-constructor-function.english.md

Co-Authored-By: hilliarj <hilliarj@dickinson.edu>

* Update to #17865 PR

Fix(Curriculum): Constructor function not explained before ES6. Used an unordered list and the syntax that others recommended.
2019-03-26 09:53:19 -07:00
seanlaing
e4870c472a fix/update-es6-destructor-challenge: Added test (#35455)
* fix/update-es6-destructor-challenge: Added test
- Added test incase during destructuring somebody pass and extra key

* fix/update-es6-destructor-challenge: Fixed the test case per review comments
-Cleaned up regex
- Setup two cases one where additional assignment of variables before and then after
- Did not put uppercase case CONSTANT checks because not related to question

* fix: corrected tests
2019-03-25 15:49:56 -05:00
Hrishit Prasad Biswas
4eb4afe53b Fixed bug in 2nd test for Access Multi-Dimensional Arrays With Indexe… (#35666)
* Fixed bug in 2nd test for Access Multi-Dimensional Arrays With Indexes Challenge

* Fix for issue #35665

Fixed Bug In 2nd test case for Access Multi Dimensional Arrays With Indexes

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/access-multi-dimensional-arrays-with-indexes.english.md

Co-Authored-By: Artistic18 <hrishitbiswas20@gmail.com>

* fix: added missing ) for assert statement
2019-03-25 15:42:21 -05:00
Jean Jordaan
33edc072b9 Use the correct element name in <code> blocks, gloss it seperately (#35616)
* Update link-to-external-pages-with-anchor-elements.english.md

If you write "`anchor` element" instead of "`a` element", you should also write "`hyperreference` attribute", instead of "`href` attribute".
Suggestion: write "`a` (_anchor_) element", or "anchor (`a`) element", to communicate the element name explicitly and gloss it at the same time.
The `<code>` sections should be valid code as far as possible.

* Change md to html

* Don't mark up 'anchor' as code

The tag is `a`, the name is _anchor_.

* Revert "Don't mark up 'anchor' as code"

This reverts commit 50c6a3a7c9.

* Don't mark up 'anchor' as code

The tag is `a`, the name is _anchor_.
2019-03-25 10:50:33 -05:00