Commit Graph

25444 Commits

Author SHA1 Message Date
62e1464eb7 change "given" to "adding" (Was: change "given" to "giving") (#37823)
* change "given" to "giving"

* change to "adding" as suggested

As suggested in https://github.com/freeCodeCamp/freeCodeCamp/pull/37823
2019-11-25 08:14:08 -08:00
cc9c86bd72 Update docs/how-to-open-a-pull-request.md for grammar and readability (#37235)
* Fix minor grammar errors

* Rephrase keyword section

* Add keyword documentation link for learners

* Reword for clarity and fix grammar

* fix: make suggested changes

* fix: removed comma
2019-11-25 10:09:30 -06:00
9dd1d42b7e Update how-to-set-up-freeCodeCamp-locally (#37264)
Made some minor grammatical changes to clarify the message intended by the sentence
2019-11-25 09:58:13 -06:00
a987245e18 Added new test cases and corrected the solution for positive and negative lookahead for ensuring that strings beginning with numbers are not accepted (#37485)
* Added new test case '8pass99' for positive and negative lookahead

* Changed the pwRegex to reflect the new solution

* Updated the pwRegex to reflect the latest solution as on forum

* Added another test case to catch "/^(?=\w{6,})(?=\D*\d{2})/" solution
2019-11-24 17:11:20 -05:00
deb24f77b6 fix(curriculum): English editing (#37814)
* fix(curriculum): English editing

* fix(curriculum): English editing

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-class-syntax-to-define-a-constructor-function.english.md

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* Update use-class-syntax-to-define-a-constructor-function.english.md
2019-11-24 16:38:30 -05:00
dc1b59070e fix: use arrow function syntax (#37818) 2019-11-24 02:37:11 -05:00
0c22313760 fix(curriculum): English editing (#37815)
* fix(curriculum): English editing

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-getters-and-setters-to-control-access-to-an-object.english.md

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
2019-11-23 18:37:36 -05:00
70f736fe07 fix(curriculum): English editing (#37816) 2019-11-23 17:28:56 -05:00
174af7fa66 feat(client): pagination on timeline (#37569)
* Implemented pagination on timeline

* Made requested change and removed outline from button

* fix: PropTypes and off-by-one error

* Keep buttons centered in all cases and give fixed height timeline table rows to prevent jerk while changing pages

* First and last page navigation and margin issue fix.

* Explicitly importing specific lodash functions

* Refactored timeline pagination into a separate file.

* Refactored timeline to have total Pages as prop and made text corrections.

* Added proptypes for total pages

* made changes to setState call for lastPage

* Made a11y changes
2019-11-23 12:06:13 -08:00
5ea745d61f fix(curriculum): English punctuation correction (#37811) 2019-11-22 06:35:10 -08:00
1fc71e6969 Update create-a-basic-javascript-object.english.md (#37810)
small spelling correction (everyday -> every day)
2019-11-22 06:34:34 -08:00
6fc32ab9b6 fix(curriculum): changed test text to use should for Front End Libraries (#37762)
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-22 13:44:40 +01:00
9706bc47ff Work on the space-evenly option for flexbox justify-content (#37797)
This challenge requests setting the justify-content attribute to one of the possible values shown in the previous challenge. One of these values - space-evenly - doesn't actually work (at least for the English version).

In this commit I fix the space-evenly issues to some extent.

I cannot tick the box saying that all files changed are in the same world language. However, the changes made should be understandable in all languages.

There still is more to be done for languages other than English, like adding to the test text for Arabic, Portuguese, and Spanish, and adding descriptions for space-evenly in the previous challenge.
2019-11-21 12:46:46 -05:00
06a26861f6 fix(donate): unify layouts and navigation for consitency (#37795)
This commit updates the layouts and the styles to be consistent with the rest of the application. This also ensures now that the gatsby navigation is used for smoother transtions.
2019-11-21 15:00:22 +05:30
c25916c9a2 fix(curriculum): changed test text to use should for Coding Interview Prep - part 2 of 2 (#37766)
* fix: changed test text to use should

* fix: corrected typo

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: removed extra period

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: removed extra period

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: removed extra period

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: removed extra period

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: corrected typo

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-20 10:01:31 -05:00
9cd57105af fix(curriculum): changed test text to use should for Information Security and Quality Assurance (#37763)
* fix: changed test text to use should

* fix: corrected typo

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: corrected typo

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: remove unnecessary backslash

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: simplified text

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: added period

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
2019-11-20 09:58:14 -05:00
9bf3fdbf38 fix(curriculum): changed challenge test text to use the word should for Responsive Web Design (#36860)
* fix: changed challenge test text to use should

* fix: changed have to be used in

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: reworded test verbiage

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: improved test verbiage

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: improved test verbiage

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: corrected typo

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: corrected typo

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: changed have the to be used in

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: corrected verbiage

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2019-11-20 20:15:19 +05:30
b663c39901 fix(donate): fix computed hours donated for monthly donation
Closes #37786
2019-11-20 12:15:00 +05:30
65e5b26fa1 fix(donate): update default donation amounts
Closes #37787
2019-11-20 12:15:00 +05:30
c25fa49b5b fix(curriculum): changed test text to use should for Coding Interview Prep - part 1 of 2 (#37765)
* fix: changed test text to use should

* fix: corrected typo

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: corrected typo

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: corrected typo

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: use singular of verb

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: changed punctuation

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: reworded test text

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-19 20:13:45 -05:00
301d03df7b Update add-font-awesome-icons-to-all-of-our-buttons.english.md (#37668)
The thumbs up from the previous challenge was removed from the seed in an earlier merge -- seems like it should be there since the instructions only say to add the icons to the remaining buttons.
2019-11-19 20:12:15 -05:00
437ba8b103 fix(curriculum): Read-search-ask link now point to correct url as noted in the issue (#37753)
* fix: broken Read-search-ask link now point to correct url

* fix: changed link to original forum link with more views

* fix: changed http links to correct version

* fix: link in help modal
2019-11-19 19:54:48 -05:00
62aa54efba fix(donate): apply suggestions from code review
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-11-20 00:02:07 +05:30
0bd66eaf82 chore: temporarily remove PayPal components
This commit should be reverted while implementing PayPal integration
2019-11-19 23:09:56 +05:30
f30f8072b0 chore(donate): unify donation config
This commit can be further optimised to DRY out values
2019-11-19 23:09:56 +05:30
a5969ac0e5 fix(donate): update font to Lato on paragraphs 2019-11-19 23:09:55 +05:30
1da1f7d0be fix(donate): re-order and scroll to top on processing 2019-11-19 23:09:54 +05:30
aeec1bb9e6 feat(donate): integrate servicebot 2019-11-19 23:09:53 +05:30
2cb8c16b28 fix(donate): control plan creation with environment variable 2019-11-19 23:09:52 +05:30
21b09b53cb fix(donate): adjust verbiage and time contibuted 2019-11-19 23:09:48 +05:30
f737b24b6f feat(donate): remove themes from donate pages 2019-11-19 22:28:05 +05:30
ef0a801c90 feat(donate): remove unauthenticated routes 2019-11-19 22:28:05 +05:30
e13f35171c feat(donate): updated donate page and plans
- [x] two column layout for the page.
- [x] amount to learning minutes mapping for contribution impact.
- [x] handle one-time and recurring stripe subscription charges.
- [x] server side validation of donate forms.
- [x] prevent multiple subscriptions and onetime donations per user.
2019-11-19 22:28:04 +05:30
6921c3fecc updates text for the location of the button (#37764)
fixes the text describing the location of the logs button, due to the new design of the glitch.com website
2019-11-19 10:54:14 -06:00
febba792e7 fix: allow log in testString, restrict test errors
Console logs from testString get reported and test errors are sent to
the dev console (JS).

challenge building is only attempted if there is a build function to do
so.

Various functions have been renamed to better reflect what they do.
2019-11-19 22:23:57 +05:30
9194b7731b fix: simplify logging and include console.log
This comes at the cost of creating a flash of the default message when
the preview updates, but significantly simplifies the code.
2019-11-19 22:23:57 +05:30
beecb04c1a fix: report errors thrown after the frame is ready
Certain challenges involve code that is not run until the user
interacts with the preview (typically via a click listener). This uses
consoleProxy to report those errors.

Error logging has been simplified, reducing the number of places errors
can be reported from.

Some of the redux-saga code has been renamed in an attempt to improve
clarity.
2019-11-19 22:23:57 +05:30
04d2de96df fix: conditionally log non-assertion errors (JS)
console.logs and errors are only reported during the first evaluation of
the user's code.  This is because the code is evaluated for each test,
but the logs will not change between the build phases of the tests.

Errors thrown during testing (except failing assertions) are always
reported. This is to inform the user that their code is faulty, rather
than that it does not meet the challenge's requirements.
2019-11-19 22:23:57 +05:30
9a97d639f5 fix: add dynamic output for legacy challenges
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-11-19 22:23:57 +05:30
64fcbbb491 fix: output console.logs as user types (JS) 2019-11-19 22:23:57 +05:30
29641986ab fix: output console.logs as user types (DOM)
Any console.logs inside script tags will be written to the fcc console
as the user types.  DOM challenges only.

Also, DRYed out the main and test frame creation.
2019-11-19 22:23:57 +05:30
6acab90cb6 fix: report user code evaluation errors
Errors thrown during evaluation of the user's code will now be reported.

JavaScript challenges will only report to the browser console and only
during testing.

DOM challenges will report to the browser console during testing and as
the user types, but only report to the fcc console during testing
2019-11-19 22:23:57 +05:30
5059d23600 fix: report all build errors to the fcc console
Previously only challenges with previews would inform the user of syntax
errors.  This extends that to all challenges and corrects the output
format so errors are clearer.
2019-11-19 22:23:57 +05:30
890ce894cc fix: correct typos in incidence matrix instruction (#37779) 2019-11-18 16:34:23 -08:00
73943994ff Update add-font-awesome-icons-to-our-buttons.english.md (#37667)
Correct typo in instructions  -- says to add the "fa" class instead of the "fas" class.
2019-11-17 07:55:39 -08:00
fc1a923dd5 Made description of logical operator under "or operator" challenge a little more intuitive. (#37772)
* Update comparisons-with-the-logical-or-operator.english.md

* Update comparisons-with-the-logical-or-operator.english.md

* Update comparisons-with-the-logical-or-operator.english.md
2019-11-16 21:30:52 -05:00
Tom
5ca2d2467a fix: make help button use subforum topics (#37741)
* fix: make help button use subforum topics

* fix: add test to check that block exists

Co-authored-by: ojeytonwilliams <ojeytonwilliams@gmail.com>

* fix: improve error message

* Update curriculum/test/test-challenges.js

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-11-15 23:03:08 +05:30
07b74ab70b Improved translate russian language (#37647) 2019-11-15 22:36:52 +05:30
39df6a2b56 fix(curriculum): added new test to Give Links Meaning by Using Descriptive Link Text challenge to specifically for href attribute (#37699)
* fix: added new test to test href attribute

* fix: changed You to Your

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: changed a to an

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-15 10:14:54 -06:00
1fb202b742 fix(curriculum) - Add class box in json apis and ajax (#37725)
* Add class box in json apis and ajax

* Remove .box in id & add .box in seed code
2019-11-15 08:56:28 +01:00