Commit Graph

1503 Commits

Author SHA1 Message Date
Gregory Gubarev
5a44fcf77e Improved Russian translate (#37537)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-03-26 12:13:23 -07:00
Víctor Lasa
f9eefa18f0 Fixed Google translations and added Solution (#37488)
Also modified the wording to be more cohesive with the rest of the documentation.
2020-03-26 11:23:03 -07:00
Randell Dawson
1fdb691996 fix(learn): updated tests and deleted old sample code (#38450) 2020-03-26 23:12:18 +05:30
Hassaan Pasha
4fbce07792 fix: improve test regex to validate disallowed methods that can be bypassed by prototype reassignments and/or otherwise (#38214)
* fix: improve test regex to validate disallowed methods that can be bypassed by prototype reassignments and/or otherwise

* fix: fixing regex pattern
2020-03-26 08:13:34 -07:00
Relsig
bb7a50e341 Enable newlines in Authentication with Socket.IO, test 3 (#37862)
* newlines in Authentication with Socket.IO, test 3

Both my original formatting and glitch's "format this file" button add a newline between "io.use("  and  "passport.authorize"
".+" catches one or more of anything that isn't a newline.
"[^]+" catches one or more of anything including newlines. 
This change updates the test accordingly so people who use glitch's formatting don't get left searching for assistance

* less permissive match to prevent shenanigans

Won't work with comments still.

* fix my own silliness
2020-03-26 08:09:34 -05:00
Bet-Zua
ff0973ad65 restructured grammar for clarity (#37368)
Rewrote parts of the sentences about the zero-index to add clarity.
2020-03-26 16:38:07 +05:30
Andres Arrieta
448068888c fix(i18n): Spanish corrected explanation and fixed redundancy (#37281)
described the media query in a bit more detail and fixed a redundancy description on the first paragraph.
2020-03-26 16:11:04 +05:30
Arthur
7ad220d1ac fix: add tests for exercise tracker (#37696)
* fix: add tests for exercise tracker
2020-03-26 10:39:06 +01:00
Randell Dawson
e0e6334628 fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 3 of 4 (#38264)
* fix: remove example code from challenge seed

* fix: remove declaration from solution

* fix: added sum variable back in

* fix: reverted description back to original version

* fix: added examples to description section

* fix: added complete sentence

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: corrected typo

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* fix: reverted to original desc with formatted code

* fix: removed unnecessary code example from description section

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: failiing test on iterate through array with for loop

* fix: changed to Only change this line

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Manish Giri <manish.giri.me@gmail.com>
Co-authored-by: moT01 <tmondloch01@gmail.com>
2020-03-25 16:07:13 +01:00
Randell Dawson
50f15886b8 fix(curriculum): Strip comments from user code for Use Destructuring Assignment to Extract Values from Objects challenge (#38213)
* fix: strip user code to improve tests

* fix: removed closing section tag messing up tests
2020-03-25 13:28:17 +01:00
Kalyanasundaram
8b0cbd6f83 Modify tests for testing objects for properties challenge (#38414)
* Stronger test cases for testing objects for properties

Change function signature to take in a custom object to be tested

* YML formatting mistake

* Yaml no space in string

* Small one more fix - most likely final

* REmove double space in return

* Update instruction Section
2020-03-24 22:09:57 -07:00
Randell Dawson
1f2a93b646 fix: added additional test for altText (#38395) 2020-03-23 07:02:34 -05:00
Keith Warter
022bbdd1b0 Adding a solution for searching within a linked list for future students (#38326)
* Adding a solution for future students

* fix: added new tests and correctied existing tests

* Adding isEmpty method as well

* Update curriculum/challenges/english/08-coding-interview-prep/data-structures/search-within-a-linked-list.english.md

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

Co-authored-by: Randell Dawson <rdawson@onepathtech.com>
Co-authored-by: Manish Giri <manish.giri.me@gmail.com>
2020-03-21 09:30:14 -05:00
Vincent Shury
6920634e6c TYPO-FIX JS-regex-match-non-whitespace-characters (#38407)
Added Markdown to correctly display second test
2020-03-20 21:13:48 -07:00
Sanket Kogekar
f25d035e9d add: solution to project euler problem 23 md file (#38369) 2020-03-18 16:37:26 -07:00
Hassaan Pasha
a282c24bf4 fix (curriculum): added console output checks for the inheritance challenge (#38360)
Co-authored-by: Hassaan Pasha <hassaan.pasha@teamo.io>
2020-03-14 21:55:21 -07:00
Sanket Kogekar
705cc32579 add: solution to project euler problem 22 md file (#38263)
* add: solution to project euler 22 md file

* Copied the array instead of using it directly

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-03-13 14:31:13 -07:00
Shivam saini
4ef78f7f7d Update use-recursion-to-create-a-countdown.english.md (#38366) 2020-03-13 16:05:59 +01:00
Randell Dawson
cc190aba99 fix: removed assert message arguments 2020-03-12 20:46:46 +09:00
Bhanu Pratap Singh
72bc067e6b feat(interview-prep): Regenerated IDs 2020-03-12 20:46:46 +09:00
Bhanu Pratap Singh
ec0a5e0b6f feat(interview-prep): Updated descriptions and corrected syntax 2020-03-12 20:46:46 +09:00
unknown
e4a6f5563f feat(interview-prep): Converting and transferring Rosetta problems 2020-03-12 20:46:46 +09:00
Randell Dawson
fde8c05a20 fix(curriculum): strip comments from CSS in testString to fix bug caught by tests (#38351)
* fix: strip-comments-from-css

* fix: added challenge referenced in issue

* fix: added call to function removeCssComments

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-03-11 08:56:34 -05:00
Hassaan Pasha
8c435c8b75 fix (curriculum): changed the index to 0 for the fibonacci sequence challenge (#38331) 2020-03-10 13:43:41 +03:00
Ashraf Nazar
a2d31afe81 fix: Update test in Redux challenge to accomodate backticks (#38345) 2020-03-10 12:15:50 +03:00
Randell Dawson
c401fc7f83 fix(curriculum): removed solution required comment from 6 challenges (#38339)
* fix: removed solution required comments

* fix: fixed two more challenge soltuions with solution required comment

* fix: remove debugging code

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-03-09 13:58:46 +01:00
Randell Dawson
9252f96566 fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 4 of 4 (#38267)
* fix: consolidate comments


Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2020-03-08 15:46:28 +01:00
Shivam
dbf3815fc7 added:solution for Coding Interview Prep/Data Structures-Create a Map Data Structure (#38337)
* add: solution to Data Structures-Create a Map Data Structure

* Proper usage of -hasOwnProperty

removed unnecessary returns
2020-03-07 22:07:40 -08:00
Hassaan Pasha
3a47c5411f fix (curriculum): made the order of the required code to be re… (#38320)
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-03-06 12:44:39 +05:30
underlineGalaxy
b99d2d8e1f Correção de título javascript-algorithms-and-data-structures-c… (#37252)
"Javascript" no texto original se refere a algoritmos, o que não é o caso na tradução original. Isso é corrigido aqui.
2020-03-06 12:35:51 +05:30
underlineGalaxy
e64747ec25 Correção de erros de linguagem e clareza em understand-the-con… (#37251)
Como o inglês não posse gêneros em objetos (it), é necessário colocá-los em algumas traduções para que se mantenha a mesma claridade. Aqui era necessário pois o usuário pode não entender que o texto está se referindo a função em si. 
Outras palavras foram mudadas para se condizer com as normas do português, assim como algumas pontuações.
2020-03-06 12:35:01 +05:30
Tom
17a55c6e18 fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 1 of 4 (#38258)
* fix: consolidate/remove comments

* fix: remove => from comment

* fix: reverted changes to add same changes to another PR

* fix: removed 'the' from sentence

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: removed 'the' from the sentence

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-03-04 13:08:54 -06:00
Kristofer Koishigawa
0b1ba11959 fix: sync english and chinese responsive web design challenges (#38309) 2020-03-03 19:11:15 +05:30
Kristofer Koishigawa
b3213fc892 fix(i18n): chinese test suite (#38220)
* fix: Chinese test suite

Add localeTiltes, descriptions, and adjust test text and testStrings to get the automated test suite working.

* fix: ran script, updated testStrings and solutions
2020-03-03 18:49:47 +05:30
Randell Dawson
6a7a7e6d7d fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 2 of 4 (#38259) 2020-03-03 10:18:30 +03:00
Senipah
012e5c848b reword instruction referring to 3d array (#38272) 2020-02-29 22:35:53 -08:00
Ashraf Nazar
181ac1e8ad fix: Update test for wrapping strong tag around text to include periods at the end (#38305) 2020-02-29 01:02:39 -05:00
Oliver Eyton-Williams
2d7b1255cc fix: add missing .english extensions (#38298) 2020-02-28 07:19:22 -08:00
Kristofer Koishigawa
6cfd0fc503 fix: improve Project Euler descriptions, challenge seeds, and test cases (#38016)
* fix: improve Project Euler descriptions and test case

Improve formatting of Project Euler test descriptions. Also add poker hands array and new test case for problem 54

* feat: add typeof tests and gave functions proper names for first 100 challenges

* fix: continue fixing test descriptions and adding "before test" sections

* fix: address review comments

* fix: adjust grids in 18 and 67 and fix some text that reference files rather than the given arrays

* fix: implement bug fixes and improvements from review

* fix: remove console.log statements from seed and solution
2020-02-28 06:39:47 -06:00
Randell Dawson
41718abf76 fix(learn): consolidate comments for responsive web design cert (#38256)
Related to PR #38040

This PR is an attempt to consolidate/remove as many comments in the challenge seed code in the Responsive Web Design certification challenges, to be able to create a small translation lookup object for translating the English comments to other languages.
2020-02-27 20:50:46 +05:30
Andres Arrieta
baf2ec6c42 fix(i18n): spanish correct description of the challenge (#37132) 2020-02-27 19:05:21 +05:30
Harsh Savergaonkar
c21c9f0acb Added meaning of ones in adjacency matrices (#37048)
* Added meaning of ones in the matrix

* Apply suggestions from code review

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: add slash to avoid markdown lint error

Co-authored-by: mrugesh <1884376+raisedadead@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-02-27 06:54:11 -06:00
Igor Hideki Trindade
d4f8b00c84 Fix portuguese translations (#37051) 2020-02-27 15:38:11 +05:30
Igor Hideki Trindade
94712af264 Fix portuguese translations on curriculum challenge (#37050) 2020-02-27 15:37:28 +05:30
Sanket Kogekar
1a87f1f7c0 add: solution to project euler problem 20 (#38257)
* add: solution to project euler problem 20

* Update curriculum/challenges/english/08-coding-interview-prep/project-euler/problem-20-factorial-digit-sum.english.md

Accidentally added last line. Calling function is unnecessary in solution.

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* right place for starting braces

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* moved starting brace to previous line.

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Manish Giri <manish.giri.me@gmail.com>
2020-02-26 14:22:40 -05:00
Prakash Kumar
c9d8c2a73c fix(learn): typo in Serialization of a User Object (#38262) 2020-02-26 15:07:32 +05:30
Vincent Shury
b49b9f3e3c Typo whitespace fix in access-multi-dimensional-arrays-with-indexes.english.md (#38247)
* Update access-multi-dimensional-arrays-with-indexes.english.md

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-02-24 17:02:53 +01:00
Randell Dawson
78156a65f0 fix(curriculum): Added test to Return a Sorted Array Without Changing the Original Array challenge to validate new array is returned (#38105)
* fix: added test to validate new array is returned

* fix: changed text to reflect changed test

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-02-24 15:30:48 +01:00
Tom
a09ffadd5a fix: responsive image challenge (#37934)
* fix: responve image challenge

* fix: bad solution

* Update curriculum/challenges/english/01-responsive-web-design/responsive-web-design-principles/make-an-image-responsive.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/01-responsive-web-design/responsive-web-design-principles/make-an-image-responsive.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/01-responsive-web-design/responsive-web-design-principles/make-an-image-responsive.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-02-20 22:53:30 +05:30
Oliver Eyton-Williams
b0f1fa4b96 fix: make recursion challenge more intuitive (#37399) 2020-02-20 21:36:33 +05:30