Timo Köhler
7ce8c58709
Put value into quotes ( #40172 )
...
* Put value into quotes
It can be missunderstanding that "value" is a string!
* fix: remove quotes from inside code tags
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2020-11-25 16:32:14 -06:00
Nicholas Carrigan (he/him)
49f6875db5
fix(learn): ES6 Getters + Setters tests ( #40238 )
...
* Strengthen tests
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
* Improve verbiage
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
* Add second check to setter test
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
2020-11-25 14:22:44 -08:00
Nicholas Carrigan (he/him)
ec8b2dc016
feat(learn): Message Board User Stories ( #40219 )
...
* Update verbiage, add instructions
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
* Remove unit test mention
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
* Move test descriptions to learn
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
* target blank on gh link
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
2020-11-25 14:11:38 -08:00
Nicholas Carrigan (he/him)
49f2055b98
Move tests to /learn ( #40263 )
...
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-11-25 13:27:22 -08:00
Nicholas Carrigan (he/him)
62713f0e10
feat(learn): Move American British Translator tests ( #40265 )
...
* Move tests to /learn
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
* Replace quotes with code
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
2020-11-25 12:10:52 -08:00
Nicholas Carrigan (he/him)
c0b9ad6bf2
Move tests to /learn ( #40264 )
...
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
2020-11-25 12:06:42 -08:00
Nicholas Carrigan (he/him)
b5d5ec5a90
feat(learn): Stock Price Checker user stories ( #40218 )
...
* Adjust user stories, add instructions
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
* Apply review suggestion
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* Move tests to /learn
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
* Apply suggestions from code review
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-11-25 11:55:03 -06:00
Lasse Jørgensen
df44da9dc2
fix(challenge): correct terminology and inform of correct array copying ( #40045 )
...
* fix(challenge): correct terminology and inform of correct array copying
* fix(challenge): update text with proposed changes
2020-11-25 08:14:33 -08:00
Tom
0b117274d7
fix(learn): enhance exercise tracker user stories ( #39965 )
...
* fix(learn): enhance exercise tracker user stories
* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/exercise-tracker.md
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/exercise-tracker.md
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/exercise-tracker.md
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/exercise-tracker.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/exercise-tracker.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/exercise-tracker.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/exercise-tracker.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/exercise-tracker.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* fix: remove duplication mention of count
* fix: add more tests for user story
* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/exercise-tracker.md
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/exercise-tracker.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* fix: change single quotes to double quotes
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2020-11-25 09:25:01 +00:00
Rex Schrader
79e3cb51e5
feat(learn): add/remove tests for Imperial-Metric Converter ( #39615 )
...
* Remove Infosoc Tests, Add tests, fix error reporting
* Add capital 'L' for liter requirement, check unit/funct test counts
* Apply suggestions from code review
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>
* Apply suggestions from code review
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-11-24 20:19:49 +00:00
Kristofer Koishigawa
5a41edca1a
fix(learn): issue tracker test text error message ( #40301 )
2020-11-24 12:56:41 -06:00
Randell Dawson
b47487b8b2
fix(learn): Change Node project descriptions to all use same template ( #40266 )
...
* fix/change-node-project-descriptions-to-all-use-same-template
* fix: use correct boilerplate
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
* fix: add url to link text
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
* fix: add _blank for target attribute
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
* fix: add missing single quote
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
* fix: remove extra lines
* fix: improved wording of description
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
* fix: move sentence to previous paragraph
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
* fix: move sentence to previous paragraph
* fix: move sentence to previous paragraph
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-11-20 12:02:31 -08:00
Farhan Ullah
9ba94e38b4
fix(learn): isSorted returning true on empty arrays which passes the test ( #40192 )
...
* bug-fix: isSorted returning true on empty arrays
* sorted order test improvements
2020-11-20 09:51:59 -08:00
Shaun Hamilton
bce3d5b372
fix(learn): remove white space for quick fix ( #40231 )
...
* fix(learn): remove white space for quick fix
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2020-11-20 09:21:21 +01:00
Yasamin Yaldaei
72b8629ecc
fix(learn): personal library boilerplate links destination ( #40267 )
2020-11-19 14:51:59 -08:00
Randell Dawson
2c9a900353
fix: added more values to list to improve tests ( #40256 )
2020-11-18 09:38:26 +00:00
lucia montero
c03beb3ca6
Fix tests to allow spaces in "Sass: Create Reusable CSS with Mixins" ( #40230 )
...
* Fix tests to allow spaces. Closes #40212
* Apply suggestions from code review
Remove redundant whitespace from regex
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-11-15 00:14:47 +01:00
Amy Surrett
1ef49d2c57
fix(learn): add note about tweet button restrictions ( #40118 )
...
* fix: add note about tweet button restrictions
* fix: added target blank and top hint
2020-11-14 11:52:48 +00:00
pkarczma
273f1d1aed
fix(learn): typo in an answer to the Numpy question ( #40227 )
...
* fix: typo in an answer to the Numpy question
* fix: revert typo in Chinese file
2020-11-13 13:52:13 -06:00
Rex Schrader
5a9680a1a6
feat(learn): Add Tests to Issue Tracker Project, Remove InfoSec Tests ( #39627 )
...
* Feature: Add Tests to Issue Tracker Project
* Refactored User Stories
* Apply suggestions from code review
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
* Modify verbiage for #39721
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2020-11-12 19:51:09 -08:00
Rex Schrader
bd593667f6
feat(learn): Add tests to Personal Library ( #39642 )
...
* Resolve Merge Conflict
* Add Instructions, Reformat Description
* Update curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/personal-library.md
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
* Update curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/personal-library.md
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
* Update curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/personal-library.md
* Change links to Markdown style
* Apply suggestions from code review
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
* Apply suggestions from code review
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* Verbiage per #39721
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
* Update curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/personal-library.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* Update curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/personal-library.md
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-11-12 16:13:00 -06:00
Tom
f353278905
feat: update description and user stories ( #40217 )
...
* feat: update description and user stories
* feat: add hint from boilerplate
* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/file-metadata-microservice.md
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2020-11-11 12:32:10 -08:00
Kristofer Koishigawa
135928dc5d
fix(learn): update machine learning project colab links ( #40213 )
...
* fix(learn): update machine learning project colab links
Update current machine learning project Colab links to clone Jupyter notebooks from the boilerplate repos rather than the ones in Google Drive.
* fix(learn): update chinese versions of colab links
2020-11-11 08:56:23 -08:00
Tom
5aef8a70c6
Fix(learn): improve timestamp project user stories ( #39961 )
...
* fix(learn): enhance timestamp project user stories
* fix(learn): clarify user stories for timestamp project
* fix: update description area
* fix: update verbiage
* fix: broken tests + add a specific example
* fix: add code highlighting
2020-11-10 15:53:57 -08:00
rajapandi_vijayakumar
e8b6a9e5dd
fix(learn): add example declaration for clarity ( #40207 )
...
Variable declaration is added which is used inside the switch case.
2020-11-09 17:09:21 +00:00
Rex Schrader
8fd00afd9c
feat(learn): Add tests for refactored American/British Translator ( #39822 )
...
* feat(learn): Add tests for refactored American/British Translator
* Move to Markdown formatting
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
* Update curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/american-british-translator.md
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
* Update american-british-translator.md
With contributions from @mot01
* Apply suggestions from code review
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-11-06 20:23:11 -06:00
Nicholas Carrigan (he/him)
9cfd9ad887
feat: Add tests for Sudoku Solver ( #39816 )
...
* Add tests
* Apply Tom's requests
* Verbiage change
* Apply suggestions from code review
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-11-06 20:03:43 -06:00
Randell Dawson
895e6b8daf
fix(learn): add test to prevent hardcoded pass ( #40179 )
2020-11-06 17:05:20 +00:00
Tom
7ce85a8f03
fix(learn): update helmet and bcrypt instructions so we can remove them from boilerplates ( #39954 )
...
* fix: update helmet and bcrypt lesson instructions
* fix: update instrutions I missed
* Update curriculum/challenges/english/09-information-security/information-security-with-helmetjs/install-and-require-helmet.md
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
* Update curriculum/challenges/english/09-information-security/information-security-with-helmetjs/understand-bcrypt-hashes.md
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-11-04 19:11:36 -08:00
Ty Mick
f2236983a2
Strengthen test for reassigning node reference ( #40133 )
2020-11-04 09:46:18 -08:00
Nicholas Carrigan (he/him)
cf35d24311
feat(learn): Add Stock Price Checker tests ( #39640 )
...
* Add some tests
* More tests
* remove extraneous declaration
* Remove unneeded test string
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-11-04 09:37:27 -08:00
Shaun Hamilton
c058af2caa
feat(learn): add url-shortener instructions ( #40162 )
...
* feat(learn): add url-shortener instructions
* capatalise post word
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
* remove sentence with external link
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2020-11-03 09:06:07 -06:00
Nicholas Carrigan (he/him)
d8be4d24a5
feat(learn): Some tests for Anonymous Message Board ( #39652 )
...
* Clean up text, partial test completion
* remove extraneous declaration
* Apply suggestions from code review
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* Use non-breaking space after colon
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-11-03 08:26:10 -06:00
Shaun Hamilton
e1bae44036
feat(learn): migrate mongodb-mongoose instructions to learn ( #39970 )
...
* feat(learn): migrate mongodb-mongoose instructions to learn
* remove extraneous quotation mark
* update with boilerplate change
* grammar changes on instructions
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-11-03 08:22:55 -06:00
Shaun Hamilton
d2e1a385e7
fix(learn): add route to timestamp api in tests ( #40144 )
2020-11-02 12:54:56 +09:00
Marc Antoni
1badd3c3a6
fix(learn): add test case to regex challenge ( #40087 )
...
existing test cases can be satisfied by /^[a-z][a-z]+$|^[a-z][a-z]*\d\d+$/i
2020-11-01 13:24:35 +00:00
Atakan
fb0812b6d2
fix(learn): added description about a nonallowed method ( #40121 )
2020-10-31 20:01:03 +01:00
Shai
8ceae38730
fix(learn): modified usage of words from argument to parameter based on the title ( #40130 )
2020-10-31 19:59:43 +01:00
Steven Walker
2645fae939
fix(learn): updated instructions to be explicit ( #40131 )
2020-10-31 19:53:30 +01:00
Oliver Eyton-Williams
e4a9b2988c
feat: update Ask for help ( #40114 )
...
* feat: get helpCategory from frontmatter
* DEBUG: sets all the projects to JavaScript
This is just so the tests pass, it'll need to go.
* fix: updated helpCategoryMap categories
* fix: added Python to helpCategory frontmatter key
Co-authored-by: Randell Dawson <rdawson@onepathtech.com>
2020-10-30 14:10:34 -05:00
Ty Mick
5f956e9a16
Strengthen isBinarySearchTree test ( #39982 )
2020-10-26 13:30:46 -05:00
Adrian Muntean
0ae1df30c7
fix: add info for problem 54 - project Euler ( #40057 )
...
* fix: add info for problem 54 - project Euler
* update text
2020-10-22 11:59:49 -07:00
Akiko Takano
8ec0da2259
fix(learn): update the required package name ( #40056 )
2020-10-22 19:32:55 +05:30
sreekumar menon
dec4b2180f
Scalar addition issue on Element-wise operations ( #40013 )
...
* Scalar addition issue on Element-wise operations
* remove chinese from PR
Co-authored-by: Sreekumar Menon <sreekumar@roofstock.com>
2020-10-19 11:29:23 -07:00
steviehailey
b503333c64
Rephrase linear gradient explanation ( #39990 )
...
* Rephrase linear gradient explanation
Small tweak to explanation to remove ambiguity over horizontal vs vertical
* Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/create-a-gradual-css-linear-gradient.md
Code review suggestion - mention horizontal and quote the values
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* Use code tag for snippets
Was using backtick but updated based on formatting guidelines - https://contribute.freecodecamp.org/#/how-to-work-on-coding-challenges?id=formatting-challenge-text
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-10-19 11:01:03 -07:00
Bobby BuffaloBoy
71659b7c94
fix(learn): Date corrected the example description from Sunday, to Friday, in the date-format Rosetta Code Challenge (English) ( #39998 )
2020-10-17 23:01:18 +02:00
Ke Cleveland
13e7251ed9
fix(learn): Update findXmasSunday function arguments from (2008,2121) to (1970, 2017) to match expected return. ( #39996 )
...
Co-authored-by: keiveland <keivelanddev@gmail.com>
2020-10-17 22:46:03 +02:00
Oliver Eyton-Williams
35c4020f4d
fix(curriculum): test typos ( #39984 )
2020-10-15 14:49:57 -04:00
Ty Mick
f6fcb26a9d
fix(learn): strengthen a test in "Data Structures: Remove Elements from a Linked List" ( #39977 )
...
* Add an additional test to LinkedList.remove
* Consolidate tests
2020-10-15 17:14:05 +01:00
Tom
15cf41e7e1
fix(learn): Update basic node express instructions to remove them from boilerplates ( #39953 )
...
* fix: adjust instuctions so we can remove them all from the boilerplate
* fix: adjust instuctions so we can remove them all from the boilerplate
2020-10-15 16:01:10 +01:00
