Commit Graph

37 Commits

Author SHA1 Message Date
Niraj Nandish
64b93dfb64 fix(challenges): broken link 2018-07-20 19:15:49 +09:00
Niraj Nandish
0c0702d6c0 fix(challenges): Typo errors (#39) 2018-06-29 23:47:58 +05:30
Guy Even
2375d0c98d fix(challenges): cherry pick pr 17664 & 17672 from main repo (#52) 2018-06-29 23:47:58 +05:30
Tom
d31e0a3a24 fix: blockquote-formatting-in-challenges (#17590) 2018-06-19 17:53:24 +05:30
Jarek Wojciechowski
68b089e95d fix(challenges): add info about ReactDOM.render in an early react challenge (#17186) (#17473) 2018-06-11 18:22:32 +05:30
manjeet5
ff8b13b316 fix(challenges): Corrected a test case for challenge (#17162)
For the last test case in 'Access Props using this.props' challenge, I
updated the test condition to check that the value of the tempPassword
prop is the same as the content within the <strong/> tags. This test
case will ensure that there is text present in the strong tag and its
value is as expected.

BREAKING CHANGE: none

Closes #17134
2018-05-30 01:47:52 +08:00
Stuart Taylor
7c694c2666 Fix/react versions (#17236)
<!-- freeCodeCamp Pull Request Template -->

<!-- IMPORTANT Please review https://github.com/freeCodeCamp/freeCodeCamp/blob/staging/CONTRIBUTING.md for detailed contributing guidelines -->
<!-- Help with PRs can be found at https://gitter.im/FreeCodeCamp/Contributors -->
<!-- Make sure that your PR is not a duplicate -->

#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply. -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [x] Your pull request targets the `staging` branch of freeCodeCamp.
- [x] Branch starts with either `fix/`, `feature/`, or `translate/` (e.g. `fix/signin-issue`)
- [ ] You have only one commit (if not, [squash](http://forum.freecodecamp.org/t/how-to-squash-multiple-commits-into-one-with-git/13231) them into one commit).
- [x] All new and existing tests pass the command `npm test`. Use `git commit --amend` to amend any fixes.

#### Type of Change
<!-- What type of change does your code introduce? After creating the PR, tick the checkboxes that apply. -->
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
- [ ] Add new translation (feature adding new translations)

#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply. -->
<!-- If you're unsure about any of these, don't hesitate to ask in the Contributors room linked above. We're here to help! -->
- [x] Tested changes locally.
- [x] Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #17215

#### Description
<!-- Describe your changes in detail -->
2018-05-25 17:27:15 +05:30
Stuart Taylor
ee66d84ccb feat(package): Initial Curriculum separation (#17174)
* feat(package): Initial Curriculum separation

* feat(package): Add org scope to package

* chore(ooops): Remove development file

* feat(npm): Add .npmignore

* fix(paths): Fix curriculum paths

* feat(build): Add a build step

* chore(seed): Move package file back to seed

* fix(ignore): Fix .npmIgnore file

* chore(docs): Update README

* chore(seed): Rename coding interview blocks

* fix(seed): Challenge files now fit into learn

* chore(seed): Update seed files for use in learn

* chore(escapes): Unescape script tags of jQuery
2018-05-21 19:26:49 +05:30
Aditya Rohilla
c212258e2d fix(seed): removed typo from task description (#17166) 2018-05-15 10:16:33 +05:30
Nicholas Nadeau, P.Eng., AVS
a8efeb50d7 chore: fixed typos via client9/misspell (#17081) 2018-04-25 10:37:27 +05:30
Chaitanya
9610c2729f Fix to tests messages (#17059)
In https://beta.freecodecamp.org/en/challenges/react/write-a-simple-counter challenge code is referring to Component Counter but messages are referring to myComponent
2018-04-17 15:02:57 -04:00
Hakeem Davis
9f5eb3b14c fix(seed): Clarify instructions (#17050)
Closes #17044
2018-04-13 09:49:01 +05:30
Edit Bazso
b208c477fc fix(seed): Fixed broken link in React Introducing Inline Styl (#17040)
* fix(seed): Fixed broken link in React Introducing Inline Styl

* fix(seed): Fixed broken link in React Introducing Inline Style
2018-04-07 22:06:11 -04:00
Varun
ad2d782c4d fix: typo in challenges/react.json (#17037) 2018-04-07 21:43:22 -04:00
Alex Chaffee
52ca2b9ad6 feat(seed): reformat seed/challenges JSON via repack script 2018-04-03 19:53:44 +05:30
Stuart Taylor
2d77dc00b6 chore(challenges): Normalise challengeTypes 2018-04-03 19:52:01 +05:30
Nguyen Quoc Bao
444aa7f939 fix(seed): Add length check for component find (#16678)
Closes #16677

fix(seed): Use triple equal
2018-02-14 17:50:38 +00:00
Jason Kao
e0aded6565 fix(seed): Removed inconsistent and unnecessary ReactDOM.rend (#16711) 2018-02-14 22:25:05 +05:30
Samuel Coe
5668502720 fix(seed): Replaced 'include' with 'match' and RegExp for the (#16700)
Closes #16698
2018-02-14 11:24:25 +00:00
Nguyen Quoc Bao
65a28d95e2 fix(seed): Add default values to incompleted declarations (#16704)
Closes #16696

fix(seed): Fix undefined render
2018-02-13 11:45:12 +00:00
Jason Kao
63069db4bf test(seed): Tests now send string values into input, not number (#16639)
Closes #16636
2018-02-08 11:36:42 +05:30
Nguyen Quoc Bao
536ef79213 fix(seed): Fix solution doesn't pass for challenge "React: Use Advanced JavaScript in React Render Method" (#16631)
Closes #16629
2018-02-08 11:23:20 +05:30
Jason Kao
d3b663338c fix(seed): Fixed disruptive, unclosed <code> tag (#16594)
Closes #16581
2018-02-06 10:18:11 +00:00
Nguyen Quoc Bao
6d566bfb9b fix(seed): Add missing bindings outside comment lines (#16585) 2018-02-05 23:18:10 -05:00
Neenad Ingole
0a225dce8f fix(seed): Change Line Number & Typo (#16586)
Line number in the problem is corrected to 52 which was previously 38
and spelling mistake of 'compponent' is changed to 'component'

Closes #16567
2018-01-28 17:37:37 +05:30
Diogo Righi
698eeb33e3 fix(challenges): Fix test on react challenge that was always passing (#16558) 2018-01-23 20:16:57 -05:00
mrugesh mohapatra
77808b0feb fix(seed): Typos in testing code (#16515)
Just formatting issues - missing quote, unescaped quotes in strings and
fixed a typo by moving code chars out of string literals.
2018-01-17 23:10:50 -05:00
Stephen Mayeux
0f73022cfd fix(seed): Eliminate regex bug for async assertions (#16341) 2018-01-16 11:25:20 +05:30
Peter Weinberg
652f943709 fix(challenges): put finishing touches on react & redux challenges 2017-12-21 00:03:42 -05:00
Berkeley Martinez
3c56044e6c Feat: react redux migration (#16200)
* feat: crudely enables test to run solution code against React challenge (and passes!)

* feat: Updates comment

* feat: Adds React 2 and 3, validates challenges in app

* feat: Adds React 4, validates tests

* feat: Adds Peter's migrated challenge seed files for all challenges

* feat: Adds redux, react-redux imports, adds tests for React 7,

* feat: Adds tests for React 08

* fix(challenges): wrap reserved words in <code> and add tests

* feat: complete first two tests for React 9

* feat: modifies tests in React 09

* feat: Adds working tests for React 37, including async setState tests

* feat: Escape hatch to avoid async tests in automated test suite

* feat: Updates React 15 with working tests

* feat: build passes, yay

* feat: Provisions original code string in challenges and adds tests for React Redux 01

* fix(tests): add self-closing tags challenge, other small fixes

* fix(challenge): add react_10, some other stuff

* fix(challenges): update react 22, add react 23

* fix(challenges): react 5 and react 8

* feat: removes dependencies that will break in browser, will replace later

* feat: fix build

* feat: add redux 1

* fix(challenge): add react 24 tests

* feat: partial implemented Redux 2

* feat: migrate redux 3

* feat: Adds React-Redux 04 with working tests under npm test

* feat: Updates automated test runner, just provide all the dependencies. Adds Redux-Thunk.

* feat: Adds working tests for React Redux 07

* feat: redux challenge 4

* feat: migrate redux 5

* feat: redux 6

* feat: migrate Redux test 7

* fix(challenge): add react 25 tests

* feat: Adds tests for React 48, npm test does not pass...

* feat: Migrate Redux test 8

* fix(challenges): skip 26, add react 27 tests

* fix(challenges): add react 28 tests, replace function w/ => throughout, fix linter warnings

* feat: fixes (patches) hard to understand problem with automated test suite

* feat: updates async tests patch

* feat: adds converted tests for React 47

* feat: adds converted tests for React 46

* feat: Partially adds tests for React 43

* docs: adds TO-DO tests for React 43

* feat: migrates tests for React 42

* feat: migrates tests for React 41

* feat: migrates tests for React 39

* feat: Migrates tests for React 38, automated test script fails again!

* feat: migrates tests for React 32

* feat: QAs more React Redux challenge in FCC UI

* feat: Updates tests for React 7

* feat: Migrates React-Redux 3 tests and hardcodes deep-freeze dependency

* feat: migrates React Redux 05 tests

* feat: migrates React Redux 06 tests

* feat: Migrates React Redux 10

* feat: Migrates tests for React 16

* feat: Migrates React 17 tests

* feat: Migrates React 18 tests

* feat: Migrates React 19 tests

* feat: Migrates React 19 tests

* feat: fixing usage of code, replace with editor.getOriginalCode

* feat: Migrates React 21 tests

* feat: Finishes migration of React 09

* fix(challenges): add react 45 tests 💀

* feat: Adds React 11 tests

* feat: Migrates React 50 tests

* feat: Re-enables original code in FCC editor, QAs challenges blocked by original code

* feat: hacks head tail code in editor test environment

* feat: updates React 20 head code

* feat: QAs React Redux 07 in UI

* fix(challenges): add React 29 tests

* fix(challenges): add React 30 tests

* feat: updates async tests

* feat: Migrates React 12, gets ReactDOM challenges working and QAs them

* feat: Migrates React 13 tests

* feat: Migrates tests for React 14 and updates challenge description formatting

* feat: Refactors 2nd test for Redux 02

* feat: Migrates React 33

* feat: Removes React 26 and 43

* feat: Adds React 34 from Kevin

* fix(challenges): add React 31 & 35 tests (thanks Kevin)

* feat: Migrate Redux challenge 10 - pass both UI QA and terminal test

* fix(challenge): add react 40 tests

* feat: Migrates React Redux 02 tests

* feat: Migrates React Redux 08 and fixes async syntax in React challenge

* fix(challenge): add react 49 tests with caveat

* feat: fixes React 49 tests and adds first tests for React Redux 09

* feat: Migrate Redux 11 - pass both terminal test and UI test

* feat: Migrate Redux 12 - passing both UI test and terminal test

* feat: Migrate Redux 13 - passing both terminal and UI tests

* feat: Adding in code tags for previous redux challenges - terminal and UI tests pass

* feat: Migrates React Redux 09 and React 44 (thanks Kevin)

* feat: fix code tag issues - passed UI and terminal tests

* feat: Migrates Redux 14 tests

* feat: Migrates Redux 14

* feat: Migrates Redux 15

* feat: Migrates Redux 17

* feat: Final migration and QA of Redux, except for Redux 9

* feat: migrates React 36 and QAs

* feat: Rewrites Redux 09 and migrates

* feat: refactors pull request and cleans up code

* style(challenges): QA React challenges

* style(challenges): QA react challenges

* fix(challenges): fix react 41 and 45 tests

* style(challenges): QA redux challenges

* style(challenges): QA react and redux challenges

* fix(seed/react): Move head/tail to files

* fix(seed/redux): Move head/tail to file level

* chore(packages): Move jsdom to dev deps

* fix(seed/react/redux): Async funcs

make async func defined

* fix(seed): %s/editor.getUserCode/getUserInput/gc

* fix(Challenges/build): Make sure head/tail is bundled and transformed

* feat(Challenges.react): Add tail to render component

* chore(seed): Disable modern challenge testing for now

We will put these on beta while we update the auto testing framework
2017-12-18 15:04:03 -06:00
Berkeley Martinez
2f34e67331 Fix(Challenges): get user code (#16187)
* fix(Challenges.): Prevent source from being overwritten

* fix(Challenges): Tests should use name

* fix(seed/react): Namespace tests for now
2017-12-13 17:24:36 -06:00
Berkeley Martinez
b4084f94ff feat: react challenges (#16099)
* chore(packages): Update redux utils

* feat(Panes): Invert control of panes map creation

* feat(Modern): Add view

* feat(Panes): Decouple panes from Challenges

* fix(Challenges): Decouple challenge views from panes map

* fix(Challenge/views): PanesMap => mapStateToPanesMap

This clarifies what these functions are doing

* fix(Challenges): Add view type

* fix(Panes): Remove unneeded panes container

* feat(Panes): Invert control of pane content render

This decouples the Panes from the content they render, allowing for
greater flexibility.

* feat(Modern): Add side panel

This is common between modern and classic

* feat(seed): Array to string file content

* fix(files): Modern files should be polyvinyls

* feat(Modern): Create editors per file

* fix(seed/React): Incorrect keyfile name

* feat(Modern): Highligh jsx correctly

This adds highlighting for jsx. Unfortunately, this disables linting for
non-javascript files as jshint will only work for those

* feat(rechallenge): Add jsx ext to babel transformer

* feat(seed): Normalize challenge files head/tail/content

* refactor(rechallenge/build): Rename function

* fix(code-storage): Pull in files from localStorage

* feat(Modern/React): Add Enzyme to test runner

This enables testing of React challenges

* feat(Modern): Add submission type

* refactor(Panes): Rename panes map update action
2017-11-29 17:44:51 -06:00
Berkeley Martinez
f00449a066 feat: prep for modern challenges (#15781)
* feat(seed): Add modern challenge

* chore(react): Use prop-types package

* feat: Initial refactor to redux-first-router

BREAKING CHANGE: Everything is different!

* feat: First rendering

* feat(routes): Challenges view render but failing

* fix(Challenges): Remove contain HOC

* fix(RFR): Add params selector

* fix(RFR): :en should be :lang

* fix: Update berks utils for redux

* fix(Map): Challenge link to arg

* fix(Map): Add trailing slash to map page

* fix(RFR): Use FCC Link

Use fcc Link to get around issue of lang being undefined

* fix(Router): Link to is required

* fix(app): Rely on RFR state for app lang

* chore(RFR): Remove unused RFR Link

* fix(RFR): Hydrate initial challenge using RFR and RO

* fix: Casing issue

* fix(RFR): Undefined links

* fix(RFR): Use onRoute<name> convention for route types

* feat(server/react): Add helpful redux logging/throwing

* fix(server/react): Strip out nonjson from state

This prevents thunks in routesMap from breaking serialization

* fix(RFR/Link): Should accept any renderable

* fix(RFR): Get redirects working

* fix(RFR): Redirects and not found's

* fix(Map): Move challenge onClick handler

* fix(Map): Allow Router.link to handle clicks after onClick

* fix(routes): Remove react-router-redux

* feat(Router): Add lang to all route actions by default

* fix(entities): Only fetch challenge if not already loaded

* fix(Files): Move files to own feature

* chore(Challenges): Remove vestigial hints logic

* fix(RFR): Update challenges on route challenges

* fix(code-storage): Should use events instead of commands

* fix(Map): ClickOnMap should not hold on to event

* chore(lint): Use eslint-config-freecodecamp

Closes #15938

* feat(Panes): Update panes on route instead of render

* fix(Panes): Store panesmap and update on fetchchallenges

* fix(Panes): Normalize panesmaps

* fix(Panes): Remove filter from createpanemap

* fix(Panes): Middleware on location meta object

* feat(Panes): Filter preview on nonhtml challenges

* build(babel): Add lodash babel plugin

* chore(lint): Lint js files

* fix(server/user-stats): Remove use of lodash chain

this interferes with babel-plugin-lodash

* feat(dev): Add remote redux devtools for ssr

* fix(Panes): Dispatch mount action

this is needed to trigger window/divider epics

* fix(Panes): Getpane to use new panesmap format

* fix(Panes): Always update panes after state

this lets the panes logic be affected by changes in state
2017-11-09 19:10:30 -06:00
Donnie Reese
c1ab6dac98 Fixed a minor formatting issue in the React challenges. 2017-02-27 15:46:03 -06:00
Quincy Larson
2709eb6b3a add releasedOn dates to all new challenges (#13417) 2017-02-19 00:00:12 +05:30
Peter Weinberg
512506fa33 chore(seed): freeCodeCampify remaining sections of codebase 2017-02-02 18:29:59 -05:00
Quincy Larson
6f9fab3043 add new challenges 2017-01-19 15:25:07 -08:00