Commit Graph

16274 Commits

Author SHA1 Message Date
d1993ea4b6 Filter functions almost ready.
Our pretty bar changes visual state of the filtered elements, clears with the X, restores hidden elements when deleting characters. Etc.

For the future: if a chapterBlock is collapsed but has results, expand it. No?
Also, hopefully getting fontawesome to the latest version... Regardless of that, this is a great opportunity for a legendary 404.

Expansion of containers achieved

Still working on collapsing them back when search terms change.
If users had just pressed "collapse all" before the search, they should remain thus afterwards.

The UX focus here is not to change the users' expected behaviour and final result.

Future: updating font awesome.
Working on a legendary "not found" image to make FCC join the internet hall of fame.
(btw, where would I keep that file in the server?)
2016-01-31 19:29:32 -08:00
d100e53b50 Merge pull request #6601 from SaintPeter/feature/challenge-checksum
Add Checksum to Challenges for Google Analytics
2016-01-31 17:36:16 -08:00
c7fc9dc99f Merge pull request #6601 from SaintPeter/feature/challenge-checksum
Add Checksum to Challenges for Google Analytics
2016-01-31 17:36:16 -08:00
3e989de2a3 Fix isCheater/isLocked not blocking certs 2016-01-31 16:35:15 -08:00
fa18734a59 Add Live Filter to Map - partial 2016-01-31 14:42:35 -08:00
d049d7b646 Merge pull request #6592 from SaintPeter/fix/remove-filter-adjust-spacing
Fix/Remove Filter and Adjust Map Spacing and Coloring
2016-01-31 14:34:47 -08:00
806b196d5e improve map spacing 2016-01-31 14:11:59 -08:00
08d170aa08 Merge pull request #6622 from erictleung/fix/clarify-escape-literal-quote-instructions
Clarify escape literal quotes instructions
2016-01-31 10:38:14 -08:00
cbcdb8df4f Clarify escape literal quotes instructions
- Change example quote to valid JavaScript
- Add example of what you will get if you print said example quote
- Place emphasis on "if" in the instructions so that it'll hopefully be clear
  you do not actually need to print it
2016-01-31 01:39:47 -08:00
b4e35cb535 Clarify escape literal quotes instructions
- Change example quote to valid JavaScript
- Add example of what you will get if you print said example quote
- Place emphasis on "if" in the instructions so that it'll hopefully be clear
  you do not actually need to print it
2016-01-31 01:39:47 -08:00
ddcd37237c Merge pull request #6621 from raisedadead/fix/roman-numerals-add-test-case
Add additional test cases to Roman Numeral
2016-01-31 18:44:36 +11:00
a1d5bcce5e Add additional test cases to Roman Numeral
This commit adds additional test case to the Roman Numeral challenge.

It was possible to pass the tests with incorrect code, as seen in the
issue discussion.

Tested locally.

closes #6616
2016-01-31 11:53:52 +05:30
a9be8f9990 Add additional test cases to Roman Numeral
This commit adds additional test case to the Roman Numeral challenge.

It was possible to pass the tests with incorrect code, as seen in the
issue discussion.

Tested locally.

closes #6616
2016-01-31 11:53:52 +05:30
34ec40d298 chore(package): update react-motion to version 0.4.2
http://greenkeeper.io/
2016-01-30 20:30:12 -08:00
76c75b8e48 Merge pull request #6333 from LenaBarinova/fix/streak-seems-broken-because-of-timezone
Fixed streak and completion dates to be showed using users timezone
2016-01-30 11:47:38 -08:00
ee2b7e5ef9 Merge pull request #6581 from raisedadead/fix/comparison-with-the-greater-than-or-equal-to-operator
Fix the test case for Comparison with operators
2016-01-30 11:35:53 -08:00
29e50b4bc5 Merge pull request #6581 from raisedadead/fix/comparison-with-the-greater-than-or-equal-to-operator
Fix the test case for Comparison with operators
2016-01-30 11:35:53 -08:00
6292867132 Merge pull request #6583 from raisedadead/fix/undefined-is-not-explained
Add a hint to Return Early Pattern for Functions
2016-01-30 11:32:07 -08:00
3e6b2f34f5 Merge pull request #6583 from raisedadead/fix/undefined-is-not-explained
Add a hint to Return Early Pattern for Functions
2016-01-30 11:32:07 -08:00
ab2a4d8f6f [HOTFIX] remove twit
twit is not depending on it's dependencies.
2016-01-30 10:53:52 -08:00
317d8ea9ba Add Checksum to Challenges for Google Analytics 2016-01-30 09:02:22 -08:00
f2e61ea0ac Add Checksum to Challenges for Google Analytics 2016-01-30 09:02:22 -08:00
18e8df53b9 Temporarily remove the 'popup' feature 2016-01-30 11:55:07 +04:00
1b6ae0b462 Change the label text from "View my solution" to "View Solution"
This commit changes the text of the label from "View my solution" to
"View solution".

As disscussed in the issue, campers visiting profile pages of others,
saw "View my solution" and found this confusing.

Removing the "my" from the text makes it generic, to either user's own
page or other's pages.

Tested locally.
2016-01-30 13:13:22 +05:30
3c83f25de9 Merge pull request #6579 from FreeCodeCamp/greenkeeper-lodash-4.1.0
Update lodash to version 4.1.0 🚀
2016-01-29 23:02:24 -08:00
6761aa4aef Fix the test case for Comparison with operators
This commit fixes the test case with change to assert in one case,
and change to the test case message in another case.

I intentionally, changed the assert for one case and message for other

Tested locally.
2016-01-30 11:45:40 +05:30
42ec641645 Fix the test case for Comparison with operators
This commit fixes the test case with change to assert in one case,
and change to the test case message in another case.

I intentionally, changed the assert for one case and message for other

Tested locally.
2016-01-30 11:45:40 +05:30
6af0f0f448 Add a hint to Return Early Pattern for Functions
This commit adds a hint as disccussed in the issue, to clarify,
the difference between `undefined` and `"undefined"`.

Tested locally.
2016-01-30 11:34:11 +05:30
a3c9d1fce6 Add a hint to Return Early Pattern for Functions
This commit adds a hint as disccussed in the issue, to clarify,
the difference between `undefined` and `"undefined"`.

Tested locally.
2016-01-30 11:34:11 +05:30
d5cb8b3ff6 Merge pull request #6594 from hallaathrad/fix/typos-and-style
Fix for "Multiple Identical Options in Switch Statements"
2016-01-29 20:09:01 -08:00
7726989f9a Fix for "Multiple Identical Options in Switch Statements"
Corrects typo "ommitted".
Closes #6593
2016-01-29 22:58:29 -05:00
a04fa02d7c Fix for "Multiple Identical Options in Switch Statements"
Corrects typo "ommitted".
Closes #6593
2016-01-29 22:58:29 -05:00
81f9b92bed Adjust spaces and sizes on sidebar
Addressing the changes discussed over skype to fix #6564, and an incoming issue with #6584 in which the absence of the button will create awkward empty spaces.
Took that chance to improve the spacing even further —vertical real state.

----

bonus: changed the colour for the navbar hover status (brown -> darkgreen)
2016-01-29 18:29:26 -08:00
c62b7abf8f Remove the filter button and collapse completed blocks by default 2016-01-29 18:29:26 -08:00
39b8ee0c97 Merge pull request #6567 from raisedadead/fix/introducing-javascript-object-notation-json
Fix the release year for Billy Joel - Piano Man
2016-01-29 09:26:52 -08:00
317b27b614 Merge pull request #6567 from raisedadead/fix/introducing-javascript-object-notation-json
Fix the release year for Billy Joel - Piano Man
2016-01-29 09:26:52 -08:00
89dd705921 Merge pull request #6574 from raisedadead/fix/comparisons-with-the-logical-and-operator
Fix test case in Comparisons with the Logical And Operator
2016-01-29 09:25:04 -08:00
082f2ce87c chore(package): update lodash to version 4.1.0
http://greenkeeper.io/
2016-01-29 08:41:45 -08:00
2376c545ec Fix test case in Comparisons with the Logical And Operator
This fixes the test case to do the correct assert as per the message.

tested locally.
2016-01-29 13:55:59 +00:00
cee3b691ef Fix test case in Comparisons with the Logical And Operator
This fixes the test case to do the correct assert as per the message.

tested locally.
2016-01-29 13:55:59 +00:00
74528cc98b Fix the release year for Billy Joel - Piano Man
This fixes the release year as mentioned in the issue.
Hope the fans will forgive us!

Tested locally.
closes #6561
2016-01-29 07:42:48 +00:00
6094a9da12 Fix the release year for Billy Joel - Piano Man
This fixes the release year as mentioned in the issue.
Hope the fans will forgive us!

Tested locally.
closes #6561
2016-01-29 07:42:48 +00:00
dac587cb67 Restore Prior Spanish Translations to basic-javascript.json
Tested Locally

Please review, @vtamara
2016-01-28 20:07:34 -08:00
6af6091793 Restore Prior Spanish Translations to basic-javascript.json
Tested Locally

Please review, @vtamara
2016-01-28 20:07:34 -08:00
369288cdd5 Merge pull request #6549 from robjloranger/fix/set-font-size-of-element
Fix for set the font size of an element
2016-01-28 18:47:37 -08:00
ba78a4988a Merge pull request #6549 from robjloranger/fix/set-font-size-of-element
Fix for set the font size of an element
2016-01-28 18:47:37 -08:00
93dfc42e04 Merge pull request #6403 from hallaathrad/change/center-map-layout
Centre map layout, colour enhancement for UX
2016-01-28 17:06:47 -08:00
64efbd36a2 Merge pull request #6548 from hallaathrad/change/about-page
Change space in population table
2016-01-28 17:04:59 -08:00
5ea9eb2d9e Merge pull request #6348 from bugron/feature/last-signin-method
Highlight last signin method's button
2016-01-28 13:47:27 -08:00
838314be23 Merge pull request #6555 from robjloranger/fix/typo-validate-telephone
fixed typo on test for 1 555)555-5555
2016-01-28 13:45:58 -08:00