gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
8,239 Commits 9 Branches 0 Tags
6c06cde9faa598f15226281d4764d7c332b2cf5f
Commit Graph

679 Commits

Author SHA1 Message Date
Berkeley Martinez
9cc8c11f31 Merge pull request #6550 from QuincyLarson/fix/sample-watermark-certs 
update sample certificate images and fix a couple other onboarding as…
 2016-01-31 23:13:05 -08:00
Eric Leung
b4e35cb535 Clarify escape literal quotes instructions 
- Change example quote to valid JavaScript
- Add example of what you will get if you print said example quote
- Place emphasis on "if" in the instructions so that it'll hopefully be clear
  you do not actually need to print it
 2016-01-31 01:39:47 -08:00
Mrugesh Mohapatra
a9be8f9990 Add additional test cases to Roman Numeral 
This commit adds additional test case to the Roman Numeral challenge.

It was possible to pass the tests with incorrect code, as seen in the
issue discussion.

Tested locally.

closes #6616
 2016-01-31 11:53:52 +05:30
Rex Schrader
29e50b4bc5 Merge pull request #6581 from raisedadead/fix/comparison-with-the-greater-than-or-equal-to-operator 
Fix the test case for Comparison with operators
 2016-01-30 11:35:53 -08:00
Rex Schrader
3e6b2f34f5 Merge pull request #6583 from raisedadead/fix/undefined-is-not-explained 
Add a hint to Return Early Pattern for Functions
 2016-01-30 11:32:07 -08:00
Mrugesh Mohapatra
42ec641645 Fix the test case for Comparison with operators 
This commit fixes the test case with change to assert in one case,
and change to the test case message in another case.

I intentionally, changed the assert for one case and message for other

Tested locally.
 2016-01-30 11:45:40 +05:30
Mrugesh Mohapatra
a3c9d1fce6 Add a hint to Return Early Pattern for Functions 
This commit adds a hint as disccussed in the issue, to clarify,
the difference between `undefined` and `"undefined"`.

Tested locally.
 2016-01-30 11:34:11 +05:30
Hallaathrad
a04fa02d7c Fix for "Multiple Identical Options in Switch Statements" 
Corrects typo "ommitted".
Closes #6593
 2016-01-29 22:58:29 -05:00
Rex Schrader
317b27b614 Merge pull request #6567 from raisedadead/fix/introducing-javascript-object-notation-json 
Fix the release year for Billy Joel - Piano Man
 2016-01-29 09:26:52 -08:00
Mrugesh Mohapatra
cee3b691ef Fix test case in Comparisons with the Logical And Operator 
This fixes the test case to do the correct assert as per the message.

tested locally.
 2016-01-29 13:55:59 +00:00
Mrugesh Mohapatra
6094a9da12 Fix the release year for Billy Joel - Piano Man 
This fixes the release year as mentioned in the issue.
Hope the fans will forgive us!

Tested locally.
closes #6561
 2016-01-29 07:42:48 +00:00
SaintPeter
6af6091793 Restore Prior Spanish Translations to basic-javascript.json 
Tested Locally

Please review, @vtamara
 2016-01-28 20:07:34 -08:00
Rex Schrader
369288cdd5 Merge pull request #6549 from robjloranger/fix/set-font-size-of-element 
Fix for set the font size of an element
 2016-01-28 18:47:37 -08:00
robjloranger
3fe6ba79b4 fixed typo on test 1 555)555-5555 2016-01-28 12:25:34 -08:00
Rex Schrader
6be38c5330 Merge pull request #6536 from AkiraLaine/edit/remove-terminology 
removed depreciated terminology from certificate challenges
 2016-01-28 10:59:17 -08:00
Rex Schrader
a006e48738 Merge pull request #6529 from robjloranger/fix/all-greaterthan-quotes 
Fix for greater than + less than quotes
 2016-01-28 10:20:48 -08:00
Rex Schrader
bb6dc470a9 Merge pull request #6535 from alistermada/fix/test-comparison-equality-operator 
Fix test for Comparison with the Equality Operator
 2016-01-28 10:16:42 -08:00
robjloranger
95347d9c95 this fixes false positives and clears up instructions 
trying out similar test to change the font family of an element

tried to better clarify instructions
 2016-01-28 09:44:52 -08:00
Quincy Larson
696fdde9f2 update sample certificate images and fix a couple other onboarding assets to jive with new color scheme 2016-01-28 09:34:59 -08:00
Akira Laine
9f9c8c3f58 removed depreciated terminology from certificate challenges 
made some edits

corrected backend certificate text
 2016-01-28 19:10:33 +11:00
Alister N. Mada
85637d0ba7 Fix test for Comparison with the Equality Operator 2016-01-28 11:15:52 +07:00
robjloranger
81d514a8ca fixing regex asserts 
Changed all regex test to accept option single/double quotes around digits in comparrisons.
Used ('|\")*

Mistakenly had strict comparisons changed, reverted those.

fixed typo

one last typo

how did i miss so many errors

last error i hope

..last .. one ..
 2016-01-28 03:15:13 +00:00
Timothy Cyrus
ee23a7b470 Update json-apis-and-ajax.json 
Replace Multiple Line's of `<code>` blocks with `<blockquote>` to improve formatting
 2016-01-27 21:58:56 -05:00
Berkeley Martinez
ff72a57352 [HOTFIX] Fix step index type 2016-01-27 12:13:46 -08:00
Rex Schrader
a890c1de07 Merge pull request #6467 from tahmid-ul/fix/improve-assignment-with-a-returned-value 
Assignment with a Returned Value - Improved Challenge Seed
 2016-01-27 10:58:27 -08:00
Rex Schrader
95995b4731 Merge pull request #6455 from alistermada/fix/more-tests-basic-javascript 
Add more tests for Basic JavaScript challenges
 2016-01-27 10:55:59 -08:00
Tim Hordern
d895053a70 Adds spaces in CSS selectors for a consistent style 2016-01-26 23:22:21 -05:00
Logan Tegman
e5e45815d8 Merge pull request #6303 from dooglus/fix/allow_2_lorem_ipsum_words 
Fix validation for "Fill in the Blank with Placeholder Text"
 2016-01-26 19:54:44 -08:00
Tahmid ul karim
a5096f9523 Improved Challenge Seed 
Assignment with a Returned Value .
 2016-01-26 21:36:55 +06:00
Eric Leung
aaba9283ac Adds spaces between paragraphs 
Tested locally. Closes #6374
 2016-01-26 07:36:55 -08:00
Alister N. Mada
e5aff5d451 Remove extra spaces from Basic Javascript challenge description 2016-01-26 17:24:21 +07:00
Alister N. Mada
a707a77af9 Add more tests for Basic JavaScript challenges 2016-01-26 16:37:26 +07:00
Jason Jiang
f3cefa71aa Correct the array description of Chunky Monkey 
The array required from the Chunky Monkey challenge is two-dimensional, not multidimensional.
The change has been made in both English and Spanish.
 2016-01-26 15:28:53 +13:00
Rex Schrader
cfb151ef49 Merge pull request #6445 from alistermada/fix/css-add-test-class-selector 
Adds test for class selector in Prioritize One Style Over Another
 2016-01-25 18:09:24 -08:00
Alister N. Mada
56719dfedc Adds test for class selector in Prioritize One Style Over Another 2016-01-26 08:27:17 +07:00
Alister N. Mada
803c04d45c Add more test cases for Make Object Properties Private 2016-01-26 06:31:30 +07:00
Rex Schrader
ee0feee70f Merge pull request #6437 from raisedadead/fix/change-instruction-accesing-nested-objects-in-json 
Fix the instruction text in the Accessing Nested objects challenge
 2016-01-25 11:53:24 -08:00
Rex Schrader
6135350f39 Merge pull request #6439 from alistermada/fix/html-css-tests 
Fixes HMTL tests that don't accept classes in different order
 2016-01-25 11:07:21 -08:00
Rex Schrader
449a20252b Merge pull request #6438 from Endi1/fix/class-issue-#6426 
Fixes CSS test that didn't accept spaces between `color` and `:`
 2016-01-25 10:58:20 -08:00
Tahmid ul karim
4c00a60331 Removed double quotes 
closes #5825
 2016-01-25 21:19:59 +06:00
Alister N. Mada
089b2d6c6b Fix HTML tests that don't accept classes in different order 2016-01-25 19:46:40 +07:00
Endi Sukaj
d854db3780 Fix for issue #6426 
This is a fix for #6426
 2016-01-25 13:25:12 +01:00
Mrugesh Mohapatra
02cff5f6ab Fix the instruction text in the Accessing Nested objects challenge 
This commit fixes the instruction text in the challenge to
`Use bracket notation for properties with a space in their name.`
from
`Only use object notation for properties with a space in their name.`
I have removed the extra `Only` on purpose for sake of grammar.

closes #6422
 2016-01-25 12:13:50 +00:00
Arsen Melikyan
1185447c12 Merge pull request #6415 from erictleung/fix/extra-spacing-in-editor 
Remove unnecessary spaces in the editor
 2016-01-25 11:11:25 +04:00
Arsen Melikyan
588bc3ecd6 Merge pull request #6417 from erictleung/fix/add-open-new-tab-in-links 
Added "target='_blank'" to links missing them
 2016-01-25 11:09:56 +04:00
Eric Leung
05c0322a19 Added "target='_blank'" to links missing them 2016-01-24 12:46:30 -08:00
Eric Leung
cdc3f52b0c Remove extra word of 'use' in range challenge 2016-01-24 12:24:41 -08:00
Eric Leung
211ef7fec3 Remove unnecessary spaces in the editor 2016-01-24 12:19:26 -08:00
Rex Schrader
17bdbd39ca Merge pull request #6407 from robjloranger/font-family 
Fix for false positive on paragraph elements font-family
 2016-01-24 09:05:41 -08:00
robjloranger
4371c8075f -fixed typo 
started new branch as last one was a mess.
this fix removes the false positive assert test mentioned in bug #6286
 2016-01-24 08:37:13 -08:00