Commit Graph

105 Commits

Author SHA1 Message Date
f334734e98 feat: split JS challenge into two ()
* feat: split JS challenge into two

* fix/change-to-not-use-untaught-assignments

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2020-08-31 19:44:56 +01:00
20d397f719 remove MDN links from English challenges ()
* remove MDN links from English challenges

* add push challenge reference to record-collection

* refactor truthy falsy verbiage

* replace MDN link with news link

* remove unnecessary whitespace
2020-07-31 15:19:49 +09:00
35f24c6085 Fix text inconsistency ()
* Fix text inconsistency

To match the eight ECMAScript Language Types on the previous paragraph.

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2020-07-09 16:18:11 +02:00
2aee480c46 Remove example code from challenge seed ()
Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2020-06-22 16:13:21 +05:30
62dcb1f3fa fix(curriculum): remove whitespace typo () 2020-06-05 16:08:38 +02:00
95371f92b3 fix(learn): clarify formatting requirements for multiple ternary operators challenge ()
* fix(learn): clarify formatting requirements for multiple ternary operators challenge

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-06-03 18:33:03 +02:00
87ef15befa Fixes a broken link to 'undefined is a keyword' ()
Fixes a broken link to 'undefined is a keyword' by replacing the wrong link with the correct one.
2020-06-02 16:22:59 +09:00
a6c2b5ee1d fix(curriculum) remove unnecessary */ from description () 2020-05-31 10:49:10 -05:00
5cd850f666 Update wording of what multiplyAll should do in "Nesting For Loops" () 2020-05-31 08:16:00 -05:00
2e819b2e0a fix(curriculum): update instructions ()
* fix(learn): update instructions

edited text - change "returns a random number" to "returns a random whole number" to be more clear on the problem statement.

Address review comments : add the keyword "whole" to description, to make it consistent with challenge title and Instructions.
2020-05-29 10:56:17 +02:00
3c3ceaa3f5 Update declare-javascript-variables.english.md () 2020-05-27 09:37:34 +02:00
f1c9b08cf3 fix(curriculum): add isHidden: false to challenges
This includes certificates (where it does nothing), but does not
include any translations.
2020-05-25 16:25:19 +05:30
b017ce192c fix: dotall flag not supported in firefox ()
Addresses https://github.com/freeCodeCamp/freeCodeCamp/pull/38546#issuecomment-625611675 where it's pointed out that Firefox doesn't support the /s regex flag yet. This workaround matches anything that's not blank.
2020-05-08 19:27:32 +02:00
f757840624 fix(learn): add test to return early pattern ()
* add: test to return early pattern

Currently no test for a = 0 or b = 0. This results in if(a<=0 || b<= 0) also being a valid solution

* fix: typo in test text

* fix: update return early pattern test

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-05-07 14:37:48 -05:00
1f2b66a432 feat: edit 2nd test description for clarity ()
current description logically fits, yet fails this solution: myVar = ++myVar;
2020-05-02 08:27:52 -05:00
fd85f57376 fix(learn): fixed typo "in the left" should be "at the left" ()
* Fixed typo "in the left" should be "at the left"

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/comparison-with-the-equality-operator.english.md

Co-Authored-By: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-05-02 08:17:11 -05:00
7035516483 fix: typo in 'Build JavaScript Objects' () 2020-04-30 17:41:55 +05:30
f2f5dbc4b8 fix(curriculum): improve declaration tests () 2020-04-29 16:39:48 +05:30
756f33775e fix(learn): update video challenge ()
* fix(learn): update video challenge

* fix: update scrimba URL

Co-authored-by: Mrugesh Mohapatra <me@raisedadead.com>
2020-04-18 16:16:31 +05:30
a5818506f0 fix(curriculum): remove setup code not needed anymore from Testing Objects for Properties challenge ()
* fix: remove setup code

* fix: remove call to function
2020-03-28 02:25:04 +12:00
1fdb691996 fix(learn): updated tests and deleted old sample code () 2020-03-26 23:12:18 +05:30
e0e6334628 fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 3 of 4 ()
* fix: remove example code from challenge seed

* fix: remove declaration from solution

* fix: added sum variable back in

* fix: reverted description back to original version

* fix: added examples to description section

* fix: added complete sentence

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: corrected typo

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* fix: reverted to original desc with formatted code

* fix: removed unnecessary code example from description section

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: failiing test on iterate through array with for loop

* fix: changed to Only change this line

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Manish Giri <manish.giri.me@gmail.com>
Co-authored-by: moT01 <tmondloch01@gmail.com>
2020-03-25 16:07:13 +01:00
8b0cbd6f83 Modify tests for testing objects for properties challenge ()
* Stronger test cases for testing objects for properties

Change function signature to take in a custom object to be tested

* YML formatting mistake

* Yaml no space in string

* Small one more fix - most likely final

* REmove double space in return

* Update instruction Section
2020-03-24 22:09:57 -07:00
4ef78f7f7d Update use-recursion-to-create-a-countdown.english.md () 2020-03-13 16:05:59 +01:00
9252f96566 fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 4 of 4 ()
* fix: consolidate comments


Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2020-03-08 15:46:28 +01:00
Tom
17a55c6e18 fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 1 of 4 ()
* fix: consolidate/remove comments

* fix: remove => from comment

* fix: reverted changes to add same changes to another PR

* fix: removed 'the' from sentence

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: removed 'the' from the sentence

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-03-04 13:08:54 -06:00
6a7a7e6d7d fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 2 of 4 () 2020-03-03 10:18:30 +03:00
2d7b1255cc fix: add missing .english extensions () 2020-02-28 07:19:22 -08:00
b49b9f3e3c Typo whitespace fix in access-multi-dimensional-arrays-with-indexes.english.md ()
* Update access-multi-dimensional-arrays-with-indexes.english.md

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-02-24 17:02:53 +01:00
b0f1fa4b96 fix: make recursion challenge more intuitive () 2020-02-20 21:36:33 +05:30
fda7fb174e fix: Correct paths in English exercises by prefixing "/" before "learn" ()
* fix: Correct paths in English exercises by prefixing "/" before "learn"

* fix(lang): Correct paths to exercises by prefixing "/" before "learn" in remaining languages
2020-01-26 12:51:21 -06:00
d07c85151b Fix typo (remove duplicate word 'should') () 2019-12-31 08:50:46 -08:00
203c9823e8 Fixed minor grammar issue in escape-sequences-in-strings.english.md ()
* Update escape-sequences-in-strings.english.md

Fixed minor grammar issue in list item 1 of the description section.

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/escape-sequences-in-strings.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-12-16 06:16:16 -08:00
cb3524ee31 fix: simplify challenge testString () 2019-12-07 15:47:08 -05:00
623c08cbfa fix: removed semi-colon from regex () 2019-12-07 15:02:42 -05:00
dd2fb28ee0 fix: make tests more robust () 2019-12-02 18:42:32 -05:00
7454719334 fix(curriculum): Improved Use Recursion to Create a Countdown challenge ()
* fix: improved recursive challenge

* fix: rewording of two challenges

* fix: add code tags

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-12-02 17:58:07 +01:00
c331b12413 fix(curriculum): correct typo in nest one array within another array challenge instruction () 2019-11-29 10:07:51 +01:00
2c15bcbb43 fix(curriculum): changed test text to use should for JavaScript Algorithms and Data Structures ()
* fix: corrected typo

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-27 11:57:38 +01:00
fc1a923dd5 Made description of logical operator under "or operator" challenge a little more intuitive. ()
* Update comparisons-with-the-logical-or-operator.english.md

* Update comparisons-with-the-logical-or-operator.english.md

* Update comparisons-with-the-logical-or-operator.english.md
2019-11-16 21:30:52 -05:00
c4dc0b297f Switch statement example updated ()
* Switch statement example updated

* Update switch-statements.english.md example

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update switch-statements.english.md example

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-11-14 12:07:08 -08:00
2c5453e3bd Clarify instructions ()
Closes 
2019-11-11 16:48:51 +01:00
f3ee4f85ae Changes to "access-array-data-with-indexes.english" challenge description ()
* edited description to be a little more clear on how to access elements in an array through indeces

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/access-array-data-with-indexes.english.md

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-10 15:53:05 -05:00
3119da3ec5 Changes to "Iterate with JavaScript While Loops - English" challenge description ()
* Update iterate-with-javascript-while-loops.english.md

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-with-javascript-while-loops.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-11-06 13:26:44 -05:00
a52b5b4ebb feat: rewrite Iterate with JavaScript While Loops challenge ()
* feat: rewrite Iterate with JavaScript While Loops challenge

Previous example in the challenge description was the exact code
that challenge instructions say to implement. Change the challenge to
differentiate from the example.

resolve 

* fix: update iterate with javascript while loops solution

* refactor: improve iterate with js while loops challenge wording

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-11-06 12:51:59 -05:00
28575e9877 Add updated Scrimba link to Word Blank challenge () 2019-10-31 11:37:26 -05:00
bfa5c26288 fix: use dfn instead of code tag ()
* Use dfn tags

* remove misused <dfn> tags

* Revert "remove misused <dfn> tags"

This reverts commit b24968a968.

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/fill-in-the-blank-with-placeholder-text.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Make "array" lowercase

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Fix dfn usage

* Address last dfn tags
2019-10-27 12:45:37 -04:00
b59f72961f Fix Typo () 2019-10-26 16:48:06 -04:00
dd8168133f Added escape characters to the javascript comment curriculum () 2019-10-25 13:41:42 -05:00
Tom
69d4d4fe2f fix: recursion test ()
* fix(challenge): recursion test

* fix(challenge): replace regex s flag with g
2019-10-23 00:18:40 +05:30