Commit Graph

2147 Commits

Author SHA1 Message Date
Oliver Eyton-Williams
7c4e0ec41e refactor: abstract out walk in getChallenges 2021-01-31 12:15:33 +05:30
Tom
3978c6be28 feat: i18n user interface (#40306)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-01-31 12:15:32 +05:30
dependabot[bot]
a60a887e63 chore(deps-dev): bump acorn from 8.0.4 to 8.0.5 in /curriculum
Bumps [acorn](https://github.com/acornjs/acorn) from 8.0.4 to 8.0.5.
- [Release notes](https://github.com/acornjs/acorn/releases)
- [Commits](https://github.com/acornjs/acorn/compare/8.0.4...8.0.5)

Signed-off-by: dependabot[bot] <support@github.com>
2021-01-31 05:19:39 +00:00
Hernando Guzmán
3394a654bd fix(learn): Correct syntax in the code example (#40811)
Closes #40810
2021-01-27 11:03:22 -08:00
gikf
d41630ee19 fix(learn): clarify test description for Use Rest Parameter with Function Parameter (#40725)
* fix: clarify test description

* fix: improve wording regarding rest parameters syntax

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: improve with better sounding wording

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-01-24 08:30:13 -08:00
Mainak Debnath
d5ad87d915 fix(learn): put test cases under --seed-- and remove them from the solution (#40755)
* fix: put test cases under --seed--

* fix: put test cases under --seed--
2021-01-21 18:26:06 -08:00
Shaun Hamilton
ce3a20e552 fix(learn): change requirements for positive and negative lookaheads (#40570) 2021-01-21 15:35:19 -06:00
Lasse Jørgensen
f2b1d7b147 fix(challenge): Assert arrays contain expected values (#40693) 2021-01-21 10:52:52 -08:00
Ilenia
a38922536c Adding language to code fences and pre to console logs (#40603)
* added languages to prismjs

* added language to code fences for python for everybody

* multiline pre to python for everybody questions

* multiline pre for data analysis with python

* multiline pre in numpy questions

* single line pre for python for everybody

* single line pre for data analysis with python

* single line pre for numpy

* Revert "multiline pre in numpy questions"

This reverts commit af1a02cdd3.

* fix unneded escaping

commit suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Revert "single line pre for numpy"

This reverts commit 5f90981108.

* revert changes to snippet that have a language

* one last code fence to pre

* Revert "fix unneded escaping
"

This reverts commit 64c84a9213.

* Revert "single line pre for data analysis with python"

This reverts commit 3bccaff753.

* Revert "single line pre for python for everybody"

This reverts commit 03a5379062.

* remove unnecessary escape

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-01-21 12:12:42 -06:00
github-actions[bot]
392005154c chore(i8n,learn): processed chinese translations (#40752)
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
2021-01-21 10:07:18 -08:00
Nicholas Carrigan (he/him)
8e62a243bb fix(learn): Update demo links (#40575)
* fix(learn): Replace demo projects

Replaces the Heroku demo project links with the
.rocks demo projects that @moT01 provided.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix(learn): Use correct endpoint

Corrects the API endpoint for the image search
project.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: user stories to align with project + backticks

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2021-01-21 11:09:35 -06:00
Durbatuluk1701
0a7aa59d51 fix(learn): Convert response testcase regex handles any variable name (#40568)
* Update convert response to JSON testcase

Testcase previously required that variable be named exactly "response". Changes will allow variable of any name to be used.
Example: res can now be used and tests still pass.

* Forgot the \ in front of )
2021-01-21 08:54:24 -08:00
matias-miller
8a9f3319c6 fix(learn): Fixed typos in count-backwards-with-a-for-loop.md (#40478)
* Spelling change in count-backwards-with-a-for-loop

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/count-backwards-with-a-for-loop.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-01-21 08:44:10 -08:00
Mukesh Gurpude
a5dceb3e7e Fixed error when changing the default order of css properties (#40525)
* Bug with psoitioning

Fixed bug with positioning of background-color` property for Selector `.heart::after`

* Trying new changes

* Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/create-a-more-complex-shape-using-css-and-html.md

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* Tests passing

Check the regex matching at [Regex101](https://regex101.com/r/GU18ds/4)

* fixed typo

* applied suggestions

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-01-21 10:17:16 -06:00
Nicholas Carrigan (he/him)
062b1cd424 fix: replace h tags (#40750)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-01-21 13:41:46 +05:30
Randell Dawson
83e3d93953 fix(learn): Remove strong syntax around code inline code (#40754) 2021-01-21 13:40:19 +05:30
Kim Leung
e57f32438c fix(learn): correct LCG equation in description (#40615)
* fix(learn): correct LCG equation in description

* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/linear-congruential-generator.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Update curriculum/challenges/chinese/10-coding-interview-prep/rosetta-code/linear-congruential-generator.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Revert LCG equation in Chinese file

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-01-20 22:05:37 -08:00
Alex Soto
ef394093f7 fix(learn): removing unnecessary test case for regex challenge (#40581)
Co-authored-by: Alejandro Soto <alejandro.soto@wundermanthompson.com>
2021-01-20 21:53:04 -08:00
Randell Dawson
dd4c7e0097 fix(learn): Update text as code for vector-dot-product (#40460)
* fix: implemented suggestted changes

* fix: correct last test expected return value

* fix: remove slash

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: remove slash

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: add test to return null if more than 2 vectors

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: added correct solution

* fix: removed extra brackets

Co-authored-by: Yuval Levental <yhl3051@rit.edu>

Co-authored-by: Lakshya Baghel <lakshyab.1999@gmail.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Yuval Levental <yhl3051@rit.edu>
2021-01-20 21:23:10 -08:00
Ian Turner
fb2e5d81f3 Add line breaks to instructions (#40425) (#40428)
* feat: add line breaks to instructions  (#40425)

* feat: add punctuation to instructions (#40425)
2021-01-20 22:19:21 -07:00
Brandon Dusch
570d9ad906 fix: updated JSON string in snippet for Python Web Services (#40742) 2021-01-20 22:09:16 -07:00
Sergey Musiyenko
0b01b73e1f fix: a typo - TSL certificate ===> TLS certificate (#40697)
* Fixed a typo

* fix: a typo - TSL certificate ===> TLS certificate

* revert: non-English translations have to adhere to a new policy
2021-01-20 22:08:47 -07:00
Jason Liao
0b812c91e3 update task description (#40586) 2021-01-20 22:06:51 -07:00
Durbatuluk1701
b62cf73116 Correcting type on word error (#40578)
Bug Fix for #40533
2021-01-20 22:05:42 -07:00
Niraj Nair
a8230fda57 Added Change this line comment (#40497) 2021-01-20 22:03:24 -07:00
Jagadeesh G
3061a5a0eb Text in Basic Data Structures lesson is better clarified. (#40492)
* text_changes

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/add-items-using-splice.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

Co-authored-by: Jagadeesh G <17941713+GJ-16@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-01-20 22:02:37 -07:00
Yaseen Sayyed
3bdf143fd8 Changed the question to one with no ambiguity (#40488)
* Changed the question to one with no ambiguity

* Update curriculum/challenges/english/08-data-analysis-with-python/data-analysis-with-python-course/jupyter-notebooks-cells.md

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* Update curriculum/challenges/english/08-data-analysis-with-python/data-analysis-with-python-course/jupyter-notebooks-cells.md

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* Update curriculum/challenges/english/08-data-analysis-with-python/data-analysis-with-python-course/jupyter-notebooks-cells.md

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-01-20 22:00:18 -07:00
Nicholas Carrigan (he/him)
891a64fa3d fix(learn): Remove arrows from test name assertion (#40467)
* fix: Remove arrows from test name assertion

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: Add note about time span

Adds a note regarding the expectation of the `span` element to wrap the
entire time string when translated, not just the delimiter symbol.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: use correct note syntax

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: remove note syntax

New line was breaking the build, so changing the `note` comment to be
regular text.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-01-20 21:57:32 -07:00
Nicholas Carrigan (he/him)
b07394603b feat(learn): Move metric imperial converter tests (#40358)
* Move tests to /learn

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Modify test verbiage

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Update curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/metric-imperial-converter.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/metric-imperial-converter.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: add missing tests

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: Correct inaccurate test text - thx @ShaunSHamilton

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: remove arrow from test name

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-01-20 21:51:57 -07:00
Ismail Tlemçani
d6e47037de fix(learn): tests of the for in issue regarding the curly braces (#40344)
* fix: fix the regex of the test of the challenge

* fix: fix data structure challenge

* fix: fix data structure challenge

* fix:fix the test regex of the challenge

* fix: fix the test regex
2021-01-20 21:50:44 -07:00
Martin Milani
8e96fef862 fix(learn): Updated instructions for challenge solution for Reuse Patterns Using Capture Groups (#40658)
* Grammatically updated the instructions for the challenge

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/regular-expressions/reuse-patterns-using-capture-groups.md

Co-authored-by: Eric Leung <eric@erictleung.com>

Co-authored-by: Eric Leung <eric@erictleung.com>
2021-01-20 19:39:23 -08:00
github-actions[bot]
7bd905f393 chore(i8n,learn): processed chinese translations (#40716)
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
2021-01-20 18:58:05 -08:00
Nicholas Carrigan (he/him)
8d8d25e9f2 fix(learn): address escaped backticks (#40717)
* fix(learn): address escaped backticks

Addresses the instances of escaped backticks - where a backtick is
preceded by a backslash.  In most cases, this was left over from the
old parser. In some cases, a backtick was intended to be wrapped in
code tags and has been adjusted accordingly.

This issue came to light due to a bug in the translation flow on
Crowdin.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: EVEN MORE :( :( :(

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: backslash nightmares

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: When you wish upon a *******

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix(curriculum): md error introduced by formatter

* fix(curriculum): remove extra `s

* fix: restore quote symbol

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: Typo

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: apply review changes

Applying review feedback from call with @RandellDawson.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: markdown does weird stuff sometimes

Can't stick backticks together - use code.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-01-20 19:01:00 -07:00
Sergey Rufanov
5379b04387 fix(learn): Removed note about commented array from sorting algorithm challenges (#40652) 2021-01-16 12:00:10 -08:00
Vicky Zhang
594b63bc35 fix(learn): Clarify sudoku solver instructions (#40604)
* Clarify sudoku solver instructions

* decrease spaces
2021-01-16 11:58:48 -08:00
Mathieu HAAGE
1f62718f52 fix(docs): Add empty line after HTTP request headers (#40654) 2021-01-16 12:58:21 -07:00
Jeremy L Thompson
a5840f57a4 Update Description of Stern-Brocot Challenge (#40686)
* fix: update description of target function

* fix: include note about 1 based indexing
2021-01-16 12:57:38 -07:00
Nicholas Carrigan (he/him)
bab54ad619 fix(learn): no capital code block (#40688)
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
2021-01-16 12:54:38 -07:00
majkelmichel
3ecdfe87d7 Update create-a-form-element.md (#40720)
Improved wording in Description and Instructions sections
2021-01-16 12:25:13 -07:00
Randell Dawson
8856f4887c fix: remove update-option from config file (#40719) 2021-01-16 11:12:51 +01:00
Thomas
fc976aba74 fix(learn): Change example text in create-a-form-element.md (#40542)
* Update create-a-form-element.md

Update example. For issue 40523

* Clearer formatting of example
2021-01-16 01:11:47 -08:00
Xing Liu
2cbb30a2f3 partial translation of basic-javascript (#40689) 2021-01-13 10:11:33 -07:00
Randell Dawson
2956a01f3d fix: upload all challenge sections in config (#40687) 2021-01-12 21:09:59 -06:00
Oliver Eyton-Williams
ee1e8abd87 feat(curriculum): restore seed + solution to Chinese (#40683)
* feat(tools): add seed/solution restore script

* chore(curriculum): remove empty sections' markers

* chore(curriculum): add seed + solution to Chinese

* chore: remove old formatter

* fix: update getChallenges

parse translated challenges separately, without reference to the source

* chore(curriculum): add dashedName to English

* chore(curriculum): add dashedName to Chinese

* refactor: remove unused challenge property 'name'

* fix: relax dashedName requirement

* fix: stray tag

Remove stray `pre` tag from challenge file.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: nhcarrigan <nhcarrigan@gmail.com>
2021-01-12 19:31:00 -07:00
Randell Dawson
0095583028 feat: Crowdin integration scripts/actions (#40657) 2021-01-12 23:50:54 +05:30
Steven Ding
ab222e31e7 an audit for some changes (#40680) 2021-01-12 09:31:18 -07:00
ZhichengChen
797cc3024e Update Chinese translation of fornt-end-libraries (#40653)
* Update Chinese translation of fornt-end-libraries

* fix: revert to previous translation

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-01-12 09:22:19 -07:00
Xing Liu
306e4aaacf add translation of algorithm and data structures (#40678) 2021-01-12 09:18:51 -07:00
Nicky Xu
a469138ae4 feat: audit for data visualization projects (#40612)
* feat: audit for data visualization projects

* feat: translate data visualization curriculum
2021-01-12 08:56:49 -07:00
dependabot[bot]
439c6e2091 chore(deps-dev): bump string-similarity in /curriculum
Bumps [string-similarity](https://github.com/aceakash/string-similarity) from 4.0.3 to 4.0.4.
- [Release notes](https://github.com/aceakash/string-similarity/releases)
- [Commits](https://github.com/aceakash/string-similarity/commits/4.0.4)

Signed-off-by: dependabot[bot] <support@github.com>
2021-01-10 05:20:48 +00:00