331 Commits

Author SHA1 Message Date
Vipul Sinha
7e2b159350
fix(curriculum): update solution to match seed (#38828) 2020-05-18 19:52:38 +02:00
Ashraf Nazar
e10a046f8a
fix(curriculum): use example in Modifying an Object Within a Nested Object challenge (#38468)
* fix: use example in modifying an object within a nested object exercise to explain how to do so

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/modify-an-object-nested-within-an-object.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/modify-an-object-nested-within-an-object.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/modify-an-object-nested-within-an-object.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/modify-an-object-nested-within-an-object.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-05-15 16:41:40 -05:00
Kristofer Koishigawa
b017ce192c
fix: dotall flag not supported in firefox (#38762)
Addresses https://github.com/freeCodeCamp/freeCodeCamp/pull/38546#issuecomment-625611675 where it's pointed out that Firefox doesn't support the /s regex flag yet. This workaround matches anything that's not blank.
2020-05-08 19:27:32 +02:00
Eric Elli
f757840624
fix(learn): add test to return early pattern (#38751)
* add: test to return early pattern

Currently no test for a = 0 or b = 0. This results in if(a<=0 || b<= 0) also being a valid solution

* fix: typo in test text

* fix: update return early pattern test

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-05-07 14:37:48 -05:00
Twaha Rahman
c0e2b65864
Wrapped all the test results with quotation (#38706) 2020-05-02 09:25:55 -05:00
Michael Schneider
1f2b66a432
feat: edit 2nd test description for clarity (#38661)
current description logically fits, yet fails this solution: myVar = ++myVar;
2020-05-02 08:27:52 -05:00
Farjad Fazli
fd85f57376
fix(learn): fixed typo "in the left" should be "at the left" (#38651)
* Fixed typo "in the left" should be "at the left"

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/comparison-with-the-equality-operator.english.md

Co-Authored-By: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-05-02 08:17:11 -05:00
Joel Duran
7035516483
fix: typo in 'Build JavaScript Objects' (#38690) 2020-04-30 17:41:55 +05:30
Oliver Eyton-Williams
f2f5dbc4b8
fix(curriculum): improve declaration tests (#38546) 2020-04-29 16:39:48 +05:30
Gabriel Majeri
9230db42ee
fix(learn): update currency name in cash register challenge (#38637) 2020-04-26 17:38:22 +05:30
Kimon
a3b54d34cb
Differentiate between test & match (#38498)
* Differentiate between test & match

I noticed that nowhere was there a mention that .match() and .test() pass in and are applied to opposite objects.  This would've saved me a few minutes of searching during later challenges that assume this is understood.

* Add in .match & .test difference after example

* fix: add spaces to stop lint errors

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-04-25 08:35:46 -05:00
Ashraf Nazar
c2558b3816
fix(Curriculum): ensure code that includes and is not equal to the fl… (#38497)
* fix(Curriculum): ensure code that includes and is not equal to the flat or flatMap methods do not fail the test suite

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/intermediate-algorithm-scripting/steamroller.english.md

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* Update steamroller.english.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-04-23 14:59:58 -05:00
Ashraf Nazar
3a82e9f857
fix: add more examples on how to set key-value pairs (#38472)
* fix(Curriculum): update examples on how to set key-value pairs

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/add-key-value-pairs-to-javascript-objects.english.md

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/add-key-value-pairs-to-javascript-objects.english.md

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* Update add-key-value-pairs-to-javascript-objects.english.md

* Update add-key-value-pairs-to-javascript-objects.english.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-04-22 11:20:30 -05:00
Shaun Hamilton
17585b63f8
added const to test string (#38583) 2020-04-21 09:12:53 +02:00
piouson
2b60f3e61e
fixed arrow function with no curly braces failing IIFE test (#38544)
* fixed arrow function with no curly braces failing IIFE test

* added iife 2nd test fix and 3 new solutions
2020-04-20 11:04:28 +02:00
Shaun Hamilton
d739a0cc5d
fix(curriculum): change debugging console lesson (#38554)
* changed lesson to match behaviour

* Update wording for debugging

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update wording from suggestion

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* all suggestions with note

* fix: replaced code tags with backticks for markdown

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Ashraf Nazar <ashraf.caspian@gmail.com>

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-04-18 16:31:41 +05:30
Beau Carnes
756f33775e
fix(learn): update video challenge (#38564)
* fix(learn): update video challenge

* fix: update scrimba URL

Co-authored-by: Mrugesh Mohapatra <me@raisedadead.com>
2020-04-18 16:16:31 +05:30
kundan kumar
19c514b702
Fix/functional programming challange (#38516)
* Improved readbility of FP challage

* replace the with a

* corrected gramatical mistake
2020-04-11 21:20:44 -05:00
Randell Dawson
a5818506f0
fix(curriculum): remove setup code not needed anymore from Testing Objects for Properties challenge (#38454)
* fix: remove setup code

* fix: remove call to function
2020-03-28 02:25:04 +12:00
Enock Kasaadha
06d97ac813
fix(curriculum/learn): moved the comment one line below. (#38422)
moved the comment ` //add code above this line` in the text editor of [this challenge](https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures/es6/use--to-import-everything-from-a-file) one line below so that it makes meaning.
2020-03-26 20:01:58 -05:00
Joseph Crandal
f142eed6ef
Fix pig latin challenge description (#38018)
* Fix pig latin challenge description

Added statement for beginning with consonants and if a vowel does not begin with a vowel.

* fix: update description/instructions

* fix:  removed extra line break

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix:  removed extra line break

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-03-26 23:38:07 +01:00
Randell Dawson
1fdb691996
fix(learn): updated tests and deleted old sample code (#38450) 2020-03-26 23:12:18 +05:30
Hassaan Pasha
4fbce07792
fix: improve test regex to validate disallowed methods that can be bypassed by prototype reassignments and/or otherwise (#38214)
* fix: improve test regex to validate disallowed methods that can be bypassed by prototype reassignments and/or otherwise

* fix: fixing regex pattern
2020-03-26 08:13:34 -07:00
Randell Dawson
e0e6334628
fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 3 of 4 (#38264)
* fix: remove example code from challenge seed

* fix: remove declaration from solution

* fix: added sum variable back in

* fix: reverted description back to original version

* fix: added examples to description section

* fix: added complete sentence

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: corrected typo

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* fix: reverted to original desc with formatted code

* fix: removed unnecessary code example from description section

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: failiing test on iterate through array with for loop

* fix: changed to Only change this line

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Manish Giri <manish.giri.me@gmail.com>
Co-authored-by: moT01 <tmondloch01@gmail.com>
2020-03-25 16:07:13 +01:00
Randell Dawson
50f15886b8
fix(curriculum): Strip comments from user code for Use Destructuring Assignment to Extract Values from Objects challenge (#38213)
* fix: strip user code to improve tests

* fix: removed closing section tag messing up tests
2020-03-25 13:28:17 +01:00
Kalyanasundaram
8b0cbd6f83
Modify tests for testing objects for properties challenge (#38414)
* Stronger test cases for testing objects for properties

Change function signature to take in a custom object to be tested

* YML formatting mistake

* Yaml no space in string

* Small one more fix - most likely final

* REmove double space in return

* Update instruction Section
2020-03-24 22:09:57 -07:00
Vincent Shury
6920634e6c
TYPO-FIX JS-regex-match-non-whitespace-characters (#38407)
Added Markdown to correctly display second test
2020-03-20 21:13:48 -07:00
Hassaan Pasha
a282c24bf4
fix (curriculum): added console output checks for the inheritance challenge (#38360)
Co-authored-by: Hassaan Pasha <hassaan.pasha@teamo.io>
2020-03-14 21:55:21 -07:00
Shivam saini
4ef78f7f7d
Update use-recursion-to-create-a-countdown.english.md (#38366) 2020-03-13 16:05:59 +01:00
Randell Dawson
c401fc7f83
fix(curriculum): removed solution required comment from 6 challenges (#38339)
* fix: removed solution required comments

* fix: fixed two more challenge soltuions with solution required comment

* fix: remove debugging code

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-03-09 13:58:46 +01:00
Randell Dawson
9252f96566
fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 4 of 4 (#38267)
* fix: consolidate comments


Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2020-03-08 15:46:28 +01:00
Tom
17a55c6e18
fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 1 of 4 (#38258)
* fix: consolidate/remove comments

* fix: remove => from comment

* fix: reverted changes to add same changes to another PR

* fix: removed 'the' from sentence

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: removed 'the' from the sentence

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-03-04 13:08:54 -06:00
Randell Dawson
6a7a7e6d7d
fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 2 of 4 (#38259) 2020-03-03 10:18:30 +03:00
Oliver Eyton-Williams
2d7b1255cc
fix: add missing .english extensions (#38298) 2020-02-28 07:19:22 -08:00
Vincent Shury
b49b9f3e3c
Typo whitespace fix in access-multi-dimensional-arrays-with-indexes.english.md (#38247)
* Update access-multi-dimensional-arrays-with-indexes.english.md

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-02-24 17:02:53 +01:00
Randell Dawson
78156a65f0
fix(curriculum): Added test to Return a Sorted Array Without Changing the Original Array challenge to validate new array is returned (#38105)
* fix: added test to validate new array is returned

* fix: changed text to reflect changed test

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-02-24 15:30:48 +01:00
Oliver Eyton-Williams
b0f1fa4b96
fix: make recursion challenge more intuitive (#37399) 2020-02-20 21:36:33 +05:30
Igor Snitkin
dc7092ecd1
(fix learn): Update description to accommodate tests (#38224) 2020-02-19 00:13:34 +05:30
Oliver Eyton-Williams
f84173866a
fix: make frankenSplice tests more robust (#38225) 2020-02-18 21:24:24 +05:30
Hassaan Pasha
0498e27902
fix: added white space checks including newlines to ensure pro… (#38166)
* fix: added white space checks including newlines to ensure proper validation of trim method

* fix: Addressing comments
2020-02-12 12:17:54 +05:30
Ashraf Nazar
5feabd762c
fix: Add tests to check lazy matching is applied and that the string "h1" is not matched (#38193) 2020-02-11 10:17:51 -06:00
Hassaan Pasha
80ba943ca3
fix: fixed regex for validating newlines in for loops (#38180) 2020-02-09 18:43:43 -06:00
Josh Soref
004b99bf8f chore: fix typos in spelling (#38100)
* spelling: accidentally

* spelling: announce

* spelling: assembly

* spelling: avoid

* spelling: backend

* spelling: because

* spelling: claimed

* spelling: candidate

* spelling: certification

* spelling: certified

* spelling: challenge

* spelling: circular

* spelling: it isn't

* spelling: coins

* spelling: combination

* spelling: compliant

* spelling: containers

* spelling: concise

* spelling: deprecated

* spelling: development

* spelling: donor

* spelling: error

* spelling: everything

* spelling: exceed

* spelling: exist

* spelling: falsy

* spelling: faulty

* spelling: forward

* spelling: handle

* spelling: indicates

* spelling: initial

* spelling: integers

* spelling: issealed

* spelling: javascript

* spelling: length

* spelling: maximum

* spelling: minimum

* spelling: mutable

* spelling: notifier

* spelling: coordinate

* spelling: passport

* spelling: perform

* spelling: permuter

* spelling: placeholder

* spelling: progressively

* spelling: semantic

* spelling: submission

* spelling: submit

* spelling: translations

* spelling: turquoise

* spelling: visualization

* spelling: without

* spelling: registration

* spelling: representation
2020-02-08 23:59:10 +05:30
Kiara Barias
afd467f5dc
Removes RSA links from English challenges (#37869)
* RSA links deleted from challenges

* fix: remove remaining RSA links in challenges
2020-02-07 14:46:07 +09:00
Shubham Shah
bef738f0d4
modfied tests and made correction in solution (#38023) 2020-02-06 20:31:03 -05:00
Hassaan Pasha
d89eae392f
fix: adding test to check if flat or flatMap method was used in the steamroller challenge (#38158)
* fix: adding test to check if flat or flatMap method was used in the steamroller challenge

* Addressed comments and acknowledged suggestions
2020-02-04 17:00:33 -05:00
Ashraf Nazar
fda7fb174e fix: Correct paths in English exercises by prefixing "/" before "learn" (#38099)
* fix: Correct paths in English exercises by prefixing "/" before "learn"

* fix(lang): Correct paths to exercises by prefixing "/" before "learn" in remaining languages
2020-01-26 12:51:21 -06:00
Ashraf Nazar
1159a8dcaf fix: Add edge case for mixed grouping of characters exercise, where "Frank Roosevelt" returns false (#38097) 2020-01-22 15:58:47 +05:30
Perrottarichard
bc470325d0 Update use-destructuring-assignment-with-the-rest-parameter-to-reassign-array-elements.english.md (#38092)
I added 'the' to correct the English grammar and hence improve the readability of the instructions.
2020-01-21 08:25:10 -06:00
ML
d824c77012 Move the comment on line 71 to its own line (#38036)
* Move the comment on line 71 to its own line

The comment "use function argument destructuring" was on the same line as some code, and when displayed as a challenge it returned to a new line and was not commented out.

* Update line 71 comment per @manish-giri suggestion

Move the comment "use function argument destructuring" to above the "change code below this line" comment for clarity. Based on conversation in this pull request https://github.com/freeCodeCamp/freeCodeCamp/pull/38036
2020-01-15 08:17:34 +05:30