Commit Graph

1832 Commits

Author SHA1 Message Date
Pyi Theim Kyaw
faf426bb40 PR ready fix(learn) (#39208) 2020-08-31 15:31:30 -05:00
Beau Carnes
f334734e98 feat: split JS challenge into two (#39044)
* feat: split JS challenge into two

* fix/change-to-not-use-untaught-assignments

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2020-08-31 19:44:56 +01:00
Kristofer Koishigawa
8e3f740127 fix: update take home project links (#39444)
* fix: update take home project links and update mentions of Glitch with Repl.it

* fix: clean up text, fix typos, and remove deploy to Heroku text

* fix: update nightlife coordination app description text

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: update GH link text based on suggestion

* fix: update links to the fCC forum

* fix: update nightlife coordination app url

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: change http to https

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-08-31 10:32:22 -07:00
Yasmin Yazdi
cf82a2b33e fix global flag fail in Regex by resetting last Index (#39457)
* fixing global flag fail by resetting last index. Issue #37890

* fixed syntax error

* making requested changes
2020-08-31 16:59:42 +05:30
Ashraf Nazar
71051fef50 fix(Curriculum): make sure the nested input element in the form is th… (#38480)
* fix(Curriculum): make sure the nested input element in the form is the existing element given in the editor

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: use backticks to avoid linting error

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Randell Dawson <rdawson@onepathtech.com>
2020-08-30 22:50:46 -07:00
Ty Mick
474ae28d72 Fix number of noun (#38833)
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-08-30 22:15:58 -07:00
Quinn
29ab6c32ec minor <code> tag fixes (#39046) 2020-08-30 23:12:04 -05:00
Shaun Hamilton
fe3f0b2ac4 fix: remove quotation marks from code tag text (#38316) 2020-08-30 22:53:09 -05:00
Carlos Diaz
e0a062a3e7 Changes order of padding, border, margin in introductory sentence. (#39414) 2020-08-30 22:28:42 -05:00
tomki1
9c3de2df24 added test to assert h1 is before h2 (#39040) 2020-08-30 22:13:30 -05:00
law27
b88c8ab351 Update use-the-s-tag-to-strikethrough-text.english.md (#38515)
Alphabet word is not wrapped inside double quotes

Co-authored-by: LawranceMichaelite <40236169+LawranceMichaelite@users.noreply.github.com>
2020-08-30 22:08:51 -05:00
Charles Ross
3db5bd7067 Update import-a-google-font.english.md (#38839)
Changed optional plural to possessive.
2020-08-30 22:07:46 -05:00
Ieahleen
ed6246b91a update description of "Nest an anchor element in a paragraph" as discussed in #38507 (#38524)
* remove parenthesis from description

As discussed in #38507 , I'm removing the phrase in parenthesis

* more succint description

Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2020-08-30 22:01:40 -05:00
Kristofer Koishigawa
b73156373f fix: tests for use a retina image challenge (#39133) 2020-08-29 22:09:43 -05:00
Karuppiah Natarajan
efa4e09efa fix typo in 'integer' word (#39339)
Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2020-08-26 07:38:43 -07:00
Samuel S. Hernandez
e71cf1da10 fixed spelling errors on .spanish.md (#39030)
fixed spelling errors to improve instruction readability
2020-08-25 19:55:38 -07:00
Samuel S. Hernandez
8ae1902c79 Spelling error on 'motores de busqueda' (#39029)
I fixed a spelling error.
2020-08-25 19:53:37 -07:00
Aviel212
fb77d48d13 curriculum: add test in React challenge to detect constructor call (#39304)
* fix: resolve #39301

Add a test to check the "MyComponent" constructor's parameters (params) and to check that the super function exists in the constructor.

* docs: describe the test better

* Update curriculum/challenges/english/03-front-end-libraries/react/write-a-react-component-from-scratch.english.md

Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>

Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>
2020-08-25 08:41:35 -07:00
Joseph Mawa
fccc436e23 Fixed test description for Rosetta Code: Euler method challenge. (#39452)
* Update greatest-subsequential-sum.english.md

Added missing closing bracket in test description in the tests section.
Removed variable declared twice in the solution section.

* Update euler-method.english.md

* Update euler-method.english.md

* Update euler-method.english.md

Added parameter description  fixing the suggested changes.

* Update euler-method.english.md

Removed some formatting from the added text.

* Update euler-method.english.md

Moved seed function parameter description to instructions section.
2020-08-25 08:37:10 -07:00
Shaun Hamilton
cdc1a63ca8 fix(learn): correct personal library replit link (#39442) 2020-08-20 13:08:02 -07:00
Joseph Mawa
fc1200ae2c Update greatest-subsequential-sum.english.md (#39422)
Added missing closing bracket in test description in the tests section.
Removed variable declared twice in the solution section.
2020-08-19 08:04:47 -07:00
Ryan-Chu
bd02c989df fix(curriculum): rename variable to avoid conflict (#39428) 2020-08-19 16:47:30 +02:00
Kristofer Koishigawa
6b3c61c737 feat: update backend project links (#39314)
* feat: update backend project links

Replace solution and remix Glitch links with equivalent Repl.it links in backend projects/challenges and intro pages.

* fix: link and Repl.it casing

* fix: update mention of glitch in testing challenge

* Apply suggestions from code review

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-08-17 14:38:16 -07:00
ML
9a4976bd57 fix(curriculum) typo in Create Reusable CSS (#39418)
Fixed a typo on the Sass Challenge "Create Reusable CSS with Mixins" where the word "vendor" was spelled incorrectly as "vender" in the test cases.
2020-08-16 18:33:34 -07:00
Nicholas Carrigan
4858c2eb0a Remove extra / from link (#39419) 2020-08-16 18:25:55 -07:00
Oliver Eyton-Williams
109f2d8eab fix: outstanding md linting issues 2020-08-16 04:45:20 +05:30
Oliver Eyton-Williams
61460c8601 fix: insert blank line after ```
search and replace ```\n< with ```\n\n< to ensure there's an empty line
before closing tags
2020-08-16 04:45:20 +05:30
Oliver Eyton-Williams
a66455b983 fix: test text mismatched quotes 2020-08-16 04:45:19 +05:30
Oliver Eyton-Williams
3c9ccb524c fix: add missing chinese extensions 2020-08-16 04:45:19 +05:30
Oliver Eyton-Williams
1cfa09adc4 fix: QA/Infosec update and python to chinese 2020-08-16 04:45:18 +05:30
Oliver Eyton-Williams
f9ffcf0c61 fix: update chinese certificates 2020-08-16 04:45:17 +05:30
Oliver Eyton-Williams
be3171169c fix: remove cn challenges already removed from eng 2020-08-16 04:45:17 +05:30
Oliver Eyton-Williams
c40eab94b7 fix(curriculum): add missing .english extensions 2020-08-16 04:45:17 +05:30
Mrugesh Mohapatra
38dee5b577 revert: chinese curriculum updates break structure (#39416) 2020-08-16 04:43:26 +05:30
ZhichengChen
d7cd3f7777 fix(i18n): update Chinese translation of install and set up mongoose (#38901) 2020-08-16 02:20:44 +05:30
ZhichengChen
f35e7de03e fix(i18n): update Chinese translation of information security with helmetjs (#38908) 2020-08-16 02:20:30 +05:30
ZhichengChen
4326253440 fix(i18n): update Chinese translation of quality assurance and testing with chai (#38945) 2020-08-16 02:19:48 +05:30
ZhichengChen
ce2085d240 fix(i18n): update Chinese translation of advanced node and express (#38946) 2020-08-16 02:19:14 +05:30
Ruchi Kushwaha
35c3609489 fix:Incorrect Usage of setState in React Challenge (#39290)
* fix:Incorrect Usaage of setState in React Challenge

* apply suggestion

* also set stage usage in other challenges

* fix setState usage in challenges

* correct syntax

* correct usage of useState in other files

* add current message to state

* remove current message from state

* change connect redux to the message app

* remove extra space
2020-08-11 10:12:27 -07:00
Ty Mick
817325d68e Change comma to semicolon (#39258) 2020-08-11 10:02:09 -07:00
Kartik Soneji
f813dfff87 fix: Replace Array.prototype.sort and update old isSorted method. (#39360)
* fix: Replace Array.prototype.sort and update old isSorted method.

* fix: Change name of function from 'checkInBuiltSort' to 'checkBuilitInSort'.

* fix: Change name of function from 'checkBuilitInSort' to 'isBuiltInSortUsed'.
2020-08-10 13:31:18 -07:00
Amy Gurski
8996fa7502 fix: rosetta day of week typos (#39380)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-08-08 19:00:29 -07:00
Iván Franco
0471f7f8d8 Removing # from property name to be consistent with previous challenges (#39334) 2020-08-06 08:33:56 -07:00
ZhichengChen
1046e21a90 fix(i18n): update Chinese translation of functional programming (#38061)
* fix(i18n): update Chinese translation of functional programming

* fix(i18n): update review suggestion

Co-authored-by: Zhicheng Chen <chenzhicheng@dayuwuxian.com>
2020-08-05 14:08:04 +05:30
Ty Mick
0642002005 Remove add method test (#38824) 2020-08-04 14:37:58 -07:00
Samuel S. Hernandez
fd6f34a801 fixed spacing errors on .spanish.md (#39031)
I eliminated unnecessary spaces to improve readability
2020-08-04 14:20:27 -07:00
Shaun Hamilton
c974fd39dd fix(curriculum): add regex to chai tests for double quotes (#39187)
* fix: allow for use of double quotes in chai tests

* fix: escape forward slash
2020-08-05 01:27:09 +05:30
Shaun Hamilton
7d8e558b91 fix(curriculum): convert all video challenges to markdown (#39189) 2020-08-05 01:26:41 +05:30
Mike Robinson
e7d2028bba fix(learn): change test order to test for the value after execution has finished (#39363)
Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>
2020-08-05 01:18:50 +05:30
ZhichengChen
303e228299 fix(i18n): update Chinese i18n of object oriented programming (#38055)
Co-authored-by: Zhicheng Chen <chenzhicheng@dayuwuxian.com>
2020-08-04 12:45:28 +05:30