Quincy Larson
51012bd121
remove console.log statement
2015-10-11 17:05:28 -07:00
Berkeley Martinez
1627aa522a
Fix form action attribute regex
...
Should ignore whitespace and new lines
2015-10-10 11:44:20 -07:00
Berkeley Martinez
113c9a297b
Fix form action attr throwing xss errors
...
This PR fixes codeURI xss errors in chrome due to action
attribute.
2015-10-07 16:16:02 -07:00
Quincy Larson
cdbd052b35
Merge branch 'staging' into clementine
2015-10-07 01:29:15 -07:00
Berkeley Martinez
33e8f35bbf
Fix replace script tags in URL
...
Replace script tags in URL with fcc tags.
This prevents some xss bugs blocking code from running
in the iFrame.
2015-10-06 16:39:15 -07:00
Quincy Larson
c27e5bf6c4
start adding clementine challenge
2015-10-05 21:57:15 -07:00
Berkeley Martinez
8c48626f03
Add certification page
2015-10-05 15:55:50 -07:00
Berkeley Martinez
72e0595ca6
add uri code storage
2015-09-30 22:32:31 -07:00
Berkeley Martinez
5de6837959
Merge pull request #3548 from FreeCodeCamp/converge-bonfires
...
refactor all Bonfire tests to use assert and have friendly messages
2015-09-30 19:47:20 -07:00
Quincy Larson
416a866ec0
add step based challenge to framework
2015-09-30 13:26:06 -07:00
Quincy Larson
03675ef0a6
finish QAing basic and intermediate bonfires
2015-09-30 01:33:07 -07:00
Quincy Larson
27f231e72f
refactor tests to show same message when passing and failing
2015-09-27 23:22:06 -07:00
bugron
615173ef91
fixes 'only 11 lines' issue
2015-09-14 08:37:45 +04:00
Berkeley Martinez
2186f36067
fix modal auto-submitting
2015-09-09 21:33:45 -07:00
Quincy Larson
8ed1cf2fb9
Merge branch 'staging' of github.com:FreeCodeCamp/freecodecamp into staging
2015-09-09 20:41:13 -07:00
Quincy Larson
0d31256a10
Merge branch 'feature/ctrl-enter-submit' of github.com:FreeCodeCamp/freecodecamp into feature/ctrl-enter-submit
...
Conflicts:
client/commonFramework.js
server/views/coursewares/showBonfire.jade
server/views/coursewares/showJS.jade
2015-09-09 20:40:40 -07:00
Quincy Larson
d02ad70913
Merge pull request #3205 from FreeCodeCamp/feature/ctrl-enter-submit
...
add ctrl enter press to submit on modal
2015-09-09 20:40:02 -07:00
Berkeley Martinez
f1b29a6fd1
fix modal showing when challenge already completed
...
This fix fixes a regression introduced in an earlier commit.
Now, isInitRun is always set false on user involvement.
This prevents the completion modal from poping up during challenges
that have preview windows.
2015-09-09 20:13:35 -07:00
Berkeley Martinez
d3e77f1282
add ctrl enter press to submit on modal
...
this adds the ability for a camper to press ctrl + enter to submit
a challenge while the challenge completion modal is open
2015-09-09 19:33:01 -07:00
Quincy Larson
09b6dae11b
Merge branch 'staging' into feature/ctrl-enter-submit
...
Conflicts:
server/views/coursewares/showBonfire.jade
server/views/coursewares/showHTML.jade
2015-09-09 18:32:31 -07:00
Quincy Larson
308071b33c
Merge pull request #3187 from QuincyLarson/learn-button
...
add learn button
2015-09-09 18:30:22 -07:00
Berkeley Martinez
f3f6dad026
fix emmet undefined in non-html challenges
2015-09-09 14:39:01 -07:00
Ben McMahon
f4f9f183ba
Merge pull request #3203 from FreeCodeCamp/fix/run-button
...
fix isInitRun flag not set
2015-09-09 21:46:27 +01:00
Berkeley Martinez
82f7b3825c
Merge pull request #3123 from abhisekp/add-emmet
...
Restore emmet.io support
2015-09-09 13:15:16 -07:00
Berkeley Martinez
c10f81408a
add ctrl enter press to submit on modal
...
this adds the ability for a camper to press ctrl + enter to submit
a challenge while the challenge completion modal is open
2015-09-09 12:57:22 -07:00
Berkeley Martinez
7874dc5222
fix isInitRun flag not set
...
When doing jQuery challenges and starting with failing tests
isInitRun, the flag that prevents initial run from auto submitting
a challenge does not get set due to bonfireExecute not running in
this situation. This fixes that by setting consitantly setting
the flag on failing tests so that when tests do pass by camper
the flag will always be set and allow the camper to continue.
closes #2772
2015-09-09 12:07:00 -07:00
Quincy Larson
f0a4924671
start refactoring next challenge logic
2015-09-08 21:45:53 -07:00
Ben McMahon
6e9e7bb7a9
Merge pull request #2945 from FreeCodeCamp/fix/coreStorage-not-saving
...
fix codeStorage not saving on keyUp events
2015-09-07 21:49:30 +01:00
Abhisek Pattnaik
c043e370d9
Restore emmet.io support
...
close FreeCodeCamp/FreeCodeCamp#2720
2015-09-06 21:34:33 +05:30
benmcmahon100
1c85bdf8bd
Tweaked how the modal is focused
2015-09-04 21:51:34 +01:00
benmcmahon100
f7d7990c4f
Fixed double click issue
2015-09-04 21:34:07 +01:00
Berkeley Martinez
3cb16bfa18
fix codeStorage not saving on keyUp events
...
closes #2894
2015-08-31 22:48:20 -07:00
Berkeley Martinez
a737466e68
fix remove hack causing looping
2015-08-30 01:54:55 -07:00
benmcmahon100
71b6e21e77
Added the accessibility fix and added the hack to fix the challenge complete modal
2015-08-30 00:31:07 +01:00
Berkeley Martinez
376b58cc15
combine sandbox into commonFramework
...
a @benmcmahon suggestion
2015-08-27 12:37:41 -07:00
Berkeley Martinez
ed9e89b51f
super lint commonFramework
2015-08-27 11:23:17 -07:00
Berkeley Martinez
384dec42ac
mid finished linting commonFramework
2015-08-27 00:15:13 -07:00
Berkeley Martinez
8f54932cab
fix refactor codemirror
2015-08-27 00:02:07 -07:00
Berkeley Martinez
306c441ae7
add revisioning to js/css files to break caching
...
This moves the location of javascript files, commonFramework,
iFrameScript, sandbox, plugin, and all the less files.
On gulp or gulp build these files are moved and revisioned.
Places where they are references in jade/html are now removed and
replaced with the use of a helper function `rev`. This function will
take the required file and return a string referencing the revisioned
file. This should alleviate the need for hard refreshing and will break
caches when files change, so fixes for firefox caching issue as well.
NOTE: @benmcmahon @quincylarson, This means files will need to be build
on the server in production before doing a server restart/reload
In production: 'npm run build' To build and revision js/css files
`gulp` and `gulp build` will used in development
npm install also needs to be run in production on initial deploy
2015-08-26 23:30:33 -07:00
