Emer Conghaile
87b0e5bb7a
fix(curriculum): Remove unnecessary comments ( #41781 )
...
* Remove unnecessary comments
https://github.com/freeCodeCamp/freeCodeCamp/pull/41612
* Update the hints section
2021-04-08 10:49:47 -07:00
Emer Conghaile
c4ba0c692f
fix(curriculum): Remove unnecessary comments ( #41776 )
...
* Remove unnecessary comments
* Remove last comment, change instruction wording
2021-04-08 10:46:39 -07:00
Emer Conghaile
591a534701
Remove unnecessary comments ( #41775 )
...
https://github.com/freeCodeCamp/freeCodeCamp/pull/41612
2021-04-08 09:40:34 -07:00
Emer Conghaile
a9a68fa498
fix(curriculum): Remove unnecessary comments ( #41774 )
...
* fix: Remove unnecessary comments
https://github.com/freeCodeCamp/freeCodeCamp/pull/41612
* Add empty line
2021-04-08 09:36:05 -07:00
Saurabh Kumar singh
617f7b07e9
Update iterate-through-an-array-with-a-for-loop ( #41742 )
...
* Update iterate-through-an-array-with-a-for-loop
* Update iterate-through-an-array-with-a-for-loop
Add space around minus for better readablilty.
* Update iterate-through-an-array-with-a-for-loop
* Update iterate-through-an-array-with-a-for-loop
* Update iterate-through-an-array-with-a-for-loop.md
2021-04-08 09:56:49 -05:00
Nicholas Carrigan (he/him)
a962d6afd4
fix(curriculum): cat photo app ( #41768 )
...
Fix a couple of bugs I encountered when running through this
course.
2021-04-08 13:37:18 +05:30
Jonathan
fa52f4cafe
fix(curriculum): "Get JSON with the JavaScript fetch method" test too tpecific ( #41766 )
2021-04-08 09:20:29 +02:00
gikf
9c35bf0bd1
fix(curriculum): prevent malforming of svg image ( #41755 )
...
* fix: correct displaying of malformed svg
2021-04-07 09:59:33 +02:00
Akib Maredia
523997c33b
fix: Mr.Page's firstname to Elliot ( #41744 )
2021-04-05 08:49:12 +02:00
Hassaan Pasha
d51460dba8
fix (curriculum): added top level label-input pair to challenge ( #41717 )
...
* fix (curriculum): added top level label-input pair to challenge
* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-set-of-radio-buttons.md
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
2021-04-05 08:41:31 +02:00
Nicholas Carrigan (he/him)
7d83a6b65d
fix(curriculum): verbiage ( #41732 )
...
* fix(curriculum): verbiage
Modify the wording of the tests in this challenge to avoid having
two tests which sound the same.
* fix: Shaun's arrays have elements
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
2021-04-03 23:00:15 +02:00
Sem Bauke
e75685f803
fix(curriculum): change tests to allow more solutions ( #41703 )
...
* fix(curriculum) only allow new object to be the second value in array
* fix(curriculum) remove direct array index notation
* Apply suggestions from Shaun
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
2021-03-31 14:24:20 -07:00
Rafael D. Hernandez
37e8d0b757
fix/ownProps ( #41686 )
...
related issue:#4114
2021-03-31 13:48:37 +05:30
Nicholas Carrigan (he/him)
e1ea77412b
chore(i18n,curriculum): updates ( #41689 )
...
Apply typo fixes and formatting changes based on feedback from
internationalisation process.
2021-03-31 13:48:01 +05:30
danzel-py
48e19ccd7b
fix: typo in instructions ( #41696 )
2021-03-31 13:47:19 +05:30
Alan
fb40f56876
fix(curriculum): malformed paragraph in react/redux ( #41645 )
...
* fix: re-arranged paragraph in react-redux lesson
* fix: re-arranged paragraph in react-redux lesson in different locales
* fix: reverted other locale changes
* fix: switched link to enable opening as a new tab
2021-03-29 16:00:12 +00:00
Sem Bauke
87c9c799c6
fix(curriculum): Regex fix for Create a Variable for a Specific Area ( #41501 )
2021-03-29 17:09:52 +05:30
Rafael D. Hernandez
c962c0c8e5
fix: wrap own properties and not just own ( #41614 )
...
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-03-27 07:59:44 -06:00
Randell Dawson
18ac058840
fix(curriculum): Improve wording of test text ( #41606 )
...
Co-authored-by: Ricardo Passos <55499252+dizz-y@users.noreply.github.com >
2021-03-26 13:01:20 -05:00
Emer Conghaile
e5b4ae17a0
fix: Simplify wording to make more sense ( #41586 )
...
* fix: Simplify wording to make more sense
I think that "count odd numbers backward by twos" instead of "count backward by twos by odd numbers" is easier to understand.
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/count-backwards-with-a-for-loop.md
I think that this variation sounds better than what I originally wrote.
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-03-25 22:18:51 +00:00
Randell Dawson
b5ed2619eb
fix: replace inline code blocks ( #41576 )
2021-03-26 02:37:48 +05:30
gikf
8cc172d9e8
fix(learn): rework Rosetta Code Harshad or Niven series ( #41554 )
...
* fix: rework challenge to use argument in function
* fix: remove unnecessary link
* fix: improve wording
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-03-26 02:28:09 +05:30
Laurent Labine
8e22962523
fix(curriculum) replace single-line blocks with multi-line blocks for… ( #41526 )
...
* fix(curriculum) replace single-line blocks with multi-line blocks for issue 51418
Data visualization and Coding Interview Prep portions.
* Update execute-a-markov-algorithm.md
Implemented as inline code blocks as discussed
* Adding missed blocks
* Last file added
2021-03-25 07:43:13 -07:00
fuzzyray
2ad908b3a9
fix(learn): correct the instructions for functional tests ( #41459 )
2021-03-23 10:24:55 +05:30
CoolBlueDesigns
fd5e6eebfb
fix(curriculum): add blank like to seed code
2021-03-22 16:18:15 +00:00
Randell Dawson
e18c6955b0
fix(curriculum): Improve test to allow any valid function call for Write Reusable JavaScript with Functions challenge ( #41538 )
...
* fix: improve test to allow function call anywhere
* fix: force user to put console.log in function
2021-03-20 12:23:32 +00:00
Seth
654d66186e
Stock Price Checker: Change "form data" to "query parameter" ( #41492 )
...
* Stock Price Checker: Replace form data with query parameter
* Improve wording of Stock Price Checker user stories
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* More consistent wording and link term to Wikipedia
* Removed Link to External Resource
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-03-19 15:19:13 -06:00
Arjun Yadav
3f1cd6eb33
fixed the grammar of the description ( #41531 )
2021-03-19 06:55:21 -06:00
Shaun Hamilton
251d916e76
fix(learn): specify connect-mongo version in adnode ( #41524 )
2021-03-19 06:43:56 +01:00
Laurent Labine
00b37093db
fix(curriculum): replace single-line blocks with multi-line blocks for… ( #41525 )
...
* fix(curriculum) replace single-line blocks with multi-line blocks for Front End Libraries #41523
Second attempt
* Update curriculum/challenges/english/03-front-end-libraries/react/use--for-a-more-concise-conditional.md
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
2021-03-18 23:40:32 +00:00
Sem Bauke
b064991667
fix(curriculum): Replace single-line blocks with multi-line blocks for Responsive Web Design ( #41519 )
...
* fix(curriculum) replace single-line block with multi-line blocks
* fix(curriculum) replace single-line block with multi-line blocks (missed blocks)
2021-03-18 17:24:09 -06:00
gikf
b8ddfc08b3
fix(learn): rework Project Euler 63 ( #41425 )
...
* fix: rework challenge to use argument in function
* fix: add solution
* fix: correct function call in seed code
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com >
* fix: improve instructions wording
* fix: correct typo
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com >
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
2021-03-16 18:41:47 -05:00
Randell Dawson
d2f4b70ea6
fix: remove end of line chars after code blocks ( #41498 )
2021-03-16 07:49:43 -07:00
Randell Dawson
c198d508be
fix(learn): Improve tests for the Nest an Anchor Element within a Paragraph challenge ( #41456 )
2021-03-12 10:09:22 -07:00
gikf
9669e39b85
fix(learn): make tests and test descriptions more explicit ( #41281 )
...
* fix: make tests and descriptions more explicit
* fix: add example to description
* fix: replace pre tags with markdown
* fix: move test data to seed code for convenience
* fix: correct grammar from review
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
* Revert "fix: move test data to seed code for convenience"
This reverts commit 7a9c4723d6
.
* fix: small corrections
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
2021-03-12 07:29:03 -08:00
Randell Dawson
33bd4fb2c4
fix(learn): Change Codepen template link ( #41440 )
2021-03-12 10:41:48 +05:30
pandacoder7
53d372c298
fix: update challenge for crowdin in anchor page ( #41450 )
2021-03-11 13:35:34 -07:00
Luca
5589c37804
fix(learn): remove wrong spaces and make quotes consistent ( #41434 )
...
* Remove spaces that are not meant to be there (L37, L134, L156) Makes quotes consistent (L61)
Remove spaces that are not meant to be there (L37, L134, L156)
Makes quotes consistent (L61)
* Consistent spacing after commas
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com >
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com >
2021-03-11 07:19:07 -08:00
Kelvin Sánchez
35a8f55515
fix(learn): Remove unnecessary inline code tag in challenge ( #41428 )
...
* remove unnecessary inline code tag
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/comparison-with-the-less-than-or-equal-to-operator.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* improve challenge wording
* improve challenge wording
* keep wording consistency
* keep wording consistency between similar challenges
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-03-10 10:16:03 -08:00
Sem Bauke
5b760e50a3
fix(curriculum) Improved readability and grammar ( #41340 )
...
* fix(curriculum) Improved readability and grammar
* fix missing tags and grammar
* fix(curriculum) changes to grammar
* fix(curriculum) grammar fixes
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/make-elements-only-visible-to-a-screen-reader-by-using-custom-css.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* fix(curriculum) Grammar fix
* chore: apply suggestions from code review
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com >
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
2021-03-10 09:00:03 -08:00
Caden Parker
6b9aeff09e
fix(learn): Rework Euler Problem 461 ( #41333 )
...
* Made instructions more clear + Corrected test cases
* Added highlight for return values
* Adjusted challenge description
* Rework
* Fixed minor linting error
* Address PR Comments
* Adjusted wording in description
2021-03-10 08:14:27 -07:00
Caden Parker
d8e6d8dc46
fix(learn): Rework Euler Problem 182 ( #41337 )
...
* Rework Euler Problem 182
* Reordered tests
* Fixes for formatting
2021-03-10 15:55:52 +01:00
Caden Parker
256e7f416d
fix(learn): Added more robust logic for the remove test case in Create A Hash Table ( #41283 )
...
* Added extra test cases for hashtable.remove
* Minor Change
* Adjusted tests to use user created add function / Modified description
* Made test case description much more clear
* Changed instructions to be more clear
* Minor change to instructions
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-03-09 12:45:20 -06:00
Emer Conghaile
18068cdeaa
fix: remove forward slash from <source> tag ( #41422 )
...
The forward slash at the end of the <source> tag in the example is removed, as this is more common.
2021-03-09 16:20:22 +00:00
Nicholas Carrigan (he/him)
c5bcebc724
fix(learn): revert backslash change ( #41382 )
...
* fix(learn): revert backslash change
Crowdin resolved the issue with backslashes escaping backtics in
the markdown parser, so this reverts the workaround we implemented
for that bug.
* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/s-expressions.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-03-09 10:13:27 -06:00
gikf
bd02249a23
fix(learn): rework Rosetta Code Count the Coins ( #41282 )
...
* fix: rework challenge to use argument in function
* fix: use better wording
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com >
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com >
2021-03-09 08:34:10 -06:00
Nicholas Carrigan (he/him)
77730ae209
fix(learn): address translator comments ( #41381 )
...
* fix(learn): address translator comments
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/quoting-strings-with-single-quotes.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-03-09 08:15:26 -06:00
gikf
93495ef6db
fix(learn): correct tests description ( #41280 )
...
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-03-09 11:48:12 +05:30
Nicholas Carrigan (he/him)
16e420021c
chore: audit data visualisation challenges ( #41336 )
...
* chore(learn): audit d3 projects
* chore: audit data vis
* chore: audit json apis
* Update curriculum/challenges/english/04-data-visualization/data-visualization-projects/visualize-data-with-a-scatterplot-graph.md
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
* fix: apply suggestions
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
* fix: no colour backticks
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/get-geolocation-data-to-find-a-users-gps-coordinates.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* Apply suggestions from code review
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-03-05 12:25:29 -07:00
Ricardo Passos
ae79525493
fix(learn): added a missing period and removed single quotes ( #41377 )
...
* Added missing period
On line 24, just before "Note that in your CSS..." a period was missing.
* Removed single quotes and added a missing period
On line 24, just before "Note that in your CSS..." there is a missing period.
On line 30, the text "red-text" within a code tag is enclosed in single quotes.
2021-03-05 07:16:30 -08:00