Commit Graph

1792 Commits

Author SHA1 Message Date
Oliver Eyton-Williams
9194b7731b fix: simplify logging and include console.log
This comes at the cost of creating a flash of the default message when
the preview updates, but significantly simplifies the code.
2019-11-19 22:23:57 +05:30
Oliver Eyton-Williams
beecb04c1a fix: report errors thrown after the frame is ready
Certain challenges involve code that is not run until the user
interacts with the preview (typically via a click listener). This uses
consoleProxy to report those errors.

Error logging has been simplified, reducing the number of places errors
can be reported from.

Some of the redux-saga code has been renamed in an attempt to improve
clarity.
2019-11-19 22:23:57 +05:30
Oliver Eyton-Williams
04d2de96df fix: conditionally log non-assertion errors (JS)
console.logs and errors are only reported during the first evaluation of
the user's code.  This is because the code is evaluated for each test,
but the logs will not change between the build phases of the tests.

Errors thrown during testing (except failing assertions) are always
reported. This is to inform the user that their code is faulty, rather
than that it does not meet the challenge's requirements.
2019-11-19 22:23:57 +05:30
Oliver Eyton-Williams
9a97d639f5 fix: add dynamic output for legacy challenges
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-11-19 22:23:57 +05:30
Oliver Eyton-Williams
64fcbbb491 fix: output console.logs as user types (JS) 2019-11-19 22:23:57 +05:30
Oliver Eyton-Williams
29641986ab fix: output console.logs as user types (DOM)
Any console.logs inside script tags will be written to the fcc console
as the user types.  DOM challenges only.

Also, DRYed out the main and test frame creation.
2019-11-19 22:23:57 +05:30
Oliver Eyton-Williams
6acab90cb6 fix: report user code evaluation errors
Errors thrown during evaluation of the user's code will now be reported.

JavaScript challenges will only report to the browser console and only
during testing.

DOM challenges will report to the browser console during testing and as
the user types, but only report to the fcc console during testing
2019-11-19 22:23:57 +05:30
Oliver Eyton-Williams
5059d23600 fix: report all build errors to the fcc console
Previously only challenges with previews would inform the user of syntax
errors.  This extends that to all challenges and corrects the output
format so errors are clearer.
2019-11-19 22:23:57 +05:30
Tom
5ca2d2467a fix: make help button use subforum topics (#37741)
* fix: make help button use subforum topics

* fix: add test to check that block exists

Co-authored-by: ojeytonwilliams <ojeytonwilliams@gmail.com>

* fix: improve error message

* Update curriculum/test/test-challenges.js

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-11-15 23:03:08 +05:30
Oliver Eyton-Williams
687c4fdb98 fix(client): add cache-busting hashes to chunks (#37746)
* fix(client): add cache-busting hashes to chunks

* fix: create cache-busting names for the workers

Prior to this PR the first webpack compilation gave the workers static
names.  This can cause caching problems, so this PR adds hashes to
their names to invalidate the cache.

In order for Gatsby to find them, the names are added to the
config directory.
2019-11-15 01:43:44 +05:30
Oliver Eyton-Williams
c5d4bedda5 feat: add accessibility toggle
Users can now press ctrl/cmd+f1 to toggle the screen reader mode, in
addition to using the accessibility tooltip.  The mode now persists
between challenges.

If screen reader mode is on, the instructions are focused by default so
the user is not required to navigate to them before reading starts.
2019-11-14 22:17:13 +05:30
Oliver Eyton-Williams
265e383705 fix: allow username submission after failure
If the server rejects a username submission, the submit button became
stuck as disabled.  This ensures that new (valid) input will unlock the
button.
2019-11-14 22:16:24 +05:30
Oliver Eyton-Williams
e1236a0c15 refactor: use validate util in client 2019-11-14 22:16:24 +05:30
Subash Iglesias
385287838e fix(curriculum) - fixed function keyword not misspelled in debugging guide (#37711)
* [ FIXES ] - fixed function keyword not misspelled

* Update client/src/pages/learn/javascript-algorithms-and-data-structures/debugging/index.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: added comment back into example code
2019-11-11 07:37:11 -06:00
jasonranney
26e857b6ab fix: update JavaScript capitalization (#37466) 2019-11-10 04:24:34 -08:00
lasjorg
e1a1ed5c12 fix(client): use JSON.stringify replacer function for NaN (#37684) 2019-11-10 04:17:18 -08:00
Kirankumar Ambati
32954923e1 fix: Read-Search-Ask link on Frontend-Libraries projects (#37710) 2019-11-10 04:16:18 -08:00
Mrugesh Mohapatra
8107106915 fix(donate): quick patch for auth 2019-11-09 11:39:29 -08:00
Mrugesh Mohapatra
139f8fcb1b chore: remove poweredByStripe asset 2019-11-09 11:39:29 -08:00
Mrugesh Mohapatra
4cd5542489 feat(donate): two col layout checkout page 2019-11-09 11:39:29 -08:00
Mrugesh Mohapatra
7a4e84d163 chore(donate): remove donate page tests
Removed the donate page tests, which seemed weirdly depending on
the rendered tree. Unreliable at the best.

We sould be adding comprehensive tests to the components instead.
2019-11-09 11:39:29 -08:00
Mrugesh Mohapatra
83ac3c5f95 chore(donate): remove unused donate modal wiring
This commit removed the donate modal and related wiring,
although some of the state mapping is still around.

The remaining state mapping can either be removed, or kept
for now, because it will be replaced as is for the newer
motivation based donation prompts
2019-11-09 11:39:29 -08:00
imgbot[bot]
a36e0d8351 [ImgBot] Optimize images (#37723)
*Total -- 50.98kb -> 38.49kb (24.51%)

/client/src/assets/images/square_puck.png -- 25.51kb -> 13.31kb (47.81%)
/client/src/assets/images/freeCodeCamp-404.svg -- 25.47kb -> 25.17kb (1.17%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
2019-11-09 01:33:48 -08:00
Ahmad Abdolsaheb
ccd135f268 feat: update logo (#37716)
* feat: update logo

* fix: adjust logo height
2019-11-09 01:31:49 -08:00
Abdelrahman Ashraf
94532f98db refactor(tests): enzyme => react-testing-library (#37712)
* refactor: 💡 rewrite enzyme tests in react-testing-library

* fix: 🐛 remove enzyme imports from frame-runner.js

* chore: 🤖 install and add enzyme imports to frame-runner.js back
2019-11-08 16:50:25 +05:30
Randell Dawson
18891bf3ff feat(curriculum): download solution as non-json text file (#37681)
* feat: download solution as non-json text file

* fix: added missing end of line character

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-11-07 16:11:57 +05:30
Kishore Devaraj
06277c8436 fix(client): Improve client validation accessibility (#37459) 2019-11-06 19:43:58 +05:30
Nirvin M
699ffc5593 fix(client): reduce height of the alert banner (#37497) 2019-11-05 21:23:35 +05:30
Ahmad Abdolsaheb
55a4cadf2a fix: clean failed challenges (#37526) 2019-11-04 19:20:14 +05:30
Parth Parth
c2e7809ccd feat: add message to warn users before changing name (#37527)
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
2019-11-04 18:54:18 +05:30
Ahmad Abdolsaheb
8f73a92e16 fix: set color based on theme (#37634) 2019-10-31 22:59:47 +05:30
Oliver Eyton-Williams
c6a11dd50a fix: escape HTML entities in code editor log (#37601) 2019-10-31 17:56:10 +05:30
Michaël De Boey
c22ca2429e [ImgBot] Optimize images (#37520)
*Total -- 70.80kb -> 52.55kb (25.77%)

/docs/images/devops/travis-build.png -- 65.11kb -> 46.87kb (28.02%)
/api-server/public/images/freeCodeCamp-puck.svg -- 2.03kb -> 2.03kb (0.05%)
/client/src/assets/images/freeCodeCamp-404.svg -- 3.66kb -> 3.66kb (0.03%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: Imgbot <ImgBotHelp@gmail.com>
2019-10-31 17:54:30 +05:30
Mathew Joseph
ebb7d8f3f7 fix(client): icon background not covering on hover. (#37414)
* Fixed the issue of icon background

* Removed background from icons

* Reverted the margin in last icon and fixed the slight color change on hover.

* Update client/src/components/profile/components/social-icons.css

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: null <mathew@sovereignwallet.network>
2019-10-31 17:49:04 +05:30
Kristofer Koishigawa
77b27d79f6 fix: conditionally load MathJax (#37360)
* fix: Removed MathJax CDN from header and set it up to download whenever a user goes to a Rosetta Code challenge

* Reworked slightly so that MathJax CDN script is only rendered once

* Simplified further

* Resolved conflicts and updated MathJax fallback to work like the one on donate.js

* Escaped backticks in scriptLoaders.js

* refactor: remove reliance on state
2019-10-30 15:46:39 +03:00
Parth Parth
f6add96fd6 feat: Make modal scrollable (#37504) 2019-10-30 14:30:24 +03:00
Kristofer Koishigawa
740c839f3f fix: submit backend projects (#37498) 2019-10-24 20:33:33 +05:30
Ahmad Abdolsaheb
3ca4dd5500 feat: update footer (#37476)
* feat: update footer

* fix: update tests

* fix: clean up

* fix: rearrange links

* fix: update test
2019-10-23 23:45:15 +05:30
Ahmad Abdolsaheb
da1fe7971e feat: new logo landing (#37482) 2019-10-23 22:22:37 +05:30
Kishore Devaraj
b6470f93dc fix(client): Signin page button's cursor made pointer (#37478) 2019-10-23 18:31:42 +05:30
Mrugesh Mohapatra
37528a6d26 fix: a11y on primary logo 2019-10-23 16:15:44 +05:30
Kishore Devaraj
45101c63fa fix(client): border visibility for form control in nightmode (#37470) 2019-10-23 15:26:51 +05:30
Kristofer Koishigawa
a475ddc65b fix: remove unnecessary stripe iframes (#37428)
* fix: Remove stripe iframes when navigating away from /donate while still leaving two that may/may not be essential to Stripe

* Moved MutationObserver code into Header component

* fix: make MutationObserver remove old iframes


Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-10-23 15:25:04 +05:30
Tom
3fb5a2c361 fix: separate certs from interview prep on landing page (#37462) 2019-10-23 00:20:55 +05:30
mrugesh
8469975e52 fix: update caching on resources (#37460) 2019-10-23 00:19:56 +05:30
Ahmad Abdolsaheb
b9014e2ceb feat: add local navigation 2019-10-22 21:21:10 +05:30
Ahmad Abdolsaheb
54db501138 fix: update nav items 2019-10-22 21:21:09 +05:30
Ahmad Abdolsaheb
d7ad40688a feat: add settings button to learn 2019-10-22 21:21:08 +05:30
Ahmad Abdolsaheb
1606502784 fix: update test 2019-10-22 21:21:08 +05:30
Ahmad Abdolsaheb
2352c0b1d9 feat: remove portfolio and add conditional intro 2019-10-22 21:21:07 +05:30